Fix RG35XX Battery Charging Issues

From: Chris Morgan <[email protected]>

Add the vendor specific boolean property of x-powers,no-thermistor. This property optionally describes hardware where no thermistor is present on the battery and is specific to the AXP717. In rare circumstances this value can be set incorrectly in the efuse of the PMIC, and if it is not hard-coded the device will fail to charge.

Signed-off-by Chris Morgan <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

---

 .../x-powers,axp20x-battery-power-supply.yaml | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml +17 -3

index 5ccd375eb294..3504c76a01d8 100644
@@ -14,9 +14,6 @@ maintainers:
   - Chen-Yu Tsai <[email protected]>
   - Sebastian Reichel <[email protected]>
 
-allOf:
-  - $ref: power-supply.yaml#
-
 properties:
   compatible:
     oneOf:

@@ -35,7 +32,24 @@ properties:
       this gauge.
     $ref: /schemas/types.yaml#/definitions/phandle
 
+  x-powers,no-thermistor:
+    type: boolean
+    description: Indicates that no thermistor is connected to the TS pin
+
 required:
   - compatible
 
+allOf:
+  - $ref: power-supply.yaml#
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - x-powers,axp717-battery-power-supply
+    then:
+      properties:
+        x-powers,no-thermistor: false
+
 additionalProperties: false

Signature · 1 line

2.43.0

Add AXP717_TS_PIN_CFG (register 0x50) to the table of writeable registers so that the temperature sensor can be configured by the battery driver.

Quoted 5 lines · Chris Morgan

Add AXP717_TS_PIN_CFG (register 0x50) to the table of writeable registers so that the temperature sensor can be configured by the battery driver.

Applied, thanks!

[2/4] mfd: axp20x: AXP717: Add AXP717_TS_PIN_CFG to writeable regs

      commit: ab797d7faf4c28328d2e45b09991f47a9b8e08aa

Hello Lee,

Quoted 7 lines · Lee Jones

Quoted 5 lines · Chris Morgan

Add AXP717_TS_PIN_CFG (register 0x50) to the table of writeable registers so that the temperature sensor can be configured by the battery driver.

Quoted 4 lines

Applied, thanks!

[2/4] mfd: axp20x: AXP717: Add AXP717_TS_PIN_CFG to writeable regs

      commit: ab797d7faf4c28328d2e45b09991f47a9b8e08aa

Patch 3/4 has a dependency on this one. As you probably haven't done an immutable branch for this one, please also pick up 1/4 and 3/4. I just provided Acked-by to them.

From: Chris Morgan <[email protected]>

Allow a boolean property of "x-powers,no-thermistor" to specify devices where the ts pin is not connected to anything. This works around an issue found with some devices where the efuse is not programmed correctly from the factory or when the register gets set erroneously.

Signed-off-by Chris Morgan <[email protected]>

---
  drivers/power/supply/axp20x_battery.c | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)

drivers/power/supply/axp20x_battery.c +21 -0

index 3c3158f31a48..f4cf129a0b68 100644
@@ -89,6 +89,8 @@
  #define AXP717_BAT_CC_MIN_UA		0
  #define AXP717_BAT_CC_MAX_UA		3008000
 
+#define AXP717_TS_PIN_DISABLE		BIT(4)
+
  struct axp20x_batt_ps;
 
  struct axp_data {

@@ -117,6 +119,7 @@ struct axp20x_batt_ps {
  	/* Maximum constant charge current */
  	unsigned int max_ccc;
  	const struct axp_data	*data;
+	bool ts_disable;
  };
 
  static int axp20x_battery_get_max_voltage(struct axp20x_batt_ps *axp20x_batt,

@@ -984,6 +987,24 @@ static void axp717_set_battery_info(struct platform_device *pdev,
  	int ccc = info->constant_charge_current_max_ua;
  	int val;
 
+	axp_batt->ts_disable = (device_property_read_bool(axp_batt->dev,
+							  "x-powers,no-thermistor"));
+
+	/*
+	 * Under rare conditions an incorrectly programmed efuse for
+	 * the temp sensor on the PMIC may trigger a fault condition.
+	 * Allow users to hard-code if the ts pin is not used to work
+	 * around this problem. Note that this requires the battery
+	 * be correctly defined in the device tree with a monitored
+	 * battery node.
+	 */
+	if (axp_batt->ts_disable) {
+		regmap_update_bits(axp_batt->regmap,
+				   AXP717_TS_PIN_CFG,
+				   AXP717_TS_PIN_DISABLE,
+				   AXP717_TS_PIN_DISABLE);
+	}
+
  	if (vmin > 0 && axp717_set_voltage_min_design(axp_batt, vmin))
  		dev_err(&pdev->dev,
  			"couldn't set voltage_min_design\n");

From: Chris Morgan <[email protected]>

Allow a boolean property of "x-powers,no-thermistor" to specify devices where the ts pin is not connected to anything. This works around an issue found with some devices where the efuse is not programmed correctly from the factory or when the register gets set erroneously.

Signed-off-by Chris Morgan <[email protected]>

---

 drivers/power/supply/axp20x_battery.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

drivers/power/supply/axp20x_battery.c +21 -0

index 3c3158f31a48..f4cf129a0b68 100644
@@ -89,6 +89,8 @@
 #define AXP717_BAT_CC_MIN_UA		0
 #define AXP717_BAT_CC_MAX_UA		3008000
 
+#define AXP717_TS_PIN_DISABLE		BIT(4)
+
 struct axp20x_batt_ps;
 
 struct axp_data {

@@ -117,6 +119,7 @@ struct axp20x_batt_ps {
 	/* Maximum constant charge current */
 	unsigned int max_ccc;
 	const struct axp_data	*data;
+	bool ts_disable;
 };
 
 static int axp20x_battery_get_max_voltage(struct axp20x_batt_ps *axp20x_batt,

@@ -984,6 +987,24 @@ static void axp717_set_battery_info(struct platform_device *pdev,
 	int ccc = info->constant_charge_current_max_ua;
 	int val;
 
+	axp_batt->ts_disable = (device_property_read_bool(axp_batt->dev,
+							  "x-powers,no-thermistor"));
+
+	/*
+	 * Under rare conditions an incorrectly programmed efuse for
+	 * the temp sensor on the PMIC may trigger a fault condition.
+	 * Allow users to hard-code if the ts pin is not used to work
+	 * around this problem. Note that this requires the battery
+	 * be correctly defined in the device tree with a monitored
+	 * battery node.
+	 */
+	if (axp_batt->ts_disable) {
+		regmap_update_bits(axp_batt->regmap,
+				   AXP717_TS_PIN_CFG,
+				   AXP717_TS_PIN_DISABLE,
+				   AXP717_TS_PIN_DISABLE);
+	}
+
 	if (vmin > 0 && axp717_set_voltage_min_design(axp_batt, vmin))
 		dev_err(&pdev->dev,
 			"couldn't set voltage_min_design\n");

Signature · 1 line

2.43.0

From: Chris Morgan <[email protected]>

Add the property of x-powers,no-thermistor for the battery of the Anbernic RG35XX series of H700 devices.

Signed-off-by Chris Morgan <[email protected]>

From: Chris Morgan <[email protected]>

The Anbernic RG35XX devices sometimes fail to charge when the register for the battery temperature sensor is set to the incorrect value either by user error or an incorrectly programmed efuse. Allow users to hard-code if a temperature sensor is not present (which is the case for all Anbernic RGxx series devices) to prevent this issue from causing problems. Additionally, a bug was identified with the handling of PMU faults while this fix was being tested.

[...]

From: Chris Morgan <[email protected]>

The Anbernic RG35XX devices sometimes fail to charge when the register for the battery temperature sensor is set to the incorrect value either by user error or an incorrectly programmed efuse. Allow users to hard-code if a temperature sensor is not present (which is the case for all Anbernic RGxx series devices) to prevent this issue from causing problems. Additionally, a bug was identified with the handling of PMU faults while this fix was being tested.

[...]