Skip to contentSkip to conversation

EDAC: Simplify return statement in dct_ecc_enabled()

PATCH Applied Thorsten Blum 4 participants 4 messages Feb 1, 2025 – Feb 28, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC: Simplify return statement in dct_ecc_enabled()

Simplify the return statement to improve the code's readability.

---
 drivers/edac/amd64_edac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/edac/amd64_edac.c +1 -4
index 8414ceb43e4a..1f106b4fafdf 100644
@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
 
 	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" : "disabled"));
 
-	if (!ecc_en || !nb_mce_en)
-		return false;
-	else
-		return true;
+	return ecc_en && nb_mce_en;
 }
 
 static bool umc_ecc_enabled(struct amd64_pvt *pvt)
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Thorsten Blum

Simplify the return statement to improve the code's readability.

---
 drivers/edac/amd64_edac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/edac/amd64_edac.c +0 -0
index 8414ceb43e4a..1f106b4fafdf 100644
@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
 

drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt *pvt) · line 3361

Quoted 10 lines
drivers/edac/amd64_edac.c +1 -4
 	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" : "disabled"));
 
-	if (!ecc_en || !nb_mce_en)
-		return false;
-	else
-		return true;
+	return ecc_en && nb_mce_en;
 }
 
 static bool umc_ecc_enabled(struct amd64_pvt *pvt)

Looks good to me.

Thanks,
Yazen

Reviewed-by on v1 1/1
#2 lore raw
In reply to Thorsten Blum
Quoted 17 lines

From: Thorsten Blum <[email protected]>
[...]
Subject: [PATCH] EDAC: Simplify return statement in dct_ecc_enabled()

Simplify the return statement to improve the code's readability.

---
 drivers/edac/amd64_edac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/edac/amd64_edac.c index renamed from drivers/edac/amd64_edac.c +0 -0

8414ceb43e4a..1f106b4fafdf 100644

drivers/edac/amd64_edac.c +0 -0
@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt
 *pvt)

drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt · line 3361

Quoted 10 lines
drivers/edac/amd64_edac.c +1 -4
 
 	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" :
 "disabled"));
 
-	if (!ecc_en || !nb_mce_en)
-		return false;
-	else
-		return true;
+	return ecc_en && nb_mce_en;
 }

LGTM. Thanks!

maintainer Applied
#3 lore raw
In reply to Thorsten Blum
Quoted 14 lines · Thorsten Blum

Simplify the return statement to improve the code's readability.

---
 drivers/edac/amd64_edac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/edac/amd64_edac.c +0 -0
index 8414ceb43e4a..1f106b4fafdf 100644
@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
 

drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt *pvt) · line 3361

Quoted 10 lines
drivers/edac/amd64_edac.c +1 -4
 	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" : "disabled"));
 
-	if (!ecc_en || !nb_mce_en)
-		return false;
-	else
-		return true;
+	return ecc_en && nb_mce_en;
 }
 
 static bool umc_ecc_enabled(struct amd64_pvt *pvt)

Applied, thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette