EDAC: Simplify return statement in dct_ecc_enabled()
Subsystems (2)
PATCH 1/1 EDAC: Simplify return statement in dct_ecc_enabled()
Simplify the return statement to improve the code's readability.
--- drivers/edac/amd64_edac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/edac/amd64_edac.c +1 -4
@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)edac_dbg (3 ,"Node %d: DRAM ECC %s.\n" , nid, (ecc_en ?"enabled" :"disabled" )); -if (!ecc_en || !nb_mce_en) -return false; -else -return true; +return ecc_en && nb_mce_en; }static bool umc_ecc_enabled (struct amd64_pvt *pvt)
Signature · 1 line
2.48.1
Quoted 14 lines · Thorsten Blum
Simplify the return statement to improve the code's readability.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/edac/amd64_edac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/edac/amd64_edac.c +0
-0@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt *pvt) · line 3361
Quoted 10 lines
drivers/edac/amd64_edac.c +1
-4edac_dbg (3 ,"Node %d: DRAM ECC %s.\n" , nid, (ecc_en ?"enabled" :"disabled" )); -if (!ecc_en || !nb_mce_en) -return false; -else -return true; +return ecc_en && nb_mce_en; }static bool umc_ecc_enabled (struct amd64_pvt *pvt)
Looks good to me.
Thanks,
Yazen
Quoted 17 lines
From: Thorsten Blum <[email protected]>
[...]
Subject: [PATCH] EDAC: Simplify return statement indct_ecc_enabled()Simplify the return statement to improve the code's readability.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/edac/amd64_edac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/edac/amd64_edac.c index renamed from drivers/edac/amd64_edac.c +0
-0
8414ceb43e4a..1f106b4fafdf100644drivers/edac/amd64_edac.c +0
-0@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt · line 3361
Quoted 10 lines
drivers/edac/amd64_edac.c +1
-4edac_dbg (3 ,"Node %d: DRAM ECC %s.\n" , nid, (ecc_en ?"enabled" :"disabled" )); -if (!ecc_en || !nb_mce_en) -return false; -else -return true; +return ecc_en && nb_mce_en; }
LGTM. Thanks!
Quoted 14 lines · Thorsten Blum
Simplify the return statement to improve the code's readability.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/edac/amd64_edac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/edac/amd64_edac.c +0
-0@@ -3355,10 +3355,7 @@ static bool dct_ecc_enabled(struct amd64_pvt *pvt)
drivers/edac/amd64_edac.c static bool dct_ecc_enabled(struct amd64_pvt *pvt) · line 3361
Quoted 10 lines
drivers/edac/amd64_edac.c +1
-4edac_dbg (3 ,"Node %d: DRAM ECC %s.\n" , nid, (ecc_en ?"enabled" :"disabled" )); -if (!ecc_en || !nb_mce_en) -return false; -else -return true; +return ecc_en && nb_mce_en; }static bool umc_ecc_enabled (struct amd64_pvt *pvt)
Applied, thanks.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette