int3472: Support GPIO con_id based on _HID
Sakari Ailus
maintainerv6 cover int3472: Support GPIO con_id based on _HID
Hi folks,
One patch turned into a set, the second patch being the original one.
since v5:
- Add a comment to the GPIO mapping code.
- Align ternary operator conditionals right of "= " on the previous line.
Sakari Ailus (3):
platform/x86: int3472: Use correct type for "polarity", call it
gpio_flags
platform/x86: int3472: Call "reset" GPIO "enable" for INT347E platform/x86: int3472: Call "func" "con_id" instead
drivers/platform/x86/intel/int3472/discrete.c | 105 +++++++++++++----- 1 file changed, 75 insertions(+), 30 deletions(-)
Signature · 1 line
2.39.5
Sakari Ailus
maintainerPATCH v6 1/3 platform/x86: int3472: Use correct type for "polarity", call it gpio_flags
Struct gpiod_lookup flags field's type is unsigned long. Thus use unsigned long for values to be assigned to that field. Similarly, also call the field gpio_flags which it really is.
--- drivers/platform/x86/intel/int3472/discrete.c | 39 ++++++++++--------- 1 file changed, 20 insertions(+), 19 deletions(-)
drivers/platform/x86/intel/int3472/discrete.c +20 -19
@@ -55,7 +55,7 @@ static void skl_int3472_log_sensor_module_name(struct int3472_discrete_device *istatic int skl_int3472_fill_gpiod_lookup (struct gpiod_lookup *table_entry,struct acpi_resource_gpio *agpio, -const char *func,u32 polarity) +const char *func,unsigned long gpio_flags) {char *path = agpio->resource_source.string_ptr;struct acpi_device *adev;
@@ -70,14 +70,14 @@ static int skl_int3472_fill_gpiod_lookup(struct gpiod_lookup *table_entry,if (!adev)return -ENODEV ; - *table_entry =GPIO_LOOKUP (acpi_dev_name (adev), agpio->pin_table[0 ], func, polarity); + *table_entry =GPIO_LOOKUP (acpi_dev_name (adev), agpio->pin_table[0 ], func, gpio_flags);return 0 ; }static int skl_int3472_map_gpio_to_sensor (struct int3472_discrete_device *int3472,struct acpi_resource_gpio *agpio, -const char *func,u32 polarity) +const char *func,unsigned long gpio_flags) {int ret;
@@ -87,7 +87,7 @@ static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int347 } ret =skl_int3472_fill_gpiod_lookup (&int3472->gpios.table[int3472->n_sensor_gpios], - agpio, func, polarity); + agpio, func, gpio_flags);if (ret)return ret;
@@ -100,7 +100,7 @@ static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int347static struct gpio_desc *skl_int3472_gpiod_get_from_temp_lookup (struct int3472_discrete_device *int3472,struct acpi_resource_gpio *agpio, -const char *func,u32 polarity) +const char *func,unsigned long gpio_flags) {struct gpio_desc *desc;int ret;
@@ -111,7 +111,7 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,return ERR_PTR (-ENOMEM ); lookup->dev_id =dev_name (int3472->dev); - ret =skl_int3472_fill_gpiod_lookup (&lookup->table[0 ], agpio, func, polarity); + ret =skl_int3472_fill_gpiod_lookup (&lookup->table[0 ], agpio, func, gpio_flags);if (ret)return ERR_PTR (ret);
@@ -122,32 +122,33 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,return desc; } -static void int3472_get_func_and_polarity (u8 type,const char **func,u32 *polarity) +static void int3472_get_func_and_polarity (u8 type,const char **func, +unsigned long *gpio_flags) {switch (type) {case INT3472_GPIO_TYPE_RESET : *func ="reset" ; - *polarity =GPIO_ACTIVE_LOW ; + *gpio_flags =GPIO_ACTIVE_LOW ;break ;case INT3472_GPIO_TYPE_POWERDOWN : *func ="powerdown" ; - *polarity =GPIO_ACTIVE_LOW ; + *gpio_flags =GPIO_ACTIVE_LOW ;break ;case INT3472_GPIO_TYPE_CLK_ENABLE : *func ="clk-enable" ; - *polarity =GPIO_ACTIVE_HIGH ; + *gpio_flags =GPIO_ACTIVE_HIGH ;break ;case INT3472_GPIO_TYPE_PRIVACY_LED : *func ="privacy-led" ; - *polarity =GPIO_ACTIVE_HIGH ; + *gpio_flags =GPIO_ACTIVE_HIGH ;break ;case INT3472_GPIO_TYPE_POWER_ENABLE : *func ="power-enable" ; - *polarity =GPIO_ACTIVE_HIGH ; + *gpio_flags =GPIO_ACTIVE_HIGH ;break ;default : *func ="unknown" ; - *polarity =GPIO_ACTIVE_HIGH ; + *gpio_flags =GPIO_ACTIVE_HIGH ;break ; } }
@@ -194,7 +195,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,struct gpio_desc *gpio;const char *err_msg;const char *func; -u32 polarity; +unsigned long gpio_flags;int ret;if (!acpi_gpio_get_io_resource (ares, &agpio))
@@ -217,7 +218,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, type =FIELD_GET (INT3472_GPIO_DSM_TYPE , obj->integer.value); -int3472_get_func_and_polarity (type, &func, &polarity); +int3472_get_func_and_polarity (type, &func, &gpio_flags); pin =FIELD_GET (INT3472_GPIO_DSM_PIN , obj->integer.value);/* Pin field is not really used under Windows and wraps around at 8 bits */
@@ -227,16 +228,16 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, active_value =FIELD_GET (INT3472_GPIO_DSM_SENSOR_ON_VAL , obj->integer.value);if (!active_value) - polarity ^=GPIO_ACTIVE_LOW ; + gpio_flags ^=GPIO_ACTIVE_LOW ;dev_dbg (int3472->dev,"%s %s pin %d active-%s\n" , func, agpio->resource_source.string_ptr, agpio->pin_table[0 ], -str_high_low (polarity ==GPIO_ACTIVE_HIGH )); +str_high_low (gpio_flags ==GPIO_ACTIVE_HIGH ));switch (type) {case INT3472_GPIO_TYPE_RESET :case INT3472_GPIO_TYPE_POWERDOWN : - ret =skl_int3472_map_gpio_to_sensor (int3472, agpio, func, polarity); + ret =skl_int3472_map_gpio_to_sensor (int3472, agpio, func, gpio_flags);if (ret) err_msg ="Failed to map GPIO pin to sensor\n" ;
@@ -244,7 +245,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,case INT3472_GPIO_TYPE_CLK_ENABLE :case INT3472_GPIO_TYPE_PRIVACY_LED :case INT3472_GPIO_TYPE_POWER_ENABLE : - gpio =skl_int3472_gpiod_get_from_temp_lookup (int3472, agpio, func, polarity); + gpio =skl_int3472_gpiod_get_from_temp_lookup (int3472, agpio, func, gpio_flags);if (IS_ERR (gpio)) { ret =PTR_ERR (gpio); err_msg ="Failed to get GPIO\n" ;
Signature · 1 line
2.39.5
Sakari Ailus
maintainerPATCH v6 2/3 platform/x86: int3472: Call "reset" GPIO "enable" for INT347E
In reply to Sakari AilusThe DT bindings for ov7251 specify "enable" GPIO (xshutdown in documentation) but the int3472 indiscriminately provides this as a "reset" GPIO to sensor drivers. Take this into account by assigning it as "enable" with active high polarity for INT347E devices, i.e. ov7251. "reset" with active low polarity remains the default GPIO name for other devices.
--- drivers/platform/x86/intel/int3472/discrete.c | 52 +++++++++++++++++-- 1 file changed, 48 insertions(+), 4 deletions(-)
drivers/platform/x86/intel/int3472/discrete.c +48 -4
@@ -2,6 +2,7 @@/* Author: Dan Scally <[email protected]> */ #include <linux/acpi.h> +#include <linux/array_size.h> #include <linux/bitfield.h> #include <linux/device.h> #include <linux/gpio/consumer.h>
@@ -122,10 +123,53 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,return desc; } -static void int3472_get_func_and_polarity (u8 type,const char **func, -unsigned long *gpio_flags) +/** +* struct int3472_gpio_map - Map GPIOs to whatever is expected by the +* sensor driver (as in DT bindings) +* @hid: The ACPI HID of the device without the instance number e.g. INT347E +* @type_from: The GPIO type from ACPI ?SDT +* @type_to: The assigned GPIO type, typically same as @type_from +* @func: The function, e.g. "enable" +* @polarity_low: GPIO_ACTIVE_LOW true if the @polarity_low is true, +* GPIO_ACTIVE_HIGH otherwise +*/ +struct int3472_gpio_map { +const char *hid; +u8 type_from; +u8 type_to; +bool polarity_low; +const char *func; +}; + +static const struct int3472_gpio_map int3472_gpio_map[] = { + {"INT347E" ,INT3472_GPIO_TYPE_RESET ,INT3472_GPIO_TYPE_RESET , false,"enable" }, +}; + +static void int3472_get_func_and_polarity (struct acpi_device *adev,u8 *type, +const char **func,unsigned long *gpio_flags) { -switch (type) { +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (int3472_gpio_map); i++) { +/* +* Map the firmware-provided GPIO to whatever a driver expects +* (as in DT bindings). First check if the requested GPIO name +* matches the GPIO map, then see that the device _HID matches. +*/ +if (*type != int3472_gpio_map[i].type_from) +continue ; + +if (!acpi_dev_hid_uid_match (adev, int3472_gpio_map[i].hid,NULL )) +continue ; + + *type = int3472_gpio_map[i].type_to; + *gpio_flags = int3472_gpio_map[i].polarity_low ? +GPIO_ACTIVE_LOW :GPIO_ACTIVE_HIGH ; + *func = int3472_gpio_map[i].func; +return ; + } + +switch (*type) {case INT3472_GPIO_TYPE_RESET : *func ="reset" ; *gpio_flags =GPIO_ACTIVE_LOW ;
@@ -218,7 +262,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, type =FIELD_GET (INT3472_GPIO_DSM_TYPE , obj->integer.value); -int3472_get_func_and_polarity (type, &func, &gpio_flags); +int3472_get_func_and_polarity (int3472->sensor, &type, &func, &gpio_flags); pin =FIELD_GET (INT3472_GPIO_DSM_PIN , obj->integer.value);/* Pin field is not really used under Windows and wraps around at 8 bits */
Signature · 1 line
2.39.5
Re: [PATCH v6 2/3] platform/x86: int3472: Call "reset" GPIO "enable" for INT347E
Quoted 5 lines · Sakari Ailus
The DT bindings for ov7251 specify "enable" GPIO (xshutdown in documentation) but the int3472 indiscriminately provides this as a "reset" GPIO to sensor drivers. Take this into account by assigning it as "enable" with active high polarity for INT347E devices, i.e. ov7251. "reset" with active low polarity remains the default GPIO name for other devices.
...
Quoted 4 lines
drivers/platform/x86/intel/int3472/discrete.c +4
-0+static const struct int3472_gpio_map int3472_gpio_map[] = { + {"INT347E" ,INT3472_GPIO_TYPE_RESET ,INT3472_GPIO_TYPE_RESET , false,"enable" }, +}; +
drivers/platform/x86/intel/int3472/discrete.c skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472, · line 156
Quoted 10 lines
drivers/platform/x86/intel/int3472/discrete.c +8
-1+static void int3472_get_func_and_polarity (struct acpi_device *adev,u8 *type, +const char **func,unsigned long *gpio_flags) { -switch (type) { +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (int3472_gpio_map); i++) { +/* +* Map the firmware-provided GPIO to whatever a driver expects +* (as in DT bindings). First check if the requested GPIO name
What name?
drivers/platform/x86/intel/int3472/discrete.c skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472, · line 163
Quoted 7 lines
drivers/platform/x86/intel/int3472/discrete.c +7
-0+* matches the GPIO map, then see that the device _HID matches. +*/ +if (*type != int3472_gpio_map[i].type_from) +continue ; + +if (!acpi_dev_hid_uid_match (adev, int3472_gpio_map[i].hid,NULL )) +continue ;
I still think this is unusual and confusing order of checks.
At the end, it is up to the PDx86 maintainers.
Quoted 6 lines
drivers/platform/x86/intel/int3472/discrete.c +6
-0+ *type = int3472_gpio_map[i].type_to; + *gpio_flags = int3472_gpio_map[i].polarity_low ? +GPIO_ACTIVE_LOW :GPIO_ACTIVE_HIGH ; + *func = int3472_gpio_map[i].func; +return ; + }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
maintainerRe: [PATCH v6 2/3] platform/x86: int3472: Call "reset" GPIO "enable" for INT347E
Hi Andy,
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Sakari Ailus
The DT bindings for ov7251 specify "enable" GPIO (xshutdown in documentation) but the int3472 indiscriminately provides this as a "reset" GPIO to sensor drivers. Take this into account by assigning it as "enable" with active high polarity for INT347E devices, i.e. ov7251. "reset" with active low polarity remains the default GPIO name for other devices.
...
Quoted 16 lines
Quoted 4 lines
drivers/platform/x86/intel/int3472/discrete.c +4
-0+static const struct int3472_gpio_map int3472_gpio_map[] = { + {"INT347E" ,INT3472_GPIO_TYPE_RESET ,INT3472_GPIO_TYPE_RESET , false,"enable" }, +}; +drivers/platform/x86/intel/int3472/discrete.c skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472, · line 156
Quoted 10 lines
drivers/platform/x86/intel/int3472/discrete.c +8
-1+static void int3472_get_func_and_polarity (struct acpi_device *adev,u8 *type, +const char **func,unsigned long *gpio_flags) { -switch (type) { +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (int3472_gpio_map); i++) { +/* +* Map the firmware-provided GPIO to whatever a driver expects +* (as in DT bindings). First check if the requested GPIO name What name?
Right, I was accidentally thinking of a driver here. How about:
Map the firmware-provided GPIO type to whatever a driver expects (as in DT bindings). First check if the type matches with the GPIO map, then further check that the device _HID matches.
Quoted 20 lines
drivers/platform/x86/intel/int3472/discrete.c skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472, · line 163
Quoted 8 lines
drivers/platform/x86/intel/int3472/discrete.c +7
-0+* matches the GPIO map, then see that the device _HID matches. +*/ +if (*type != int3472_gpio_map[i].type_from) +continue ; + +if (!acpi_dev_hid_uid_match (adev, int3472_gpio_map[i].hid,NULL )) +continue ;I still think this is unusual and confusing order of checks.
At the end, it is up to the PDx86 maintainers.
Quoted 6 lines
drivers/platform/x86/intel/int3472/discrete.c +6
-0+ *type = int3472_gpio_map[i].type_to; + *gpio_flags = int3472_gpio_map[i].polarity_low ? +GPIO_ACTIVE_LOW :GPIO_ACTIVE_HIGH ; + *func = int3472_gpio_map[i].func; +return ; + }
Signature · 3 lines
Regards, Sakari Ailus
Sakari Ailus
maintainerPATCH v6 3/3 platform/x86: int3472: Call "func" "con_id" instead
In reply to Sakari Ailus"con_id" is an established variable name for the GPIO naming for drivers. Use it instead of "func" in the int3472 driver, too.
--- drivers/platform/x86/intel/int3472/discrete.c | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-)
drivers/platform/x86/intel/int3472/discrete.c +24 -24
@@ -56,7 +56,7 @@ static void skl_int3472_log_sensor_module_name(struct int3472_discrete_device *istatic int skl_int3472_fill_gpiod_lookup (struct gpiod_lookup *table_entry,struct acpi_resource_gpio *agpio, -const char *func,unsigned long gpio_flags) +const char *con_id,unsigned long gpio_flags) {char *path = agpio->resource_source.string_ptr;struct acpi_device *adev;
@@ -71,14 +71,14 @@ static int skl_int3472_fill_gpiod_lookup(struct gpiod_lookup *table_entry,if (!adev)return -ENODEV ; - *table_entry =GPIO_LOOKUP (acpi_dev_name (adev), agpio->pin_table[0 ], func, gpio_flags); + *table_entry =GPIO_LOOKUP (acpi_dev_name (adev), agpio->pin_table[0 ], con_id, gpio_flags);return 0 ; }static int skl_int3472_map_gpio_to_sensor (struct int3472_discrete_device *int3472,struct acpi_resource_gpio *agpio, -const char *func,unsigned long gpio_flags) +const char *con_id,unsigned long gpio_flags) {int ret;
@@ -88,7 +88,7 @@ static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int347 } ret =skl_int3472_fill_gpiod_lookup (&int3472->gpios.table[int3472->n_sensor_gpios], - agpio, func, gpio_flags); + agpio, con_id, gpio_flags);if (ret)return ret;
@@ -101,7 +101,7 @@ static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int347static struct gpio_desc *skl_int3472_gpiod_get_from_temp_lookup (struct int3472_discrete_device *int3472,struct acpi_resource_gpio *agpio, -const char *func,unsigned long gpio_flags) +const char *con_id,unsigned long gpio_flags) {struct gpio_desc *desc;int ret;
@@ -112,12 +112,12 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,return ERR_PTR (-ENOMEM ); lookup->dev_id =dev_name (int3472->dev); - ret =skl_int3472_fill_gpiod_lookup (&lookup->table[0 ], agpio, func, gpio_flags); + ret =skl_int3472_fill_gpiod_lookup (&lookup->table[0 ], agpio, con_id, gpio_flags);if (ret)return ERR_PTR (ret);gpiod_add_lookup_table (lookup); - desc =devm_gpiod_get (int3472->dev, func,GPIOD_OUT_LOW ); + desc =devm_gpiod_get (int3472->dev, con_id,GPIOD_OUT_LOW );gpiod_remove_lookup_table (lookup);return desc;
@@ -129,7 +129,7 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,* @hid: The ACPI HID of the device without the instance number e.g. INT347E * @type_from: The GPIO type from ACPI ?SDT * @type_to: The assigned GPIO type, typically same as @type_from -* @func: The function, e.g. "enable" +* @con_id: The name of the GPIO for the device * @polarity_low: GPIO_ACTIVE_LOW true if the @polarity_low is true, * GPIO_ACTIVE_HIGH otherwise */
@@ -138,15 +138,15 @@ struct int3472_gpio_map {u8 type_from;u8 type_to;bool polarity_low; -const char *func; +const char *con_id; };static const struct int3472_gpio_map int3472_gpio_map[] = { {"INT347E" ,INT3472_GPIO_TYPE_RESET ,INT3472_GPIO_TYPE_RESET , false,"enable" }, }; -static void int3472_get_func_and_polarity (struct acpi_device *adev,u8 *type, -const char **func,unsigned long *gpio_flags) +static void int3472_get_con_id_and_polarity (struct acpi_device *adev,u8 *type, +const char **con_id,unsigned long *gpio_flags) {unsigned int i;
@@ -165,33 +165,33 @@ static void int3472_get_func_and_polarity(struct acpi_device *adev, u8 *type, *type = int3472_gpio_map[i].type_to; *gpio_flags = int3472_gpio_map[i].polarity_low ?GPIO_ACTIVE_LOW :GPIO_ACTIVE_HIGH ; - *func = int3472_gpio_map[i].func; + *con_id = int3472_gpio_map[i].con_id;return ; }switch (*type) {case INT3472_GPIO_TYPE_RESET : - *func ="reset" ; + *con_id ="reset" ; *gpio_flags =GPIO_ACTIVE_LOW ;break ;case INT3472_GPIO_TYPE_POWERDOWN : - *func ="powerdown" ; + *con_id ="powerdown" ; *gpio_flags =GPIO_ACTIVE_LOW ;break ;case INT3472_GPIO_TYPE_CLK_ENABLE : - *func ="clk-enable" ; + *con_id ="clk-enable" ; *gpio_flags =GPIO_ACTIVE_HIGH ;break ;case INT3472_GPIO_TYPE_PRIVACY_LED : - *func ="privacy-led" ; + *con_id ="privacy-led" ; *gpio_flags =GPIO_ACTIVE_HIGH ;break ;case INT3472_GPIO_TYPE_POWER_ENABLE : - *func ="power-enable" ; + *con_id ="power-enable" ; *gpio_flags =GPIO_ACTIVE_HIGH ;break ;default : - *func ="unknown" ; + *con_id ="unknown" ; *gpio_flags =GPIO_ACTIVE_HIGH ;break ; }
@@ -238,7 +238,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,union acpi_object *obj;struct gpio_desc *gpio;const char *err_msg; -const char *func; +const char *con_id;unsigned long gpio_flags;int ret;
@@ -262,26 +262,26 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, type =FIELD_GET (INT3472_GPIO_DSM_TYPE , obj->integer.value); -int3472_get_func_and_polarity (int3472->sensor, &type, &func, &gpio_flags); +int3472_get_con_id_and_polarity (int3472->sensor, &type, &con_id, &gpio_flags); pin =FIELD_GET (INT3472_GPIO_DSM_PIN , obj->integer.value);/* Pin field is not really used under Windows and wraps around at 8 bits */ if (pin != (agpio->pin_table[0 ] &0xff ))dev_dbg (int3472->dev,FW_BUG "%s %s pin number mismatch _DSM %d resource %d\n" , - func, agpio->resource_source.string_ptr, pin, agpio->pin_table[0 ]); + con_id, agpio->resource_source.string_ptr, pin, agpio->pin_table[0 ]); active_value =FIELD_GET (INT3472_GPIO_DSM_SENSOR_ON_VAL , obj->integer.value);if (!active_value) gpio_flags ^=GPIO_ACTIVE_LOW ; -dev_dbg (int3472->dev,"%s %s pin %d active-%s\n" , func, +dev_dbg (int3472->dev,"%s %s pin %d active-%s\n" , con_id, agpio->resource_source.string_ptr, agpio->pin_table[0 ],str_high_low (gpio_flags ==GPIO_ACTIVE_HIGH ));switch (type) {case INT3472_GPIO_TYPE_RESET :case INT3472_GPIO_TYPE_POWERDOWN : - ret =skl_int3472_map_gpio_to_sensor (int3472, agpio, func, gpio_flags); + ret =skl_int3472_map_gpio_to_sensor (int3472, agpio, con_id, gpio_flags);if (ret) err_msg ="Failed to map GPIO pin to sensor\n" ;
@@ -289,7 +289,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,case INT3472_GPIO_TYPE_CLK_ENABLE :case INT3472_GPIO_TYPE_PRIVACY_LED :case INT3472_GPIO_TYPE_POWER_ENABLE : - gpio =skl_int3472_gpiod_get_from_temp_lookup (int3472, agpio, func, gpio_flags); + gpio =skl_int3472_gpiod_get_from_temp_lookup (int3472, agpio, con_id, gpio_flags);if (IS_ERR (gpio)) { ret =PTR_ERR (gpio); err_msg ="Failed to get GPIO\n" ;
Signature · 1 line
2.39.5