Skip to contentSkip to conversation

arm64: dts: rockchip: rock-3a: Remove bluetooth node

PATCH Applied Chen-Yu Tsai 3 participants 3 messages Feb 20, 2025 – Mar 12, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: rock-3a: Remove bluetooth node

From: Chen-Yu Tsai <[email protected]>

The Bluetooth node described in the device tree is actually on an M.2 slot. What module is present depends on what the end user installed, and should be left to an overlay.

Remove the existing bluetooth node. This gets rid of bogus timeout errors.

Fixes 8cf890aabd45 ("arm64: dts: rockchip: Add nodes for SDIO/UART Wi-Fi/Bluetooth modules to Radxa Rock 3A")
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 14 --------------
 1 file changed, 14 deletions(-)
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +0 -14
index ac79140a9ecd..44cfdfeed668 100644
@@ -778,20 +778,6 @@ &uart1 {
 	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
 	uart-has-rtscts;
 	status = "okay";
-
-	bluetooth {
-		compatible = "brcm,bcm43438-bt";
-		clocks = <&rk809 1>;
-		clock-names = "lpo";
-		device-wakeup-gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>;
-		host-wakeup-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
-		shutdown-gpios = <&gpio4 RK_PB2 GPIO_ACTIVE_HIGH>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&bt_host_wake &bt_wake &bt_enable>;
-		vbat-supply = <&vcc3v3_sys>;
-		vddio-supply = <&vcc_1v8>;
-		/* vddio comes from regulator on module, use IO bank voltage instead */
-	};
 };
 
 &uart2 {
Signature · 1 line
2.39.5
#1 lore raw

Hi,

What about adding another patch that converts it to a dtso?

Best regards,
Shengyu

Quoted 40 lines · Chen-Yu Tsai

From: Chen-Yu Tsai <[email protected]>

The Bluetooth node described in the device tree is actually on an M.2 slot. What module is present depends on what the end user installed, and should be left to an overlay.

Remove the existing bluetooth node. This gets rid of bogus timeout errors.

Fixes 8cf890aabd45 ("arm64: dts: rockchip: Add nodes for SDIO/UART Wi-Fi/Bluetooth modules to Radxa Rock 3A")
---
  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 14 --------------
  1 file changed, 14 deletions(-)
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +0 -14
index ac79140a9ecd..44cfdfeed668 100644
@@ -778,20 +778,6 @@ &uart1 {
  	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
  	uart-has-rtscts;
  	status = "okay";
-
-	bluetooth {
-		compatible = "brcm,bcm43438-bt";
-		clocks = <&rk809 1>;
-		clock-names = "lpo";
-		device-wakeup-gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>;
-		host-wakeup-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
-		shutdown-gpios = <&gpio4 RK_PB2 GPIO_ACTIVE_HIGH>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&bt_host_wake &bt_wake &bt_enable>;
-		vbat-supply = <&vcc3v3_sys>;
-		vddio-supply = <&vcc_1v8>;
-		/* vddio comes from regulator on module, use IO bank voltage instead */
-	};
  };
 
  &uart2 {
maintainer Applied
#2 lore raw
In reply to Chen-Yu Tsai
Quoted 8 lines · Chen-Yu Tsai

The Bluetooth node described in the device tree is actually on an M.2 slot. What module is present depends on what the end user installed, and should be left to an overlay.

Remove the existing bluetooth node. This gets rid of bogus timeout errors.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: rock-3a: Remove bluetooth node

      commit: 9602f47fe6dcca9318f35f7b72b4e98b91c5a5cf

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>