Skip to contentSkip to conversation

RDMA/hfi1: Remove unused one_qsfp_write

PATCH Applied [email protected] 2 participants 2 messages Feb 23, 2025 – Feb 24, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/hfi1: Remove unused one_qsfp_write

From: "Dr. David Alan Gilbert" <[email protected]>

The last use of one_qsfp_write() was removed in 2016's commit 145dd2b39958 ("IB/hfi1: Always turn on CDRs for low power QSFP modules")

Remove it.

---
 drivers/infiniband/hw/hfi1/qsfp.c | 20 --------------------
 drivers/infiniband/hw/hfi1/qsfp.h |  2 --
 2 files changed, 22 deletions(-)
drivers/infiniband/hw/hfi1/qsfp.c +0 -20
index 52cce1c8b76a..3b7842a7f634 100644
@@ -404,26 +404,6 @@ int qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
 	return count;
 }
 
-/*
- * Perform a stand-alone single QSFP write.  Acquire the resource, do the
- * write, then release the resource.
- */
-int one_qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
-		   int len)
-{
-	struct hfi1_devdata *dd = ppd->dd;
-	u32 resource = qsfp_resource(dd);
-	int ret;
-
-	ret = acquire_chip_resource(dd, resource, QSFP_WAIT);
-	if (ret)
-		return ret;
-	ret = qsfp_write(ppd, target, addr, bp, len);
-	release_chip_resource(dd, resource);
-
-	return ret;
-}
-
 /*
  * Access page n, offset m of QSFP memory as defined by SFF 8636
  * by reading @addr = ((256 * n) + m)
drivers/infiniband/hw/hfi1/qsfp.h +0 -2
index df1389bad86b..5c59d53fcb63 100644
@@ -195,8 +195,6 @@ int qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
 	       int len);
 int qsfp_read(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
 	      int len);
-int one_qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
-		   int len);
 int one_qsfp_read(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,
 		  int len);
 struct hfi1_asic_data;
Signature · 1 line
2.48.1