RDMA/hfi1: Remove unused one_qsfp_write
Subsystems (2)
PATCH 1/1 RDMA/hfi1: Remove unused one_qsfp_write
From: "Dr. David Alan Gilbert" <[email protected]>
The last use of one_qsfp_write() was removed in 2016's commit 145dd2b39958 ("IB/hfi1: Always turn on CDRs for low power QSFP modules")
Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
--- drivers/infiniband/hw/hfi1/qsfp.c | 20 -------------------- drivers/infiniband/hw/hfi1/qsfp.h | 2 -- 2 files changed, 22 deletions(-)
drivers/infiniband/hw/hfi1/qsfp.c +0 -20
@@ -404,26 +404,6 @@ int qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp,return count; } -/* -* Perform a stand-alone single QSFP write. Acquire the resource, do the -* write, then release the resource. -*/ -int one_qsfp_write (struct hfi1_pportdata *ppd,u32 target,int addr,void *bp, -int len) -{ -struct hfi1_devdata *dd = ppd->dd; -u32 resource =qsfp_resource (dd); -int ret; - - ret =acquire_chip_resource (dd, resource,QSFP_WAIT ); -if (ret) -return ret; - ret =qsfp_write (ppd, target, addr, bp, len); -release_chip_resource (dd, resource); - -return ret; -} -/* * Access page n, offset m of QSFP memory as defined by SFF 8636 * by reading @addr = ((256 * n) + m)
drivers/infiniband/hw/hfi1/qsfp.h +0 -2
@@ -195,8 +195,6 @@ int qsfp_write(struct hfi1_pportdata *ppd, u32 target, int addr, void *bp, int len);int qsfp_read (struct hfi1_pportdata *ppd,u32 target,int addr,void *bp,int len); -int one_qsfp_write (struct hfi1_pportdata *ppd,u32 target,int addr,void *bp, -int len);int one_qsfp_read (struct hfi1_pportdata *ppd,u32 target,int addr,void *bp,int len);struct hfi1_asic_data ;
Signature · 1 line
2.48.1
Leon Romanovsky
AppliedQuoted 8 lines · On Sun, 23 Feb 2025 21:55:43 +0000, [email protected] wrote:
The last use of
one_qsfp_write()was removed in 2016's commit145dd2b39958("IB/hfi1: Always turn on CDRs for low power QSFP modules")Remove it.
[...]
Applied, thanks!
[1/1] RDMA/hfi1: Remove unused one_qsfp_write
https://git.kernel.org/rdma/rdma/c/ba7fbaa6a83e5c
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>