Skip to contentSkip to conversation

dt-bindings: iio: accel: add binding documentation for ADIS16203

PATCH In review Saalim Quadri 5 participants 6 messages Mar 3, 2025 – Mar 6, 2025

Subsystems (4)
Device tree bindings Staging IIO Analog Devices IIO drivers
lore
Share & tools
lore

Saalim Quadri

author
#0 lore raw

PATCH v2 1/1 dt-bindings: iio: accel: add binding documentation for ADIS16203

This patch add device tree binding documentation for ADIS16203.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: change compatible property from enum to const

 .../bindings/iio/accel/adi,adis16203.yaml     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml new file +52 -0
new file mode 100644
index 000000000000..64370f13e1dc
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/accel/adi,adis16203.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADIS16203 Programmable 360 Degrees Inclinometer
+
+maintainers:
+  - Barry Song <[email protected]>
+
+description: |
+  https://www.analog.com/media/en/technical-documentation/data-sheets/adis16203.pdf
+
+properties:
+  compatible:
+    const:
+      - adi,adis16203
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        accelerometer@0 {
+            compatible = "adi,adis16203";
+            reg = <0>;
+            spi-max-frequency = <2500000>;
+            interrupt-parent = <&gpio0>;
+            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+        };
+    };
+...
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 11 lines · Saalim Quadri

This patch add device tree binding documentation for ADIS16203.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: change compatible property from enum to const

 .../bindings/iio/accel/adi,adis16203.yaml     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml: properties:compatible:const: ['adi,adis16203'] is not of type 'integer', 'string'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml: properties:compatible:const: ['adi,adis16203'] is not of type 'string'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
Documentation/devicetree/bindings/iio/accel/adi,adis16203.example.dtb: /example-0/spi/accelerometer@0: failed to match any schema with compatible: ['adi,adis16203']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

maintainer
#3 lore raw
In reply to Saalim Quadri
Quoted 17 lines · On Tue, 4 Mar 2025 05:29:30 +0530 Saalim Quadri <[email protected]> wrote:

This patch add device tree binding documentation for ADIS16203.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: change compatible property from enum to const

 .../bindings/iio/accel/adi,adis16203.yaml     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml new file +0 -0
new file mode 100644
index 000000000000..64370f13e1dc

Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml new file +10 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/accel/adi,adis16203.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADIS16203 Programmable 360 Degrees Inclinometer
+
+maintainers:
+  - Barry Song <[email protected]>

I think you'll be dropping this patch anyway, but just a quick not that it isn't good to volunteer people. Barry hasn't worked on these devices for quite a long time now so seems unlikely he agreed to this.

Jonathan

author
#4 lore raw

Apologies, it was a mistake on my end, I had wrong dependencies installed which passed the dt-bindings check on my end when I tried to verify.

Sincerely,
Saalim Quadri

#5 lore raw
In reply to Jonathan Cameron
Quoted 26 lines · Jonathan Cameron
Quoted 22 lines · On Tue, 4 Mar 2025 05:29:30 +0530 Saalim Quadri <[email protected]> wrote:

This patch add device tree binding documentation for ADIS16203.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: change compatible property from enum to const

 .../bindings/iio/accel/adi,adis16203.yaml     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml new file +5 -0
new file mode 100644
index 000000000000..64370f13e1dc
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/accel/adi,adis16203.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
Quoted 8 lines

Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml line 10

Quoted 5 lines
Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml new file +5 -0
+
+title: Analog Devices ADIS16203 Programmable 360 Degrees Inclinometer
+
+maintainers:
+  - Barry Song <[email protected]>

I think you'll be dropping this patch anyway, but just a quick not that it isn't good to volunteer people. Barry hasn't worked on these devices for quite a long time now so seems unlikely he agreed to this.

Hi Saalim, if you're sending a v2, feel free to nominate yourself or anyone interested as the maintainer. Apologies, but I probably won’t have time to handle this :-)

Quoted 2 lines

Jonathan

Thanks
Barry