Skip to contentSkip to conversation

iio: gyro: bmg160_spi: add of_match_table

PATCH In review Jun Yan 3 participants 3 messages Mar 6, 2025 – Mar 8, 2025 IIO

lore
Share & tools
lore

Jun Yan

author
#0 lore raw

PATCH v3 1/1 iio: gyro: bmg160_spi: add of_match_table

Add the missing of_match_table to bmg160_spi
driver to enhance device tree compatibility.

---

Changes in v3
- Adjust the content of the commit message; there are no code changes.
- Link to v2: https://lore.kernel.org/linux-iio/[email protected]/

Changes in v2
- Fix a syntax error (a missing comma after the .of_match_table = bmg160_of_match).
- Fix the style issues found by checkpatch.pl.
- Link to v1: https://lore.kernel.org/linux-iio/[email protected]/

---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+	{ .compatible = "bosch,bmg160" },
+	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
 	.driver = {
 		.name	= "bmg160_spi",
+		.of_match_table = bmg160_of_match,
 		.pm	= &bmg160_pm_ops,
 	},
 	.probe		= bmg160_spi_probe,
Signature · 1 line
2.48.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 6 lines · Jun Yan

Add the missing of_match_table to bmg160_spi
driver to enhance device tree compatibility.

---

LGTM

Quoted 42 lines

Changes in v3
- Adjust the content of the commit message; there are no code changes.
- Link to v2: https://lore.kernel.org/linux-iio/[email protected]/

Changes in v2
- Fix a syntax error (a missing comma after the .of_match_table = bmg160_of_match).
- Fix the style issues found by checkpatch.pl.
- Link to v1: https://lore.kernel.org/linux-iio/[email protected]/

---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+	{ .compatible = "bosch,bmg160" },
+	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
 	.driver = {
 		.name	= "bmg160_spi",
+		.of_match_table = bmg160_of_match,
 		.pm	= &bmg160_pm_ops,
 	},
 	.probe		= bmg160_spi_probe,
Signature · 1 line
2.48.1
maintainer
#2 lore raw
Quoted 3 lines · On Fri, 7 Mar 2025 00:46:29 -0300 Marcelo Schmitt <[email protected]>…
Quoted 2 lines · Jun Yan

Add the missing of_match_table to bmg160_spi
driver to enhance device tree compatibility.

Wrap commit messages to 75 chars.

Quoted 8 lines
Quoted 4 lines

---

LGTM

Applied with commit message wrap tweaked. Initially applied to the testing branch of iio.git to give some exposure to the 0-day bot.

Thanks,

Jonathan

Quoted 43 lines
Quoted 43 lines

Changes in v3
- Adjust the content of the commit message; there are no code changes.
- Link to v2: https://lore.kernel.org/linux-iio/[email protected]/

Changes in v2
- Fix a syntax error (a missing comma after the .of_match_table = bmg160_of_match).
- Fix the style issues found by checkpatch.pl.
- Link to v1: https://lore.kernel.org/linux-iio/[email protected]/

---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+	{ .compatible = "bosch,bmg160" },
+	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
 	.driver = {
 		.name	= "bmg160_spi",
+		.of_match_table = bmg160_of_match,
 		.pm	= &bmg160_pm_ops,
 	},
 	.probe		= bmg160_spi_probe,
Signature · 1 line
2.48.1