Skip to contentSkip to conversation

iio: gyro: bmg160: Improve BMG160 driver with of_match_table support

PATCH Superseded Jun Yan 2 participants 6 messages Feb 20, 2025 – Mar 6, 2025 IIO

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jun Yan

author
#0 lore raw

v2 cover iio: gyro: bmg160: Improve BMG160 driver with of_match_table support

This patch set enhances BMG160 gyro driver and improve device-tree compatibility.

---
Changes in v2
- Fix a syntax error (a missing comma after the .of_match_table = bmg160_of_match).
- Fix the style issues found by checkpatch.pl.
- Link to v1: https://lore.kernel.org/linux-iio/[email protected]/
---

Jun Yan (2):
iio: gyro: bmg160_spi: add of_match_table
iio: gyro: bmg160_i2c: add BMI088 to of_match_table

 drivers/iio/gyro/bmg160_i2c.c |  1 +
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 2 files changed, 11 insertions(+)
Signature · 1 line
2.48.1
author
#1 lore raw

PATCH v2 1/2 iio: gyro: bmg160_spi: add of_match_table

Add of_match_table to bmg160_spi driver.

This fixes automatic driver loading by userspace When using the device tree and the driver is built as a module, devices can be probed.

---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+	{ .compatible = "bosch,bmg160" },
+	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
 	.driver = {
 		.name	= "bmg160_spi",
+		.of_match_table = bmg160_of_match,
 		.pm	= &bmg160_pm_ops,
 	},
 	.probe		= bmg160_spi_probe,
Signature · 1 line
2.48.1
maintainer
#2 lore raw

Re: [PATCH v2 1/2] iio: gyro: bmg160_spi: add of_match_table

Quoted 5 lines · On Fri, 21 Feb 2025 00:50:00 +0800 Jun Yan <[email protected]> wrote:

Add of_match_table to bmg160_spi driver.

This fixes automatic driver loading by userspace When using the device tree and the driver is built as a module, devices can be probed.

Wrap patch descriptions at 75 chars as mentioned in submitting-patches.rst

Quoted 2 lines

Hi.

The patch content is fine, but I'm doubtful about the autoloading. Did you actually try this and see a failure without this patch?

For SPI autoloading even with device tree compatibles should work without the of_match_table though it will match against the compatible without the bosch, part. Maybe I missed a change that means that no longer works.

I in general don't mind the actual change because it does ensure we have the manufacturer in the match as well so makes future problems less likely.

Jonathan

Quoted 28 lines
---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+	{ .compatible = "bosch,bmg160" },
+	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
 	.driver = {
 		.name	= "bmg160_spi",
+		.of_match_table = bmg160_of_match,
 		.pm	= &bmg160_pm_ops,
 	},
 	.probe		= bmg160_spi_probe,
author
#3 lore raw

Re: [PATCH v2 1/2] iio: gyro: bmg160_spi: add of_match_table

I'm sorry. The commit message was referenced from other similar submissions and hasn't been actually verified. I will resubmit the patch in V3.

Quoted 60 lines · Jonathan Cameron
Quoted 5 lines · On Fri, 21 Feb 2025 00:50:00 +0800 Jun Yan <[email protected]> wrote:

Add of_match_table to bmg160_spi driver.

This fixes automatic driver loading by userspace When using the device tree and the driver is built as a module, devices can be probed.

Wrap patch descriptions at 75 chars as mentioned in submitting-patches.rst

Quoted 2 lines

Hi.

The patch content is fine, but I'm doubtful about the autoloading. Did you actually try this and see a failure without this patch?

For SPI autoloading even with device tree compatibles should work without the of_match_table though it will match against the compatible without the bosch, part. Maybe I missed a change that means that no longer works.

I in general don't mind the actual change because it does ensure we have the manufacturer in the match as well so makes future problems less likely.

Jonathan

Quoted 28 lines
---
 drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/iio/gyro/bmg160_spi.c +10 -0
index fc2e453527b9..ac04b3b1b554 100644
@@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
 
+static const struct of_device_id bmg160_of_match[] = {
+     { .compatible = "bosch,bmg160" },
+     { .compatible = "bosch,bmi055_gyro" },
+     { .compatible = "bosch,bmi088_gyro" },
+     { }
+};
+
+MODULE_DEVICE_TABLE(of, bmg160_of_match);
+
 static struct spi_driver bmg160_spi_driver = {
      .driver = {
              .name   = "bmg160_spi",
+             .of_match_table = bmg160_of_match,
              .pm     = &bmg160_pm_ops,
      },
      .probe          = bmg160_spi_probe,
author
#4 lore raw

PATCH v2 2/2 iio: gyro: bmg160_i2c: add BMI088 to of_match_table

In reply to Jun Yan

BMI088 is missing from the of_match_table. Let's complete it.

---
 drivers/iio/gyro/bmg160_i2c.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/gyro/bmg160_i2c.c +1 -0
index 9c5d7e8ee99c..e6caab49f98a 100644
@@ -58,6 +58,7 @@ MODULE_DEVICE_TABLE(i2c, bmg160_i2c_id);
 static const struct of_device_id bmg160_of_match[] = {
 	{ .compatible = "bosch,bmg160" },
 	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
 	{ }
 };
 
Signature · 1 line
2.48.1
maintainer
#5 lore raw

Re: [PATCH v2 2/2] iio: gyro: bmg160_i2c: add BMI088 to of_match_table

Quoted 3 lines · On Fri, 21 Feb 2025 00:50:01 +0800 Jun Yan <[email protected]> wrote:

BMI088 is missing from the of_match_table. Let's complete it.

Applied this patch. I'll initially push out as testing for 0-day to see if it can find any problems.

Thanks,

Jonathan

Quoted 16 lines
---
 drivers/iio/gyro/bmg160_i2c.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/gyro/bmg160_i2c.c +1 -0
index 9c5d7e8ee99c..e6caab49f98a 100644
@@ -58,6 +58,7 @@ MODULE_DEVICE_TABLE(i2c, bmg160_i2c_id);
 static const struct of_device_id bmg160_of_match[] = {
 	{ .compatible = "bosch,bmg160" },
 	{ .compatible = "bosch,bmi055_gyro" },
+	{ .compatible = "bosch,bmi088_gyro" },
 	{ }
 };