riscv: add SBI FWFT misaligned exception delegation support
Subsystems (5)
v3 cover riscv: add SBI FWFT misaligned exception delegation support
The SBI Firmware Feature extension allows the S-mode to request some specific features (either hardware or software) to be enabled. This series uses this extension to request misaligned access exception delegation to S-mode in order to let the kernel handle it. It also adds support for the KVM FWFT SBI extension based on the misaligned access handling infrastructure.
FWFT SBI extension is part of the SBI V3.0 specifications [1]. It can be tested using the qemu provided at [2] which contains the series from [3]. kvm-unit-tests [4] can be used inside kvm to tests the correct delegation of misaligned exceptions. Upstream OpenSBI can be used.
Note: Since SBI V3.0 is not yet ratified, FWFT extension API is split between interface only and implementation, allowing to pick only the interface which do not have hard dependencies on SBI.
The tests can be run using the included kselftest:
$ qemu-system-riscv64 \ -cpu rv64,trap-misaligned-access=true,v=true \ -M virt \ -m 1024M \ -bios fw_dynamic.bin \ -kernel Image ...
# ./misaligned TAP version 13 1..23 # Starting 23 tests from 1 test cases. # RUN global.gp_load_lh ... # OK global.gp_load_lh ok 1 global.gp_load_lh # RUN global.gp_load_lhu ... # OK global.gp_load_lhu ok 2 global.gp_load_lhu # RUN global.gp_load_lw ... # OK global.gp_load_lw ok 3 global.gp_load_lw # RUN global.gp_load_lwu ... # OK global.gp_load_lwu ok 4 global.gp_load_lwu # RUN global.gp_load_ld ... # OK global.gp_load_ld ok 5 global.gp_load_ld # RUN global.gp_load_c_lw ... # OK global.gp_load_c_lw ok 6 global.gp_load_c_lw # RUN global.gp_load_c_ld ... # OK global.gp_load_c_ld ok 7 global.gp_load_c_ld # RUN global.gp_load_c_ldsp ... # OK global.gp_load_c_ldsp ok 8 global.gp_load_c_ldsp # RUN global.gp_load_sh ... # OK global.gp_load_sh ok 9 global.gp_load_sh # RUN global.gp_load_sw ... # OK global.gp_load_sw ok 10 global.gp_load_sw # RUN global.gp_load_sd ... # OK global.gp_load_sd ok 11 global.gp_load_sd # RUN global.gp_load_c_sw ... # OK global.gp_load_c_sw ok 12 global.gp_load_c_sw # RUN global.gp_load_c_sd ... # OK global.gp_load_c_sd ok 13 global.gp_load_c_sd # RUN global.gp_load_c_sdsp ... # OK global.gp_load_c_sdsp ok 14 global.gp_load_c_sdsp # RUN global.fpu_load_flw ... # OK global.fpu_load_flw ok 15 global.fpu_load_flw # RUN global.fpu_load_fld ... # OK global.fpu_load_fld ok 16 global.fpu_load_fld # RUN global.fpu_load_c_fld ... # OK global.fpu_load_c_fld ok 17 global.fpu_load_c_fld # RUN global.fpu_load_c_fldsp ... # OK global.fpu_load_c_fldsp ok 18 global.fpu_load_c_fldsp # RUN global.fpu_store_fsw ... # OK global.fpu_store_fsw ok 19 global.fpu_store_fsw # RUN global.fpu_store_fsd ... # OK global.fpu_store_fsd ok 20 global.fpu_store_fsd # RUN global.fpu_store_c_fsd ... # OK global.fpu_store_c_fsd ok 21 global.fpu_store_c_fsd # RUN global.fpu_store_c_fsdsp ... # OK global.fpu_store_c_fsdsp ok 22 global.fpu_store_c_fsdsp # RUN global.gen_sigbus ... [12797.988647] misaligned[618]: unhandled signal 7 code 0x1 at 0x0000000000014dc0 in misaligned[4dc0,10000+76000] [12797.988990] CPU: 0 UID: 0 PID: 618 Comm: misaligned Not tainted 6.13.0-rc6-00008-g4ec4468967c9-dirty #51 [12797.989169] Hardware name: riscv-virtio,qemu (DT) [12797.989264] epc : 0000000000014dc0 ra : 0000000000014d00 sp : 00007fffe165d100 [12797.989407] gp : 000000000008f6e8 tp : 0000000000095760 t0 : 0000000000000008 [12797.989544] t1 : 00000000000965d8 t2 : 000000000008e830 s0 : 00007fffe165d160 [12797.989692] s1 : 000000000000001a a0 : 0000000000000000 a1 : 0000000000000002 [12797.989831] a2 : 0000000000000000 a3 : 0000000000000000 a4 : ffffffffdeadbeef [12797.989964] a5 : 000000000008ef61 a6 : 626769735f6e0000 a7 : fffffffffffff000 [12797.990094] s2 : 0000000000000001 s3 : 00007fffe165d838 s4 : 00007fffe165d848 [12797.990238] s5 : 000000000000001a s6 : 0000000000010442 s7 : 0000000000010200 [12797.990391] s8 : 000000000000003a s9 : 0000000000094508 s10: 0000000000000000 [12797.990526] s11: 0000555567460668 t3 : 00007fffe165d070 t4 : 00000000000965d0 [12797.990656] t5 : fefefefefefefeff t6 : 0000000000000073 [12797.990756] status: 0000000200004020 badaddr: 000000000008ef61 cause: 0000000000000006 [12797.990911] Code: 8793 8791 3423 fcf4 3783 fc84 c737 dead 0713 eef7 (c398) 0001 # OK global.gen_sigbus ok 23 global.gen_sigbus # PASSED: 23 / 23 tests passed. # Totals: pass:23 fail:0 xfail:0 xpass:0 skip:0 error:0
With kvm-tools:
# lkvm run -k sbi.flat -m 128 Info: # lkvm run -k sbi.flat -m 128 -c 1 --name guest-97 Info: Removed ghost socket file "/root/.lkvm//guest-97.sock".
##########################################################################
# kvm-unit-tests
##########################################################################
... [test messages elided]
PASS: sbi: fwft: FWFT extension probing no error
PASS: sbi: fwft: get/set reserved feature 0x6 error == SBI_ERR_DENIED
PASS: sbi: fwft: get/set reserved feature 0x3fffffff error == SBI_ERR_DENIED
PASS: sbi: fwft: get/set reserved feature 0x80000000 error == SBI_ERR_DENIED
PASS: sbi: fwft: get/set reserved feature 0xbfffffff error == SBI_ERR_DENIED
PASS: sbi: fwft: misaligned_deleg: Get misaligned deleg feature no error
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature invalid value error
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature invalid value error
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature value no error
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature value 0
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature value no error
PASS: sbi: fwft: misaligned_deleg: Set misaligned deleg feature value 1
PASS: sbi: fwft: misaligned_deleg: Verify misaligned load exception trap in supervisor
SUMMARY: 50 tests, 2 unexpected failures, 12 skipped
This series is available at [6].
---
V3:
- Added comment about kvm sbi fwft supported/set/get callback requirements
- Move struct kvm_sbi_fwft_feature in kvm_sbi_fwft.c
- Add a FWFT interface
V2:
- Added Kselftest for misaligned testing
- Added get_user() usage instead of __get_user()
- Reenable interrupt when possible in misaligned access handling
- Document that riscv supports unaligned-traps
- Fix KVM extension state when an init function is present
- Rework SBI misaligned accesses trap delegation code
- Added support for CPU hotplugging
- Added KVM SBI reset callback
- Added reset for KVM SBI FWFT lock
- Return SBI_ERR_DENIED_LOCKED when LOCK flag is set
Clément Léger (17):
riscv: add Firmware Feature (FWFT) SBI extensions definitions
riscv: sbi: add FWFT extension interface
riscv: sbi: add SBI FWFT extension calls
riscv: misaligned: request misaligned exception from SBI
riscv: misaligned: use on_each_cpu() for scalar misaligned access
probing
riscv: misaligned: use correct CONFIG_ ifdef for
misaligned_access_speed
riscv: misaligned: move emulated access uniformity check in a function
riscv: misaligned: add a function to check misalign trap delegability
riscv: misaligned: factorize trap handling
riscv: misaligned: enable IRQs while handling misaligned accesses
riscv: misaligned: use get_user() instead of __get_user() Documentation/sysctl: add riscv to unaligned-trap supported archs
selftests: riscv: add misaligned access testing
RISC-V: KVM: add SBI extension init()/deinit() functions
RISC-V: KVM: add SBI extension reset callback
RISC-V: KVM: add support for FWFT SBI extension
RISC-V: KVM: add support for SBI_FWFT_MISALIGNED_DELEG
Documentation/admin-guide/sysctl/kernel.rst | 4 +- arch/riscv/include/asm/cpufeature.h | 8 +- arch/riscv/include/asm/kvm_host.h | 5 +- arch/riscv/include/asm/kvm_vcpu_sbi.h | 12 + arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h | 31 +++ arch/riscv/include/asm/sbi.h | 38 +++ arch/riscv/include/uapi/asm/kvm.h | 1 + arch/riscv/kernel/sbi.c | 123 +++++++++ arch/riscv/kernel/traps.c | 57 ++-- arch/riscv/kernel/traps_misaligned.c | 119 +++++++- arch/riscv/kernel/unaligned_access_speed.c | 11 +- arch/riscv/kvm/Makefile | 1 + arch/riscv/kvm/vcpu.c | 7 +- arch/riscv/kvm/vcpu_sbi.c | 57 ++++ arch/riscv/kvm/vcpu_sbi_fwft.c | 251 +++++++++++++++++ arch/riscv/kvm/vcpu_sbi_sta.c | 3 +- .../selftests/riscv/misaligned/.gitignore | 1 + .../selftests/riscv/misaligned/Makefile | 12 + .../selftests/riscv/misaligned/common.S | 33 +++ .../testing/selftests/riscv/misaligned/fpu.S | 180 +++++++++++++ tools/testing/selftests/riscv/misaligned/gp.S | 103 +++++++ .../selftests/riscv/misaligned/misaligned.c | 254 ++++++++++++++++++ 22 files changed, 1264 insertions(+), 47 deletions(-) create mode 100644 arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h create mode 100644 arch/riscv/kvm/vcpu_sbi_fwft.c create mode 100644 tools/testing/selftests/riscv/misaligned/.gitignore create mode 100644 tools/testing/selftests/riscv/misaligned/Makefile create mode 100644 tools/testing/selftests/riscv/misaligned/common.S create mode 100644 tools/testing/selftests/riscv/misaligned/fpu.S create mode 100644 tools/testing/selftests/riscv/misaligned/gp.S create mode 100644 tools/testing/selftests/riscv/misaligned/misaligned.c
Signature · 1 line
2.47.2
PATCH v3 1/17 riscv: add Firmware Feature (FWFT) SBI extensions definitions
The Firmware Features extension (FWFT) was added as part of the SBI 3.0 specification. Add SBI definitions to use this extension.
--- arch/riscv/include/asm/sbi.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
arch/riscv/include/asm/sbi.h +33 -0
@@ -35,6 +35,7 @@ enum sbi_ext_id {SBI_EXT_DBCN =0x4442434E ,SBI_EXT_STA =0x535441 ,SBI_EXT_NACL =0x4E41434C , +SBI_EXT_FWFT =0x46574654 ,/* Experimentals extensions must lie within this range */ SBI_EXT_EXPERIMENTAL_START = 0x08000000,
@@ -402,6 +403,33 @@ enum sbi_ext_nacl_feature {#define SBI_NACL_SHMEM_SRET_X (__i) ((__riscv_xlen / 8) * (__i))#define SBI_NACL_SHMEM_SRET_X_LAST 31 +/* SBI function IDs for FW feature extension */ +#define SBI_EXT_FWFT_SET 0x0 +#define SBI_EXT_FWFT_GET 0x1 + +enum sbi_fwft_feature_t { +SBI_FWFT_MISALIGNED_EXC_DELEG =0x0 , +SBI_FWFT_LANDING_PAD =0x1 , +SBI_FWFT_SHADOW_STACK =0x2 , +SBI_FWFT_DOUBLE_TRAP =0x3 , +SBI_FWFT_PTE_AD_HW_UPDATING =0x4 , +SBI_FWFT_POINTER_MASKING_PMLEN =0x5 , +SBI_FWFT_LOCAL_RESERVED_START =0x6 , +SBI_FWFT_LOCAL_RESERVED_END =0x3fffffff , +SBI_FWFT_LOCAL_PLATFORM_START =0x40000000 , +SBI_FWFT_LOCAL_PLATFORM_END =0x7fffffff , + +SBI_FWFT_GLOBAL_RESERVED_START =0x80000000 , +SBI_FWFT_GLOBAL_RESERVED_END =0xbfffffff , +SBI_FWFT_GLOBAL_PLATFORM_START =0xc0000000 , +SBI_FWFT_GLOBAL_PLATFORM_END =0xffffffff , +}; + +#define SBI_FWFT_PLATFORM_FEATURE_BIT BIT(30) +#define SBI_FWFT_GLOBAL_FEATURE_BIT BIT(31) + +#define SBI_FWFT_SET_FLAG_LOCK BIT(0) +/* SBI spec version fields */ #define SBI_SPEC_VERSION_DEFAULT 0x1#define SBI_SPEC_VERSION_MAJOR_SHIFT 24
@@ -419,6 +447,11 @@ enum sbi_ext_nacl_feature {#define SBI_ERR_ALREADY_STARTED -7#define SBI_ERR_ALREADY_STOPPED -8#define SBI_ERR_NO_SHMEM -9 +#define SBI_ERR_INVALID_STATE -10 +#define SBI_ERR_BAD_RANGE -11 +#define SBI_ERR_TIMEOUT -12 +#define SBI_ERR_IO -13 +#define SBI_ERR_DENIED_LOCKED -14extern unsigned long sbi_spec_version;struct sbiret {
Signature · 1 line
2.47.2
Re: [PATCH v3 01/17] riscv: add Firmware Feature (FWFT) SBI extensions definitions
Quoted 11 lines · Clément Léger
The Firmware Features extension (FWFT) was added as part of the SBI 3.0 specification. Add SBI definitions to use this extension.
Signed-off-by Clément Léger <[email protected]>Reviewed-by Samuel Holland <[email protected]>Tested-by Samuel Holland <[email protected]>Reviewed-by Deepak Gupta <[email protected]>--- arch/riscv/include/asm/sbi.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
PATCH v3 2/17 riscv: sbi: add FWFT extension interface
In reply to Clément LégerThis SBI extensions enables supervisor mode to control feature that are under M-mode control (For instance, Svadu menvcfg ADUE bit, Ssdbltrp DTE, etc).
--- arch/riscv/include/asm/sbi.h | 5 ++ arch/riscv/kernel/sbi.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+)
arch/riscv/include/asm/sbi.h +5 -0
@@ -503,6 +503,11 @@ int sbi_remote_hfence_vvma_asid(const struct cpumask *cpu_mask, unsigned long asid);long sbi_probe_extension (int ext); +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_failure); +int sbi_fwft_get (u32 feature,unsigned long *value); +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags); +/* Check if current SBI specification version is 0.1 or not */ static inline int sbi_spec_is_0_1 (void ) {
arch/riscv/kernel/sbi.c +97 -0
103 lines not on this page · raw message
Signature · 1 line
2.47.2
Re: [PATCH v3 02/17] riscv: sbi: add FWFT extension interface
Quoted 31 lines · Clément Léger
This SBI extensions enables supervisor mode to control feature that are under M-mode control (For instance, Svadu menvcfg ADUE bit, Ssdbltrp DTE, etc).
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/sbi.h | 5 ++ arch/riscv/kernel/sbi.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+)arch/riscv/include/asm/sbi.h +5
-0@@ -503,6 +503,11 @@ int sbi_remote_hfence_vvma_asid(const struct cpumask *cpu_mask, unsigned long asid);long sbi_probe_extension (int ext); +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_failure); +int sbi_fwft_get (u32 feature,unsigned long *value); +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags); +/* Check if current SBI specification version is 0.1 or not */ static inline int sbi_spec_is_0_1 (void ) {arch/riscv/kernel/sbi.c +0
-0
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 308
Quoted 10 lines
arch/riscv/kernel/sbi.c +7
-0@@ -299,6 +299,103 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +int sbi_fwft_get (u32 feature,unsigned long *value) +{ +return -EOPNOTSUPP ; +} + +/** +* sbi_fwft_set() - Set a feature on all online cpus
copy+paste of description from sbi_fwft_all_cpus_set(). This function only sets the feature on the calling hart.
Quoted 33 lines
arch/riscv/kernel/sbi.c +33
-0+* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) +{ +return -EOPNOTSUPP ; +} + +struct fwft_set_req { +u32 feature; +unsigned long value; +unsigned long flags; +cpumask_t mask; +}; + +static void cpu_sbi_fwft_set (void *arg) +{ +struct fwft_set_req *req = arg; + +if (sbi_fwft_set (req->feature, req->value, req->flags)) +cpumask_clear_cpu (smp_processor_id (), &req->mask); +} + +static int sbi_fwft_feature_local_set (u32 feature,unsigned long value, +unsigned long flags, +bool revert_on_fail) +{ +int ret; +unsigned long prev_value; +cpumask_t tmp;
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 351
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+struct fwft_set_req req = { + .feature = feature, + .value = value, + .flags = flags, + }; + +cpumask_copy (&req.mask, cpu_online_mask); + +/* We can not revert if features are locked */ +if (revert_on_fail && flags &SBI_FWFT_SET_FLAG_LOCK )
Should use () around the flags &. I thought checkpatch complained about that?
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 354
Quoted 3 lines
arch/riscv/kernel/sbi.c +3
-0+return -EINVAL ; + +/* Reset value is the same for all cpus, read it once. */
How do we know we're reading the reset value? sbi_fwft_all_cpus_set() may be called multiple times on the same feature. And harts may have had sbi_fwft_set() called on them independently. I think we should drop the whole prev_value optimization.
Quoted 4 lines
arch/riscv/kernel/sbi.c +4
-0+ ret =sbi_fwft_get (feature, &prev_value); +if (ret) +return ret; +
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 368
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+/* Feature might already be set to the value we want */ +if (prev_value == value) +return 0 ; + +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, cpu_online_mask)) +return 0 ; + +pr_err ("Failed to set feature %x for all online cpus, reverting\n" , + feature);
nit: I'd let the above line stick out. We have 100 chars.
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 374
Quoted 6 lines
arch/riscv/kernel/sbi.c +6
-0+ + req.value = prev_value; +cpumask_copy (&tmp, &req.mask); +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, &tmp)) +return 0 ;
I'm not sure we want the revert_on_fail support either. What happens when the revert fails and we return -EINVAL below? Also returning zero when revert succeeds means the caller won't know if we successfully set what we wanted or just successfully reverted.
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 384
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+ +return -EINVAL ; +} + +/** +* sbi_fwft_all_cpus_set() - Set a feature on all online cpus +* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* @revert_on_fail: true if feature value should be restored to it's orignal
its original
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 385
Quoted 1 line
arch/riscv/kernel/sbi.c +1
-0+* value on failure.
Line 'value' up under 'true'
Quoted 18 lines
arch/riscv/kernel/sbi.c +13
-0+* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_fail) +{ +if (feature &SBI_FWFT_GLOBAL_FEATURE_BIT ) +return sbi_fwft_set (feature, value, flags); + +return sbi_fwft_feature_local_set (feature, value, flags, + revert_on_fail); +} +/** * sbi_set_timer() - Program the timer for next timer event. * @stime_value: The value after which next timer event should fire. Signature · 1 line
2.47.2
Thanks,
drew
Re: [PATCH v3 02/17] riscv: sbi: add FWFT extension interface
Quoted 93 lines · Andrew Jones
Quoted 31 lines · Clément Léger
This SBI extensions enables supervisor mode to control feature that are under M-mode control (For instance, Svadu menvcfg ADUE bit, Ssdbltrp DTE, etc).
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/sbi.h | 5 ++ arch/riscv/kernel/sbi.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+)arch/riscv/include/asm/sbi.h +5
-0@@ -503,6 +503,11 @@ int sbi_remote_hfence_vvma_asid(const struct cpumask *cpu_mask, unsigned long asid);long sbi_probe_extension (int ext); +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_failure); +int sbi_fwft_get (u32 feature,unsigned long *value); +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags); +/* Check if current SBI specification version is 0.1 or not */ static inline int sbi_spec_is_0_1 (void ) {arch/riscv/kernel/sbi.c +0
-0arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 308
Quoted 10 lines
arch/riscv/kernel/sbi.c +7
-0@@ -299,6 +299,103 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +int sbi_fwft_get (u32 feature,unsigned long *value) +{ +return -EOPNOTSUPP ; +} + +/** +* sbi_fwft_set() - Set a feature on all online cpus copy+paste of description from
sbi_fwft_all_cpus_set(). This function only sets the feature on the calling hart.Quoted 33 lines
arch/riscv/kernel/sbi.c +33
-0+* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) +{ +return -EOPNOTSUPP ; +} + +struct fwft_set_req { +u32 feature; +unsigned long value; +unsigned long flags; +cpumask_t mask; +}; + +static void cpu_sbi_fwft_set (void *arg) +{ +struct fwft_set_req *req = arg; + +if (sbi_fwft_set (req->feature, req->value, req->flags)) +cpumask_clear_cpu (smp_processor_id (), &req->mask); +} + +static int sbi_fwft_feature_local_set (u32 feature,unsigned long value, +unsigned long flags, +bool revert_on_fail) +{ +int ret; +unsigned long prev_value; +cpumask_t tmp;arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 351
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+struct fwft_set_req req = { + .feature = feature, + .value = value, + .flags = flags, + }; + +cpumask_copy (&req.mask, cpu_online_mask); + +/* We can not revert if features are locked */ +if (revert_on_fail && flags &SBI_FWFT_SET_FLAG_LOCK )Should use () around the flags &. I thought checkpatch complained about that?
Quoted 8 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 354
Quoted 3 lines
arch/riscv/kernel/sbi.c +3
-0+return -EINVAL ; + +/* Reset value is the same for all cpus, read it once. */ How do we know we're reading the reset value?
sbi_fwft_all_cpus_set()may be called multiple times on the same feature. And harts may have hadsbi_fwft_set()called on them independently. I think we should drop the wholeprev_valueoptimization.
That's actually used for revert_on_failure as well not only the optimization.
Quoted 18 lines
Quoted 5 lines
arch/riscv/kernel/sbi.c +4
-0+ ret =sbi_fwft_get (feature, &prev_value); +if (ret) +return ret; +arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 368
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+/* Feature might already be set to the value we want */ +if (prev_value == value) +return 0 ; + +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, cpu_online_mask)) +return 0 ; + +pr_err ("Failed to set feature %x for all online cpus, reverting\n" , + feature);nit: I'd let the above line stick out. We have 100 chars.
Quoted 11 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 374
Quoted 6 lines
arch/riscv/kernel/sbi.c +6
-0+ + req.value = prev_value; +cpumask_copy (&tmp, &req.mask); +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, &tmp)) +return 0 ;I'm not sure we want the
revert_on_failsupport either. What happens when the revert fails and we return-EINVALbelow? Also returning zero when revert succeeds means the caller won't know if we successfully set what we wanted or just successfully reverted.
So that might actually be needed for features that needs to be enabled on all hart or not enabled at all. If we fail to enable all of them, them the hart will be in some non coherent state between the harts. The returned error code though is wrong and I'm not sure we would have a way to gracefully handle revertion failure (except maybe panicking ?).
Thanks,
Clément
Quoted 39 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 384
Quoted 11 lines
arch/riscv/kernel/sbi.c +10
-0+ +return -EINVAL ; +} + +/** +* sbi_fwft_all_cpus_set() - Set a feature on all online cpus +* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* @revert_on_fail: true if feature value should be restored to it's orignal its original
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 385
Quoted 1 line
arch/riscv/kernel/sbi.c +1
-0+* value on failure. Line 'value' up under 'true'
Quoted 18 lines
arch/riscv/kernel/sbi.c +13
-0+* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_fail) +{ +if (feature &SBI_FWFT_GLOBAL_FEATURE_BIT ) +return sbi_fwft_set (feature, value, flags); + +return sbi_fwft_feature_local_set (feature, value, flags, + revert_on_fail); +} +/** * sbi_set_timer() - Program the timer for next timer event. * @stime_value: The value after which next timer event should fire. Signature · 1 line
2.47.2Thanks,
drew
Re: [PATCH v3 02/17] riscv: sbi: add FWFT extension interface
Quoted 105 lines · Clément Léger
Quoted 93 lines · Andrew Jones
Quoted 31 lines · Clément Léger
This SBI extensions enables supervisor mode to control feature that are under M-mode control (For instance, Svadu menvcfg ADUE bit, Ssdbltrp DTE, etc).
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/sbi.h | 5 ++ arch/riscv/kernel/sbi.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+)arch/riscv/include/asm/sbi.h +5
-0@@ -503,6 +503,11 @@ int sbi_remote_hfence_vvma_asid(const struct cpumask *cpu_mask, unsigned long asid);long sbi_probe_extension (int ext); +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_failure); +int sbi_fwft_get (u32 feature,unsigned long *value); +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags); +/* Check if current SBI specification version is 0.1 or not */ static inline int sbi_spec_is_0_1 (void ) {arch/riscv/kernel/sbi.c +0
-0arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 308
Quoted 10 lines
arch/riscv/kernel/sbi.c +7
-0@@ -299,6 +299,103 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +int sbi_fwft_get (u32 feature,unsigned long *value) +{ +return -EOPNOTSUPP ; +} + +/** +* sbi_fwft_set() - Set a feature on all online cpus copy+paste of description from
sbi_fwft_all_cpus_set(). This function only sets the feature on the calling hart.Quoted 33 lines
arch/riscv/kernel/sbi.c +33
-0+* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) +{ +return -EOPNOTSUPP ; +} + +struct fwft_set_req { +u32 feature; +unsigned long value; +unsigned long flags; +cpumask_t mask; +}; + +static void cpu_sbi_fwft_set (void *arg) +{ +struct fwft_set_req *req = arg; + +if (sbi_fwft_set (req->feature, req->value, req->flags)) +cpumask_clear_cpu (smp_processor_id (), &req->mask); +} + +static int sbi_fwft_feature_local_set (u32 feature,unsigned long value, +unsigned long flags, +bool revert_on_fail) +{ +int ret; +unsigned long prev_value; +cpumask_t tmp;arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 351
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+struct fwft_set_req req = { + .feature = feature, + .value = value, + .flags = flags, + }; + +cpumask_copy (&req.mask, cpu_online_mask); + +/* We can not revert if features are locked */ +if (revert_on_fail && flags &SBI_FWFT_SET_FLAG_LOCK )Should use () around the flags &. I thought checkpatch complained about that?
Quoted 8 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 354
Quoted 3 lines
arch/riscv/kernel/sbi.c +3
-0+return -EINVAL ; + +/* Reset value is the same for all cpus, read it once. */ How do we know we're reading the reset value?
sbi_fwft_all_cpus_set()may be called multiple times on the same feature. And harts may have hadsbi_fwft_set()called on them independently. I think we should drop the wholeprev_valueoptimization.
Quoted 2 lines
That's actually used for
revert_on_failureas well not only the optimization.
At least the comment should drop the word 'Reset' and if there's a chance that not all harts having the same value then we should call get on all of them. (We'll probably want SBI FWFT functions which operate on hartmasks eventually.)
Quoted 31 lines
Quoted 19 lines
Quoted 6 lines
arch/riscv/kernel/sbi.c +4
-0+ ret =sbi_fwft_get (feature, &prev_value); +if (ret) +return ret; +arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 368
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+/* Feature might already be set to the value we want */ +if (prev_value == value) +return 0 ; + +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, cpu_online_mask)) +return 0 ; + +pr_err ("Failed to set feature %x for all online cpus, reverting\n" , + feature);nit: I'd let the above line stick out. We have 100 chars.
Quoted 11 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 374
Quoted 6 lines
arch/riscv/kernel/sbi.c +6
-0+ + req.value = prev_value; +cpumask_copy (&tmp, &req.mask); +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, &tmp)) +return 0 ;I'm not sure we want the
revert_on_failsupport either. What happens when the revert fails and we return-EINVALbelow? Also returning zero when revert succeeds means the caller won't know if we successfully set what we wanted or just successfully reverted.
Quoted 5 lines
So that might actually be needed for features that needs to be enabled on all hart or not enabled at all. If we fail to enable all of them, them the hart will be in some non coherent state between the harts. The returned error code though is wrong and I'm not sure we would have a way to gracefully handle revertion failure (except maybe panicking ?).
How about offlining all harts which don't have the desired state, along with complaining loudly to the boot log.
Thanks,
drew
Re: [PATCH v3 02/17] riscv: sbi: add FWFT extension interface
Quoted 106 lines · Andrew Jones
Quoted 105 lines · Clément Léger
Quoted 101 lines · Andrew Jones
Quoted 31 lines · Clément Léger
This SBI extensions enables supervisor mode to control feature that are under M-mode control (For instance, Svadu menvcfg ADUE bit, Ssdbltrp DTE, etc).
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/sbi.h | 5 ++ arch/riscv/kernel/sbi.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+)arch/riscv/include/asm/sbi.h +5
-0@@ -503,6 +503,11 @@ int sbi_remote_hfence_vvma_asid(const struct cpumask *cpu_mask, unsigned long asid);long sbi_probe_extension (int ext); +int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags, +bool revert_on_failure); +int sbi_fwft_get (u32 feature,unsigned long *value); +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags); +/* Check if current SBI specification version is 0.1 or not */ static inline int sbi_spec_is_0_1 (void ) {arch/riscv/kernel/sbi.c +0
-0arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 308
Quoted 10 lines
arch/riscv/kernel/sbi.c +7
-0@@ -299,6 +299,103 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +int sbi_fwft_get (u32 feature,unsigned long *value) +{ +return -EOPNOTSUPP ; +} + +/** +* sbi_fwft_set() - Set a feature on all online cpus copy+paste of description from
sbi_fwft_all_cpus_set(). This function only sets the feature on the calling hart.Quoted 33 lines
arch/riscv/kernel/sbi.c +33
-0+* @feature: The feature to be set +* @value: The feature value to be set +* @flags: FWFT feature set flags +* +* Return: 0 on success, appropriate linux error code otherwise. +*/ +int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) +{ +return -EOPNOTSUPP ; +} + +struct fwft_set_req { +u32 feature; +unsigned long value; +unsigned long flags; +cpumask_t mask; +}; + +static void cpu_sbi_fwft_set (void *arg) +{ +struct fwft_set_req *req = arg; + +if (sbi_fwft_set (req->feature, req->value, req->flags)) +cpumask_clear_cpu (smp_processor_id (), &req->mask); +} + +static int sbi_fwft_feature_local_set (u32 feature,unsigned long value, +unsigned long flags, +bool revert_on_fail) +{ +int ret; +unsigned long prev_value; +cpumask_t tmp;arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 351
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+struct fwft_set_req req = { + .feature = feature, + .value = value, + .flags = flags, + }; + +cpumask_copy (&req.mask, cpu_online_mask); + +/* We can not revert if features are locked */ +if (revert_on_fail && flags &SBI_FWFT_SET_FLAG_LOCK )Should use () around the flags &. I thought checkpatch complained about that?
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 354
Quoted 3 lines
arch/riscv/kernel/sbi.c +3
-0+return -EINVAL ; + +/* Reset value is the same for all cpus, read it once. */ How do we know we're reading the reset value?
sbi_fwft_all_cpus_set()may be called multiple times on the same feature. And harts may have hadsbi_fwft_set()called on them independently. I think we should drop the wholeprev_valueoptimization.
Quoted 7 lines
Quoted 2 lines
That's actually used for
revert_on_failureas well not only the optimization.At least the comment should drop the word 'Reset' and if there's a chance that not all harts having the same value then we should call get on all of them. (We'll probably want SBI FWFT functions which operate on hartmasks eventually.)
Ok, then I can pass a cpu_mask as well so that caller just have to pass online_cpus() if they want it on all cpus.
Quoted 43 lines
Quoted 32 lines
Quoted 20 lines
Quoted 7 lines
arch/riscv/kernel/sbi.c +4
-0+ ret =sbi_fwft_get (feature, &prev_value); +if (ret) +return ret; +arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 368
Quoted 10 lines
arch/riscv/kernel/sbi.c +10
-0+/* Feature might already be set to the value we want */ +if (prev_value == value) +return 0 ; + +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, cpu_online_mask)) +return 0 ; + +pr_err ("Failed to set feature %x for all online cpus, reverting\n" , + feature);nit: I'd let the above line stick out. We have 100 chars.
Quoted 11 lines
arch/riscv/kernel/sbi.c static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, · line 374
Quoted 6 lines
arch/riscv/kernel/sbi.c +6
-0+ + req.value = prev_value; +cpumask_copy (&tmp, &req.mask); +on_each_cpu_mask (&req.mask, cpu_sbi_fwft_set, &req,1 ); +if (cpumask_equal (&req.mask, &tmp)) +return 0 ;I'm not sure we want the
revert_on_failsupport either. What happens when the revert fails and we return-EINVALbelow? Also returning zero when revert succeeds means the caller won't know if we successfully set what we wanted or just successfully reverted.Quoted 5 lines
So that might actually be needed for features that needs to be enabled on all hart or not enabled at all. If we fail to enable all of them, them the hart will be in some non coherent state between the harts. The returned error code though is wrong and I'm not sure we would have a way to gracefully handle revertion failure (except maybe panicking ?).
How about offlining all harts which don't have the desired state, along with complaining loudly to the boot log.
Thanks,
drew
PATCH v3 3/17 riscv: sbi: add SBI FWFT extension calls
In reply to Clément LégerAdd FWFT extension calls. This will be ratified in SBI V3.0 hence, it is provided as a separate commit that can be left out if needed.
--- arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
arch/riscv/kernel/sbi.c +28 -2
@@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +static bool sbi_fwft_supported; +int sbi_fwft_get (u32 feature,unsigned long *value) { -return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_GET , + feature,0 ,0 ,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error); }/**
@@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value)*/ int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) { -return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_SET , + feature, value, flags,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error); }struct fwft_set_req {
@@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, unsigned long value,int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags,bool revert_on_fail) { +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; +if (feature &SBI_FWFT_GLOBAL_FEATURE_BIT )return sbi_fwft_set (feature, value, flags);
@@ -719,6 +740,11 @@ void __init sbi_init(void)pr_info ("SBI DBCN extension detected\n" ); sbi_debug_console_available = true; } +if ((sbi_spec_version >=sbi_mk_version (2 ,0 )) && + (sbi_probe_extension (SBI_EXT_FWFT ) >0 )) { +pr_info ("SBI FWFT extension detected\n" ); + sbi_fwft_supported = true; + } }else { __sbi_set_timer = __sbi_set_timer_v01; __sbi_send_ipi = __sbi_send_ipi_v01;
Signature · 1 line
2.47.2
Re: [PATCH v3 03/17] riscv: sbi: add SBI FWFT extension calls
Quoted 37 lines · Clément Léger
Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is provided as a separate commit that can be left out if needed.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)arch/riscv/kernel/sbi.c +11
-1@@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +static bool sbi_fwft_supported; +int sbi_fwft_get (u32 feature,unsigned long *value) { -return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_GET , + feature,0 ,0 ,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error); }/** @@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value)*/ int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) {
arch/riscv/kernel/sbi.c int sbi_fwft_get(u32 feature, unsigned long *value) · line 335
Quoted 10 lines
arch/riscv/kernel/sbi.c +9
-1-return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_SET , + feature, value, flags,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error);
sbi_err_map_linux_errno() doesn't know about SBI_ERR_DENIED_LOCKED.
Quoted 14 lines
arch/riscv/kernel/sbi.c +3
-0}struct fwft_set_req {@@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, unsigned long value,int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags,bool revert_on_fail) { +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; +if (feature &SBI_FWFT_GLOBAL_FEATURE_BIT )return sbi_fwft_set (feature, value, flags);
arch/riscv/kernel/sbi.c void __init sbi_init(void) · line 743
Quoted 4 lines
arch/riscv/kernel/sbi.c +1
-0@@ -719,6 +740,11 @@ void __init sbi_init(void)pr_info ("SBI DBCN extension detected\n" ); sbi_debug_console_available = true; } + if ((sbi_spec_version >= sbi_mk_version(2, 0)) &&
Should check sbi_mk_version(3, 0)
Quoted 10 lines
arch/riscv/kernel/sbi.c +4
-0+ (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { +pr_info ("SBI FWFT extension detected\n" ); + sbi_fwft_supported = true; + } }else { __sbi_set_timer = __sbi_set_timer_v01; __sbi_send_ipi = __sbi_send_ipi_v01;Signature · 1 line
2.47.2
Thanks,
drew
Re: [PATCH v3 03/17] riscv: sbi: add SBI FWFT extension calls
Quoted 42 lines · Andrew Jones
Quoted 41 lines · Clément Léger
Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is provided as a separate commit that can be left out if needed.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)arch/riscv/kernel/sbi.c +14
-2@@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask,return 0 ; } +static bool sbi_fwft_supported; +int sbi_fwft_get (u32 feature,unsigned long *value) { -return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_GET , + feature,0 ,0 ,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error); }/** @@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value)*/ int sbi_fwft_set (u32 feature,unsigned long value,unsigned long flags) { -return -EOPNOTSUPP ; +struct sbiret ret; + +if (!sbi_fwft_supported)
Quoted 8 lines
arch/riscv/kernel/sbi.c int sbi_fwft_get(u32 feature, unsigned long *value) · line 335
Quoted 6 lines
arch/riscv/kernel/sbi.c +6
-0+return -EOPNOTSUPP ; + + ret =sbi_ecall (SBI_EXT_FWFT ,SBI_EXT_FWFT_SET , + feature, value, flags,0 ,0 ,0 ); + +return sbi_err_map_linux_errno (ret.error);
sbi_err_map_linux_errno()doesn't know aboutSBI_ERR_DENIED_LOCKED.
Not only it doesn't knows about DENIED_LOCKED but also another bunch of errors. I'll add them in a separate commit.
Quoted 14 lines
Quoted 14 lines
arch/riscv/kernel/sbi.c +3
-0}struct fwft_set_req {@@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, unsigned long value,int sbi_fwft_all_cpus_set (u32 feature,unsigned long value,unsigned long flags,bool revert_on_fail) { +if (!sbi_fwft_supported) +return -EOPNOTSUPP ; +if (feature &SBI_FWFT_GLOBAL_FEATURE_BIT )return sbi_fwft_set (feature, value, flags);
Quoted 7 lines
arch/riscv/kernel/sbi.c void __init sbi_init(void) · line 743
Quoted 5 lines
arch/riscv/kernel/sbi.c +1
-0@@ -719,6 +740,11 @@ void __init sbi_init(void)pr_info ("SBI DBCN extension detected\n" ); sbi_debug_console_available = true; } + if ((sbi_spec_version >= sbi_mk_version(2, 0)) &&Should check
sbi_mk_version(3, 0)
Oh yes that was for testing purpose and I incorrectly squashed it.
Quoted 12 lines
Quoted 11 lines
arch/riscv/kernel/sbi.c +4
-0+ (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { +pr_info ("SBI FWFT extension detected\n" ); + sbi_fwft_supported = true; + } }else { __sbi_set_timer = __sbi_set_timer_v01; __sbi_send_ipi = __sbi_send_ipi_v01;Signature · 1 line
2.47.2
Thanks,
Clément
Quoted 2 lines
Thanks,
drew
PATCH v3 4/17 riscv: misaligned: request misaligned exception from SBI
In reply to Clément LégerNow that the kernel can handle misaligned accesses in S-mode, request misaligned access exception delegation from SBI. This uses the FWFT SBI extension defined in SBI version 3.0.
--- arch/riscv/include/asm/cpufeature.h | 3 +- arch/riscv/kernel/traps_misaligned.c | 77 +++++++++++++++++++++- arch/riscv/kernel/unaligned_access_speed.c | 11 +++- 3 files changed, 86 insertions(+), 5 deletions(-)
arch/riscv/include/asm/cpufeature.h +2 -1
@@ -64,8 +64,9 @@ void __init riscv_user_isa_enable(void); _RISCV_ISA_EXT_DATA(_name, _id, _sub_exts, ARRAY_SIZE(_sub_exts), _validate)bool check_unaligned_access_emulated_all_cpus (void ); +void unaligned_access_init (void ); +int cpu_online_unaligned_access_init (unsigned int cpu);#if defined(CONFIG_RISCV_SCALAR_MISALIGNED ) -void check_unaligned_access_emulated (struct work_struct *work__always_unused );void unaligned_emulation_finish (void );bool unaligned_ctl_available (void );DECLARE_PER_CPU (long, misaligned_access_speed);
arch/riscv/kernel/traps_misaligned.c +74 -3
106 lines not on this page · raw message
arch/riscv/kernel/unaligned_access_speed.c +10 -1
@@ -188,13 +188,20 @@ arch_initcall_sync(lock_and_set_unaligned_access_static_branch);static int riscv_online_cpu (unsigned int cpu) { +int ret;static struct page *buf;/* We are already set since the last check */ if (per_cpu (misaligned_access_speed, cpu) !=RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN ) goto exit; -check_unaligned_access_emulated (NULL ); + ret =cpu_online_unaligned_access_init (cpu); +if (ret) +return ret; + +if (per_cpu (misaligned_access_speed, cpu) ==RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) + goto exit; + buf =alloc_pages (GFP_KERNEL ,MISALIGNED_BUFFER_ORDER );if (!buf) {pr_warn ("Allocation failure, not measuring misaligned performance\n" );
@@ -403,6 +410,8 @@ static int check_unaligned_access_all_cpus(void) {bool all_cpus_emulated, all_cpus_vec_unsupported; +unaligned_access_init (); + all_cpus_emulated =check_unaligned_access_emulated_all_cpus (); all_cpus_vec_unsupported =check_vector_unaligned_access_emulated_all_cpus ();
Signature · 1 line
2.47.2
Re: [PATCH v3 04/17] riscv: misaligned: request misaligned exception from SBI
Quoted 179 lines · Clément Léger
Now that the kernel can handle misaligned accesses in S-mode, request misaligned access exception delegation from SBI. This uses the FWFT SBI extension defined in SBI version 3.0.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/cpufeature.h | 3 +- arch/riscv/kernel/traps_misaligned.c | 77 +++++++++++++++++++++- arch/riscv/kernel/unaligned_access_speed.c | 11 +++- 3 files changed, 86 insertions(+), 5 deletions(-)arch/riscv/include/asm/cpufeature.h +2
-1@@ -64,8 +64,9 @@ void __init riscv_user_isa_enable(void); _RISCV_ISA_EXT_DATA(_name, _id, _sub_exts, ARRAY_SIZE(_sub_exts), _validate)bool check_unaligned_access_emulated_all_cpus (void ); +void unaligned_access_init (void ); +int cpu_online_unaligned_access_init (unsigned int cpu);#if defined(CONFIG_RISCV_SCALAR_MISALIGNED ) -void check_unaligned_access_emulated (struct work_struct *work__always_unused );void unaligned_emulation_finish (void );bool unaligned_ctl_available (void );DECLARE_PER_CPU (long, misaligned_access_speed);arch/riscv/kernel/traps_misaligned.c +74
-3@@ -16,6 +16,7 @@#include <asm/entry-common.h> #include <asm/hwprobe.h> #include <asm/cpufeature.h> +#include <asm/sbi.h> #include <asm/vector.h> #define INSN_MATCH_LB 0x3@@ -635,7 +636,7 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)static bool unaligned_ctl__read_mostly ; -void check_unaligned_access_emulated (struct work_struct *work__always_unused ) +static void check_unaligned_access_emulated (struct work_struct *work__always_unused ) {int cpu =smp_processor_id ();long *mas_ptr =per_cpu_ptr (&misaligned_access_speed, cpu);@@ -646,6 +647,13 @@ void check_unaligned_access_emulated(struct work_struct *work __always_unused) __asm__ __volatile__ (" " REG_L " %[tmp], 1(%[ptr])\n" : [tmp]"=r" (tmp_val) : [ptr]"r" (&tmp_var) :"memory" ); +} + +static int cpu_online_check_unaligned_access_emulated (unsigned int cpu) +{ +long *mas_ptr =per_cpu_ptr (&misaligned_access_speed, cpu); + +check_unaligned_access_emulated (NULL );/* * If unaligned_ctl is already set, this means that we detected that all @@ -654,9 +662,10 @@ void check_unaligned_access_emulated(struct work_struct *work __always_unused)*/ if (unlikely (unaligned_ctl && (*mas_ptr !=RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ))) {pr_crit ("CPU misaligned accesses non homogeneous (expected all emulated)\n" ); -while (true) -cpu_relax (); +return -EINVAL ; } + +return 0 ; }bool check_unaligned_access_emulated_all_cpus (void )@@ -688,4 +697,66 @@ bool check_unaligned_access_emulated_all_cpus(void) {return false; } +static int cpu_online_check_unaligned_access_emulated (unsigned int cpu) +{ +return 0 ; +}#endif + +#ifdef CONFIG_RISCV_SBI + +static bool misaligned_traps_delegated; + +static int cpu_online_sbi_unaligned_setup (unsigned int cpu) +{ +if (sbi_fwft_set (SBI_FWFT_MISALIGNED_EXC_DELEG ,1 ,0 ) && + misaligned_traps_delegated) { +pr_crit ("Misaligned trap delegation non homogeneous (expected delegated)" ); +return -EINVAL ; + } + +return 0 ; +} + +static void unaligned_sbi_request_delegation (void ) +{ +int ret; + + ret =sbi_fwft_all_cpus_set (SBI_FWFT_MISALIGNED_EXC_DELEG ,1 ,0 ,0 ); +if (ret) +return ; + + misaligned_traps_delegated = true; +pr_info ("SBI misaligned access exception delegation ok\n" ); +/* +* Note that we don't have to take any specific action here, if +* the delegation is successful, then +* check_unaligned_access_emulated() will verify that indeed the +* platform traps on misaligned accesses. +*/ +} + +void unaligned_access_init (void ) +{ +if (sbi_probe_extension (SBI_EXT_FWFT ) >0 ) +unaligned_sbi_request_delegation (); +} +#else +void unaligned_access_init (void ) {} + +static int cpu_online_sbi_unaligned_setup (unsigned int cpu__always_unused ) +{ +return 0 ; +} +#endif + +int cpu_online_unaligned_access_init (unsigned int cpu) +{ +int ret; + + ret =cpu_online_sbi_unaligned_setup (cpu); +if (ret) +return ret; + +return cpu_online_check_unaligned_access_emulated (cpu); +}arch/riscv/kernel/unaligned_access_speed.c +10
-1@@ -188,13 +188,20 @@ arch_initcall_sync(lock_and_set_unaligned_access_static_branch);static int riscv_online_cpu (unsigned int cpu) { +int ret;static struct page *buf;/* We are already set since the last check */ if (per_cpu (misaligned_access_speed, cpu) !=RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN ) goto exit; -check_unaligned_access_emulated (NULL ); + ret =cpu_online_unaligned_access_init (cpu); +if (ret) +return ret; + +if (per_cpu (misaligned_access_speed, cpu) ==RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) + goto exit; + buf =alloc_pages (GFP_KERNEL ,MISALIGNED_BUFFER_ORDER );if (!buf) {pr_warn ("Allocation failure, not measuring misaligned performance\n" );@@ -403,6 +410,8 @@ static int check_unaligned_access_all_cpus(void) {bool all_cpus_emulated, all_cpus_vec_unsupported; +unaligned_access_init (); + all_cpus_emulated =check_unaligned_access_emulated_all_cpus (); all_cpus_vec_unsupported =check_vector_unaligned_access_emulated_all_cpus ();Signature · 1 line
2.47.2
PATCH v3 5/17 riscv: misaligned: use on_each_cpu() for scalar misaligned access probing
In reply to Clément Légerschedule_on_each_cpu() was used without any good reason while documented as very slow. This call was in the boot path, so better use on_each_cpu() for scalar misaligned checking. Vector misaligned check still needs to use schedule_on_each_cpu() since it requires irqs to be enabled but that's less of a problem since this code is ran in a kthread. Add a comment to explicit that.
--- arch/riscv/kernel/traps_misaligned.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
arch/riscv/kernel/traps_misaligned.c +7 -2
@@ -616,6 +616,11 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)return false; } +/* +* While being documented as very slow, schedule_on_each_cpu() is used +* since kernel_vector_begin() that is called inside the vector code +* expects irqs to be enabled or it will panic(). +*/ schedule_on_each_cpu (check_vector_unaligned_access_emulated);for_each_online_cpu (cpu)
@@ -636,7 +641,7 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)static bool unaligned_ctl__read_mostly ; -static void check_unaligned_access_emulated (struct work_struct *work__always_unused ) +static void check_unaligned_access_emulated (void *arg__always_unused ) {int cpu =smp_processor_id ();long *mas_ptr =per_cpu_ptr (&misaligned_access_speed, cpu);
@@ -677,7 +682,7 @@ bool check_unaligned_access_emulated_all_cpus(void)* accesses emulated since tasks requesting such control can run on any * CPU. */ -schedule_on_each_cpu (check_unaligned_access_emulated); +on_each_cpu (check_unaligned_access_emulated,NULL ,1 );for_each_online_cpu (cpu) if (per_cpu(misaligned_access_speed, cpu)
Signature · 1 line
2.47.2
Re: [PATCH v3 05/17] riscv: misaligned: use on_each_cpu() for scalar misaligned access probing
Quoted 17 lines · Clément Léger
schedule_on_each_cpu()was used without any good reason while documented as very slow. This call was in the boot path, so better useon_each_cpu()for scalar misaligned checking. Vector misaligned check still needs to useschedule_on_each_cpu()since it requires irqs to be enabled but that's less of a problem since this code is ran in a kthread. Add a comment to explicit that.Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/traps_misaligned.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)arch/riscv/kernel/traps_misaligned.c +0
-0
arch/riscv/kernel/traps_misaligned.c bool check_vector_unaligned_access_emulated_all_cpus(void) · line 622
Quoted 7 lines
arch/riscv/kernel/traps_misaligned.c +4
-0@@ -616,6 +616,11 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)return false; } +/* +* While being documented as very slow, schedule_on_each_cpu() is used +* since kernel_vector_begin() that is called inside the vector code +* expects irqs to be enabled or it will panic().
which expects
Quoted 25 lines
arch/riscv/kernel/traps_misaligned.c +3
-2+*/ schedule_on_each_cpu (check_vector_unaligned_access_emulated);for_each_online_cpu (cpu)@@ -636,7 +641,7 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)static bool unaligned_ctl__read_mostly ; -static void check_unaligned_access_emulated (struct work_struct *work__always_unused ) +static void check_unaligned_access_emulated (void *arg__always_unused ) {int cpu =smp_processor_id ();long *mas_ptr =per_cpu_ptr (&misaligned_access_speed, cpu);@@ -677,7 +682,7 @@ bool check_unaligned_access_emulated_all_cpus(void)* accesses emulated since tasks requesting such control can run on any * CPU. */ -schedule_on_each_cpu (check_unaligned_access_emulated); +on_each_cpu (check_unaligned_access_emulated,NULL ,1 );for_each_online_cpu (cpu) if (per_cpu(misaligned_access_speed, cpu)Signature · 1 line
2.47.2
Re: [PATCH v3 05/17] riscv: misaligned: use on_each_cpu() for scalar misaligned access probing
Quoted 21 lines · Andrew Jones
Quoted 20 lines · Clément Léger
schedule_on_each_cpu()was used without any good reason while documented as very slow. This call was in the boot path, so better useon_each_cpu()for scalar misaligned checking. Vector misaligned check still needs to useschedule_on_each_cpu()since it requires irqs to be enabled but that's less of a problem since this code is ran in a kthread. Add a comment to explicit that.Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/traps_misaligned.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)arch/riscv/kernel/traps_misaligned.c +0
-0@@ -616,6 +616,11 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)return false; }
Quoted 5 lines
arch/riscv/kernel/traps_misaligned.c bool check_vector_unaligned_access_emulated_all_cpus(void)
Quoted 3 lines
arch/riscv/kernel/traps_misaligned.c +3
-0+/* +* While being documented as very slow, schedule_on_each_cpu() is used +* since kernel_vector_begin() expects irqs to be enabled or it will panic(). which expects
Hum that would yield the following:
"schedule_on_each_cpu() is used since kernel_vector_begin() that is called inside the vector code 'which' expects irqs to be enabled or it will panic()." which seems wrong as well.
I guess something like this would be better:
"While being documented as very slow, schedule_on_each_cpu() is used since kernel_vector_begin() expects irqs to be enabled or it will panic()"
Thanks,
Clément
Quoted 28 lines
Quoted 26 lines
arch/riscv/kernel/traps_misaligned.c +3
-2+*/ schedule_on_each_cpu (check_vector_unaligned_access_emulated);for_each_online_cpu (cpu)@@ -636,7 +641,7 @@ bool check_vector_unaligned_access_emulated_all_cpus(void)static bool unaligned_ctl__read_mostly ; -static void check_unaligned_access_emulated (struct work_struct *work__always_unused ) +static void check_unaligned_access_emulated (void *arg__always_unused ) {int cpu =smp_processor_id ();long *mas_ptr =per_cpu_ptr (&misaligned_access_speed, cpu);@@ -677,7 +682,7 @@ bool check_unaligned_access_emulated_all_cpus(void)* accesses emulated since tasks requesting such control can run on any * CPU. */ -schedule_on_each_cpu (check_unaligned_access_emulated); +on_each_cpu (check_unaligned_access_emulated,NULL ,1 );for_each_online_cpu (cpu) if (per_cpu(misaligned_access_speed, cpu)Signature · 1 line
2.47.2Reviewed-by Andrew Jones <[email protected]>
PATCH v3 6/17 riscv: misaligned: use correct CONFIG_ ifdef for misaligned_access_speed
In reply to Clément Légermisaligned_access_speed is defined under CONFIG_RISCV_SCALAR_MISALIGNED but was used under CONFIG_RISCV_PROBE_UNALIGNED_ACCESS. Fix that by using the correct config option.
--- arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/traps_misaligned.c +1 -1
@@ -362,7 +362,7 @@ static int handle_scalar_misaligned_load(struct pt_regs *regs)perf_sw_event (PERF_COUNT_SW_ALIGNMENT_FAULTS ,1 , regs, addr); -#ifdef CONFIG_RISCV_PROBE_UNALIGNED_ACCESS +#ifdef CONFIG_RISCV_SCALAR_MISALIGNED *this_cpu_ptr (&misaligned_access_speed) =RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ;#endif
Signature · 1 line
2.47.2
Re: [PATCH v3 06/17] riscv: misaligned: use correct CONFIG_ ifdef for misaligned_access_speed
Quoted 14 lines · Clément Léger
misaligned_access_speedis defined underCONFIG_RISCV_SCALAR_MISALIGNEDbut was used underCONFIG_RISCV_PROBE_UNALIGNED_ACCESS. Fix that by using the correct config option.Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/kernel/traps_misaligned.c +0
-0
arch/riscv/kernel/traps_misaligned.c static int handle_scalar_misaligned_load(struct pt_regs *regs) · line 367
Quoted 7 lines
arch/riscv/kernel/traps_misaligned.c +1
-1@@ -362,7 +362,7 @@ static int handle_scalar_misaligned_load(struct pt_regs *regs)perf_sw_event (PERF_COUNT_SW_ALIGNMENT_FAULTS ,1 , regs, addr); -#ifdef CONFIG_RISCV_PROBE_UNALIGNED_ACCESS +#ifdef CONFIG_RISCV_SCALAR_MISALIGNED *this_cpu_ptr (&misaligned_access_speed) =RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ;#endif
Sure, but CONFIG_RISCV_PROBE_UNALIGNED_ACCESS selects CONFIG_RISCV_SCALAR_MISALIGNED, so this isn't fixing anything. Changing it does make sense though since this line in handle_scalar_misaligned_load() "belongs" to check_unaligned_access_emulated() which is also under CONFIG_RISCV_SCALAR_MISALIGNED. Anyway, all this unaligned configs need a major cleanup.
Thanks,
drew
Quoted 9 lines
Signature · 8 lines
-- 2.47.2 -- kvm-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kvm-riscv
Re: [PATCH v3 06/17] riscv: misaligned: use correct CONFIG_ ifdef for misaligned_access_speed
Quoted 18 lines · Andrew Jones
Quoted 17 lines · Clément Léger
misaligned_access_speedis defined underCONFIG_RISCV_SCALAR_MISALIGNEDbut was used underCONFIG_RISCV_PROBE_UNALIGNED_ACCESS. Fix that by using the correct config option.Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/kernel/traps_misaligned.c +0
-0@@ -362,7 +362,7 @@ static int handle_scalar_misaligned_load(struct pt_regs *regs)perf_sw_event (PERF_COUNT_SW_ALIGNMENT_FAULTS ,1 , regs, addr);
Quoted 7 lines
arch/riscv/kernel/traps_misaligned.c static int handle_scalar_misaligned_load(struct pt_regs *regs) · line 367
Quoted 4 lines
arch/riscv/kernel/traps_misaligned.c +1
-1-#ifdef CONFIG_RISCV_PROBE_UNALIGNED_ACCESS +#ifdef CONFIG_RISCV_SCALAR_MISALIGNED *this_cpu_ptr (&misaligned_access_speed) =RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ;#endif Sure, but
CONFIG_RISCV_PROBE_UNALIGNED_ACCESSselectsCONFIG_RISCV_SCALAR_MISALIGNED, so this isn't fixing anything.
Indeed, that is not fixing anything (hence no Fixes tag), it compiles as a side effect of Kconfig dependencies.
Quoted 5 lines
Changing it
does make sense though since this line inhandle_scalar_misaligned_load()"belongs" tocheck_unaligned_access_emulated()which is also underCONFIG_RISCV_SCALAR_MISALIGNED. Anyway, all this unaligned configs need a major cleanup.
Yes, as I said, I'd be advocating to remove all that ifdefery mess.
Thanks,
Clément
Quoted 16 lines
Reviewed-by Andrew Jones <[email protected]>Thanks,
drewQuoted 9 lines
Signature · 8 lines
-- 2.47.2 -- kvm-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kvm-riscv
PATCH v3 7/17 riscv: misaligned: move emulated access uniformity check in a function
In reply to Clément LégerSplit the code that check for the uniformity of misaligned accesses performance on all cpus from check_unaligned_access_emulated_all_cpus() to its own function which will be used for delegation check. No functional changes intended.
--- arch/riscv/kernel/traps_misaligned.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
arch/riscv/kernel/traps_misaligned.c +13 -5
@@ -673,10 +673,20 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu)return 0 ; } -bool check_unaligned_access_emulated_all_cpus (void ) +static bool all_cpus_unaligned_scalar_access_emulated (void ) {int cpu; +for_each_online_cpu (cpu) +if (per_cpu (misaligned_access_speed, cpu) != +RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) +return false; + +return true; +} + +bool check_unaligned_access_emulated_all_cpus (void ) +{/* * We can only support PR_UNALIGN controls if all CPUs have misaligned * accesses emulated since tasks requesting such control can run on any
@@ -684,10 +694,8 @@ bool check_unaligned_access_emulated_all_cpus(void)*/ on_each_cpu (check_unaligned_access_emulated,NULL ,1 ); -for_each_online_cpu (cpu) -if (per_cpu (misaligned_access_speed, cpu) - !=RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) -return false; +if (!all_cpus_unaligned_scalar_access_emulated ()) +return false; unaligned_ctl = true;return true;
Signature · 1 line
2.47.2
Re: [PATCH v3 07/17] riscv: misaligned: move emulated access uniformity check in a function
Quoted 52 lines · Clément Léger
Split the code that check for the uniformity of misaligned accesses performance on all cpus from
check_unaligned_access_emulated_all_cpus()to its own function which will be used for delegation check. No functional changes intended.Signed-off-by Clément Léger <[email protected]>--- arch/riscv/kernel/traps_misaligned.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)arch/riscv/kernel/traps_misaligned.c +13
-5@@ -673,10 +673,20 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu)return 0 ; } -bool check_unaligned_access_emulated_all_cpus (void ) +static bool all_cpus_unaligned_scalar_access_emulated (void ) {int cpu; +for_each_online_cpu (cpu) +if (per_cpu (misaligned_access_speed, cpu) != +RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) +return false; + +return true; +} + +bool check_unaligned_access_emulated_all_cpus (void ) +{/* * We can only support PR_UNALIGN controls if all CPUs have misaligned * accesses emulated since tasks requesting such control can run on any @@ -684,10 +694,8 @@ bool check_unaligned_access_emulated_all_cpus(void)*/ on_each_cpu (check_unaligned_access_emulated,NULL ,1 ); -for_each_online_cpu (cpu) -if (per_cpu (misaligned_access_speed, cpu) - !=RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED ) -return false; +if (!all_cpus_unaligned_scalar_access_emulated ()) +return false; unaligned_ctl = true;return true;Signature · 1 line
2.47.2
PATCH v3 8/17 riscv: misaligned: add a function to check misalign trap delegability
In reply to Clément LégerChecking for the delegability of the misaligned access trap is needed for the KVM FWFT extension implementation. Add a function to get the delegability of the misaligned trap exception.
--- arch/riscv/include/asm/cpufeature.h | 5 +++++ arch/riscv/kernel/traps_misaligned.c | 17 +++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-)
arch/riscv/include/asm/cpufeature.h +5 -0
@@ -69,12 +69,17 @@ int cpu_online_unaligned_access_init(unsigned int cpu);#if defined(CONFIG_RISCV_SCALAR_MISALIGNED )void unaligned_emulation_finish (void );bool unaligned_ctl_available (void ); +bool misaligned_traps_can_delegate (void );DECLARE_PER_CPU (long, misaligned_access_speed);#else static inline bool unaligned_ctl_available (void ) {return false; } +static inline bool misaligned_traps_can_delegate (void ) +{ +return false; +}#endif bool check_vector_unaligned_access_emulated_all_cpus (void );
arch/riscv/kernel/traps_misaligned.c +15 -2
@@ -716,10 +716,10 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) }#endif -#ifdef CONFIG_RISCV_SBI -static bool misaligned_traps_delegated; +#ifdef CONFIG_RISCV_SBI +static int cpu_online_sbi_unaligned_setup (unsigned int cpu) { if (sbi_fwft_set(SBI_FWFT_MISALIGNED_EXC_DELEG, 1, 0) &&
@@ -761,6 +761,7 @@ static int cpu_online_sbi_unaligned_setup(unsigned int cpu __always_unused) {return 0 ; } +#endif int cpu_online_unaligned_access_init (unsigned int cpu)
@@ -773,3 +774,15 @@ int cpu_online_unaligned_access_init(unsigned int cpu)return cpu_online_check_unaligned_access_emulated (cpu); } + +bool misaligned_traps_can_delegate (void ) +{ +/* +* Either we successfully requested misaligned traps delegation for all +* CPUS or the SBI does not implemented FWFT extension but delegated the +* exception by default. +*/ +return misaligned_traps_delegated || +all_cpus_unaligned_scalar_access_emulated (); +} +EXPORT_SYMBOL_GPL (misaligned_traps_can_delegate);
Signature · 1 line
2.47.2
Re: [PATCH v3 08/17] riscv: misaligned: add a function to check misalign trap delegability
Quoted 64 lines · Clément Léger
Checking for the delegability of the misaligned access trap is needed for the KVM FWFT extension implementation. Add a function to get the delegability of the misaligned trap exception.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/cpufeature.h | 5 +++++ arch/riscv/kernel/traps_misaligned.c | 17 +++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-)arch/riscv/include/asm/cpufeature.h +5
-0@@ -69,12 +69,17 @@ int cpu_online_unaligned_access_init(unsigned int cpu);#if defined(CONFIG_RISCV_SCALAR_MISALIGNED )void unaligned_emulation_finish (void );bool unaligned_ctl_available (void ); +bool misaligned_traps_can_delegate (void );DECLARE_PER_CPU (long, misaligned_access_speed);#else static inline bool unaligned_ctl_available (void ) {return false; } +static inline bool misaligned_traps_can_delegate (void ) +{ +return false; +}#endif bool check_vector_unaligned_access_emulated_all_cpus (void );arch/riscv/kernel/traps_misaligned.c +6
-2@@ -716,10 +716,10 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) }#endif -#ifdef CONFIG_RISCV_SBI -static bool misaligned_traps_delegated; +#ifdef CONFIG_RISCV_SBI +static int cpu_online_sbi_unaligned_setup (unsigned int cpu) { if (sbi_fwft_set(SBI_FWFT_MISALIGNED_EXC_DELEG, 1, 0) &&@@ -761,6 +761,7 @@ static int cpu_online_sbi_unaligned_setup(unsigned int cpu __always_unused) {return 0 ; } +#endif int cpu_online_unaligned_access_init (unsigned int cpu)@@ -773,3 +774,15 @@ int cpu_online_unaligned_access_init(unsigned int cpu)return cpu_online_check_unaligned_access_emulated (cpu); } + +bool misaligned_traps_can_delegate (void ) +{
arch/riscv/kernel/traps_misaligned.c int cpu_online_unaligned_access_init(unsigned int cpu) · line 788
Quoted 10 lines
arch/riscv/kernel/traps_misaligned.c +9
-0+/* +* Either we successfully requested misaligned traps delegation for all +* CPUS or the SBI does not implemented FWFT extension but delegated the +* exception by default. +*/ +return misaligned_traps_delegated || +all_cpus_unaligned_scalar_access_emulated (); +} +EXPORT_SYMBOL_GPL (misaligned_traps_can_delegate);
Check your editor settings.
Quoted 2 lines
Signature · 1 line
2.47.2
Re: [PATCH v3 08/17] riscv: misaligned: add a function to check misalign trap delegability
Quoted 69 lines · Andrew Jones
Quoted 68 lines · Clément Léger
Checking for the delegability of the misaligned access trap is needed for the KVM FWFT extension implementation. Add a function to get the delegability of the misaligned trap exception.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/cpufeature.h | 5 +++++ arch/riscv/kernel/traps_misaligned.c | 17 +++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-)arch/riscv/include/asm/cpufeature.h +5
-0@@ -69,12 +69,17 @@ int cpu_online_unaligned_access_init(unsigned int cpu);#if defined(CONFIG_RISCV_SCALAR_MISALIGNED )void unaligned_emulation_finish (void );bool unaligned_ctl_available (void ); +bool misaligned_traps_can_delegate (void );DECLARE_PER_CPU (long, misaligned_access_speed);#else static inline bool unaligned_ctl_available (void ) {return false; } +static inline bool misaligned_traps_can_delegate (void ) +{ +return false; +}#endif bool check_vector_unaligned_access_emulated_all_cpus (void );arch/riscv/kernel/traps_misaligned.c +10
-2@@ -716,10 +716,10 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) }#endif -#ifdef CONFIG_RISCV_SBI -static bool misaligned_traps_delegated; +#ifdef CONFIG_RISCV_SBI +static int cpu_online_sbi_unaligned_setup (unsigned int cpu) { if (sbi_fwft_set(SBI_FWFT_MISALIGNED_EXC_DELEG, 1, 0) &&@@ -761,6 +761,7 @@ static int cpu_online_sbi_unaligned_setup(unsigned int cpu __always_unused) {return 0 ; } +#endif int cpu_online_unaligned_access_init (unsigned int cpu)@@ -773,3 +774,15 @@ int cpu_online_unaligned_access_init(unsigned int cpu)return cpu_online_check_unaligned_access_emulated (cpu); } + +bool misaligned_traps_can_delegate (void ) +{ +/* +* Either we successfully requested misaligned traps delegation for all +* CPUS or the SBI does not implemented FWFT extension but delegated the +* exception by default.
Quoted 8 lines
arch/riscv/kernel/traps_misaligned.c int cpu_online_unaligned_access_init(unsigned int cpu) · line 788
Quoted 6 lines
arch/riscv/kernel/traps_misaligned.c +5
-0+*/ +return misaligned_traps_delegated || +all_cpus_unaligned_scalar_access_emulated (); +} +EXPORT_SYMBOL_GPL (misaligned_traps_can_delegate);Check your editor settings.
I just enabled EditorConfig as well as clang-format so hopefully that will be ok in the next series.
Thanks,
Clément
Quoted 5 lines
Quoted 3 lines
Signature · 2 lines
-- 2.47.2Reviewed-by Andrew Jones <[email protected]>
PATCH v3 9/17 riscv: misaligned: factorize trap handling
In reply to Clément Légermisaligned accesses traps are not nmi and should be treated as normal one using irqentry_enter()/exit(). Since both load/store and user/kernel should use almost the same path and that we are going to add some code around that, factorize it.
--- arch/riscv/kernel/traps.c | 49 ++++++++++++++++----------------------- 1 file changed, 20 insertions(+), 29 deletions(-)
arch/riscv/kernel/traps.c +20 -29
@@ -198,47 +198,38 @@ asmlinkage __visible __trap_section void do_trap_insn_illegal(struct pt_regs *reDO_ERROR_INFO (do_trap_load_fault,SIGSEGV ,SEGV_ACCERR ,"load access fault" ); -asmlinkage __visible __trap_section void do_trap_load_misaligned(struct pt_regs *regs) +enum misaligned_access_type { +MISALIGNED_STORE , +MISALIGNED_LOAD , +}; + +static void do_trap_misaligned (struct pt_regs *regs,enum misaligned_access_type type) { -if (user_mode (regs)) { -irqentry_enter_from_user_mode (regs); +irqentry_state_t state =irqentry_enter (regs); +if (type ==MISALIGNED_LOAD ) {if (handle_misaligned_load (regs))do_trap_error (regs,SIGBUS ,BUS_ADRALN , regs->epc, -"Oops - load address misaligned" ); - -irqentry_exit_to_user_mode (regs); +"Oops - load address misaligned" ); }else { -irqentry_state_t state =irqentry_nmi_enter (regs); - -if (handle_misaligned_load (regs)) +if (handle_misaligned_store (regs))do_trap_error (regs,SIGBUS ,BUS_ADRALN , regs->epc, -"Oops - load address misaligned" ); - -irqentry_nmi_exit (regs, state); +"Oops - store (or AMO) address misaligned" ); } + +irqentry_exit (regs, state); } -asmlinkage __visible __trap_section void do_trap_store_misaligned(struct pt_regs *regs) +asmlinkage __visible __trap_section void do_trap_load_misaligned(struct pt_regs *regs) { -if (user_mode (regs)) { -irqentry_enter_from_user_mode (regs); - -if (handle_misaligned_store (regs)) -do_trap_error (regs,SIGBUS ,BUS_ADRALN , regs->epc, -"Oops - store (or AMO) address misaligned" ); - -irqentry_exit_to_user_mode (regs); - }else { -irqentry_state_t state =irqentry_nmi_enter (regs); - -if (handle_misaligned_store (regs)) -do_trap_error (regs,SIGBUS ,BUS_ADRALN , regs->epc, -"Oops - store (or AMO) address misaligned" ); +do_trap_misaligned (regs,MISALIGNED_LOAD ); +} -irqentry_nmi_exit (regs, state); - } +asmlinkage __visible __trap_section void do_trap_store_misaligned(struct pt_regs *regs) +{ +do_trap_misaligned (regs,MISALIGNED_STORE ); } +DO_ERROR_INFO (do_trap_store_fault,SIGSEGV ,SEGV_ACCERR ,"store (or AMO) access fault" ); DO_ERROR_INFO(do_trap_ecall_s,
Signature · 1 line
2.47.2
PATCH v3 10/17 riscv: misaligned: enable IRQs while handling misaligned accesses
In reply to Clément LégerWe can safely reenable IRQs if they were enabled in the previous context. This allows to access user memory that could potentially trigger a page fault.
--- arch/riscv/kernel/traps.c | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/riscv/kernel/traps.c +8 -0
@@ -206,6 +206,11 @@ enum misaligned_access_type {static void do_trap_misaligned (struct pt_regs *regs,enum misaligned_access_type type) {irqentry_state_t state =irqentry_enter (regs); +bool enable_irqs = !regs_irqs_disabled (regs); + +/* Enable interrupts if they were enabled in the interrupted context. */ +if (enable_irqs) +local_irq_enable ();if (type ==MISALIGNED_LOAD ) {if (handle_misaligned_load (regs))
@@ -217,6 +222,9 @@ static void do_trap_misaligned(struct pt_regs *regs, enum misaligned_access_type "Oops - store (or AMO) address misaligned"); } +if (enable_irqs) +local_irq_disable (); +irqentry_exit (regs, state); }
Signature · 1 line
2.47.2
PATCH v3 11/17 riscv: misaligned: use get_user() instead of __get_user()
In reply to Clément LégerNow that we can safely handle user memory accesses while in the misaligned access handlers, use get_user() instead of __get_user() to have user memory access checks.
--- arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/traps_misaligned.c +1 -1
@@ -269,7 +269,7 @@ static unsigned long get_f32_rs(unsigned long insn, u8 fp_reg_offset,int __ret; \ \if (user_mode (regs)) { \ - __ret = __get_user(insn, (type __user *) insn_addr); \ + __ret = get_user(insn, (type __user *) insn_addr); \ }else { \ insn = *(type *)insn_addr; \ __ret =0 ; \
Signature · 1 line
2.47.2
PATCH v3 12/17 Documentation/sysctl: add riscv to unaligned-trap supported archs
In reply to Clément Légerriscv supports the "unaligned-trap" sysctl variable, add it to the list of supported architectures.
--- Documentation/admin-guide/sysctl/kernel.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/admin-guide/sysctl/kernel.rst +2 -2
@@ -1584,8 +1584,8 @@ unaligned-trap On architectures where unaligned accesses cause traps, and where this feature is supported (``CONFIG_SYSCTL_ARCH_UNALIGN_ALLOW``; currently, -``arc``, ``parisc`` and ``loongarch``), controls whether unaligned traps -are caught and emulated (instead of failing). +``arc``, ``parisc``, ``loongarch`` and ``riscv``), controls whether unaligned +traps are caught and emulated (instead of failing). = ======================================================== 0 Do not emulate unaligned accesses.
Signature · 1 line
2.47.2
PATCH v3 13/17 selftests: riscv: add misaligned access testing
In reply to Clément LégerNow that the kernel can emulate misaligned access and control its behavior, add a selftest for that. This selftest tests all the currently emulated instruction (except for the RV32 compressed ones which are left as a future exercise for a RV32 user). For the FPU instructions, all the FPU registers are tested.
--- .../selftests/riscv/misaligned/.gitignore | 1 + .../selftests/riscv/misaligned/Makefile | 12 + .../selftests/riscv/misaligned/common.S | 33 +++ .../testing/selftests/riscv/misaligned/fpu.S | 180 +++++++++++++ tools/testing/selftests/riscv/misaligned/gp.S | 103 +++++++ .../selftests/riscv/misaligned/misaligned.c | 254 ++++++++++++++++++ 6 files changed, 583 insertions(+) create mode 100644 tools/testing/selftests/riscv/misaligned/.gitignore create mode 100644 tools/testing/selftests/riscv/misaligned/Makefile create mode 100644 tools/testing/selftests/riscv/misaligned/common.S create mode 100644 tools/testing/selftests/riscv/misaligned/fpu.S create mode 100644 tools/testing/selftests/riscv/misaligned/gp.S create mode 100644 tools/testing/selftests/riscv/misaligned/misaligned.c
tools/testing/selftests/riscv/misaligned/.gitignore new file +1 -0
@@ -0,0 +1 @@ +misaligned
tools/testing/selftests/riscv/misaligned/Makefile new file +12 -0
@@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2021 ARM Limited +# Originally tools/testing/arm64/abi/Makefile + +CFLAGS += -I$(top_srcdir)/tools/include + +TEST_GEN_PROGS := misaligned + +include ../../lib.mk + +$(OUTPUT)/misaligned: misaligned.c fpu.S gp.S + $(CC) -g3 -static -o$@ -march=rv64imafdc $(CFLAGS) $(LDFLAGS) $^
tools/testing/selftests/riscv/misaligned/common.S new file +33 -0
@@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2025 Rivos Inc. + * + * Authors: + * Clément Léger <[email protected]> + */ + +.macro lb_sb temp, offset, src, dst + lb \temp, \offset(\src) + sb \temp, \offset(\dst) +.endm + +.macro copy_long_to temp, src, dst + lb_sb \temp, 0, \src, \dst, + lb_sb \temp, 1, \src, \dst, + lb_sb \temp, 2, \src, \dst, + lb_sb \temp, 3, \src, \dst, + lb_sb \temp, 4, \src, \dst, + lb_sb \temp, 5, \src, \dst, + lb_sb \temp, 6, \src, \dst, + lb_sb \temp, 7, \src, \dst, +.endm + +.macro sp_stack_prologue offset + addi sp, sp, -8 + sub sp, sp, \offset +.endm + +.macro sp_stack_epilogue offset + add sp, sp, \offset + addi sp, sp, 8 +.endm
tools/testing/selftests/riscv/misaligned/fpu.S new file +180 -0
180 lines not on this page · raw message
tools/testing/selftests/riscv/misaligned/gp.S new file +103 -0
103 lines not on this page · raw message
tools/testing/selftests/riscv/misaligned/misaligned.c new file +254 -0
254 lines not on this page · raw message
Signature · 1 line
2.47.2
PATCH v3 14/17 RISC-V: KVM: add SBI extension init()/deinit() functions
In reply to Clément LégerThe FWFT SBI extension will need to dynamically allocate memory and do init time specific initialization. Add an init/deinit callbacks that allows to do so.
--- arch/riscv/include/asm/kvm_vcpu_sbi.h | 9 +++++++++ arch/riscv/kvm/vcpu.c | 2 ++ arch/riscv/kvm/vcpu_sbi.c | 29 +++++++++++++++++++++++++++ 3 files changed, 40 insertions(+)
arch/riscv/include/asm/kvm_vcpu_sbi.h +9 -0
@@ -49,6 +49,14 @@ struct kvm_vcpu_sbi_extension {/* Extension specific probe function */ unsigned long (*probe)(struct kvm_vcpu *vcpu); + +/* +* Init/deinit function called once during VCPU init/destroy. These +* might be use if the SBI extensions need to allocate or do specific +* init time only configuration. +*/ +int (*init)(struct kvm_vcpu *vcpu); +void (*deinit)(struct kvm_vcpu *vcpu); };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run);
@@ -69,6 +77,7 @@ const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext(bool riscv_vcpu_supports_sbi_ext (struct kvm_vcpu *vcpu,int idx);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);void kvm_riscv_vcpu_sbi_init (struct kvm_vcpu *vcpu); +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu);int kvm_riscv_vcpu_get_reg_sbi_sta (struct kvm_vcpu *vcpu,unsigned long reg_num,unsigned long *reg_val);
arch/riscv/kvm/vcpu.c +2 -0
@@ -185,6 +185,8 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)void kvm_arch_vcpu_destroy (struct kvm_vcpu *vcpu) { +kvm_riscv_vcpu_sbi_deinit (vcpu); +/* Cleanup VCPU AIA context */ kvm_riscv_vcpu_aia_deinit (vcpu);
arch/riscv/kvm/vcpu_sbi.c +29 -0
@@ -505,8 +505,37 @@ void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu)continue ; } +if (!ext->default_disabled && ext->init && + ext->init (vcpu) !=0 ) { + scontext->ext_status[idx] =KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE ; +continue ; + } + scontext->ext_status[idx] = ext->default_disabled ?KVM_RISCV_SBI_EXT_STATUS_DISABLED :KVM_RISCV_SBI_EXT_STATUS_ENABLED ; } } + +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu) +{ +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; +const struct kvm_riscv_sbi_extension_entry *entry; +const struct kvm_vcpu_sbi_extension *ext; +int idx, i; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { + entry = &sbi_ext[i]; + ext = entry->ext_ptr; + idx = entry->ext_idx; + +if (idx <0 || idx >=ARRAY_SIZE (scontext->ext_status)) +continue ; + +if (scontext->ext_status[idx] ==KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE || + !ext->deinit) +continue ; + + ext->deinit (vcpu); + } +}
Signature · 1 line
2.47.2
Re: [PATCH v3 14/17] RISC-V: KVM: add SBI extension init()/deinit() functions
Quoted 56 lines · Clément Léger
The FWFT SBI extension will need to dynamically allocate memory and do init time specific initialization. Add an init/deinit callbacks that allows to do so.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/kvm_vcpu_sbi.h | 9 +++++++++ arch/riscv/kvm/vcpu.c | 2 ++ arch/riscv/kvm/vcpu_sbi.c | 29 +++++++++++++++++++++++++++ 3 files changed, 40 insertions(+)arch/riscv/include/asm/kvm_vcpu_sbi.h +9
-0@@ -49,6 +49,14 @@ struct kvm_vcpu_sbi_extension {/* Extension specific probe function */ unsigned long (*probe)(struct kvm_vcpu *vcpu); + +/* +* Init/deinit function called once during VCPU init/destroy. These +* might be use if the SBI extensions need to allocate or do specific +* init time only configuration. +*/ +int (*init)(struct kvm_vcpu *vcpu); +void (*deinit)(struct kvm_vcpu *vcpu); };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run);@@ -69,6 +77,7 @@ const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext(bool riscv_vcpu_supports_sbi_ext (struct kvm_vcpu *vcpu,int idx);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);void kvm_riscv_vcpu_sbi_init (struct kvm_vcpu *vcpu); +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu);int kvm_riscv_vcpu_get_reg_sbi_sta (struct kvm_vcpu *vcpu,unsigned long reg_num,unsigned long *reg_val);arch/riscv/kvm/vcpu.c +2
-0@@ -185,6 +185,8 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)void kvm_arch_vcpu_destroy (struct kvm_vcpu *vcpu) { +kvm_riscv_vcpu_sbi_deinit (vcpu); +/* Cleanup VCPU AIA context */ kvm_riscv_vcpu_aia_deinit (vcpu);arch/riscv/kvm/vcpu_sbi.c +0
-0
arch/riscv/kvm/vcpu_sbi.c void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu) · line 512
Quoted 8 lines
arch/riscv/kvm/vcpu_sbi.c +5
-0@@ -505,8 +505,37 @@ void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu)continue ; } +if (!ext->default_disabled && ext->init && + ext->init (vcpu) !=0 ) { + scontext->ext_status[idx] =KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE ; +continue ; + }
I think this new block should be below the assignment below (and it can drop the continue) and it shouldn't check default_disabled (as I've done below). IOW, we should always run ext->init when there is one to run here. Otherwise, I how will it get run later?
arch/riscv/kvm/vcpu_sbi.c void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu) · line 516
Quoted 4 lines
arch/riscv/kvm/vcpu_sbi.c +1
-0+ scontext->ext_status[idx] = ext->default_disabled ?KVM_RISCV_SBI_EXT_STATUS_DISABLED :KVM_RISCV_SBI_EXT_STATUS_ENABLED ;
if (ext->init && ext->init(vcpu))
scontext->ext_status[idx] = KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE;Quoted 28 lines
arch/riscv/kvm/vcpu_sbi.c +23
-0} } + +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu) +{ +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; +const struct kvm_riscv_sbi_extension_entry *entry; +const struct kvm_vcpu_sbi_extension *ext; +int idx, i; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { + entry = &sbi_ext[i]; + ext = entry->ext_ptr; + idx = entry->ext_idx; + +if (idx <0 || idx >=ARRAY_SIZE (scontext->ext_status)) +continue ; + +if (scontext->ext_status[idx] ==KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE || + !ext->deinit) +continue ; + + ext->deinit (vcpu); + } +}Signature · 1 line
2.47.2
Thanks,
drew
Re: [PATCH v3 14/17] RISC-V: KVM: add SBI extension init()/deinit() functions
Quoted 60 lines · Andrew Jones
Quoted 59 lines · Clément Léger
The FWFT SBI extension will need to dynamically allocate memory and do init time specific initialization. Add an init/deinit callbacks that allows to do so.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/kvm_vcpu_sbi.h | 9 +++++++++ arch/riscv/kvm/vcpu.c | 2 ++ arch/riscv/kvm/vcpu_sbi.c | 29 +++++++++++++++++++++++++++ 3 files changed, 40 insertions(+)arch/riscv/include/asm/kvm_vcpu_sbi.h +9
-0@@ -49,6 +49,14 @@ struct kvm_vcpu_sbi_extension {/* Extension specific probe function */ unsigned long (*probe)(struct kvm_vcpu *vcpu); + +/* +* Init/deinit function called once during VCPU init/destroy. These +* might be use if the SBI extensions need to allocate or do specific +* init time only configuration. +*/ +int (*init)(struct kvm_vcpu *vcpu); +void (*deinit)(struct kvm_vcpu *vcpu); };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run);@@ -69,6 +77,7 @@ const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext(bool riscv_vcpu_supports_sbi_ext (struct kvm_vcpu *vcpu,int idx);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);void kvm_riscv_vcpu_sbi_init (struct kvm_vcpu *vcpu); +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu);int kvm_riscv_vcpu_get_reg_sbi_sta (struct kvm_vcpu *vcpu,unsigned long reg_num,unsigned long *reg_val);arch/riscv/kvm/vcpu.c +2
-0@@ -185,6 +185,8 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)void kvm_arch_vcpu_destroy (struct kvm_vcpu *vcpu) { +kvm_riscv_vcpu_sbi_deinit (vcpu); +/* Cleanup VCPU AIA context */ kvm_riscv_vcpu_aia_deinit (vcpu);arch/riscv/kvm/vcpu_sbi.c +0
-0@@ -505,8 +505,37 @@ void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu)continue ; }
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi.c void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu) · line 512
Quoted 5 lines
arch/riscv/kvm/vcpu_sbi.c +5
-0+if (!ext->default_disabled && ext->init && + ext->init (vcpu) !=0 ) { + scontext->ext_status[idx] =KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE ; +continue ; + }I think this new block should be below the assignment below (and it can drop the continue) and it shouldn't check
default_disabled(as I've done below). IOW, we should always runext->initwhen there is one to run here. Otherwise, I how will it get run later?
Ok, i did not saw that there was a possibility to enable the extension at a later time. I'll fix that.
Thanks,
Clément
Quoted 40 lines
arch/riscv/kvm/vcpu_sbi.c void kvm_riscv_vcpu_sbi_init(struct kvm_vcpu *vcpu) · line 516
Quoted 5 lines
arch/riscv/kvm/vcpu_sbi.c +1
-0+ scontext->ext_status[idx] = ext->default_disabled ?KVM_RISCV_SBI_EXT_STATUS_DISABLED :KVM_RISCV_SBI_EXT_STATUS_ENABLED ;if (ext->init && ext->init(vcpu)) scontext->ext_status[idx] = KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE;Quoted 28 lines
arch/riscv/kvm/vcpu_sbi.c +23
-0} } + +void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu) +{ +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; +const struct kvm_riscv_sbi_extension_entry *entry; +const struct kvm_vcpu_sbi_extension *ext; +int idx, i; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { + entry = &sbi_ext[i]; + ext = entry->ext_ptr; + idx = entry->ext_idx; + +if (idx <0 || idx >=ARRAY_SIZE (scontext->ext_status)) +continue ; + +if (scontext->ext_status[idx] ==KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE || + !ext->deinit) +continue ; + + ext->deinit (vcpu); + } +}Signature · 1 line
2.47.2Thanks,
drew
PATCH v3 15/17 RISC-V: KVM: add SBI extension reset callback
In reply to Clément LégerCurrently, oonly the STA extension needed a reset function but that's going to be the case for FWFT as well. Add a reset callback that can be implemented by SBI extensions.
--- arch/riscv/include/asm/kvm_host.h | 1 - arch/riscv/include/asm/kvm_vcpu_sbi.h | 2 ++ arch/riscv/kvm/vcpu.c | 2 +- arch/riscv/kvm/vcpu_sbi.c | 24 ++++++++++++++++++++++++ arch/riscv/kvm/vcpu_sbi_sta.c | 3 ++- 5 files changed, 29 insertions(+), 3 deletions(-)
arch/riscv/include/asm/kvm_host.h +0 -1
@@ -409,7 +409,6 @@ void __kvm_riscv_vcpu_power_on(struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_power_on (struct kvm_vcpu *vcpu);bool kvm_riscv_vcpu_stopped (struct kvm_vcpu *vcpu); -void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_record_steal_time (struct kvm_vcpu *vcpu);#endif /* __RISCV_KVM_HOST_H__ */
arch/riscv/include/asm/kvm_vcpu_sbi.h +2 -0
@@ -57,6 +57,7 @@ struct kvm_vcpu_sbi_extension {*/ int (*init)(struct kvm_vcpu *vcpu);void (*deinit)(struct kvm_vcpu *vcpu); +void (*reset)(struct kvm_vcpu *vcpu); };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run);
@@ -78,6 +79,7 @@ bool riscv_vcpu_supports_sbi_ext(struct kvm_vcpu *vcpu, int idx);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);void kvm_riscv_vcpu_sbi_init (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu); +void kvm_riscv_vcpu_sbi_reset (struct kvm_vcpu *vcpu);int kvm_riscv_vcpu_get_reg_sbi_sta (struct kvm_vcpu *vcpu,unsigned long reg_num,unsigned long *reg_val);
arch/riscv/kvm/vcpu.c +1 -1
@@ -94,7 +94,7 @@ static void kvm_riscv_reset_vcpu(struct kvm_vcpu *vcpu) vcpu->arch.hfence_tail =0 ;memset (vcpu->arch.hfence_queue,0 ,sizeof (vcpu->arch.hfence_queue)); -kvm_riscv_vcpu_sbi_sta_reset (vcpu); +kvm_riscv_vcpu_sbi_reset (vcpu);/* Reset the guest CSRs for hotplug usecase */ if (loaded)
arch/riscv/kvm/vcpu_sbi.c +24 -0
@@ -539,3 +539,27 @@ void kvm_riscv_vcpu_sbi_deinit(struct kvm_vcpu *vcpu) ext->deinit (vcpu); } } + +void kvm_riscv_vcpu_sbi_reset (struct kvm_vcpu *vcpu) +{ +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; +const struct kvm_riscv_sbi_extension_entry *entry; +const struct kvm_vcpu_sbi_extension *ext; +int idx, i; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { + entry = &sbi_ext[i]; + ext = entry->ext_ptr; + idx = entry->ext_idx; + +if (idx <0 || idx >=ARRAY_SIZE (scontext->ext_status)) +continue ; + +if (scontext->ext_status[idx] !=KVM_RISCV_SBI_EXT_STATUS_ENABLED || + !ext->reset) +continue ; + + ext->reset (vcpu); + } +} +
arch/riscv/kvm/vcpu_sbi_sta.c +2 -1
@@ -16,7 +16,7 @@#include <asm/sbi.h> #include <asm/uaccess.h> -void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu) +static void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu) { vcpu->arch.sta.shmem =INVALID_GPA ; vcpu->arch.sta.last_steal =0 ;
@@ -156,6 +156,7 @@ const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_sta = { .extid_end = SBI_EXT_STA, .handler = kvm_sbi_ext_sta_handler, .probe = kvm_sbi_ext_sta_probe, + .reset = kvm_riscv_vcpu_sbi_sta_reset, }; int kvm_riscv_vcpu_get_reg_sbi_sta(struct kvm_vcpu *vcpu,
Signature · 1 line
2.47.2
Re: [PATCH v3 15/17] RISC-V: KVM: add SBI extension reset callback
Quoted 1 line · Clément Léger
Currently, oonly the STA extension needed a reset function but that's
only
Quoted 113 lines
going to be the case for FWFT as well. Add a reset callback that can be implemented by SBI extensions.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 1 - arch/riscv/include/asm/kvm_vcpu_sbi.h | 2 ++ arch/riscv/kvm/vcpu.c | 2 +- arch/riscv/kvm/vcpu_sbi.c | 24 ++++++++++++++++++++++++ arch/riscv/kvm/vcpu_sbi_sta.c | 3 ++- 5 files changed, 29 insertions(+), 3 deletions(-)arch/riscv/include/asm/kvm_host.h +0
-1@@ -409,7 +409,6 @@ void __kvm_riscv_vcpu_power_on(struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_power_on (struct kvm_vcpu *vcpu);bool kvm_riscv_vcpu_stopped (struct kvm_vcpu *vcpu); -void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_record_steal_time (struct kvm_vcpu *vcpu);#endif /* __RISCV_KVM_HOST_H__ */ arch/riscv/include/asm/kvm_vcpu_sbi.h +2
-0@@ -57,6 +57,7 @@ struct kvm_vcpu_sbi_extension {*/ int (*init)(struct kvm_vcpu *vcpu);void (*deinit)(struct kvm_vcpu *vcpu); +void (*reset)(struct kvm_vcpu *vcpu); };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run);@@ -78,6 +79,7 @@ bool riscv_vcpu_supports_sbi_ext(struct kvm_vcpu *vcpu, int idx);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);void kvm_riscv_vcpu_sbi_init (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_sbi_deinit (struct kvm_vcpu *vcpu); +void kvm_riscv_vcpu_sbi_reset (struct kvm_vcpu *vcpu);int kvm_riscv_vcpu_get_reg_sbi_sta (struct kvm_vcpu *vcpu,unsigned long reg_num,unsigned long *reg_val);arch/riscv/kvm/vcpu.c +1
-1@@ -94,7 +94,7 @@ static void kvm_riscv_reset_vcpu(struct kvm_vcpu *vcpu) vcpu->arch.hfence_tail =0 ;memset (vcpu->arch.hfence_queue,0 ,sizeof (vcpu->arch.hfence_queue)); -kvm_riscv_vcpu_sbi_sta_reset (vcpu); +kvm_riscv_vcpu_sbi_reset (vcpu);/* Reset the guest CSRs for hotplug usecase */ if (loaded)arch/riscv/kvm/vcpu_sbi.c +24
-0@@ -539,3 +539,27 @@ void kvm_riscv_vcpu_sbi_deinit(struct kvm_vcpu *vcpu) ext->deinit (vcpu); } } + +void kvm_riscv_vcpu_sbi_reset (struct kvm_vcpu *vcpu) +{ +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; +const struct kvm_riscv_sbi_extension_entry *entry; +const struct kvm_vcpu_sbi_extension *ext; +int idx, i; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { + entry = &sbi_ext[i]; + ext = entry->ext_ptr; + idx = entry->ext_idx; + +if (idx <0 || idx >=ARRAY_SIZE (scontext->ext_status)) +continue ; + +if (scontext->ext_status[idx] !=KVM_RISCV_SBI_EXT_STATUS_ENABLED || + !ext->reset) +continue ; + + ext->reset (vcpu); + } +} +arch/riscv/kvm/vcpu_sbi_sta.c +2
-1@@ -16,7 +16,7 @@#include <asm/sbi.h> #include <asm/uaccess.h> -void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu) +static void kvm_riscv_vcpu_sbi_sta_reset (struct kvm_vcpu *vcpu) { vcpu->arch.sta.shmem =INVALID_GPA ; vcpu->arch.sta.last_steal =0 ;@@ -156,6 +156,7 @@ const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_sta = { .extid_end = SBI_EXT_STA, .handler = kvm_sbi_ext_sta_handler, .probe = kvm_sbi_ext_sta_probe, + .reset = kvm_riscv_vcpu_sbi_sta_reset, }; int kvm_riscv_vcpu_get_reg_sbi_sta(struct kvm_vcpu *vcpu,Signature · 1 line
2.47.2
PATCH v3 16/17 RISC-V: KVM: add support for FWFT SBI extension
In reply to Clément LégerAdd basic infrastructure to support the FWFT extension in KVM.
--- arch/riscv/include/asm/kvm_host.h | 4 + arch/riscv/include/asm/kvm_vcpu_sbi.h | 1 + arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h | 31 +++ arch/riscv/include/uapi/asm/kvm.h | 1 + arch/riscv/kvm/Makefile | 1 + arch/riscv/kvm/vcpu_sbi.c | 4 + arch/riscv/kvm/vcpu_sbi_fwft.c | 212 +++++++++++++++++++++ 7 files changed, 254 insertions(+) create mode 100644 arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h create mode 100644 arch/riscv/kvm/vcpu_sbi_fwft.c
arch/riscv/include/asm/kvm_host.h +4 -0
@@ -19,6 +19,7 @@#include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h> #include <asm/kvm_vcpu_sbi.h> +#include <asm/kvm_vcpu_sbi_fwft.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_pmu.h>
@@ -281,6 +282,9 @@ struct kvm_vcpu_arch {/* Performance monitoring context */ struct kvm_pmu pmu_context; +/* Firmware feature SBI extension context */ +struct kvm_sbi_fwft fwft_context; +/* 'static' configurations which are set only once */ struct kvm_vcpu_config cfg;
arch/riscv/include/asm/kvm_vcpu_sbi.h +1 -0
@@ -98,6 +98,7 @@ extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_hsm;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_dbcn;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_susp;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_sta; +extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_fwft;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_experimental;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_vendor;
arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2025 Rivos Inc. +* +* Authors: +* Clément Léger <[email protected]> +*/ + +#ifndef __KVM_VCPU_RISCV_FWFT_H +#define __KVM_VCPU_RISCV_FWFT_H + +#include <asm/sbi.h> + +struct kvm_sbi_fwft_config ; +struct kvm_sbi_fwft_feature ; +struct kvm_vcpu ; + +struct kvm_sbi_fwft_config { +const struct kvm_sbi_fwft_feature *feature; +bool supported; +unsigned long flags; +}; + +/* FWFT data structure per vcpu */ +struct kvm_sbi_fwft { +struct kvm_sbi_fwft_config *configs; +}; + +#define vcpu_to_fwft (vcpu) (&(vcpu)->arch.fwft_context) + +#endif /* !__KVM_VCPU_RISCV_FWFT_H */
arch/riscv/include/uapi/asm/kvm.h +1 -0
@@ -202,6 +202,7 @@ enum KVM_RISCV_SBI_EXT_ID {KVM_RISCV_SBI_EXT_DBCN ,KVM_RISCV_SBI_EXT_STA ,KVM_RISCV_SBI_EXT_SUSP , +KVM_RISCV_SBI_EXT_FWFT , KVM_RISCV_SBI_EXT_MAX, };
arch/riscv/kvm/Makefile +1 -0
@@ -26,6 +26,7 @@ kvm-y += vcpu_onereg.o kvm-$(CONFIG_RISCV_PMU_SBI) += vcpu_pmu.o kvm-y += vcpu_sbi.o kvm-y += vcpu_sbi_base.o +kvm-y += vcpu_sbi_fwft.o kvm-y += vcpu_sbi_hsm.o kvm-$(CONFIG_RISCV_PMU_SBI) += vcpu_sbi_pmu.o kvm-y += vcpu_sbi_replace.o
arch/riscv/kvm/vcpu_sbi.c +4 -0
@@ -78,6 +78,10 @@ static const struct kvm_riscv_sbi_extension_entry sbi_ext[] = { .ext_idx = KVM_RISCV_SBI_EXT_STA, .ext_ptr = &vcpu_sbi_ext_sta, }, + { + .ext_idx = KVM_RISCV_SBI_EXT_FWFT, + .ext_ptr = &vcpu_sbi_ext_fwft, + }, { .ext_idx = KVM_RISCV_SBI_EXT_EXPERIMENTAL, .ext_ptr = &vcpu_sbi_ext_experimental,
arch/riscv/kvm/vcpu_sbi_fwft.c new file +212 -0
212 lines not on this page · raw message
Signature · 1 line
2.47.2
Re: [PATCH v3 16/17] RISC-V: KVM: add support for FWFT SBI extension
Quoted 61 lines · Clément Léger
Add basic infrastructure to support the FWFT extension in KVM.
Signed-off-by Clément Léger <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 4 + arch/riscv/include/asm/kvm_vcpu_sbi.h | 1 + arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h | 31 +++ arch/riscv/include/uapi/asm/kvm.h | 1 + arch/riscv/kvm/Makefile | 1 + arch/riscv/kvm/vcpu_sbi.c | 4 + arch/riscv/kvm/vcpu_sbi_fwft.c | 212 +++++++++++++++++++++ 7 files changed, 254 insertions(+) create mode 100644 arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h create mode 100644 arch/riscv/kvm/vcpu_sbi_fwft.carch/riscv/include/asm/kvm_host.h +4
-0@@ -19,6 +19,7 @@#include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h> #include <asm/kvm_vcpu_sbi.h> +#include <asm/kvm_vcpu_sbi_fwft.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_pmu.h> @@ -281,6 +282,9 @@ struct kvm_vcpu_arch {/* Performance monitoring context */ struct kvm_pmu pmu_context; +/* Firmware feature SBI extension context */ +struct kvm_sbi_fwft fwft_context; +/* 'static' configurations which are set only once */ struct kvm_vcpu_config cfg;arch/riscv/include/asm/kvm_vcpu_sbi.h +1
-0@@ -98,6 +98,7 @@ extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_hsm;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_dbcn;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_susp;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_sta; +extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_fwft;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_experimental;extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_vendor;arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h new file +6
-0@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2025 Rivos Inc. +* +* Authors: +* Clément Léger <[email protected]>
arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h line 16
Quoted 10 lines
arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h new file +10
-0+*/ + +#ifndef __KVM_VCPU_RISCV_FWFT_H +#define __KVM_VCPU_RISCV_FWFT_H + +#include <asm/sbi.h> + +struct kvm_sbi_fwft_config ; +struct kvm_sbi_fwft_feature ; +struct kvm_vcpu ;
Should only need the forward declaration for kvm_sbi_fwft_feature.
Quoted 84 lines
arch/riscv/include/asm/kvm_vcpu_sbi_fwft.h new file +15
-0+ +struct kvm_sbi_fwft_config { +const struct kvm_sbi_fwft_feature *feature; +bool supported; +unsigned long flags; +}; + +/* FWFT data structure per vcpu */ +struct kvm_sbi_fwft { +struct kvm_sbi_fwft_config *configs; +}; + +#define vcpu_to_fwft (vcpu) (&(vcpu)->arch.fwft_context) + +#endif /* !__KVM_VCPU_RISCV_FWFT_H */ arch/riscv/include/uapi/asm/kvm.h +1
-0@@ -202,6 +202,7 @@ enum KVM_RISCV_SBI_EXT_ID {KVM_RISCV_SBI_EXT_DBCN ,KVM_RISCV_SBI_EXT_STA ,KVM_RISCV_SBI_EXT_SUSP , +KVM_RISCV_SBI_EXT_FWFT , KVM_RISCV_SBI_EXT_MAX, };arch/riscv/kvm/Makefile +1
-0@@ -26,6 +26,7 @@ kvm-y += vcpu_onereg.o kvm-$(CONFIG_RISCV_PMU_SBI) += vcpu_pmu.o kvm-y += vcpu_sbi.o kvm-y += vcpu_sbi_base.o +kvm-y += vcpu_sbi_fwft.o kvm-y += vcpu_sbi_hsm.o kvm-$(CONFIG_RISCV_PMU_SBI) += vcpu_sbi_pmu.o kvm-y += vcpu_sbi_replace.oarch/riscv/kvm/vcpu_sbi.c +4
-0@@ -78,6 +78,10 @@ static const struct kvm_riscv_sbi_extension_entry sbi_ext[] = { .ext_idx = KVM_RISCV_SBI_EXT_STA, .ext_ptr = &vcpu_sbi_ext_sta, }, + { + .ext_idx = KVM_RISCV_SBI_EXT_FWFT, + .ext_ptr = &vcpu_sbi_ext_fwft, + }, { .ext_idx = KVM_RISCV_SBI_EXT_EXPERIMENTAL, .ext_ptr = &vcpu_sbi_ext_experimental,arch/riscv/kvm/vcpu_sbi_fwft.c new file +24
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2025 Rivos Inc. +* +* Authors: +* Clément Léger <[email protected]> +*/ + +#include <linux/errno.h> +#include <linux/err.h> +#include <linux/kvm_host.h> +#include <asm/cpufeature.h> +#include <asm/sbi.h> +#include <asm/kvm_vcpu_sbi.h> +#include <asm/kvm_vcpu_sbi_fwft.h> + +struct kvm_sbi_fwft_feature { +/** +* @id: Feature ID +*/ +enum sbi_fwft_feature_t id; + +/** +* @supported: Check if the feature is supported on the vcpu
arch/riscv/kvm/vcpu_sbi_fwft.c line 34
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +10
-0+* +* This callback is optional, if not provided the feature is assumed to +* be supported +*/ +bool (*supported)(struct kvm_vcpu *vcpu); + +/** +* @set: Set the feature value +* +* This callback is mandatory
Since we're doing all this documentation, then let's also state they return SBI errors (which are longs, so we should probably return longs).
Quoted 29 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +29
-0+*/ +int (*set)(struct kvm_vcpu *vcpu,struct kvm_sbi_fwft_config *conf,unsigned long value); + +/** +* @get: Get the feature current value +* +* This callback is mandatory +*/ +int (*get)(struct kvm_vcpu *vcpu,struct kvm_sbi_fwft_config *conf,unsigned long *value); +}; + +static const enum sbi_fwft_feature_t kvm_fwft_defined_features[] = { +SBI_FWFT_MISALIGNED_EXC_DELEG , +SBI_FWFT_LANDING_PAD , +SBI_FWFT_SHADOW_STACK , +SBI_FWFT_DOUBLE_TRAP , +SBI_FWFT_PTE_AD_HW_UPDATING , +SBI_FWFT_POINTER_MASKING_PMLEN , +}; + +static bool kvm_fwft_is_defined_feature (enum sbi_fwft_feature_t feature) +{ +int i; + +for (i =0 ; i <ARRAY_SIZE (kvm_fwft_defined_features); i++) { +if (kvm_fwft_defined_features[i] == feature) +return true; + } +
arch/riscv/kvm/vcpu_sbi_fwft.c line 73
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +10
-0+return false; +} + +static const struct kvm_sbi_fwft_feature features[] = { +}; + +static struct kvm_sbi_fwft_config * +kvm_sbi_fwft_get_config (struct kvm_vcpu *vcpu,enum sbi_fwft_feature_t feature) +{ +int i =0 ;
no need for '= 0'
Quoted 115 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +115
-0+struct kvm_sbi_fwft *fwft =vcpu_to_fwft (vcpu); + +for (i =0 ; i <ARRAY_SIZE (features); i++) { +if (fwft->configs[i].feature->id == feature) +return &fwft->configs[i]; + } + +return NULL ; +} + +static int kvm_fwft_get_feature (struct kvm_vcpu *vcpu,u32 feature, +struct kvm_sbi_fwft_config **conf) +{ +struct kvm_sbi_fwft_config *tconf; + + tconf =kvm_sbi_fwft_get_config (vcpu, feature); +if (!tconf) { +if (kvm_fwft_is_defined_feature (feature)) +return SBI_ERR_NOT_SUPPORTED ; + +return SBI_ERR_DENIED ; + } + +if (!tconf->supported) +return SBI_ERR_NOT_SUPPORTED ; + + *conf = tconf; + +return SBI_SUCCESS ; +} + +static int kvm_sbi_fwft_set (struct kvm_vcpu *vcpu,u32 feature, +unsigned long value,unsigned long flags) +{ +int ret; +struct kvm_sbi_fwft_config *conf; + + ret =kvm_fwft_get_feature (vcpu, feature, &conf); +if (ret) +return ret; + +if ((flags & ~SBI_FWFT_SET_FLAG_LOCK ) !=0 ) +return SBI_ERR_INVALID_PARAM ; + +if (conf->flags &SBI_FWFT_SET_FLAG_LOCK ) +return SBI_ERR_DENIED_LOCKED ; + + conf->flags = flags; + +return conf->feature->set (vcpu, conf, value); +} + +static int kvm_sbi_fwft_get (struct kvm_vcpu *vcpu,unsigned long feature, +unsigned long *value) +{ +int ret; +struct kvm_sbi_fwft_config *conf; + + ret =kvm_fwft_get_feature (vcpu, feature, &conf); +if (ret) +return ret; + +return conf->feature->get (vcpu, conf, value); +} + +static int kvm_sbi_ext_fwft_handler (struct kvm_vcpu *vcpu,struct kvm_run *run, +struct kvm_vcpu_sbi_return *retdata) +{ +int ret =0 ; +struct kvm_cpu_context *cp = &vcpu->arch.guest_context; +unsigned long funcid = cp->a6; + +switch (funcid) { +case SBI_EXT_FWFT_SET : + ret =kvm_sbi_fwft_set (vcpu, cp->a0, cp->a1, cp->a2); +break ; +case SBI_EXT_FWFT_GET : + ret =kvm_sbi_fwft_get (vcpu, cp->a0, &retdata->out_val); +break ; +default : + ret =SBI_ERR_NOT_SUPPORTED ; +break ; + } + + retdata->err_val = ret; + +return 0 ; +} + +static int kvm_sbi_ext_fwft_init (struct kvm_vcpu *vcpu) +{ +struct kvm_sbi_fwft *fwft =vcpu_to_fwft (vcpu); +const struct kvm_sbi_fwft_feature *feature; +struct kvm_sbi_fwft_config *conf; +int i; + + fwft->configs =kcalloc (ARRAY_SIZE (features),sizeof (struct kvm_sbi_fwft_config ), +GFP_KERNEL ); +if (!fwft->configs) +return -ENOMEM ; + +for (i =0 ; i <ARRAY_SIZE (features); i++) { + feature = &features[i]; + conf = &fwft->configs[i]; +if (feature->supported) + conf->supported = feature->supported (vcpu); +else + conf->supported = true; + + conf->feature = feature; + } + +return 0 ; +} +
arch/riscv/kvm/vcpu_sbi_fwft.c line 198
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +10
-0+static void kvm_sbi_ext_fwft_deinit (struct kvm_vcpu *vcpu) +{ +struct kvm_sbi_fwft *fwft =vcpu_to_fwft (vcpu); + +kfree (fwft->configs); +} + +static void kvm_sbi_ext_fwft_reset (struct kvm_vcpu *vcpu) +{ +int i =0 ;
no need for '= 0'
Quoted 17 lines
arch/riscv/kvm/vcpu_sbi_fwft.c new file +14
-0+struct kvm_sbi_fwft *fwft =vcpu_to_fwft (vcpu); + +for (i =0 ; i <ARRAY_SIZE (features); i++) + fwft->configs[i].flags =0 ; +} + +const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_fwft = { + .extid_start =SBI_EXT_FWFT , + .extid_end =SBI_EXT_FWFT , + .handler = kvm_sbi_ext_fwft_handler, + .init = kvm_sbi_ext_fwft_init, + .deinit = kvm_sbi_ext_fwft_deinit, + .reset = kvm_sbi_ext_fwft_reset, +};Signature · 1 line
2.47.2
PATCH v3 17/17 RISC-V: KVM: add support for SBI_FWFT_MISALIGNED_DELEG
In reply to Clément LégerSBI_FWFT_MISALIGNED_DELEG needs hedeleg to be modified to delegate misaligned load/store exceptions. Save and restore it during CPU load/put.
--- arch/riscv/kvm/vcpu.c | 3 +++ arch/riscv/kvm/vcpu_sbi_fwft.c | 39 ++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
arch/riscv/kvm/vcpu.c +3 -0
@@ -646,6 +646,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) {void *nsh;struct kvm_vcpu_csr *csr = &vcpu->arch.guest_csr; +struct kvm_vcpu_config *cfg = &vcpu->arch.cfg; vcpu->cpu =-1 ;
@@ -671,6 +672,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) csr->vstval =nacl_csr_read (nsh,CSR_VSTVAL ); csr->hvip =nacl_csr_read (nsh,CSR_HVIP ); csr->vsatp =nacl_csr_read (nsh,CSR_VSATP ); + cfg->hedeleg =nacl_csr_read (nsh,CSR_HEDELEG ); }else { csr->vsstatus =csr_read (CSR_VSSTATUS ); csr->vsie =csr_read (CSR_VSIE );
@@ -681,6 +683,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) csr->vstval =csr_read (CSR_VSTVAL ); csr->hvip =csr_read (CSR_HVIP ); csr->vsatp =csr_read (CSR_VSATP ); + cfg->hedeleg =csr_read (CSR_HEDELEG ); } }
arch/riscv/kvm/vcpu_sbi_fwft.c +39 -0
@@ -14,6 +14,8 @@#include <asm/kvm_vcpu_sbi.h> #include <asm/kvm_vcpu_sbi_fwft.h> +#define MIS_DELEG (BIT_ULL(EXC_LOAD_MISALIGNED) | BIT_ULL(EXC_STORE_MISALIGNED)) +struct kvm_sbi_fwft_feature {/** * @id: Feature ID
@@ -64,7 +66,44 @@ static bool kvm_fwft_is_defined_feature(enum sbi_fwft_feature_t feature)return false; } +static bool kvm_sbi_fwft_misaligned_delegation_supported (struct kvm_vcpu *vcpu) +{ +if (!misaligned_traps_can_delegate ()) +return false; + +return true; +} + +static int kvm_sbi_fwft_set_misaligned_delegation (struct kvm_vcpu *vcpu, +struct kvm_sbi_fwft_config *conf, +unsigned long value) +{ +if (value ==1 ) +csr_set (CSR_HEDELEG ,MIS_DELEG ); +else if (value ==0 ) +csr_clear (CSR_HEDELEG ,MIS_DELEG ); +else +return SBI_ERR_INVALID_PARAM ; + +return SBI_SUCCESS ; +} + +static int kvm_sbi_fwft_get_misaligned_delegation (struct kvm_vcpu *vcpu, +struct kvm_sbi_fwft_config *conf, +unsigned long *value) +{ + *value = (csr_read (CSR_HEDELEG ) &MIS_DELEG ) !=0 ; + +return SBI_SUCCESS ; +} +static const struct kvm_sbi_fwft_feature features[] = { + { + .id =SBI_FWFT_MISALIGNED_EXC_DELEG , + .supported = kvm_sbi_fwft_misaligned_delegation_supported, + .set = kvm_sbi_fwft_set_misaligned_delegation, + .get = kvm_sbi_fwft_get_misaligned_delegation, + }, }; static struct kvm_sbi_fwft_config *
Signature · 1 line
2.47.2
Re: [PATCH v3 17/17] RISC-V: KVM: add support for SBI_FWFT_MISALIGNED_DELEG
Quoted 53 lines · Clément Léger
SBI_FWFT_MISALIGNED_DELEGneeds hedeleg to be modified to delegate misaligned load/store exceptions. Save and restore it during CPU load/put.Signed-off-by Clément Léger <[email protected]>Reviewed-by Deepak Gupta <[email protected]>--- arch/riscv/kvm/vcpu.c | 3 +++ arch/riscv/kvm/vcpu_sbi_fwft.c | 39 ++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)arch/riscv/kvm/vcpu.c +3
-0@@ -646,6 +646,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) {void *nsh;struct kvm_vcpu_csr *csr = &vcpu->arch.guest_csr; +struct kvm_vcpu_config *cfg = &vcpu->arch.cfg; vcpu->cpu =-1 ;@@ -671,6 +672,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) csr->vstval =nacl_csr_read (nsh,CSR_VSTVAL ); csr->hvip =nacl_csr_read (nsh,CSR_HVIP ); csr->vsatp =nacl_csr_read (nsh,CSR_VSATP ); + cfg->hedeleg =nacl_csr_read (nsh,CSR_HEDELEG ); }else { csr->vsstatus =csr_read (CSR_VSSTATUS ); csr->vsie =csr_read (CSR_VSIE );@@ -681,6 +683,7 @@ void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) csr->vstval =csr_read (CSR_VSTVAL ); csr->hvip =csr_read (CSR_HVIP ); csr->vsatp =csr_read (CSR_VSATP ); + cfg->hedeleg =csr_read (CSR_HEDELEG ); } }arch/riscv/kvm/vcpu_sbi_fwft.c +2
-0@@ -14,6 +14,8 @@#include <asm/kvm_vcpu_sbi.h> #include <asm/kvm_vcpu_sbi_fwft.h> +#define MIS_DELEG (BIT_ULL(EXC_LOAD_MISALIGNED) | BIT_ULL(EXC_STORE_MISALIGNED)) +struct kvm_sbi_fwft_feature {/** * @id: Feature ID
arch/riscv/kvm/vcpu_sbi_fwft.c static bool kvm_fwft_is_defined_feature(enum sbi_fwft_feature_t feature) · line 74
Quoted 9 lines
arch/riscv/kvm/vcpu_sbi_fwft.c +6
-0@@ -64,7 +66,44 @@ static bool kvm_fwft_is_defined_feature(enum sbi_fwft_feature_t feature)return false; } +static bool kvm_sbi_fwft_misaligned_delegation_supported (struct kvm_vcpu *vcpu) +{ +if (!misaligned_traps_can_delegate ()) +return false; + +return true;
Just
return misaligned_traps_can_delegate();
Quoted 38 lines
arch/riscv/kvm/vcpu_sbi_fwft.c +31
-0+} + +static int kvm_sbi_fwft_set_misaligned_delegation (struct kvm_vcpu *vcpu, +struct kvm_sbi_fwft_config *conf, +unsigned long value) +{ +if (value ==1 ) +csr_set (CSR_HEDELEG ,MIS_DELEG ); +else if (value ==0 ) +csr_clear (CSR_HEDELEG ,MIS_DELEG ); +else +return SBI_ERR_INVALID_PARAM ; + +return SBI_SUCCESS ; +} + +static int kvm_sbi_fwft_get_misaligned_delegation (struct kvm_vcpu *vcpu, +struct kvm_sbi_fwft_config *conf, +unsigned long *value) +{ + *value = (csr_read (CSR_HEDELEG ) &MIS_DELEG ) !=0 ; + +return SBI_SUCCESS ; +} +static const struct kvm_sbi_fwft_feature features[] = { + { + .id =SBI_FWFT_MISALIGNED_EXC_DELEG , + .supported = kvm_sbi_fwft_misaligned_delegation_supported, + .set = kvm_sbi_fwft_set_misaligned_delegation, + .get = kvm_sbi_fwft_get_misaligned_delegation, + }, }; static struct kvm_sbi_fwft_config *Signature · 1 line
2.47.2