Skip to contentSkip to conversation

ata: libata: Fix NCQ Non-Data log not supported print

PATCH Applied Niklas Cassel 3 participants 4 messages Mar 17, 2025 – Mar 18, 2025 libata

lore
Share & tools
lore

Niklas Cassel

author maintainer
#0 lore raw

PATCH 1/1 ata: libata: Fix NCQ Non-Data log not supported print

Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() - which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:

"NCQ Send/Recv Log not supported"

This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.

Fix the print the reference the correct log.

Fixes 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
---
 drivers/ata/libata-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +1 -1
index 193fc3942fd3a..e17e16706db70 100644
@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
 
 	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
 		ata_dev_warn(dev,
-			     "NCQ Send/Recv Log not supported\n");
+			     "NCQ Non-Data Log not supported\n");
 		return;
 	}
 	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
Signature · 1 line
2.48.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Niklas Cassel

Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() - which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:

"NCQ Send/Recv Log not supported"

This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.

Fix the print the reference the correct log.

Fixes 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
---
  drivers/ata/libata-core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +0 -0
index 193fc3942fd3a..e17e16706db70 100644

drivers/ata/libata-core.c static void ata_dev_config_ncq_non_data(struct ata_device *dev) · line 2280

Quoted 8 lines
drivers/ata/libata-core.c +1 -1
@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
 
  	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
  		ata_dev_warn(dev,
-			     "NCQ Send/Recv Log not supported\n");
+			     "NCQ Non-Data Log not supported\n");
  		return;
  	}
  	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Niklas Cassel
Quoted 7 lines · Niklas Cassel

Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() - which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:

"NCQ Send/Recv Log not supported"

Quoted 7 lines

This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.

Fix the print the reference the correct log.

Fixes 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
Signature · 2 lines
Damien Le Moal
Western Digital Research
author maintainer Applied
#3 lore raw
In reply to Niklas Cassel
Quoted 8 lines · Niklas Cassel

Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() - which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:

"NCQ Send/Recv Log not supported"

[...]

Applied to libata/linux.git (for-6.15), thanks!

[1/1] ata: libata: Fix NCQ Non-Data log not supported print

      https://git.kernel.org/libata/linux/c/b500ee5f

Kind regards,
Niklas