ata: libata: Fix NCQ Non-Data log not supported print
Niklas Cassel
maintainerPATCH 1/1 ata: libata: Fix NCQ Non-Data log not supported print
Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() - which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:
"NCQ Send/Recv Log not supported"
This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.
Fix the print the reference the correct log.
--- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +1 -1
@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)if (!ata_log_supported (dev,ATA_LOG_NCQ_NON_DATA )) {ata_dev_warn (dev, -"NCQ Send/Recv Log not supported\n" ); +"NCQ Non-Data Log not supported\n" );return ; } err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
Signature · 1 line
2.48.1
Quoted 23 lines · Niklas Cassel
Currently, both
ata_dev_config_ncq_send_recv()- which checks for NCQ Send/Recv Log (Log Address 13h) andata_dev_config_ncq_non_data()- which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:"NCQ Send/Recv Log not supported"
This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.
Fix the print the reference the correct log.
Fixes 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")Signed-off-by Niklas Cassel <[email protected]>--- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/ata/libata-core.c +0
-0
drivers/ata/libata-core.c static void ata_dev_config_ncq_non_data(struct ata_device *dev) · line 2280
Quoted 8 lines
drivers/ata/libata-core.c +1
-1@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)if (!ata_log_supported (dev,ATA_LOG_NCQ_NON_DATA )) {ata_dev_warn (dev, -"NCQ Send/Recv Log not supported\n" ); +"NCQ Non-Data Log not supported\n" );return ; } err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Quoted 7 lines · Niklas Cassel
Currently, both
ata_dev_config_ncq_send_recv()- which checks for NCQ Send/Recv Log (Log Address 13h) andata_dev_config_ncq_non_data()- which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:"NCQ Send/Recv Log not supported"
Quoted 7 lines
This seems like a copy paste error, since NCQ Non-Data Log is actually a separate log.
Fix the print the reference the correct log.
Fixes 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")Signed-off-by Niklas Cassel <[email protected]>
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 8 lines · Niklas Cassel
Currently, both
ata_dev_config_ncq_send_recv()- which checks for NCQ Send/Recv Log (Log Address 13h) andata_dev_config_ncq_non_data()- which checks for NCQ Non-Data Log (Log Address 12h), uses the same print when the log is not supported:"NCQ Send/Recv Log not supported"
[...]
Applied to libata/linux.git (for-6.15), thanks!
[1/1] ata: libata: Fix NCQ Non-Data log not supported print
https://git.kernel.org/libata/linux/c/b500ee5f
Kind regards,
Niklas