media: qcom: camss: vfe: suppress VFE version log spam
Subsystems (4)
PATCH v2 1/1 media: qcom: camss: vfe: suppress VFE version log spam
A recent commit refactored the printing of the VFE hardware version, but (without it being mentioned) also changed the log level from debug to info.
This results in several hundred lines of repeated log spam during boot and use, for example, on the Lenovo ThinkPad X13s:
qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 ...
Suppress the version logging by demoting to debug level again.
---
Changes in v2:
- align continuation line to open parenthesis as instructed by the media patchwork hooks
drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/qcom/camss/camss-vfe.c +2 -2
@@ -428,8 +428,8 @@ u32 vfe_hw_version(struct vfe_device *vfe)u32 rev = (hw_version >>HW_VERSION_REVISION ) &0xFFF ;u32 step = (hw_version >>HW_VERSION_STEPPING ) &0xFFFF ; -dev_info (vfe->camss->dev,"VFE:%d HW Version = %u.%u.%u\n" , - vfe->id, gen, rev, step); +dev_dbg (vfe->camss->dev,"VFE:%d HW Version = %u.%u.%u\n" , + vfe->id, gen, rev, step);return hw_version; }
Signature · 1 line
2.49.0
Hi Johan,
Quoted 23 lines · Johan Hovold
A recent commit refactored the printing of the VFE hardware version, but (without it being mentioned) also changed the log level from debug to info.
This results in several hundred lines of repeated log spam during boot and use, for example, on the Lenovo ThinkPad X13s:
qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2 qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 ...
Quoted 6 lines
Suppress the version logging by demoting to debug level again.
Fixes 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")Cc Depeng Shao <[email protected]>Reviewed-by Bryan O'Donoghue <[email protected]>Signed-off-by Johan Hovold <[email protected]>
This makes my T14s a bit more peaceful during boot. Very welcome change:
Quoted 29 lines
---
Changes in v2:
- align continuation line to open parenthesis as instructed by the media patchwork hooksdrivers/media/platform/qcom/camss/camss-vfe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/qcom/camss/camss-vfe.c +2
-3@@ -428,8 +428,8 @@ u32 vfe_hw_version(struct vfe_device *vfe)u32 rev = (hw_version >>HW_VERSION_REVISION ) &0xFFF ;u32 step = (hw_version >>HW_VERSION_STEPPING ) &0xFFFF ; -dev_info (vfe->camss->dev,"VFE:%d HW Version = %u.%u.%u\n" , - vfe->id, gen, rev, step); +dev_dbg (vfe->camss->dev,"VFE:%d HW Version = %u.%u.%u\n" , + vfe->id, gen, rev, step);return hw_version; } --2.49.0