Skip to contentSkip to conversation

media: qcom: camss: csid: suppress CSID log spam

PATCH Superseded Johan Hovold 2 participants 2 messages Apr 7, 2025

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: qcom: camss: csid: suppress CSID log spam

A recent commit refactored the printing of the CSID hardware version, but (without it being mentioned) also changed the log level from debug to info.

This results in repeated log spam during use, for example, on the Lenovo ThinkPad X13s:

	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0

Suppress the version logging by demoting to debug level again.

Fixes f759b8fd3086 ("media: qcom: camss: csid: Move common code into csid core")
Cc Depeng Shao <[email protected]>
---
 drivers/media/platform/qcom/camss/camss-csid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/qcom/camss/camss-csid.c +2 -2
index d08117f46f3b..5284b5857368 100644
@@ -613,8 +613,8 @@ u32 csid_hw_version(struct csid_device *csid)
 	hw_gen = (hw_version >> HW_VERSION_GENERATION) & 0xF;
 	hw_rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
 	hw_step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
-	dev_info(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
-		 csid->id, hw_gen, hw_rev, hw_step);
+	dev_dbg(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
+		csid->id, hw_gen, hw_rev, hw_step);
 
 	return hw_version;
 }
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Johan Hovold

A recent commit refactored the printing of the CSID hardware version, but (without it being mentioned) also changed the log level from debug to info.

This results in repeated log spam during use, for example, on the Lenovo ThinkPad X13s:

	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0

Suppress the version logging by demoting to debug level again.

Fixes f759b8fd3086 ("media: qcom: camss: csid: Move common code into csid core")
Cc Depeng Shao <[email protected]>
---
  drivers/media/platform/qcom/camss/camss-csid.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/qcom/camss/camss-csid.c +0 -0
index d08117f46f3b..5284b5857368 100644

drivers/media/platform/qcom/camss/camss-csid.c u32 csid_hw_version(struct csid_device *csid) · line 620

Quoted 10 lines
drivers/media/platform/qcom/camss/camss-csid.c +2 -2
@@ -613,8 +613,8 @@ u32 csid_hw_version(struct csid_device *csid)
  	hw_gen = (hw_version >> HW_VERSION_GENERATION) & 0xF;
  	hw_rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
  	hw_step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
-	dev_info(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
-		 csid->id, hw_gen, hw_rev, hw_step);
+	dev_dbg(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
+		csid->id, hw_gen, hw_rev, hw_step);
 
  	return hw_version;
  }