Skip to contentSkip to conversation

J722S: DT Node cleanup for serdes0 and serdes1

PATCH In review Siddharth Vadapalli 3 participants 9 messages Apr 12, 2025 – Apr 17, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover J722S: DT Node cleanup for serdes0 and serdes1

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1

Since serdes0 and serdes1 are the child nodes of serdes_wiz0 and serdes_wiz1 respectively, and, given that serdes_wiz0 and serdes_wiz1 are already disabled, it is not necessary to disable serdes0 and serdes1.

Moreover, having serdes_wiz0/serdes_wiz1 enabled and serdes0/serdes1 disabled is not a working configuration.

Hence, remove 'status = "disabled"' from the serdes0 and serdes1 nodes.

---

Hello,

This patch depends on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
as indicated in the cover-letter.

Regards,
Siddharth.

 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/ti/k3-j722s-main.dtsi +0 -4
index beda9e40e931..562dfbdf449d 100644
@@ -52,8 +52,6 @@ serdes0: serdes@f000000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			#clock-cells = <1>;
-
-			status = "disabled"; /* Needs lane config */
 		};
 	};
 
@@ -92,8 +90,6 @@ serdes1: serdes@f010000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			#clock-cells = <1>;
-
-			status = "disabled"; /* Needs lane config */
 		};
 	};
 
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 arm64: dts: ti: k3-j722s-evm: drop redundant status within serdes0/serdes1

In reply to Siddharth Vadapalli

Since serdes0 and serdes1 are now enabled by default within the SoC file, it is no longer necessary to enable them in the board file.

Hence, remove the redundant 'status = "okay"' within the serdes0 and serdes1 device-tree nodes.

---

Hello,

This patch depends on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
as indicated in the cover-letter.

Regards,
Siddharth.

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +0 -2
index 0bf2e1821662..34b9d190800e 100644
@@ -848,7 +848,6 @@ &serdes_wiz0 {
 };
 
 &serdes0 {
-	status = "okay";
 	serdes0_usb_link: phy@0 {
 		reg = <0>;
 		cdns,num-lanes = <1>;
@@ -863,7 +862,6 @@ &serdes_wiz1 {
 };
 
 &serdes1 {
-	status = "okay";
 	serdes1_pcie_link: phy@0 {
 		reg = <0>;
 		cdns,num-lanes = <1>;
Signature · 1 line
2.34.1
Reviewed-by on the v1 series
#3 lore raw
In reply to Siddharth Vadapalli

Thanks Siddharth

Quoted 13 lines · Siddharth Vadapalli

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Quoted 7 lines

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

For series

Quoted 4 lines
  arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
  2 files changed, 6 deletions(-)
maintainer
#4 lore raw
In reply to Siddharth Vadapalli
Quoted 16 lines · Siddharth Vadapalli

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Quoted 12 lines

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Signature · 1 line
2.34.1

I do not understand the logic here. serdes cannot operate without wiz nodes, correct? why would we leave serdes on by default?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#5 lore raw

On Mon, Apr 14, 2025 at 07:09:30AM -0500, Nishanth Menon wrote:

Hello Nishanth,

Quoted 26 lines · Siddharth Vadapalli
Quoted 25 lines

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Quoted 7 lines
Quoted 3 lines
Signature · 1 line
2.34.1

I do not understand the logic here. serdes cannot operate without wiz nodes, correct? why would we leave serdes on by default?

Yes, serdesX requires serdes_wizX, but at the same time, serdesX is the child node of serdes_wizX. Therefore, without enabling serdes_wizX, we cannot enable serdesX.

Prior to this series, but with the dependent series at:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
applied, the nodes look like:

	serdes_wizX {
		...
		status = "disabled";

		serdesX {
			...
			status = "disabled";
		};
	};

The dependent series fixes 'serdes_wizX' by disabling it in the SoC file k3-j722s-main.dtsi. But after the fix, we have a 'status = "disabled";' within the serdesX node which isn't required since:
a) serdes_wizX enabled but serdesX disabled is non-functional and unusable
b) serdes_wizX disabled in DT implies that serdesX is also disabled

Regards,
Siddharth.

maintainer
#6 lore raw
Quoted 56 lines · Siddharth Vadapalli

On Mon, Apr 14, 2025 at 07:09:30AM -0500, Nishanth Menon wrote:

Hello Nishanth,

Quoted 26 lines · Siddharth Vadapalli
Quoted 25 lines

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Quoted 7 lines
Quoted 3 lines
Signature · 1 line
2.34.1

I do not understand the logic here. serdes cannot operate without wiz nodes, correct? why would we leave serdes on by default?

Yes, serdesX requires serdes_wizX, but at the same time, serdesX is the child node of serdes_wizX. Therefore, without enabling serdes_wizX, we cannot enable serdesX.

Prior to this series, but with the dependent series at:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
applied, the nodes look like:

	serdes_wizX {
		...
		status = "disabled";

		serdesX {
			...
			status = "disabled";
		};
	};
Quoted 6 lines

The dependent series fixes 'serdes_wizX' by disabling it in the SoC file k3-j722s-main.dtsi. But after the fix, we have a 'status = "disabled";' within the serdesX node which isn't required since:
a) serdes_wizX enabled but serdesX disabled is non-functional and unusable
b) serdes_wizX disabled in DT implies that serdesX is also disabled

Can we handle all of this in one series instead of two series?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#7 lore raw
Quoted 65 lines · Nishanth Menon
Quoted 56 lines · Siddharth Vadapalli

On Mon, Apr 14, 2025 at 07:09:30AM -0500, Nishanth Menon wrote:

Hello Nishanth,

Quoted 26 lines · Siddharth Vadapalli
Quoted 25 lines

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Quoted 7 lines
Quoted 3 lines
Signature · 1 line
2.34.1

I do not understand the logic here. serdes cannot operate without wiz nodes, correct? why would we leave serdes on by default?

Yes, serdesX requires serdes_wizX, but at the same time, serdesX is the child node of serdes_wizX. Therefore, without enabling serdes_wizX, we cannot enable serdesX.

Prior to this series, but with the dependent series at:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
applied, the nodes look like:

	serdes_wizX {
		...
		status = "disabled";

		serdesX {
			...
			status = "disabled";
		};
	};
Quoted 6 lines

The dependent series fixes 'serdes_wizX' by disabling it in the SoC file k3-j722s-main.dtsi. But after the fix, we have a 'status = "disabled";' within the serdesX node which isn't required since:
a) serdes_wizX enabled but serdesX disabled is non-functional and unusable
b) serdes_wizX disabled in DT implies that serdesX is also disabled

Quoted 1 line

Can we handle all of this in one series instead of two series?

The idea behind splitting it was that the dependent series is a "Fix":
- Fix to follow the convention of disabling nodes in SoC file and enable them in the board file.
while the current series is a "cleanup":
- No fixes are introduced by this series and therefore it doesn't require a backport.

I can squash the two series and post them as a v2 if that helps.

Regards,
Siddharth.

#8 lore raw
Quoted 68 lines · Siddharth Vadapalli
Quoted 65 lines · Nishanth Menon
Quoted 56 lines · Siddharth Vadapalli

On Mon, Apr 14, 2025 at 07:09:30AM -0500, Nishanth Menon wrote:

Hello Nishanth,

Quoted 26 lines · Siddharth Vadapalli
Quoted 25 lines

Hello,

This series is based on the following series:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Based on the discussion in the above series which disabled 'serdes_wiz0' and 'serdes_wiz1' nodes in the SoC file and enabled them in the board file, Udit pointed out that it wasn't necessary to disable 'serdes0' and 'serdes1' in the SoC file anymore, since that is not a working configuration - serdes_wizX enabled and serdesX disabled doesn't work.

Hence, this series aims to cleanup the serdesX nodes after the changes made by the above series.

Regards,
Siddharth.

Siddharth Vadapalli (2):
arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1
arm64: dts: ti: k3-j722s-evm: drop redundant status within
serdes0/serdes1

 arch/arm64/boot/dts/ti/k3-j722s-evm.dts   | 2 --
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ----
 2 files changed, 6 deletions(-)
Quoted 7 lines
Quoted 3 lines
Signature · 1 line
2.34.1

I do not understand the logic here. serdes cannot operate without wiz nodes, correct? why would we leave serdes on by default?

Yes, serdesX requires serdes_wizX, but at the same time, serdesX is the child node of serdes_wizX. Therefore, without enabling serdes_wizX, we cannot enable serdesX.

Prior to this series, but with the dependent series at:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
applied, the nodes look like:

	serdes_wizX {
		...
		status = "disabled";

		serdesX {
			...
			status = "disabled";
		};
	};
Quoted 6 lines

The dependent series fixes 'serdes_wizX' by disabling it in the SoC file k3-j722s-main.dtsi. But after the fix, we have a 'status = "disabled";' within the serdesX node which isn't required since:
a) serdes_wizX enabled but serdesX disabled is non-functional and unusable
b) serdes_wizX disabled in DT implies that serdesX is also disabled

Quoted 1 line

Can we handle all of this in one series instead of two series?

Quoted 8 lines

The idea behind splitting it was that the dependent series is a "Fix":
- Fix to follow the convention of disabling nodes in SoC file and enable them in the board file.
while the current series is a "cleanup":
- No fixes are introduced by this series and therefore it doesn't require a backport.

I can squash the two series and post them as a v2 if that helps.

I have squashed the series and have posted it at:
https://lore.kernel.org/r/[email protected]

Regards,
Siddharth.