X1E Asus Zenbook A14 support
Subsystems (4)
v3 cover X1E Asus Zenbook A14 support
Introduce support for the mentioned laptop.
Particular device exists in two model numbers:
* UX3407QA: X1P-42-100 or X1-26-100 (as tested)
* UX3407RA: X1E-78-100
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protected
When comparing device firmware between UX3407QA, UX3407RA, it seems that only ADSP firmware is different, CDSP and GPU firmware appears to be the same. (At least assuming the GPU firmware name in both cases is qcdxkmsuc8380.mbn). Since at least some blobs are different betweeen X1E and X1/X1P, define new firmware directory for qcom/x1p42100. This also makes it easier for distros to automatically extract firmware from Windows and place all blobs for the model under the same path. If/When firmware blobs make it to linux-firmware, same blobs can be easily symlinked between qcom/x1e80100 and qcom/x1p42100.
NVMe SSD depends on [1]. USB Type-A over USB MP controller depends on [2], or equivalent proposed solution.
Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and additionally required both newer firmware and patches to board-2.bin. I added a short how-to [3], as it is not exactly trivial.
ACPI dumps can be found on aarch64-laptops' github [4]. HWids on dtbloader's github [5].
[1] https://lore.kernel.org/linux-arm-msm/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi
[4] https://github.com/aarch64-laptops/build/pull/134/files
[5] https://github.com/TravMurav/dtbloader/pull/4/files
Changes to v1:
* Fix/re-add PS8833 as fallback
* Add EC's i2c address
* Add pwrseq for wcn6855, placeholder for wcn7850 until its tested
* Rename x1-zenbook.dtsi to x1-asus-zenbook.dtsi
Link to v2: https://lore.kernel.org/all/[email protected]/
Changes to v1:
* Drop PS8833 variant, fallback to PS8830 as they behave the same
* Drop wrong pcie6a_phy compatible revert
* Drop redundant comments, fix order of properties in the device-tree
* Fix device name bindings, express in model names instead of the soc
* Fix GPU firmware name for UX3407QA
* Fix model string, enclose variant in parenthesis
* Added missing new lines before 'status = "okay";'
* Updated cover letter to reflect some of the above changes
* Left SPI10 disabled as it is unknown how/what for to use it as of now Link to v1: https://lore.kernel.org/all/[email protected]/
Aleksandrs Vinarskis (4):
dt-bindings: usb: Add Parade PS8833 Type-C retimer variant
dt-bindings: arm: qcom: Add Asus Zenbook A14
firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
.../devicetree/bindings/arm/qcom.yaml | 2 + .../bindings/usb/parade,ps8830.yaml | 7 +- arch/arm64/boot/dts/qcom/Makefile | 2 + .../boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 1307 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 44 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 137 ++ drivers/firmware/qcom/qcom_scm.c | 2 + 7 files changed, 1499 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
Signature · 1 line
2.45.2
PATCH v3 1/4 dt-bindings: usb: Add Parade PS8833 Type-C retimer variant
Appears to behave similarly to Parade PS8830. Found on some Qualcomm Snapdragon X1 devices, such as Asus Zenbook A14.
--- Documentation/devicetree/bindings/usb/parade,ps8830.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/usb/parade,ps8830.yaml +5 -2
@@ -11,8 +11,11 @@ maintainers: properties: compatible: - enum: - - parade,ps8830 + oneOf: + - items: + - const: parade,ps8833 + - const: parade,ps8830 + - const: parade,ps8830 reg: maxItems: 1
Signature · 1 line
2.45.2
Re: [PATCH v3 1/4] dt-bindings: usb: Add Parade PS8833 Type-C retimer variant
Quoted 7 lines · Aleksandrs Vinarskis
Appears to behave similarly to Parade PS8830. Found on some Qualcomm Snapdragon X1 devices, such as Asus Zenbook A14.
Signed-off-by Aleksandrs Vinarskis <[email protected]>--- Documentation/devicetree/bindings/usb/parade,ps8830.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
---
<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>
Best regards,
Krzysztof
PATCH v3 2/4 dt-bindings: arm: qcom: Add Asus Zenbook A14
In reply to Aleksandrs VinarskisDocument the X1E-78-100 and X1P-42-100/X1-26-100 variants.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
@@ -1133,6 +1133,7 @@ properties: - items: - enum: - asus,vivobook-s15 + - asus,zenbook-a14-ux3407ra - dell,xps13-9345 - hp,omnibook-x14 - lenovo,yoga-slim7x
@@ -1144,6 +1145,7 @@ properties: - items: - enum: + - asus,zenbook-a14-ux3407qa - qcom,x1p42100-crd - const: qcom,x1p42100
Signature · 1 line
2.45.2
Re: [PATCH v3 2/4] dt-bindings: arm: qcom: Add Asus Zenbook A14
Quoted 4 lines · Aleksandrs Vinarskis
Document the X1E-78-100 and X1P-42-100/X1-26-100 variants.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
<form letter>
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
If a tag was not added on purpose, please state why and what changed. </form letter>
Best regards,
Krzysztof
PATCH v3 3/4 firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
In reply to Aleksandrs VinarskisAllow particular machine accessing eg. efivars.
--- drivers/firmware/qcom/qcom_scm.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/firmware/qcom/qcom_scm.c +2 -0
@@ -1986,6 +1986,8 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);*/ static const struct of_device_id qcom_scm_qseecom_allowlist[]__maybe_unused = { { .compatible ="asus,vivobook-s15" }, + { .compatible ="asus,zenbook-a14-ux3407qa" }, + { .compatible ="asus,zenbook-a14-ux3407ra" }, { .compatible ="dell,xps13-9345" }, { .compatible ="hp,omnibook-x14" }, { .compatible ="huawei,gaokun3" },
Signature · 1 line
2.45.2
PATCH v3 4/4 arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
In reply to Aleksandrs VinarskisInitial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protected
Working:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resume
Out of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* EC
Add dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
--- arch/arm64/boot/dts/qcom/Makefile | 2 + .../boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 1307 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 44 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 137 ++ 4 files changed, 1490 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
@@ -297,6 +297,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-zenbook-a14.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb
@@ -304,4 +305,5 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus15.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-qcp.dtb +dtb-$(CONFIG_ARCH_QCOM) += x1p42100-asus-zenbook-a14.dtb dtb-$(CONFIG_ARCH_QCOM) += x1p42100-crd.dtb
arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi new file +1307 -0
1,307 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts new file +44 -0
44 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts new file +137 -0
137 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH v3 4/4] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
Quoted 34 lines · Aleksandrs Vinarskis
Initial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWorking:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resumeOut of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* ECAdd dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
[...]
arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi line 677
Quoted 1 line
arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi new file +1
-0+ /* Left-side display-adjacent port, PS8833 */
nit: The mention of PS8833 in the comment is rather uneventful given it says so right below it as well
Quoted 2 lines
(quoted diff) +2
-0+ typec-mux@8 { + compatible = "parade,ps8833", "parade,ps8830";
[...]
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts line 44
Quoted 10 lines
+&uart14 {
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts new file +9
-0+ status = "okay"; + + bluetooth { + /* TODO: add pwrseq once validated */ + compatible = "qcom,wcn7850-bt"; + + max-speed = <3000000>; + }; +};
Drop it for now, the dt checker is angry about partial definitions
I think it looks ok otherwise
Konrad
Re: [PATCH v3 4/4] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14
Quoted 37 lines · Konrad Dybcio
Quoted 29 lines · Aleksandrs Vinarskis
Initial support for Asus Zenbook A14. Particular moddel exists in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWorking:
* Keyboard
* Touchpad
* NVME
* Lid switch
* Camera LED
* eDP (FHD OLED, SDC420D) with brightness control
* Bluetooth, WiFi (WCN6855)
* USB Type-A port
* USB Type-C ports in USB2/USB3/DP (both orientations)
* aDSP/cDPS firmware loading, battery info
* Sleep/suspend, nothing visibly broken on resumeOut of scope of this series:
* Audio (Speakers/microphones/headphone jack)
* Camera (OmniVision OV02C10)
* HDMI (Parade PS185HDM)
* ECQuoted 5 lines
Add dtsi and create two configurations for UX3407QA, UX3407RA. Tested on UX3407QA with X1-26-100.
Signed-off-by Aleksandrs Vinarskis <[email protected]>---
Quoted 6 lines
[...]
Quoted 1 line
+ /* Left-side display-adjacent port, PS8833 */
nit: The mention of PS8833 in the comment is rather uneventful given it says so right below it as well
Good point, will remove.
Quoted 6 lines
Quoted 3 lines
(quoted diff) +2
-0+ typec-mux@8 { + compatible = "parade,ps8833", "parade,ps8830";[...]
Quoted 12 lines
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts line 44
Quoted 10 lines
+&uart14 {
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts new file +9
-0+ status = "okay"; + + bluetooth { + /* TODO: add pwrseq once validated */ + compatible = "qcom,wcn7850-bt"; + + max-speed = <3000000>; + }; +};Drop it for now, the dt checker is angry about partial definitions
Hmm, but then this variant won't have bluetooth working at all... Will drop, let's hope someone from the community has x1e variant to test pwrseq for wnc7850 for a follow up patch soon.
Thanks,
Alex
Quoted 4 lines
I think it looks ok otherwise
Konrad
Rob Herring (Arm)
maintainerQuoted 76 lines · Aleksandrs Vinarskis
Introduce support for the mentioned laptop.
Particular device exists in two model numbers:
* UX3407QA: X1P-42-100 or X1-26-100 (as tested)
* UX3407RA: X1E-78-100Mostly similar to other X1-based laptops. Notable differences are:
* Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA
* USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830
* gpio90 is TZ protectedWhen comparing device firmware between UX3407QA, UX3407RA, it seems that only ADSP firmware is different, CDSP and GPU firmware appears to be the same. (At least assuming the GPU firmware name in both cases is
qcdxkmsuc8380.mbn). Since at least some blobs are different betweeen X1E and X1/X1P, define new firmware directory forqcom/x1p42100. This also makes it easier for distros to automatically extract firmware from Windows and place all blobs for the model under the same path. If/When firmware blobs make it to linux-firmware, same blobs can be easily symlinked betweenqcom/x1e80100andqcom/x1p42100.NVMe SSD depends on [1]. USB Type-A over USB MP controller depends on [2], or equivalent proposed solution.
Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and additionally required both newer firmware and patches to
board-2.bin. I added a short how-to [3], as it is not exactly trivial.ACPI dumps can be found on aarch64-laptops' github [4]. HWids on dtbloader's github [5].
[1] https://lore.kernel.org/linux-arm-msm/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi
[4] https://github.com/aarch64-laptops/build/pull/134/files
[5] https://github.com/TravMurav/dtbloader/pull/4/filesChanges to v1:
* Fix/re-add PS8833 as fallback
* Add EC's i2c address
* Add pwrseq for wcn6855, placeholder for wcn7850 until its tested
* Renamex1-zenbook.dtsitox1-asus-zenbook.dtsi
Link to v2: https://lore.kernel.org/all/[email protected]/Changes to v1:
* Drop PS8833 variant, fallback to PS8830 as they behave the same
* Drop wrongpcie6a_phycompatible revert
* Drop redundant comments, fix order of properties in the device-tree
* Fix device name bindings, express in model names instead of the soc
* Fix GPU firmware name for UX3407QA
* Fix model string, enclose variant in parenthesis
* Added missing new lines before 'status = "okay";'
* Updated cover letter to reflect some of the above changes
* Left SPI10 disabled as it is unknown how/what for to use it as of now Link to v1: https://lore.kernel.org/all/[email protected]/Aleksandrs Vinarskis (4):
dt-bindings: usb: Add Parade PS8833 Type-C retimer variant
dt-bindings: arm: qcom: Add Asus Zenbook A14
firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14
arm64: dts: qcom: Add support for X1-based Asus Zenbook A14.../devicetree/bindings/arm/qcom.yaml | 2 + .../bindings/usb/parade,ps8830.yaml | 7 +- arch/arm64/boot/dts/qcom/Makefile | 2 + .../boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 1307 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 44 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 137 ++ drivers/firmware/qcom/qcom_scm.c | 2 + 7 files changed, 1499 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts
Quoted 5 lines
--
2.45.2
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250416 (exact match)
If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for [email protected]:
arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddrfacmn-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddaon-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddwlcx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddwlmx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddrfa0p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddrfa1p2-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth (qcom,wcn7850-bt): 'vddrfa1p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#