Skip to contentSkip to conversation

Add ti,suppress-v1p8-ena

PATCH RESEND In review Judith Mendez 4 participants 9 messages Apr 22, 2025 – Apr 25, 2025

Subsystems (6)
lore
Share & tools
lore

Judith Mendez

author maintainer
#0 lore raw

v3 cover Add ti,suppress-v1p8-ena

Resend patch series to fix cc list

There are MMC boot failures seen with V1P8_SIGNAL_ENA on Kingston eMMC and Microcenter/Patriot SD cards on Sitara K3 boards due to the HS200 initialization sequence involving V1P8_SIGNAL_ENA. Since V1P8_SIGNAL_ENA is optional for eMMC, do not set V1P8_SIGNAL_ENA by default for eMMC. For SD cards we shall parse DT for ti,suppress-v1p8-ena property to determine whether to suppress V1P8_SIGNAL_ENA. Add new ti,suppress-v1p8-ena to am62x, am62ax, and am62px SoC dtsi files since there is no internal LDO tied to sdhci1 interface so V1P8_SIGNAL_ENA only affects timing.

This fix was previously merged in the kernel, but was reverted due to the "heuristics for enabling the quirk"[0]. This issue is adressed in this patch series by adding optional ti,suppress-v1p8-ena DT property which determines whether to apply the quirk for SD.

Changes since v2:
- Include patch 3/3
- Reword cover letter
- Reword binding patch description
- Add fixes/cc tags to driver patch
- Reorder patches according to binding patch first
- Resend to fix cc list in original v3 series

Link to v2:
https://lore.kernel.org/linux-mmc/[email protected]/
Link to v1:
https://lore.kernel.org/linux-mmc/[email protected]/

[0] https://lore.kernel.org/linux-mmc/[email protected]/

Judith Mendez (3):
dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena
mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch
arm64: dts: ti: k3-am62*: add ti,suppress-v1p8-ena

 .../devicetree/bindings/mmc/sdhci-am654.yaml  |  5 +++
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |  1 +
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     |  1 +
 .../dts/ti/k3-am62p-j722s-common-main.dtsi    |  1 +
 drivers/mmc/host/sdhci_am654.c                | 32 +++++++++++++++++++
 5 files changed, 40 insertions(+)

base-commit: 1be38f81251f6d276713c259ecf4414f82f22c29

Signature · 1 line
2.49.0
author maintainer
#1 lore raw

PATCH RESEND v3 1/3 dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

Some Microcenter/Patriot SD cards and Kingston eMMC are failing init across Sitara K3 boards. Init failure is due to the sequence when V1P8_SIGNAL_ENA is set. The V1P8_SIGNAL_ENA has a timing component tied to it where if set, switch to full-cycle timing happens. The failing cards do not like change to full-cycle timing before changing bus width, so add flag to sdhci-am654 binding to suppress V1P8_SIGNAL_ENA before changing bus width. The switch to full-cycle timing should happen with HIGH_SPEED_ENA after change of bus width.

---
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +5 -0
index 676a74695389..0f92bbf8e13b 100644
@@ -201,6 +201,11 @@ properties:
       and the controller is required to be forced into Test mode
       to set the TESTCD bit.
 
+  ti,suppress-v1p8-ena:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      When present, V1P8_SIGNAL_ENA shall be suppressed.
+
 required:
   - compatible
   - reg
Signature · 1 line
2.49.0
#2 lore raw

Re: [PATCH RESEND v3 1/3] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH RESEND v3 1/3] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#3 lore raw

Re: [PATCH RESEND v3 1/3] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

In reply to Judith Mendez
Quoted 19 lines · Judith Mendez

Some Microcenter/Patriot SD cards and Kingston eMMC are failing init across Sitara K3 boards. Init failure is due to the sequence when V1P8_SIGNAL_ENA is set. The V1P8_SIGNAL_ENA has a timing component tied to it where if set, switch to full-cycle timing happens. The failing cards do not like change to full-cycle timing before changing bus width, so add flag to sdhci-am654 binding to suppress V1P8_SIGNAL_ENA before changing bus width. The switch to full-cycle timing should happen with HIGH_SPEED_ENA after change of bus width.

---
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +0 -0
index 676a74695389..0f92bbf8e13b 100644

Documentation/devicetree/bindings/mmc/sdhci-am654.yaml properties: · line 204

Quoted 4 lines
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +1 -0
@@ -201,6 +201,11 @@ properties:
       and the controller is required to be forced into Test mode
       to set the TESTCD bit.
 
+  ti,suppress-v1p8-ena:

Do not tell what the drivers should do, but tell what is the issue with the hardware, e.g. some cards do not like full-cycle.... and this will also hint you that it should be most likely generic, not specific to this device.

Documentation/devicetree/bindings/mmc/sdhci-am654.yaml properties: · line 206

Quoted 2 lines
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +2 -0
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:

Best regards,
Krzysztof

author maintainer
#4 lore raw

Re: [PATCH RESEND v3 1/3] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

Hi Krzysztof,

Quoted 23 lines · Krzysztof Kozlowski
Quoted 22 lines · Judith Mendez

Some Microcenter/Patriot SD cards and Kingston eMMC are failing init across Sitara K3 boards. Init failure is due to the sequence when V1P8_SIGNAL_ENA is set. The V1P8_SIGNAL_ENA has a timing component tied to it where if set, switch to full-cycle timing happens. The failing cards do not like change to full-cycle timing before changing bus width, so add flag to sdhci-am654 binding to suppress V1P8_SIGNAL_ENA before changing bus width. The switch to full-cycle timing should happen with HIGH_SPEED_ENA after change of bus width.

---
  Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 5 +++++
  1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +0 -0
index 676a74695389..0f92bbf8e13b 100644
@@ -201,6 +201,11 @@ properties:
        and the controller is required to be forced into Test mode
        to set the TESTCD bit.
 
Quoted 7 lines

Documentation/devicetree/bindings/mmc/sdhci-am654.yaml properties: · line 204

Quoted 1 line
Documentation/devicetree/bindings/mmc/sdhci-am654.yaml +1 -0
+  ti,suppress-v1p8-ena:

Do not tell what the drivers should do, but tell what is the issue with the hardware, e.g. some cards do not like full-cycle.... and this will also hint you that it should be most likely generic, not specific to this device.

Thanks for your review, but this patch has been dropped in v4 since we adopted a new implementation [0] using compatible string.

[0] https://lore.kernel.org/linux-devicetree/20250423180809.l3l6sfbwquaaazar@shrank/

~ Judith

author maintainer
#5 lore raw

PATCH RESEND v3 2/3 mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch

In reply to Judith Mendez

The sdhci_start_signal_voltage_switch function sets V1P8_SIGNAL_ENA by default after switching to 1v8 signaling. V1P8_SIGNAL_ENA has a timing component where it determines whether to launch cmd/data on neg edge (half cycle timing) or pos edge (full cycle timing) of clock. V1P8_SIGNAL_ENA also has a voltage switch component where if there exists an internal LDO, for SD this bit is used to switch from 3.3V to 1.8V IO signal voltage.

The sequence is to switch to 1.8 IO voltage, set V1P8_SIGNAL_ENA, change bus width, then update HIGH_SPEED_ENA & UHS_MODE_SELECT. During bus width change is when eMMC failures are seen with Kingston eMMC and various types SD cards across Sitara K3 SoCs.

So, add a quirk to suppress V1P8_SIGNAL_ENA and do not enable by default for eMMC since it is anyways optional for this interface and parse DT property: ti,fails-without-test-cd to apply the quirk for SD cards.

Fixes ac5a41b472b4 ("Revert "mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch"")
Fixes 941a7abd4666 ("mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch")
---
 drivers/mmc/host/sdhci_am654.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/mmc/host/sdhci_am654.c +32 -0
index f75c31815ab0..d4cafc7af97d 100644
@@ -87,6 +87,7 @@
 #define CLOCK_TOO_SLOW_HZ	50000000
 #define SDHCI_AM654_AUTOSUSPEND_DELAY	-1
 #define RETRY_TUNING_MAX	10
+#define BUS_WIDTH_8		8
 
 /* Command Queue Host Controller Interface Base address */
 #define SDHCI_AM654_CQE_BASE_ADDR 0x200
@@ -155,6 +156,7 @@ struct sdhci_am654_data {
 	u32 tuning_loop;
 
 #define SDHCI_AM654_QUIRK_FORCE_CDTEST BIT(0)
+#define SDHCI_AM654_QUIRK_SUPPRESS_V1P8_ENA BIT(1)
 };
 
 struct window {
@@ -356,6 +358,29 @@ static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
 	sdhci_set_clock(host, clock);
 }
 
+static int sdhci_am654_start_signal_voltage_switch(struct mmc_host *mmc, struct mmc_ios *ios)
+{
+	struct sdhci_host *host = mmc_priv(mmc);
+	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
+	struct sdhci_am654_data *sdhci_am654 = sdhci_pltfm_priv(pltfm_host);
+	int ret;
+
+	if ((sdhci_am654->quirks & SDHCI_AM654_QUIRK_SUPPRESS_V1P8_ENA) &&
+	    ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180) {
+		if (!IS_ERR(mmc->supply.vqmmc)) {
+			ret = mmc_regulator_set_vqmmc(mmc, ios);
+			if (ret < 0) {
+				pr_err("%s: Switching to 1.8V signalling voltage failed,\n",
+				       mmc_hostname(mmc));
+				return -EIO;
+			}
+		}
+		return 0;
+	}
+
+	return sdhci_start_signal_voltage_switch(mmc, ios);
+}
+
 static u8 sdhci_am654_write_power_on(struct sdhci_host *host, u8 val, int reg)
 {
 	writeb(val, host->ioaddr + reg);
@@ -802,6 +827,7 @@ static int sdhci_am654_get_of_property(struct platform_device *pdev,
 {
 	struct device *dev = &pdev->dev;
 	int drv_strength;
+	u32 bus_width;
 	int ret;
 
 	if (sdhci_am654->flags & DLL_PRESENT) {
@@ -844,6 +870,11 @@ static int sdhci_am654_get_of_property(struct platform_device *pdev,
 	if (device_property_read_bool(dev, "ti,fails-without-test-cd"))
 		sdhci_am654->quirks |= SDHCI_AM654_QUIRK_FORCE_CDTEST;
 
+	/* Suppress V1P8_SIGNAL_ENA */
+	device_property_read_u32(dev, "bus-width", &bus_width);
+	if (bus_width == BUS_WIDTH_8 || device_property_read_bool(dev, "ti,suppress-v1p8-ena"))
+		sdhci_am654->quirks |= SDHCI_AM654_QUIRK_SUPPRESS_V1P8_ENA;
+
 	sdhci_get_of_property(pdev);
 
 	return 0;
@@ -940,6 +971,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
 		goto err_pltfm_free;
 	}
 
+	host->mmc_host_ops.start_signal_voltage_switch = sdhci_am654_start_signal_voltage_switch;
 	host->mmc_host_ops.execute_tuning = sdhci_am654_execute_tuning;
 
 	pm_runtime_get_noresume(dev);
Signature · 1 line
2.49.0
author maintainer
#6 lore raw

PATCH RESEND v3 3/3 arm64: dts: ti: k3-am62*: add ti,suppress-v1p8-ena

In reply to Judith Mendez

Add ti,suppress-v1p8-ena flag to sdhci1 nodes to suppress V1P8_SIGNAL_ENA.

On am62x, am62ax, and am62px SoCs, there is no internal LDO tied to sdhci1 interface so V1P8_SIGNAL_ENA only affects timing. Suppress V1P8_SIGNAL_ENA since it causes init failures across Microcenter/Patriot SD cards and Kingston eMMC on am62* SK boards.

---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi               | 1 +
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi              | 1 +
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 1 +
 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +1 -0
index 7d355aa73ea2..a61153b0af32 100644
@@ -586,6 +586,7 @@ sdhci1: mmc@fa00000 {
 		ti,itap-del-sel-sd-hs = <0x0>;
 		ti,itap-del-sel-sdr12 = <0x0>;
 		ti,itap-del-sel-sdr25 = <0x0>;
+		ti,suppress-v1p8-ena;
 		status = "disabled";
 	};
 
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi +1 -0
index a1daba7b1fad..44d973caf200 100644
@@ -606,6 +606,7 @@ sdhci1: mmc@fa00000 {
 		ti,itap-del-sel-sd-hs = <0x0>;
 		ti,itap-del-sel-sdr12 = <0x0>;
 		ti,itap-del-sel-sdr25 = <0x0>;
+		ti,suppress-v1p8-ena;
 		status = "disabled";
 	};
 
arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi +1 -0
index 6e3beb5c2e01..c4304dae9757 100644
@@ -604,6 +604,7 @@ sdhci1: mmc@fa00000 {
 		ti,itap-del-sel-sd-hs = <0x0>;
 		ti,itap-del-sel-sdr12 = <0x0>;
 		ti,itap-del-sel-sdr25 = <0x0>;
+		ti,suppress-v1p8-ena;
 		status = "disabled";
 	};
 
Signature · 1 line
2.49.0
maintainer
#7 lore raw
In reply to Judith Mendez
Quoted 15 lines · Judith Mendez

Resend patch series to fix cc list

There are MMC boot failures seen with V1P8_SIGNAL_ENA on Kingston eMMC and Microcenter/Patriot SD cards on Sitara K3 boards due to the HS200 initialization sequence involving V1P8_SIGNAL_ENA. Since V1P8_SIGNAL_ENA is optional for eMMC, do not set V1P8_SIGNAL_ENA by default for eMMC. For SD cards we shall parse DT for ti,suppress-v1p8-ena property to determine whether to suppress V1P8_SIGNAL_ENA. Add new ti,suppress-v1p8-ena to am62x, am62ax, and am62px SoC dtsi files since there is no internal LDO tied to sdhci1 interface so V1P8_SIGNAL_ENA only affects timing.

This fix was previously merged in the kernel, but was reverted due to the "heuristics for enabling the quirk"[0]. This issue is adressed in this patch series by adding optional ti,suppress-v1p8-ena DT property which determines whether to apply the quirk for SD.

[...]

Quoted 2 lines

[0] https://lore.kernel.org/linux-mmc/[email protected]/

Why cant we use compatible to enable the quirk instead of blindly enabling for all IPs including ones that have onchip LDOs? That was the reason it failed in the first place for am64x.

This is very much like a quirk that seems to go hand-in-hand with the compatible for am62-sdhci ?

Is it worth exploring that option in the driver thread? from where I stand, this sounds very much like an issue that AM62x IP has, and should be handled by the driver instead of punting to dts to select where to use and not to use the quirk.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author maintainer
#8 lore raw

Hi Nishanth,

Quoted 16 lines · Nishanth Menon
Quoted 11 lines · Judith Mendez

Resend patch series to fix cc list

There are MMC boot failures seen with V1P8_SIGNAL_ENA on Kingston eMMC and Microcenter/Patriot SD cards on Sitara K3 boards due to the HS200 initialization sequence involving V1P8_SIGNAL_ENA. Since V1P8_SIGNAL_ENA is optional for eMMC, do not set V1P8_SIGNAL_ENA by default for eMMC. For SD cards we shall parse DT for ti,suppress-v1p8-ena property to determine whether to suppress V1P8_SIGNAL_ENA. Add new ti,suppress-v1p8-ena to am62x, am62ax, and am62px SoC dtsi files since there is no internal LDO tied to sdhci1 interface so V1P8_SIGNAL_ENA only affects timing.

Quoted 4 lines

This fix was previously merged in the kernel, but was reverted due to the "heuristics for enabling the quirk"[0]. This issue is adressed in this patch series by adding optional ti,suppress-v1p8-ena DT property which determines whether to apply the quirk for SD.

Quoted 7 lines

[...]

Quoted 2 lines

[0] https://lore.kernel.org/linux-mmc/[email protected]/

Why cant we use compatible to enable the quirk instead of blindly enabling for all IPs including ones that have onchip LDOs? That was the reason it failed in the first place for am64x.

We made an assumption that did not work out.

Quoted 9 lines

This is very much like a quirk that seems to go hand-in-hand with the compatible for am62-sdhci ?

Is it worth exploring that option in the driver thread? from where I stand, this sounds very much like an issue that AM62x IP has, and should be handled by the driver instead of punting to dts to select where to use and not to use the quirk.

Sure, I can test this out and respin the series. It does seem like a more clean solution, thanks for reviewing.

~ Judith