Skip to contentSkip to conversation

zedboard correct comments in lowlevel.c

PATCH Applied [email protected] 2 participants 2 messages Apr 28, 2025 – Apr 29, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zedboard correct comments in lowlevel.c

From: Johannes Roith <[email protected]>

According to the TRM of the Zynq 7000 the registers under 'UART1 pinmux' represents the pinmux for UART0. So, I fixed the comments and also added the pin number for the UART0, UART1 and QSPI pins to the pinctrl.

Link to TRM page for pinmux:

https://docs.amd.com/r/en-US/ug585-zynq-7000-SoC-TRM/Register-slcr-MIO_PIN_50

---
 arch/arm/boards/avnet-zedboard/lowlevel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/boards/avnet-zedboard/lowlevel.c +3 -2
index 026a03d04b..605aab783a 100644
@@ -223,12 +223,13 @@ static void avnet_zedboard_ps7_init(void)
 	writel(0x00000081, 0XF8006000);
 
 	/* poor mans pinctrl */
+	/* UART1 pinmux TxD: MIO_PIN 48, RxD: MIO_PIN 49 */
 	writel(0x000002E0, ZYNQ_MIO_BASE + 0xC0);
 	writel(0x000002E1, ZYNQ_MIO_BASE + 0xC4);
-	/* UART1 pinmux */
+	/* UART0 pinmux TxD: MIO_PIN 50, RxD: MIO_PIN 51 */
 	writel(0x000002E1, ZYNQ_MIO_BASE + 0xC8);
 	writel(0x000002E0, ZYNQ_MIO_BASE + 0xCC);
-	/* QSPI pinmux */
+	/* QSPI pinmux MIO_PIN 01 - 08 */
 	writel(0x00001602, ZYNQ_MIO_BASE + 0x04);
 	writel(0x00000702, ZYNQ_MIO_BASE + 0x08);
 	writel(0x00000702, ZYNQ_MIO_BASE + 0x0c);
Signature · 1 line
2.39.5
Applied
#1 lore raw
Quoted 9 lines · On Mon, 28 Apr 2025 19:54:24 +0200, [email protected] wrote:

According to the TRM of the Zynq 7000 the registers under 'UART1 pinmux' represents the pinmux for UART0. So, I fixed the comments and also added the pin number for the UART0, UART1 and QSPI pins to the pinctrl.

Link to TRM page for pinmux:

[...]

Applied, thanks!

[1/1] zedboard correct comments in lowlevel.c
https://git.pengutronix.de/cgit/barebox/commit/?id=72ea1dbb99d6 (link may not be stable)

Best regards,

Signature · 1 line
Sascha Hauer <[email protected]>