x86/microcode/amd: fix the return value when microcode has no update
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 2.49.0.901.g37484f566f-goog
PATCH v2 1/1 x86/microcode/amd: fix the return value when microcode has no update
In commit 6f059e634dcd("x86/microcode: Clarify the late load logic"), the return value is UCODE_OK if the load is up-to-date in amd platform, which leads to load_late_locked() returning -EBADFD.
Add UCODE_OK in switch case to avoid this error.
---
Changelog since v1:
- Change the return value back to UCODE_OK and adding a switch case about UCODE_OK.
arch/x86/kernel/cpu/microcode/core.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kernel/cpu/microcode/core.c +2 -0
@@ -686,6 +686,8 @@ static int load_late_locked(void)return load_late_stop_cpus (true);case UCODE_NFOUND :return -ENOENT ; +case UCODE_OK : +return 0 ;default :return -EBADFD ; }
Signature · 1 line
2.49.0.901.g37484f566f-goog
[tip: x86/microcode] x86/microcode/AMD: Do not return error when microcode update is not necessary
The following commit has been merged into the x86/microcode branch of tip:
The following commit has been merged into the x86/microcode branch of tip:
Commit-ID: b43dc4ab097859c24e2a6993119c927cffc856aa Gitweb: https://git.kernel.org/tip/b43dc4ab097859c24e2a6993119c927cffc856aa Author: Annie Li <[email protected]> AuthorDate: Wed, 30 Apr 2025 05:34:24 Committer: Borislav Petkov (AMD) <[email protected]> CommitterDate: Wed, 30 Apr 2025 17:10:46 +02:00
x86/microcode/AMD: Do not return error when microcode update is not necessary
After
6f059e634dcd("x86/microcode: Clarify the late load logic"),
if the load is up-to-date, the AMD side returns UCODE_OK which leads to load_late_locked() returning -EBADFD.
Handle UCODE_OK in the switch case to avoid this error.
[ bp: Massage commit message. ]
--- arch/x86/kernel/cpu/microcode/core.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kernel/cpu/microcode/core.c +2 -0
@@ -686,6 +686,8 @@ static int load_late_locked(void)return load_late_stop_cpus (true);case UCODE_NFOUND :return -ENOENT ; +case UCODE_OK : +return 0 ;default :return -EBADFD ; }