Skip to contentSkip to conversation

x86/microcode/amd: fix the return value when microcode has no update

PATCH Superseded Annie Li 2 participants 2 messages Apr 29, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Annie Li

author
#0 lore raw

PATCH 1/1 x86/microcode/amd: fix the return value when microcode has no update

In commit 6f059e634dcd("x86/microcode: Clarify the late load logic"), the return value is UCODE_OK if the load is up-to-date in amd platform, which leads to load_late_locked() returning -EBADFD.

This is different from the intel platform, which will return UCODE_NFOUND and is more reasonable.

Fix the return to UCODE_NFOUND to avoid -EBADFD error.

Fixes 6f059e634dcd ("x86/microcode: Clarify the late load logic")
---
 arch/x86/kernel/cpu/microcode/amd.c | 2 ++
 1 file changed, 2 insertions(+)
arch/x86/kernel/cpu/microcode/amd.c +2 -0
index b61028cf5c8a3..f90779dc1cac5 100644
@@ -1074,6 +1074,8 @@ static enum ucode_state load_microcode_amd(u8 family, const u8 *data, size_t siz
 	if (ret != UCODE_OK)
 		return ret;
 
+	ret = UCODE_NFOUND;
+
 	for_each_node_with_cpus(nid) {
 		cpu = cpumask_first(cpumask_of_node(nid));
 		c = &cpu_data(cpu);
Signature · 1 line
2.49.0.901.g37484f566f-goog
maintainer
#1 lore raw
Quoted 8 lines · Annie Li

In commit 6f059e634dcd("x86/microcode: Clarify the late load logic"), the return value is UCODE_OK if the load is up-to-date in amd platform, which leads to load_late_locked() returning -EBADFD.

This is different from the intel platform, which will return UCODE_NFOUND and is more reasonable.

Fix the return to UCODE_NFOUND to avoid -EBADFD error.

... and return -ENOENT instead?

Is that better?

Or would it be even better for the switch-case to handle UCODE_OK too?

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette