Convert Rockchip CDN DP binding to yaml
Subsystems (5)
v3 cover Convert Rockchip CDN DP binding to yaml
From: Chaoyi Chen <[email protected]>
This series convert cdn-dp-rockchip.txt to yaml.
PATCH 1 try to improve coding style on the existing rk3399 cdn-dp node.
PATCH 2 try to convert cdn-dp-rockchip.txt to yaml.
Changes in v3:
- Link to V2: https://lore.kernel.org/all/[email protected]/
- Add more description about phy/extcon
- Fix some coding style
Changes in v2:
- Link to V1: https://lore.kernel.org/all/[email protected]/
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
Chaoyi Chen (2):
arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
.../display/rockchip/cdn-dp-rockchip.txt | 74 -------- .../rockchip/rockchip,rk3399-cdn-dp.yaml | 165 ++++++++++++++++++ arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +- 3 files changed, 174 insertions(+), 75 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
--
2.49.0
PATCH v3 1/2 arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
From: Chaoyi Chen <[email protected]>
Let's make the ports nodes of cdn_dp in the same style as the other display interface, and match the style of ports's yaml.
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi +9 -1
@@ -618,7 +618,11 @@ cdn_dp: dp@fec00000 { status = "disabled"; ports { - dp_in: port { + #address-cells = <1>; + #size-cells = <0>; + + dp_in: port@0 { + reg = <0>; #address-cells = <1>; #size-cells = <0>;
@@ -632,6 +636,10 @@ dp_in_vopl: endpoint@1 { remote-endpoint = <&vopl_out_dp>; }; }; + + dp_out: port@1 { + reg = <1>; + }; }; };
--
2.49.0
PATCH v3 2/2 dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
In reply to Chaoyi ChenFrom: Chaoyi Chen <[email protected]>
Convert cdn-dp-rockchip.txt to yaml.
---
Changes in v3:
- Add more description about phy/extcon
- Fix some coding style
Changes in v2:
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
.../display/rockchip/cdn-dp-rockchip.txt | 74 -------- .../rockchip/rockchip,rk3399-cdn-dp.yaml | 165 ++++++++++++++++++ 2 files changed, 165 insertions(+), 74 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt deleted +0 -74
@@ -1,74 +0,0 @@ -Rockchip RK3399 specific extensions to the cdn Display Port -================================ - -Required properties: -- compatible: must be "rockchip,rk3399-cdn-dp" - -- reg: physical base address of the controller and length - -- clocks: from common clock binding: handle to dp clock. - -- clock-names: from common clock binding: - Required elements: "core-clk" "pclk" "spdif" "grf" - -- resets : a list of phandle + reset specifier pairs -- reset-names : string of reset names - Required elements: "apb", "core", "dptx", "spdif" -- power-domains : power-domain property defined with a phandle - to respective power domain. -- assigned-clocks: main clock, should be <&cru SCLK_DP_CORE> -- assigned-clock-rates : the DP core clk frequency, shall be: 100000000 - -- rockchip,grf: this soc should set GRF regs, so need get grf here. - -- ports: contain a port nodes with endpoint definitions as defined in - Documentation/devicetree/bindings/media/video-interfaces.txt. - contained 2 endpoints, connecting to the output of vop. - -- phys: from general PHY binding: the phandle for the PHY device. - -- extcon: extcon specifier for the Power Delivery - -- #sound-dai-cells = it must be 1 if your system is using 2 DAIs: I2S, SPDIF - -------------------------------------------------------------------------------- - -Example: - cdn_dp: dp@fec00000 { - compatible = "rockchip,rk3399-cdn-dp"; - reg = <0x0 0xfec00000 0x0 0x100000>; - interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>, - <&cru SCLK_SPDIF_REC_DPTX>, <&cru PCLK_VIO_GRF>; - clock-names = "core-clk", "pclk", "spdif", "grf"; - assigned-clocks = <&cru SCLK_DP_CORE>; - assigned-clock-rates = <100000000>; - power-domains = <&power RK3399_PD_HDCP>; - phys = <&tcphy0_dp>, <&tcphy1_dp>; - resets = <&cru SRST_DPTX_SPDIF_REC>; - reset-names = "spdif"; - extcon = <&fusb0>, <&fusb1>; - rockchip,grf = <&grf>; - #address-cells = <1>; - #size-cells = <0>; - #sound-dai-cells = <1>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - dp_in: port { - #address-cells = <1>; - #size-cells = <0>; - dp_in_vopb: endpoint@0 { - reg = <0>; - remote-endpoint = <&vopb_out_dp>; - }; - - dp_in_vopl: endpoint@1 { - reg = <1>; - remote-endpoint = <&vopl_out_dp>; - }; - }; - }; - };
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +165 -0
165 lines not on this page · raw message
--
2.49.0
Heiko Stübner
maintainerRe: [PATCH v3 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Hi,
Am Dienstag, 13. Mai 2025, 03:19:04 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen:
Quoted 10 lines
From: Chaoyi Chen <[email protected]>
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +9
-0+ ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input of the CDN DP + properties: + endpoint@0:
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 77
Quoted 10 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +10
-0+ description: Connection to the VOPB + endpoint@1: + description: Connection to the VOPL + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Output of the CDN DP + + required: + - port@0 + - port@1
you're adding the 2nd port (port@1) as output port, which has not been part of the old binding. I think this warrants an explanation in the commit message on what it is meant to contain.
Heiko
Re: [PATCH v3 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Hi Heiko,
Quoted 18 lines · Heiko Stübner
Hi,
Am Dienstag, 13. Mai 2025, 03:19:04 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen:
Quoted 15 lines
From: Chaoyi Chen <[email protected]>
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +14
-0+ ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input of the CDN DP + properties: + endpoint@0: + description: Connection to the VOPB + endpoint@1: + description: Connection to the VOPL + port@1: + $ref: /schemas/graph.yaml#/properties/port
Quoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 77
Quoted 5 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +5
-0+ description: Output of the CDN DP + + required: + - port@0 + - port@1you're adding the 2nd port (port@1) as output port, which has not been part of the old binding. I think this warrants an explanation in the commit message on what it is meant to contain.
This is mainly to keep consistent with the binding style of other display interfaces, which all have an Input (port@0) and Output (port@1).
This change has no effect on the driver. I will explain this in v4.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip