mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info.patch removed from -mm tree
The quilt patch titled
Subject: mm/memcg: use kmem_cache when alloc memcg pernode info
has been removed from the -mm tree. Its filename was
mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Huan Yang <[email protected]>
Subject: mm/memcg: use kmem_cache when alloc memcg pernode info
Date: Fri, 25 Apr 2025 11:19:25 +0800
When tracing mem_cgroup_per_node allocations with kmalloc ftrace:
kmalloc: call_site=mem_cgroup_css_alloc+0x1d8/0x5b4 ptr=00000000d798700c
bytes_req=2896 bytes_alloc=4096 gfp_flags=GFP_KERNEL|__GFP_ZERO node=0
accounted=falseThis reveals the slab allocator provides 4096B chunks for 2896B mem_cgroup_per_node due to:
1. The slab allocator predefines bucket sizes from 64B to 8096B
2. The mem_cgroup allocation size (2312B) falls between the 2KB and 4KB slabs
3. The allocator rounds up to the nearest larger slab (4KB), resulting in ~1KB wasted memory per memcg alloc - per node.
This patch introduces a dedicated kmem_cache for mem_cgroup structs, achieving precise memory allocation. Post-patch ftrace verification shows:
kmem_cache_alloc: call_site=mem_cgroup_css_alloc+0x1b8/0x5d4
ptr=000000002989e63a bytes_req=2896 bytes_alloc=2944 gfp_flags=GFP_KERNEL|__GFP_ZERO node=0 accounted=false
Each mem_cgroup_per_node alloc 2944bytes(include hw cacheline align), compare to 4096, it avoid waste.
---
mm/memcontrol.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
mm/memcontrol.c renamed from mm/memcontrol.c~mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info +6 -1
@@ -97,6 +97,7 @@ static bool cgroup_memory_nokmem __ro_afstatic bool cgroup_memory_nobpf__ro_after_init ;static struct kmem_cache *memcg_cachep; +static struct kmem_cache *memcg_pn_cachep;#ifdef CONFIG_CGROUP_WRITEBACK static DECLARE_WAIT_QUEUE_HEAD (memcg_cgwb_frn_waitq);
@@ -3614,7 +3615,8 @@ static bool alloc_mem_cgroup_per_node_in {struct mem_cgroup_per_node *pn; - pn =kzalloc_node (sizeof (*pn),GFP_KERNEL , node); + pn =kmem_cache_alloc_node (memcg_pn_cachep,GFP_KERNEL | __GFP_ZERO, + node);if (!pn)return false;
@@ -5075,6 +5077,9 @@ int __init mem_cgroup_init(void) memcg_cachep =kmem_cache_create ("mem_cgroup" , memcg_size,0 ,SLAB_PANIC |SLAB_HWCACHE_ALIGN ,NULL ); + memcg_pn_cachep =KMEM_CACHE (mem_cgroup_per_node, +SLAB_PANIC |SLAB_HWCACHE_ALIGN ); +return 0 ; }
_
Patches currently in -mm which might be from [email protected] are