Skip to contentSkip to conversation

Add support for Firefly Station-M3/ROC-RK3588S-PC

PATCH Superseded Hsun Lai 6 participants 9 messages May 19, 2025 – May 23, 2025

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Hsun Lai

author
#0 lore raw

v4 cover Add support for Firefly Station-M3/ROC-RK3588S-PC

This series add support for Firefly Station-M3/ROC-RK3588S-PC.

Info of device can be found at:
https://wiki.t-firefly.com/en/Station-M3/index.html

Changes in v4:
- Update the name of the regulator
- Remove the i2s5_8ch node

Changes in v3:
- Update the name of leds
- Add more cpu nodes
- Update mdio compatible
- Fix the order in the node
- Add the default serial port(uart2)

Changes in v2:
- Fix rgmii delays

Changes in v1:
- Add support for Firefly ROC-RK3588S-PC

Hsun Lai (2):
dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC
arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588s-roc-pc.dts      | 922 ++++++++++++++++++
 3 files changed, 928 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v4 1/2 dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC

This documents Firefly ROC-RK3588S-PC which is a SBC based on RK3588S SoC.

---

(no changes since v1)

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 115c3ca43..701d68aca 100644
@@ -258,6 +258,11 @@ properties:
           - const: firefly,rk3566-roc-pc
           - const: rockchip,rk3566
 
+      - description: Firefly Station M3
+        items:
+          - const: firefly,rk3588s-roc-pc
+          - const: rockchip,rk3588s
+
       - description: Firefly Station P2
         items:
           - const: firefly,rk3568-roc-pc
Signature · 1 line
2.34.1
Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC

Hi Hsun Lai,

Quoted 19 lines · Hsun Lai

[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

This documents Firefly ROC-RK3588S-PC which is a SBC based on RK3588S SoC.

---

(no changes since v1)

  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
  1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 115c3ca43..701d68aca 100644

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 263

Quoted 6 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +3 -0
@@ -258,6 +258,11 @@ properties:
            - const: firefly,rk3566-roc-pc
            - const: rockchip,rk3566
 
+      - description: Firefly Station M3
+        items:
+          - const: firefly,rk3588s-roc-pc

Interesting that the product seems to have two names :)

But considering the other Firefly RK35xx products do the same, I guess it is fine?

So:

Would you know what the actual differences are? For the Station M2 they say "Based on ROC-RK3566-PC" which may indicate there are some additional things or changes? Same for the Station P2: "Based on ROC-RK3568-PC".

Thanks!
Quentin

author
#3 lore raw

Re: [v3,1/3] dt-bindings: vendor-prefixes: Add SakuraPi prefix

In reply to Hsun Lai
Quoted 4 lines · Quentin Schulz

Would you know what the actual differences are? For the Station M2 they say "Based on ROC-RK3566-PC" which may indicate there are some additional things or changes? Same for the Station P2: "Based on ROC-RK3568-PC".

Station M3 is a product from Firefly. This product usually comes with an outer case, and the internal board used is the ROC-RK3588S-PC development board, which is why this situation occurs. The same applies to the Station M2 (ROC-RK3566-PC) and Station P2 (ROC-RK3568-PC).

Thank you for your review!
Hsun

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author
#4 lore raw

PATCH v4 2/2 arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

In reply to Hsun Lai

The Firefly ROC-RK3588S-PC is a SBC based on the Rockchip RK3588s SoC.

The device contains the following hardware that is tested/working:
- 32 or 64GB eMMC
- SDMMC card slot
- Realtek USB WiFi 5/BT
- NVME 2242 socket
- 4 or 8GB of RAM
- RTL8211 GbE
- USB 3.0 port
- USB 2.0 port
- HDMI port

---

Changes in v4:
- Update the name of the regulator
- Remove the i2s5_8ch node

Changes in v3:
- Update the name of leds
- Add more cpu nodes
- Update mdio compatible
- Fix the order in the node
- Add the default serial port(uart2)

Changes in v2:
- Fix rgmii delays

Changes in v1:
- Add support for Firefly ROC-RK3588S-PC

 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588s-roc-pc.dts      | 922 ++++++++++++++++++
 2 files changed, 923 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index e63c3f5eb..dd6ae546d 100644
@@ -182,6 +182,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-roc-pc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
 
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +922 -0

922 lines not on this page · raw message

Signature · 1 line
2.34.1
#5 lore raw

Re: [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

Hi,

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 93

Quoted 12 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +11 -0
+		led-0 {
+			default-state = "on";
+			function = LED_FUNCTION_POWER;
+			gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-1 {
+			function = LED_FUNCTION_HEARTBEAT;
+			gpios = <&gpio3 RK_PB2 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};

From PATCH v1, led-1 is a user-led, so it would be better to make it off by default.

Please also add color = xxx to these leds.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 128

Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +9 -0
+	vcc5v0_usbdcin: regulator-vcc5v0-usbdcin {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_usbdcin";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc12v_dcin>;
+	};

The DC of this board is 12V, why is there 5V?

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 147

Quoted 9 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +8 -0
+	vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_pcie20";
+		enable-active-high;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		startup-delay-us = <5000>;
+		gpio = <&gpio1 RK_PD7 GPIO_ACTIVE_HIGH>;

Please put enable/gpio before regulator.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 159

Quoted 10 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +9 -0
+	vcc5v0_host: regulator-vcc5v0-host {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vcc5v0_host_en>;
+		regulator-name = "vcc5v0_host";
+		regulator-boot-on;
+		regulator-always-on;

Why does this regulator require always-on and boot-on? It will be enabled through the corresponding phy-supply.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 162

Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +3 -0
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc5v0_sys>;

The vendor dts says it's from vcc5v0_usb?

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 171

Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +7 -0
+	vbus5v0_typec_pwr_en: vbus5v0-typec-pwr-en-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&typec5v_pwren>;
+		regulator-name = "vbus5v0_typec_pwr_en";

Please use the regulator name from schematics. xxx_pwr_en is usually the name of the pinctrl.

Review

Quoted 2 lines
(quoted diff) +2 -0
+		regulator-boot-on;
+		regulator-always-on;

Why does this regulator require always-on and boot-on? It will be enabled through the corresponding phy-supply.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 162

Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +3 -0
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc5v0_sys>;

The vendor dts says it's from vcc5v0_usb?

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 229

Quoted 6 lines

+&gmac1 {

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +5 -0
+	clock_in_out = "output";
+	phy-handle = <&rgmii_phy1>;
+	phy-mode = "rgmii-id";
+	pinctrl-0 = ...
+	pinctrl-names = "default";

pinctrl-names should be placed before pinctrl-0

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 320

Quoted 12 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +11 -0
+		usb_con: connector {
+			compatible = "usb-c-connector";
+			label = "USB-C";
+			data-role = "dual";
+			op-sink-microwatt = <1000000>;
+			power-role = "dual";
+			sink-pdos =
+				<PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
+			source-pdos =
+				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+			try-power-role = "sink";

The TYPE-C of this board does not seem to support pd power supply?

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 48

Quoted 4 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +3 -0
+	};
+};
+

Extra blank lines.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 515

Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +5 -0
+
+&i2c3 {
+	status = "okay";
 
<snip>
+		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
+				<&rk806_dvs2_null>, <&rk806_dvs3_null>;

Align Indent.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 48

Quoted 4 lines

<snip>

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +3 -0
+	};
+};
+

Extra blank lines.

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 852

Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +10 -0
+
+&tsadc {
+	status = "okay";
+};
 
<snip>
+&u2phy0_otg {
+	status = "okay";
+};
 
+&u2phy3_host {
+	status = "okay";
+};

Missing phy-supply?

--
2.25.1

#6 lore raw

Re: [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

Quoted 9 lines · Chukun Pan

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 229

Quoted 7 lines

+&gmac1 {

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +5 -0
+	clock_in_out = "output";
+	phy-handle = <&rgmii_phy1>;
+	phy-mode = "rgmii-id";
+	pinctrl-0 = ...
+	pinctrl-names = "default";

pinctrl-names should be placed before pinctrl-0

That's unusual - not inline with common coding style and with most of SoCs. Is this some kind of known rule valid in Rockchip?

Best regards,
Krzysztof

maintainer
#7 lore raw

Re: [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

Am Freitag, 23. Mai 2025, 09:12:08 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:

Quoted 11 lines · Chukun Pan
Quoted 9 lines

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts line 229

Quoted 7 lines

+&gmac1 {

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts new file +5 -0
+	clock_in_out = "output";
+	phy-handle = <&rgmii_phy1>;
+	phy-mode = "rgmii-id";
+	pinctrl-0 = ...
+	pinctrl-names = "default";

pinctrl-names should be placed before pinctrl-0

Quoted 2 lines

That's unusual - not inline with common coding style and with most of SoCs. Is this some kind of known rule valid in Rockchip?

nope it isn't any sort of rule :-) .

I _think_ in the past we generally had
pinctrl-names = "defaule", "whatever"
pinctrl-0 =
pinctrl-1 =

but that was more a "looking somewhat nice" thing from before we had the more generic dts coding style .

So if in doubt nowadays, please follow the general coding style as written down in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst

Heiko

#8 lore raw
In reply to Hsun Lai
Quoted 26 lines · Hsun Lai

This series add support for Firefly Station-M3/ROC-RK3588S-PC.

Info of device can be found at:
https://wiki.t-firefly.com/en/Station-M3/index.html

Changes in v4:
- Update the name of the regulator
- Remove the i2s5_8ch node

Changes in v3:
- Update the name of leds
- Add more cpu nodes
- Update mdio compatible
- Fix the order in the node
- Add the default serial port(uart2)

Changes in v2:
- Fix rgmii delays

Changes in v1:
- Add support for Firefly ROC-RK3588S-PC

Hsun Lai (2):
dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC
arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

Quoted 11 lines
 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588s-roc-pc.dts      | 922 ++++++++++++++++++
 3 files changed, 928 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts

--
2.34.1

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: remotes/arm-soc/rockchip/dt64-31-ge463625af7f9 (exact match)

If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dtb: /edp@fdec0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']