Skip to contentSkip to conversation

arm64: dts: amlogic: Update USB hub power and reset properties

PATCH Superseded Anand Moon 2 participants 3 messages May 20, 2025

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 arm64: dts: amlogic: Update USB hub power and reset properties

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +3 -2
index 3bca8023638d..ad959f8bc1ac 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
 			compatible = "usb5e3,610";
 			reg = <1>;
 			peer-hub = <&hub_3_0>;
-			vdd-supply = <&usb_pwr_en>;
+			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+			vdd-supply = <&hub_5v>;
 		};
 
 		/* 3.0 hub on port 4 */

@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
 			reg = <2>;
 			peer-hub = <&hub_2_0>;
 			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-			vdd-supply = <&vcc_5v>;
+			vdd-supply = <&hub_5v>;
 		};
 	};

base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21

Signature · 1 line
2.49.0
maintainer
#1 lore raw
Quoted 26 lines · Anand Moon

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by Anand Moon <[email protected]>
---
  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +2 -1
index 3bca8023638d..ad959f8bc1ac 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
  			compatible = "usb5e3,610";
  			reg = <1>;
  			peer-hub = <&hub_3_0>;
-			vdd-supply = <&usb_pwr_en>;
+			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+			vdd-supply = <&hub_5v>;
  		};
 
  		/* 3.0 hub on port 4 */

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi hub_3_0: hub@2 { · line 55

Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +1 -1
@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
  			reg = <2>;
  			peer-hub = <&hub_2_0>;
  			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-			vdd-supply = <&vcc_5v>;
+			vdd-supply = <&hub_5v>;

In this case, also remove the &usb2_phy1 phy-supply since now it's managed by the hub reset control.

Neil

Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +0 -0
  		};
  	};

base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21

author
#2 lore raw

Hi Neil,

Quoted 26 lines · Neil Armstrong
Quoted 24 lines · Anand Moon

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by Anand Moon <[email protected]>
---
  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +2 -1
index 3bca8023638d..ad959f8bc1ac 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
                      compatible = "usb5e3,610";
                      reg = <1>;
                      peer-hub = <&hub_3_0>;
-                     vdd-supply = <&usb_pwr_en>;
+                     reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+                     vdd-supply = <&hub_5v>;
              };
Quoted 10 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi hub_3_0: hub@2 { · line 55

Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +1 -1
              /* 3.0 hub on port 4 */

@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
                      reg = <2>;
                      peer-hub = <&hub_2_0>;
                      reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-                     vdd-supply = <&vcc_5v>;
+                     vdd-supply = <&hub_5v>;

In this case, also remove the &usb2_phy1 phy-supply since now it's managed by the hub reset control.

Ok I will update in the next version.

Quoted 2 lines

Neil

Thank
-Anand