Skip to contentSkip to conversation

arm64: dts: amlogic: Update USB hub power and reset properties

PATCH In review Anand Moon 2 participants 4 messages May 22, 2025 – May 28, 2025

Subsystems (2)
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v3 1/2 arm64: dts: amlogic: Update USB hub power and reset properties

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")

---
v3: dropped remove of usb2_phy1.
v2: remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +3 -2
index 3bca8023638d4..ad959f8bc1acd 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
 			compatible = "usb5e3,610";
 			reg = <1>;
 			peer-hub = <&hub_3_0>;
-			vdd-supply = <&usb_pwr_en>;
+			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+			vdd-supply = <&hub_5v>;
 		};
 
 		/* 3.0 hub on port 4 */
@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
 			reg = <2>;
 			peer-hub = <&hub_2_0>;
 			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-			vdd-supply = <&vcc_5v>;
+			vdd-supply = <&hub_5v>;
 		};
 	};
 

base-commit: 5cdb2c77c4c3d36bdee83d9231649941157f8204

Signature · 1 line
2.49.0
author
#1 lore raw

PATCH v3 2/2 arm64: dts: amlogic: Adjust USB PHY power supply references

According to the Odroid-N2 schematics, the micro-USB phy is powered via a gpio-controlled regulator PWREN, updates the phy-supply to correctly assign the power supply for usb2_phy.

Additionally, the USB3 combo port, which connects to the onboard 4-port USB hub, is powered by the main VCC_5V rail. Updated the phy-supply to correctly assign vcc_5v for the USB controller node.

These changes ensure accurate power supply configuration for USB components, improving hardware compatibility and power management.

---
new patch

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +1 -1
index ad959f8bc1acd..9d63ab82302eb 100644
@@ -310,7 +310,7 @@ &toacodec {
 };
 
 &usb {
-	vbus-supply = <&usb_pwr_en>;
+	phy-supply = <&vcc_5v>;
 };
 
 &usb2_phy1 {
arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi +1 -1
index 7e8964bacfce7..b105a8ae2fec6 100644
@@ -437,5 +437,5 @@ &usb {
 };
 
 &usb2_phy0 {
-	phy-supply = <&vcc_5v>;
+	phy-supply = <&usb_pwr_en>;
 };
Signature · 1 line
2.49.0
#2 lore raw
In reply to Anand Moon
Quoted 7 lines · Anand Moon

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Quoted 8 lines

---
v3: dropped remove of usb2_phy1.
v2: remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204

If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for [email protected]:

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#

author
#3 lore raw

Hi Rob,

Quoted 40 lines · Rob Herring (Arm)
Quoted 7 lines · Anand Moon

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Quoted 8 lines

---
v3: dropped remove of usb2_phy1.
v2: remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204

If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)

Quoted 7 lines

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for [email protected]:

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#

Ok I am able to reproduce this, it seem the issue is with second patch

Currently, I am in the process of debugging the onboard_usb_dev.c driver. It appears that the driver is not correctly parsing the perr-hub node and is exiting prematurely. I’ve been able to partially identify the root cause, but I haven’t yet found a proper solution.

alarm@odroid-n2plus:~$ lsmod | grep onboard
onboard_usb_dev        20480  0
alarm@odroid-n2plus:~$

Thanks
-Anand