Skip to contentSkip to conversation

Enable/Disable DC balance along with VRR DSB

PATCH Superseded Mitul Golani 3 participants 26 messages Jun 3, 2025 – Jun 4, 2025

Subsystems (3)

v6 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v6 cover Enable/Disable DC balance along with VRR DSB

Control DC Balance Adjustment bit to accomodate changes along with VRR DSB implementation.

Mitul Golani (9):
drm/i915/display: Add source param for dc balance drm/i915/display: Add VRR DC balance registers drm/i915/vrr: Add DC Balance params to crtc_state drm/i915/vrr: Add state dump for DC Balance params drm/i915/vrr: Add compute config for DC Balance params drm/i915/vrr: Write DC balance params to hw registers drm/i915/vrr: Add function to check if DC Balance Possible drm/i915/display: Add function to configure PIPEDMC_EVT_CTL drm/i915/vrr: Enable DC Balance bit

Ville Syrjälä (8):
drm/i915/vrr: Refactor vmin/vmax stuff drm/i915/display: Add pipe dmc registers and bits for DC Balance drm/i915/vrr: Add functions to read out vmin/vmax stuff drm/i915: Extract vrr_vblank_start()
drm/i915/vrr: Implement vblank evasion with DC balancing drm/i915/dsb: Add pipedmc dc balance enable/disable drm/i915/vrr: Restructure VRR enablement bit drm/i915/vrr: Pause DC Balancing for DSB commits

 .../drm/i915/display/intel_crtc_state_dump.c  |   8 +
 drivers/gpu/drm/i915/display/intel_display.c  |  24 ++
 .../drm/i915/display/intel_display_device.h   |   1 +
 .../drm/i915/display/intel_display_types.h    |   7 +
 drivers/gpu/drm/i915/display/intel_dmc.c      |  37 +++
 drivers/gpu/drm/i915/display/intel_dmc.h      |   6 +
 drivers/gpu/drm/i915/display/intel_dmc_regs.h |  51 ++++
 drivers/gpu/drm/i915/display/intel_dsb.c      |  31 ++-
 drivers/gpu/drm/i915/display/intel_vblank.c   |  33 ++-
 drivers/gpu/drm/i915/display/intel_vrr.c      | 239 +++++++++++++++---
 drivers/gpu/drm/i915/display/intel_vrr.h      |   5 +
 drivers/gpu/drm/i915/display/intel_vrr_regs.h |  44 ++++
 12 files changed, 446 insertions(+), 40 deletions(-)
Signature · 1 line
2.48.1
#1 lore raw

PATCH v6 1/17 drm/i915/vrr: Refactor vmin/vmax stuff

From: Ville Syrjälä <[email protected]>

Refactor vmin/vmax functions for better computation.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 41 +++++++++++-------------
 1 file changed, 19 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/display/intel_vrr.c +19 -22
index c55b8144e234..6e7ec9931188 100644
@@ -146,37 +146,41 @@ static int intel_vrr_vblank_exit_length(const struct intel_crtc_state *crtc_stat
 		return crtc_state->vrr.pipeline_full + crtc_state->framestart_delay + 1;
 }
 
-int intel_vrr_vmin_vtotal(const struct intel_crtc_state *crtc_state)
+static int intel_vrr_vtotal(const struct intel_crtc_state *crtc_state, int vmin_vmax)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 
-	/* Min vblank actually determined by flipline */
 	if (DISPLAY_VER(display) >= 13)
-		return intel_vrr_vmin_flipline(crtc_state);
+		return vmin_vmax;
 	else
-		return intel_vrr_vmin_flipline(crtc_state) +
-			intel_vrr_real_vblank_delay(crtc_state);
+		return vmin_vmax + intel_vrr_real_vblank_delay(crtc_state);
 }
 
-int intel_vrr_vmax_vtotal(const struct intel_crtc_state *crtc_state)
+static int intel_vrr_vblank_start(const struct intel_crtc_state *crtc_state,
+				  int vmin_vmax)
 {
-	struct intel_display *display = to_intel_display(crtc_state);
+	return intel_vrr_vtotal(crtc_state, vmin_vmax) -
+			intel_vrr_vblank_exit_length(crtc_state);
+}
 
-	if (DISPLAY_VER(display) >= 13)
-		return crtc_state->vrr.vmax;
-	else
-		return crtc_state->vrr.vmax +
-			intel_vrr_real_vblank_delay(crtc_state);
+int intel_vrr_vmin_vtotal(const struct intel_crtc_state *crtc_state)
+{
+	return intel_vrr_vtotal(crtc_state, intel_vrr_vmin_flipline(crtc_state));
+}
+
+int intel_vrr_vmax_vtotal(const struct intel_crtc_state *crtc_state)
+{
+	return intel_vrr_vtotal(crtc_state, crtc_state->vrr.vmax);
 }
 
 int intel_vrr_vmin_vblank_start(const struct intel_crtc_state *crtc_state)
 {
-	return intel_vrr_vmin_vtotal(crtc_state) - intel_vrr_vblank_exit_length(crtc_state);
+	return intel_vrr_vblank_start(crtc_state, intel_vrr_vmin_flipline(crtc_state));
 }
 
 int intel_vrr_vmax_vblank_start(const struct intel_crtc_state *crtc_state)
 {
-	return intel_vrr_vmax_vtotal(crtc_state) - intel_vrr_vblank_exit_length(crtc_state);
+	return intel_vrr_vblank_start(crtc_state, crtc_state->vrr.vmax);
 }
 
 static bool
@@ -257,14 +261,7 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state)
 static
 int intel_vrr_fixed_rr_vtotal(const struct intel_crtc_state *crtc_state)
 {
-	struct intel_display *display = to_intel_display(crtc_state);
-	int crtc_vtotal = crtc_state->hw.adjusted_mode.crtc_vtotal;
-
-	if (DISPLAY_VER(display) >= 13)
-		return crtc_vtotal;
-	else
-		return crtc_vtotal -
-			intel_vrr_real_vblank_delay(crtc_state);
+	return intel_vrr_vtotal(crtc_state, crtc_state->hw.adjusted_mode.crtc_vtotal);
 }
 
 static
Signature · 1 line
2.48.1
#2 lore raw

PATCH v6 2/17 drm/i915/display: Add source param for dc balance

In reply to Mitul Golani

Add source param for dc balance enablement further.

--v2:
- Arrange in alphabetic order. (Ankit)
- Update name. (Ankit)

---
 drivers/gpu/drm/i915/display/intel_display_device.h | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/display/intel_display_device.h +1 -0
index 0ac5484c0043..201a22d71bf0 100644
@@ -196,6 +196,7 @@ struct intel_display_platforms {
 					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
 					 HAS_DSC(__display))
 #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
+#define HAS_VRR_DC_BALANCE(__display)	(DISPLAY_VER(__display) >= 30)
 #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
 #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)
 #define SUPPORTS_TV(__display)		(DISPLAY_INFO(__display)->supports_tv)
Signature · 1 line
2.48.1
#3 lore raw

PATCH v6 3/17 drm/i915/display: Add pipe dmc registers and bits for DC Balance

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Add pipe dmc registers and access bits for DC Balance params configuration and enablement.

--v2:
- Separate register definitions for transcoder and pipe dmc. (Ankit)
- Use MMIO pipe macros instead of transcoder ones. (Ankit)
- Remove dev_priv use. (Jani, Nikula)

--v3:
- Add all register address, from capital alphabet to small. (Ankit)
- Add EVT CTL registers.
- Add co-author tag.
- Add event flag for Triggering DC Balance.

---
 drivers/gpu/drm/i915/display/intel_dmc_regs.h | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
drivers/gpu/drm/i915/display/intel_dmc_regs.h +51 -0
index d8e715677454..1d4973bd7089 100644
@@ -394,4 +394,55 @@ enum pipedmc_event_id {
 #define  DMC_WAKELOCK_CTL_REQ	 REG_BIT(31)
 #define  DMC_WAKELOCK_CTL_ACK	 REG_BIT(15)
 
+#define _PIPEDMC_DCB_CTL_A			0x5f1a0
+#define _PIPEDMC_DCB_CTL_B			0x5f5a0
+#define PIPEDMC_DCB_CTL(pipe)			_MMIO_PIPE((pipe), _PIPEDMC_DCB_CTL_A,\
+							   _PIPEDMC_DCB_CTL_B)
+#define PIPEDMC_ADAPTIVE_DCB_ENABLE		REG_BIT(31)
+
+#define _PIPEDMC_DCB_VBLANK_A			0x5f1bc
+#define _PIPEDMC_DCB_VBLANK_B			0x5f5bc
+#define PIPEDMC_DCB_VBLANK(pipe)		_MMIO_PIPE((pipe), _PIPEDMC_DCB_VBLANK_A,\
+							   _PIPEDMC_DCB_VBLANK_B)
+
+#define _PIPEDMC_DCB_SLOPE_A			0x5f1b8
+#define _PIPEDMC_DCB_SLOPE_B			0x5f5b8
+#define PIPEDMC_DCB_SLOPE(pipe)			_MMIO_PIPE((pipe), _PIPEDMC_DCB_SLOPE_A,\
+							   _PIPEDMC_DCB_SLOPE_B)
+
+#define _PIPEDMC_DCB_GUARDBAND_A		0x5f1b4
+#define _PIPEDMC_DCB_GUARDBAND_B		0x5f5b4
+#define PIPEDMC_DCB_GUARDBAND(pipe)		_MMIO_PIPE((pipe), _PIPEDMC_DCB_GUARDBAND_A,\
+							   _PIPEDMC_DCB_GUARDBAND_B)
+
+#define _PIPEDMC_DCB_MAX_INCREASE_A		0x5f1ac
+#define _PIPEDMC_DCB_MAX_INCREASE_B		0x5f5ac
+#define PIPEDMC_DCB_MAX_INCREASE(pipe)		_MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_INCREASE_A,\
+							   _PIPEDMC_DCB_MAX_INCREASE_B)
+
+#define _PIPEDMC_DCB_MAX_DECREASE_A		0x5f1b0
+#define _PIPEDMC_DCB_MAX_DECREASE_B		0x5f5b0
+#define PIPEDMC_DCB_MAX_DECREASE(pipe)		_MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_DECREASE_A,\
+							   _PIPEDMC_DCB_MAX_DECREASE_B)
+
+#define _PIPEDMC_DCB_VMIN_A			0x5f1a4
+#define _PIPEDMC_DCB_VMIN_B			0x5f5a4
+#define PIPEDMC_DCB_VMIN(pipe)			_MMIO_PIPE((pipe), _PIPEDMC_DCB_VMIN_A,\
+							   _PIPEDMC_DCB_VMIN_B)
+
+#define _PIPEDMC_DCB_VMAX_A			0x5f1a8
+#define _PIPEDMC_DCB_VMAX_B			0x5f5a8
+#define PIPEDMC_DCB_VMAX(pipe)			_MMIO_PIPE((pipe), _PIPEDMC_DCB_VMAX_A,\
+							   _PIPEDMC_DCB_VMAX_B)
+
+#define _PIPEDMC_DCB_DEBUG_A			0x5f1c0
+#define _PIPEDMC_DCB_DEBUG_B			0x5f5c0
+#define PIPEDMC_DCB_DEBUG(pipe)			_MMIO_PIPE(pipe, _PIPEDMC_DCB_DEBUG_A,\
+							   _PIPEDMC_DCB_DEBUG_B)
+
+#define _PIPEDMC_EVT_CTL_3_A			0x5f040
+#define _PIPEDMC_EVT_CTL_3_B			0x5f440
+#define PIPEDMC_EVT_CTL_3(pipe)			_MMIO_PIPE(pipe, _PIPEDMC_EVT_CTL_3_A,\
+							   _PIPEDMC_EVT_CTL_3_B)
+
 #endif /* __INTEL_DMC_REGS_H__ */
Signature · 1 line
2.48.1
#4 lore raw

PATCH v6 4/17 drm/i915/display: Add VRR DC balance registers

In reply to Mitul Golani

Add VRR register offsets and bits to access DC Balance configuration.

--v2:
- Separate register definitions. (Ankit)
- Remove usage of dev_priv. (Jani, Nikula)

--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)

--v4:
- Use _MMIO_TRANS wherever possible. (Jani)

---
 drivers/gpu/drm/i915/display/intel_vrr_regs.h | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr_regs.h +44 -0
index 09cdd50d6187..b90dad473d8d 100644
@@ -9,6 +9,49 @@
 #include "intel_display_reg_defs.h"
 
 /* VRR registers */
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A	0x604d4
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B	0x614d4
+#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(trans)	_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A, \
+							    _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B)
+#define VRR_DCB_ADJ_FLIPLINE_CNT_MASK		REG_GENMASK(31, 24)
+#define VRR_DCB_ADJ_FLIPLINE_MASK		REG_GENMASK(19, 0)
+#define VRR_DCB_ADJ_FLIPLINE(flipline)		REG_FIELD_PREP(VRR_DCB_ADJ_FLIPLINE_MASK, \
+							       (flipline))
+
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A		0x604d8
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B		0x614d8
+#define TRANS_VRR_DCB_ADJ_VMAX_CFG(trans)	_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_ADJ_VMAX_CFG_A, \
+							    _TRANS_VRR_DCB_ADJ_VMAX_CFG_B)
+#define VRR_DCB_ADJ_VMAX_CNT_MASK		REG_GENMASK(31, 24)
+#define VRR_DCB_ADJ_VMAX_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_ADJ_VMAX(vmax)			REG_FIELD_PREP(VRR_DCB_ADJ_VMAX_MASK, (vmax))
+
+#define _TRANS_VRR_DCB_FLIPLINE_A		0x60418
+#define _TRANS_VRR_DCB_FLIPLINE_B		0x61418
+#define TRANS_VRR_DCB_FLIPLINE(trans)		_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_FLIPLINE_A, \
+							    _TRANS_VRR_DCB_FLIPLINE_B)
+#define VRR_DCB_FLIPLINE_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_FLIPLINE(flipline)		REG_FIELD_PREP(VRR_DCB_FLIPLINE_MASK, \
+							       (flipline))
+
+#define _TRANS_VRR_DCB_VMAX_A			0x60414
+#define _TRANS_VRR_DCB_VMAX_B			0x61414
+#define TRANS_VRR_DCB_VMAX(trans)		_MMIO_TRANS(trans, \
+							     _TRANS_VRR_DCB_VMAX_A, \
+							     _TRANS_VRR_DCB_VMAX_B)
+#define VRR_DCB_VMAX_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_VMAX(vmax)			REG_FIELD_PREP(VRR_DCB_VMAX_MASK, (vmax))
+
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A		0x604c0
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B		0x614c0
+#define TRANS_ADAPTIVE_SYNC_DCB_CTL(trans)	_MMIO_TRANS(trans, \
+							     _TRANS_ADAPTIVE_SYNC_DCB_CTL_A, \
+							     _TRANS_ADAPTIVE_SYNC_DCB_CTL_B)
+#define ADAPTIVE_SYNC_COUNTER_EN		REG_BIT(31)
+
 #define _TRANS_VRR_CTL_A			0x60420
 #define _TRANS_VRR_CTL_B			0x61420
 #define _TRANS_VRR_CTL_C			0x62420
@@ -20,6 +63,7 @@
 #define  VRR_CTL_PIPELINE_FULL_MASK		REG_GENMASK(10, 3)
 #define  VRR_CTL_PIPELINE_FULL(x)		REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x))
 #define  VRR_CTL_PIPELINE_FULL_OVERRIDE		REG_BIT(0)
+#define  VRR_CTL_DCB_ADJ_ENABLE			REG_BIT(28)
 #define  XELPD_VRR_CTL_VRR_GUARDBAND_MASK	REG_GENMASK(15, 0)
 #define  XELPD_VRR_CTL_VRR_GUARDBAND(x)		REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
 
Signature · 1 line
2.48.1
Reviewed-by on v6 4/17
#5 lore raw

Re: [PATCH v6 04/17] drm/i915/display: Add VRR DC balance registers

Quoted 6 lines · Mitul Golani

Add VRR register offsets and bits to access DC Balance configuration.

--v2:
- Separate register definitions. (Ankit)
- Remove usage of dev_priv. (Jani, Nikula)

Quoted 8 lines

--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)

--v4:
- Use _MMIO_TRANS wherever possible. (Jani)

Quoted 66 lines
---
  drivers/gpu/drm/i915/display/intel_vrr_regs.h | 44 +++++++++++++++++++
  1 file changed, 44 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr_regs.h +44 -0
index 09cdd50d6187..b90dad473d8d 100644
@@ -9,6 +9,49 @@
  #include "intel_display_reg_defs.h"
 
  /* VRR registers */
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A	0x604d4
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B	0x614d4
+#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(trans)	_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A, \
+							    _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B)
+#define VRR_DCB_ADJ_FLIPLINE_CNT_MASK		REG_GENMASK(31, 24)
+#define VRR_DCB_ADJ_FLIPLINE_MASK		REG_GENMASK(19, 0)
+#define VRR_DCB_ADJ_FLIPLINE(flipline)		REG_FIELD_PREP(VRR_DCB_ADJ_FLIPLINE_MASK, \
+							       (flipline))
+
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A		0x604d8
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B		0x614d8
+#define TRANS_VRR_DCB_ADJ_VMAX_CFG(trans)	_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_ADJ_VMAX_CFG_A, \
+							    _TRANS_VRR_DCB_ADJ_VMAX_CFG_B)
+#define VRR_DCB_ADJ_VMAX_CNT_MASK		REG_GENMASK(31, 24)
+#define VRR_DCB_ADJ_VMAX_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_ADJ_VMAX(vmax)			REG_FIELD_PREP(VRR_DCB_ADJ_VMAX_MASK, (vmax))
+
+#define _TRANS_VRR_DCB_FLIPLINE_A		0x60418
+#define _TRANS_VRR_DCB_FLIPLINE_B		0x61418
+#define TRANS_VRR_DCB_FLIPLINE(trans)		_MMIO_TRANS(trans, \
+							    _TRANS_VRR_DCB_FLIPLINE_A, \
+							    _TRANS_VRR_DCB_FLIPLINE_B)
+#define VRR_DCB_FLIPLINE_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_FLIPLINE(flipline)		REG_FIELD_PREP(VRR_DCB_FLIPLINE_MASK, \
+							       (flipline))
+
+#define _TRANS_VRR_DCB_VMAX_A			0x60414
+#define _TRANS_VRR_DCB_VMAX_B			0x61414
+#define TRANS_VRR_DCB_VMAX(trans)		_MMIO_TRANS(trans, \
+							     _TRANS_VRR_DCB_VMAX_A, \
+							     _TRANS_VRR_DCB_VMAX_B)
+#define VRR_DCB_VMAX_MASK			REG_GENMASK(19, 0)
+#define VRR_DCB_VMAX(vmax)			REG_FIELD_PREP(VRR_DCB_VMAX_MASK, (vmax))
+
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A		0x604c0
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B		0x614c0
+#define TRANS_ADAPTIVE_SYNC_DCB_CTL(trans)	_MMIO_TRANS(trans, \
+							     _TRANS_ADAPTIVE_SYNC_DCB_CTL_A, \
+							     _TRANS_ADAPTIVE_SYNC_DCB_CTL_B)
+#define ADAPTIVE_SYNC_COUNTER_EN		REG_BIT(31)
+
  #define _TRANS_VRR_CTL_A			0x60420
  #define _TRANS_VRR_CTL_B			0x61420
  #define _TRANS_VRR_CTL_C			0x62420
@@ -20,6 +63,7 @@
  #define  VRR_CTL_PIPELINE_FULL_MASK		REG_GENMASK(10, 3)
  #define  VRR_CTL_PIPELINE_FULL(x)		REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x))
  #define  VRR_CTL_PIPELINE_FULL_OVERRIDE		REG_BIT(0)
+#define  VRR_CTL_DCB_ADJ_ENABLE			REG_BIT(28)
  #define  XELPD_VRR_CTL_VRR_GUARDBAND_MASK	REG_GENMASK(15, 0)
  #define  XELPD_VRR_CTL_VRR_GUARDBAND(x)		REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
 
#6 lore raw

PATCH v6 5/17 drm/i915/vrr: Add functions to read out vmin/vmax stuff

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Calculate delayed vblank start position with the help of added vmin/vmax stuff for next frame and final computation.

--v2:
- Correct Author details.

--v3:
- Separate register details from this patch.

--v4:
- Add mask macros.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 50 ++++++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_vrr.h |  5 +++
 2 files changed, 55 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +50 -0
index 6e7ec9931188..2235b08369ad 100644
@@ -769,3 +769,53 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
 	if (crtc_state->vrr.enable)
 		crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
 }
+
+int intel_vrr_dcb_vmin_vblank_start_next(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 tmp = 0;
+
+	tmp = intel_de_read(display, TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(cpu_transcoder));
+
+	if (REG_FIELD_GET(VRR_DCB_ADJ_FLIPLINE_CNT_MASK, tmp) == 0)
+		return -1;
+
+	return intel_vrr_vblank_start(crtc_state, VRR_DCB_ADJ_FLIPLINE(tmp) + 1);
+}
+
+int intel_vrr_dcb_vmax_vblank_start_next(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 tmp = 0;
+
+	tmp = intel_de_read(display, TRANS_VRR_DCB_ADJ_VMAX_CFG(cpu_transcoder));
+
+	if (REG_FIELD_GET(VRR_DCB_ADJ_VMAX_CNT_MASK, tmp) == 0)
+		return -1;
+
+	return intel_vrr_vblank_start(crtc_state, VRR_DCB_ADJ_VMAX(tmp) + 1);
+}
+
+int intel_vrr_dcb_vmin_vblank_start_final(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 tmp = 0;
+
+	tmp = intel_de_read(display, TRANS_VRR_DCB_FLIPLINE(cpu_transcoder));
+
+	return intel_vrr_vblank_start(crtc_state, VRR_DCB_FLIPLINE(tmp) + 1);
+}
+
+int intel_vrr_dcb_vmax_vblank_start_final(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 tmp = 0;
+
+	tmp = intel_de_read(display, TRANS_VRR_DCB_VMAX(cpu_transcoder));
+
+	return intel_vrr_vblank_start(crtc_state, VRR_DCB_VMAX(tmp) + 1);
+}
drivers/gpu/drm/i915/display/intel_vrr.h +5 -0
index 38bf9996b883..e62b8b50aec6 100644
@@ -42,4 +42,9 @@ void intel_vrr_transcoder_disable(const struct intel_crtc_state *crtc_state);
 void intel_vrr_set_fixed_rr_timings(const struct intel_crtc_state *crtc_state);
 bool intel_vrr_always_use_vrr_tg(struct intel_display *display);
 
+int intel_vrr_dcb_vmin_vblank_start_next(const struct intel_crtc_state *crtc_state);
+int intel_vrr_dcb_vmax_vblank_start_next(const struct intel_crtc_state *crtc_state);
+int intel_vrr_dcb_vmin_vblank_start_final(const struct intel_crtc_state *crtc_state);
+int intel_vrr_dcb_vmax_vblank_start_final(const struct intel_crtc_state *crtc_state);
+
 #endif /* __INTEL_VRR_H__ */
Signature · 1 line
2.48.1
#7 lore raw

PATCH v6 6/17 drm/i915/vrr: Add DC Balance params to crtc_state

In reply to Mitul Golani

Add DC Balance params to crtc_state, also add state checker params for related properties.

--v3:
- Seggregate crtc_state params with this patch. (Ankit)

--v4:
- Update commit message and header. (Ankit)
- Add +1 to VMIN and VMAX only when it is non-zero. (Ankit)

---
 drivers/gpu/drm/i915/display/intel_display.c  |  7 ++++++
 .../drm/i915/display/intel_display_types.h    |  7 ++++++
 drivers/gpu/drm/i915/display/intel_vrr.c      | 22 +++++++++++++++++++
 3 files changed, 36 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +7 -0
index 06f58c062b29..fd869b425f3a 100644
@@ -5420,6 +5420,13 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 		PIPE_CONF_CHECK_LLI(cmrr.cmrr_m);
 		PIPE_CONF_CHECK_LLI(cmrr.cmrr_n);
 		PIPE_CONF_CHECK_BOOL(cmrr.enable);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.vmin);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.vmax);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.guardband);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.slope);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.max_increase);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.max_decrease);
+		PIPE_CONF_CHECK_I(vrr.dc_balance.vblank_target);
 	}
 
 	if (!fastset || intel_vrr_always_use_vrr_tg(display)) {
drivers/gpu/drm/i915/display/intel_display_types.h +7 -0
index ed4d743fc7c5..d8bc5c412c83 100644
@@ -1312,6 +1312,13 @@ struct intel_crtc_state {
 		u8 pipeline_full;
 		u16 flipline, vmin, vmax, guardband;
 		u32 vsync_end, vsync_start;
+		struct {
+			bool enable;
+			u16 vmin, vmax;
+			u16 guardband, slope;
+			u16 max_increase, max_decrease;
+			u16 vblank_target;
+		} dc_balance;
 	} vrr;
 
 	/* Content Match Refresh Rate state */
drivers/gpu/drm/i915/display/intel_vrr.c +22 -0
index 2235b08369ad..84f1b358946c 100644
@@ -10,6 +10,7 @@
 #include "intel_de.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
+#include "intel_dmc_regs.h"
 #include "intel_vrr.h"
 #include "intel_vrr_regs.h"
 
@@ -699,6 +700,8 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
 	u32 trans_vrr_ctl, trans_vrr_vsync;
 	bool vrr_enable;
 
@@ -761,6 +764,25 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
 	else
 		crtc_state->vrr.enable = vrr_enable;
 
+	if (HAS_VRR_DC_BALANCE(display)) {
+		crtc_state->vrr.dc_balance.vmin =
+			intel_de_read(display, PIPEDMC_DCB_VMIN(pipe)) ?
+			intel_de_read(display, PIPEDMC_DCB_VMIN(pipe)) + 1 : 0;
+		crtc_state->vrr.dc_balance.vmax =
+			intel_de_read(display, PIPEDMC_DCB_VMAX(pipe)) ?
+			intel_de_read(display, PIPEDMC_DCB_VMAX(pipe)) + 1 : 0;
+		crtc_state->vrr.dc_balance.guardband =
+			intel_de_read(display, PIPEDMC_DCB_GUARDBAND(pipe));
+		crtc_state->vrr.dc_balance.max_increase =
+			intel_de_read(display, PIPEDMC_DCB_MAX_INCREASE(pipe));
+		crtc_state->vrr.dc_balance.max_decrease =
+			intel_de_read(display, PIPEDMC_DCB_MAX_DECREASE(pipe));
+		crtc_state->vrr.dc_balance.slope =
+			intel_de_read(display, PIPEDMC_DCB_SLOPE(pipe));
+		crtc_state->vrr.dc_balance.vblank_target =
+			intel_de_read(display, PIPEDMC_DCB_VBLANK(pipe));
+	}
+
 	/*
 	 * #TODO: For Both VRR and CMRR the flag I915_MODE_FLAG_VRR is set for mode_flags.
 	 * Since CMRR is currently disabled, set this flag for VRR for now.
Signature · 1 line
2.48.1
#8 lore raw

PATCH v6 7/17 drm/i915/vrr: Add state dump for DC Balance params

In reply to Mitul Golani

Add state dump for dc balance params to track DC Balance crtc state config.

---
 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +8 -0
index 0c7f91046996..7a3d97df24c0 100644
@@ -304,6 +304,14 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
 	drm_printf(&p, "vrr: vmin vblank: %d, vmax vblank: %d, vmin vtotal: %d, vmax vtotal: %d\n",
 		   intel_vrr_vmin_vblank_start(pipe_config), intel_vrr_vmax_vblank_start(pipe_config),
 		   intel_vrr_vmin_vtotal(pipe_config), intel_vrr_vmax_vtotal(pipe_config));
+	drm_printf(&p, "vrr: dc balance: %s, vmin: %d vmax: %d guardband: %d, slope: %d max increase: %d max decrease: %d Vblank target: %d\n",
+		   str_yes_no(pipe_config->vrr.dc_balance.enable),
+		   pipe_config->vrr.dc_balance.vmin, pipe_config->vrr.dc_balance.vmax,
+		   pipe_config->vrr.dc_balance.guardband,
+		   pipe_config->vrr.dc_balance.slope,
+		   pipe_config->vrr.dc_balance.max_increase,
+		   pipe_config->vrr.dc_balance.max_decrease,
+		   pipe_config->vrr.dc_balance.vblank_target);
 
 	drm_printf(&p, "requested mode: " DRM_MODE_FMT "\n",
 		   DRM_MODE_ARG(&pipe_config->hw.mode));
Signature · 1 line
2.48.1
#9 lore raw

PATCH v6 8/17 drm/i915/vrr: Add compute config for DC Balance params

In reply to Mitul Golani

Compute DC Balance parameters and tunable params based on experiments.

--v2:
- Document tunable params. (Ankit)

--v3:
- Add line spaces to compute config. (Ankit)
- Remove redundancy checks.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 25 ++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +25 -0
index 84f1b358946c..eabfb169cb61 100644
@@ -16,6 +16,13 @@
 
 #define FIXED_POINT_PRECISION		100
 #define CMRR_PRECISION_TOLERANCE	10
+/*
+ * Tunable parameters for DC Balance correction.
+ * These are captured based on experimentations.
+ */
+#define DCB_CORRECTION_SENSITIVITY	30
+#define DCB_CORRECTION_AGGRESSIVENESS	1000
+#define DCB_BLANK_TARGET		50
 
 bool intel_vrr_is_capable(struct intel_connector *connector)
 {
@@ -409,6 +416,24 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
 			(crtc_state->hw.adjusted_mode.crtc_vtotal -
 			 crtc_state->hw.adjusted_mode.vsync_end);
 	}
+
+	if (crtc_state->vrr.dc_balance.enable) {
+		crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax;
+		crtc_state->vrr.dc_balance.vmin = crtc_state->vrr.vmin;
+		crtc_state->vrr.dc_balance.max_increase =
+			crtc_state->vrr.vmax - crtc_state->vrr.vmin;
+		crtc_state->vrr.dc_balance.max_decrease =
+			crtc_state->vrr.vmax - crtc_state->vrr.vmin;
+		crtc_state->vrr.dc_balance.guardband =
+			DIV_ROUND_UP(crtc_state->vrr.dc_balance.vmax *
+				     DCB_CORRECTION_SENSITIVITY, 100);
+		crtc_state->vrr.dc_balance.slope =
+			DIV_ROUND_UP(DCB_CORRECTION_AGGRESSIVENESS * 10,
+				     crtc_state->vrr.dc_balance.guardband);
+		crtc_state->vrr.dc_balance.vblank_target =
+			DIV_ROUND_UP((crtc_state->vrr.vmax - crtc_state->vrr.vmin) *
+				     DCB_BLANK_TARGET, 100);
+	}
 }
 
 void intel_vrr_compute_config_late(struct intel_crtc_state *crtc_state)
Signature · 1 line
2.48.1
#10 lore raw

PATCH v6 9/17 drm/i915/vrr: Write DC balance params to hw registers

In reply to Mitul Golani

Write DC Balance parameters to hw registers.

--v2:
- Update commit header.
- Separate crtc_state params from this patch. (Ankit)

--v3:
- Write registers at compute config.
- Update condition for write.

--v4:
- Address issue with state checker.

--v5:
- Initialise some more dc balance register while enabling VRR.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 43 ++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +43 -0
index eabfb169cb61..56892cd5401e 100644
@@ -622,6 +622,8 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
 
 	if (!crtc_state->vrr.enable)
 		return;
@@ -648,16 +650,57 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 				       VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state));
 		}
 	}
+
+	if (crtc_state->vrr.dc_balance.enable) {
+		intel_de_write(display, TRANS_VRR_DCB_ADJ_VMAX_CFG(cpu_transcoder),
+			       VRR_DCB_ADJ_VMAX(crtc_state->vrr.vmax - 1));
+		intel_de_write(display, TRANS_VRR_DCB_VMAX(cpu_transcoder),
+			       VRR_DCB_VMAX(crtc_state->vrr.vmax - 1));
+		intel_de_write(display, TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(cpu_transcoder),
+			       VRR_DCB_ADJ_FLIPLINE(crtc_state->vrr.flipline - 1));
+		intel_de_write(display, TRANS_VRR_DCB_FLIPLINE(cpu_transcoder),
+			       VRR_DCB_FLIPLINE(crtc_state->vrr.flipline - 1));
+		intel_de_write(display, PIPEDMC_DCB_VMIN(pipe),
+			       crtc_state->vrr.dc_balance.vmin - 1);
+		intel_de_write(display, PIPEDMC_DCB_VMAX(pipe),
+			       crtc_state->vrr.dc_balance.vmax - 1);
+		intel_de_write(display, PIPEDMC_DCB_MAX_INCREASE(pipe),
+			       crtc_state->vrr.dc_balance.max_increase);
+		intel_de_write(display, PIPEDMC_DCB_MAX_DECREASE(pipe),
+			       crtc_state->vrr.dc_balance.max_decrease);
+		intel_de_write(display, PIPEDMC_DCB_GUARDBAND(pipe),
+			       crtc_state->vrr.dc_balance.guardband);
+		intel_de_write(display, PIPEDMC_DCB_SLOPE(pipe),
+			       crtc_state->vrr.dc_balance.slope);
+		intel_de_write(display, PIPEDMC_DCB_VBLANK(pipe),
+			       crtc_state->vrr.dc_balance.vblank_target);
+	}
 }
 
 void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 {
 	struct intel_display *display = to_intel_display(old_crtc_state);
 	enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
+	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
 
 	if (!old_crtc_state->vrr.enable)
 		return;
 
+	if (old_crtc_state->vrr.dc_balance.enable) {
+		intel_de_write(display, PIPEDMC_DCB_VMIN(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_VMAX(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_MAX_INCREASE(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_MAX_DECREASE(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_GUARDBAND(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_SLOPE(pipe), 0);
+		intel_de_write(display, PIPEDMC_DCB_VBLANK(pipe), 0);
+		intel_de_write(display, TRANS_VRR_DCB_ADJ_VMAX_CFG(cpu_transcoder), 0);
+		intel_de_write(display, TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(cpu_transcoder), 0);
+		intel_de_write(display, TRANS_VRR_DCB_VMAX(cpu_transcoder), 0);
+		intel_de_write(display, TRANS_VRR_DCB_FLIPLINE(cpu_transcoder), 0);
+	}
+
 	if (!intel_vrr_always_use_vrr_tg(display)) {
 		intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
 			       trans_vrr_ctl(old_crtc_state));
Signature · 1 line
2.48.1
#11 lore raw

PATCH v6 10/17 drm/i915: Extract vrr_vblank_start()

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Initialise delayed vblank position for evasion logic.

---
 drivers/gpu/drm/i915/display/intel_vblank.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_vblank.c +9 -4
index 139fa5deba80..680013f00fc0 100644
@@ -642,6 +642,14 @@ intel_pre_commit_crtc_state(struct intel_atomic_state *state,
 	return pre_commit_crtc_state(old_crtc_state, new_crtc_state);
 }
 
+static int vrr_vblank_start(const struct intel_crtc_state *crtc_state)
+{
+	if (intel_vrr_is_push_sent(crtc_state))
+		return intel_vrr_vmin_vblank_start(crtc_state);
+	else
+		return intel_vrr_vmax_vblank_start(crtc_state);
+}
+
 void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
 			     const struct intel_crtc_state *new_crtc_state,
 			     struct intel_vblank_evade_ctx *evade)
@@ -668,10 +676,7 @@ void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
 		drm_WARN_ON(crtc->base.dev, intel_crtc_needs_modeset(new_crtc_state) ||
 			    new_crtc_state->update_m_n || new_crtc_state->update_lrr);
 
-		if (intel_vrr_is_push_sent(crtc_state))
-			evade->vblank_start = intel_vrr_vmin_vblank_start(crtc_state);
-		else
-			evade->vblank_start = intel_vrr_vmax_vblank_start(crtc_state);
+		evade->vblank_start = vrr_vblank_start(crtc_state);
 
 		vblank_delay = intel_vrr_vblank_delay(crtc_state);
 	} else {
Signature · 1 line
2.48.1
#12 lore raw

PATCH v6 11/17 drm/i915/vrr: Implement vblank evasion with DC balancing

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Add vblank evasion logic when vrr is already enabled along with dc balance is computed.

---
 drivers/gpu/drm/i915/display/intel_dsb.c    | 31 ++++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_vblank.c | 26 +++++++++++++++--
 2 files changed, 53 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dsb.c +30 -1
index a4a996018a82..2f971a5f4dc5 100644
@@ -700,7 +700,36 @@ void intel_dsb_vblank_evade(struct intel_atomic_state *state,
 	if (crtc_state->has_psr)
 		intel_dsb_emit_wait_dsl(dsb, DSB_OPCODE_WAIT_DSL_OUT, 0, 0);
 
-	if (pre_commit_is_vrr_active(state, crtc)) {
+	if (pre_commit_is_vrr_active(state, crtc) && crtc_state->vrr.dc_balance.enable) {
+		int vblank_delay = intel_vrr_vblank_delay(crtc_state);
+		int vmin_vblank_start, vmax_vblank_start;
+
+		vmin_vblank_start = intel_vrr_dcb_vmin_vblank_start_next(crtc_state);
+
+		if (vmin_vblank_start >= 0) {
+			end = vmin_vblank_start;
+			start = end - vblank_delay - latency;
+			intel_dsb_wait_scanline_out(state, dsb, start, end);
+		}
+
+		vmax_vblank_start = intel_vrr_dcb_vmax_vblank_start_next(crtc_state);
+
+		if (vmax_vblank_start >= 0) {
+			end = vmax_vblank_start;
+			start = end - vblank_delay - latency;
+			intel_dsb_wait_scanline_out(state, dsb, start, end);
+		}
+
+		vmin_vblank_start = intel_vrr_dcb_vmin_vblank_start_final(crtc_state);
+		end = vmin_vblank_start;
+		start = end - vblank_delay - latency;
+		intel_dsb_wait_scanline_out(state, dsb, start, end);
+
+		vmax_vblank_start = intel_vrr_dcb_vmax_vblank_start_final(crtc_state);
+		end = vmax_vblank_start;
+		start = end - vblank_delay - latency;
+		intel_dsb_wait_scanline_out(state, dsb, start, end);
+	} else if (pre_commit_is_vrr_active(state, crtc)) {
 		int vblank_delay = intel_vrr_vblank_delay(crtc_state);
 
 		end = intel_vrr_vmin_vblank_start(crtc_state);
drivers/gpu/drm/i915/display/intel_vblank.c +23 -3
index 680013f00fc0..eb74d08d6690 100644
@@ -644,10 +644,30 @@ intel_pre_commit_crtc_state(struct intel_atomic_state *state,
 
 static int vrr_vblank_start(const struct intel_crtc_state *crtc_state)
 {
-	if (intel_vrr_is_push_sent(crtc_state))
-		return intel_vrr_vmin_vblank_start(crtc_state);
+	bool is_push_sent = intel_vrr_is_push_sent(crtc_state);
+	int vblank_start;
+
+	if (!crtc_state->vrr.dc_balance.enable) {
+		if (is_push_sent)
+			return intel_vrr_vmin_vblank_start(crtc_state);
+		else
+			return intel_vrr_vmax_vblank_start(crtc_state);
+	}
+
+	if (is_push_sent)
+		vblank_start = intel_vrr_dcb_vmin_vblank_start_next(crtc_state);
 	else
-		return intel_vrr_vmax_vblank_start(crtc_state);
+		vblank_start = intel_vrr_dcb_vmax_vblank_start_next(crtc_state);
+
+	if (vblank_start >= 0)
+		return vblank_start;
+
+	if (is_push_sent)
+		vblank_start = intel_vrr_dcb_vmin_vblank_start_final(crtc_state);
+	else
+		vblank_start = intel_vrr_dcb_vmax_vblank_start_final(crtc_state);
+
+	return vblank_start;
 }
 
 void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
Signature · 1 line
2.48.1
#13 lore raw

PATCH v6 12/17 drm/i915/dsb: Add pipedmc dc balance enable/disable

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Add function to control DC balance enable/disable bit via DSB.

---
 drivers/gpu/drm/i915/display/intel_dmc.c | 17 +++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dmc.h |  4 ++++
 2 files changed, 21 insertions(+)
drivers/gpu/drm/i915/display/intel_dmc.c +17 -0
index a7ba17361d63..13652dd1ed2a 100644
@@ -1478,3 +1478,20 @@ void intel_pipedmc_irq_handler(struct intel_display *display, enum pipe pipe)
 		drm_err(display->drm, "[CRTC:%d:%s]] PIPEDMC interrupt vector 0x%x\n",
 			crtc->base.base.id, crtc->base.name, tmp);
 }
+
+void intel_pipedmc_dcb_enable(struct intel_dsb *dsb, struct intel_crtc *crtc)
+{
+	struct intel_display *display = to_intel_display(crtc);
+	enum pipe pipe = crtc->pipe;
+
+	intel_de_write_dsb(display, dsb, PIPEDMC_DCB_CTL(pipe),
+			   PIPEDMC_ADAPTIVE_DCB_ENABLE);
+}
+
+void intel_pipedmc_dcb_disable(struct intel_dsb *dsb, struct intel_crtc *crtc)
+{
+	struct intel_display *display = to_intel_display(crtc);
+	enum pipe pipe = crtc->pipe;
+
+	intel_de_write_dsb(display, dsb, PIPEDMC_DCB_CTL(pipe), 0);
+}
drivers/gpu/drm/i915/display/intel_dmc.h +4 -0
index a98e8deff13a..12912e80bbc6 100644
@@ -9,9 +9,11 @@
 #include <linux/types.h>
 
 enum pipe;
+struct intel_crtc;
 struct drm_printer;
 struct intel_display;
 struct intel_dmc_snapshot;
+struct intel_dsb;
 
 void intel_dmc_init(struct intel_display *display);
 void intel_dmc_load_program(struct intel_display *display);
@@ -35,5 +37,7 @@ void intel_dmc_update_dc6_allowed_count(struct intel_display *display, bool star
 void assert_dmc_loaded(struct intel_display *display);
 
 void intel_pipedmc_irq_handler(struct intel_display *display, enum pipe pipe);
+void intel_pipedmc_dcb_enable(struct intel_dsb *dsb, struct intel_crtc *crtc);
+void intel_pipedmc_dcb_disable(struct intel_dsb *dsb, struct intel_crtc *crtc);
 
 #endif /* __INTEL_DMC_H__ */
Signature · 1 line
2.48.1
#14 lore raw

PATCH v6 13/17 drm/i915/vrr: Restructure VRR enablement bit

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Restructure bits for VRR enablement.

--v2:
- Separate multiple enablement from one patch.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 29 ++++++++++++------------
 1 file changed, 14 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_vrr.c +14 -15
index 56892cd5401e..4ed517839567 100644
@@ -624,6 +624,7 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
 	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
 	enum pipe pipe = crtc->pipe;
+	u32 ctl;
 
 	if (!crtc_state->vrr.enable)
 		return;
@@ -638,19 +639,6 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 	intel_de_write(display, TRANS_PUSH(display, cpu_transcoder),
 		       TRANS_PUSH_EN);
 
-	if (!intel_vrr_always_use_vrr_tg(display)) {
-		intel_vrr_set_db_point_and_transmission_line(crtc_state);
-
-		if (crtc_state->cmrr.enable) {
-			intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
-				       VRR_CTL_VRR_ENABLE | VRR_CTL_CMRR_ENABLE |
-				       trans_vrr_ctl(crtc_state));
-		} else {
-			intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
-				       VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state));
-		}
-	}
-
 	if (crtc_state->vrr.dc_balance.enable) {
 		intel_de_write(display, TRANS_VRR_DCB_ADJ_VMAX_CFG(cpu_transcoder),
 			       VRR_DCB_ADJ_VMAX(crtc_state->vrr.vmax - 1));
@@ -675,6 +663,12 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 		intel_de_write(display, PIPEDMC_DCB_VBLANK(pipe),
 			       crtc_state->vrr.dc_balance.vblank_target);
 	}
+
+	ctl = VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state);
+	if (crtc_state->cmrr.enable)
+		ctl |= VRR_CTL_CMRR_ENABLE;
+
+	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
 }
 
 void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
@@ -683,10 +677,17 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 	enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
 	enum pipe pipe = crtc->pipe;
+	u32 ctl;
 
 	if (!old_crtc_state->vrr.enable)
 		return;
 
+	ctl = trans_vrr_ctl(old_crtc_state);
+	if (intel_vrr_always_use_vrr_tg(display))
+		ctl |= VRR_CTL_VRR_ENABLE;
+
+	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
+
 	if (old_crtc_state->vrr.dc_balance.enable) {
 		intel_de_write(display, PIPEDMC_DCB_VMIN(pipe), 0);
 		intel_de_write(display, PIPEDMC_DCB_VMAX(pipe), 0);
@@ -702,8 +703,6 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 	}
 
 	if (!intel_vrr_always_use_vrr_tg(display)) {
-		intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
-			       trans_vrr_ctl(old_crtc_state));
 		intel_de_wait_for_clear(display,
 					TRANS_VRR_STATUS(display, cpu_transcoder),
 					VRR_STATUS_VRR_EN_LIVE, 1000);
Signature · 1 line
2.48.1
#15 lore raw

PATCH v6 14/17 drm/i915/vrr: Pause DC Balancing for DSB commits

In reply to Mitul Golani

From: Ville Syrjälä <[email protected]>

Pause the DMC DC Balancing for the remainder of the commit so that vmin/vmax won't change after we've baked them into the DSB vblank evasion commands.

--v2:
- Remove typo. (Ankit)
- Separate vrr enable structuring. (Ankit)

--v3:
- Add gaurd before accessing DC balance bits.
- Remove redundancy checks.

---
 drivers/gpu/drm/i915/display/intel_display.c | 17 +++++++++++++++++
 drivers/gpu/drm/i915/display/intel_vrr.c     |  7 +++++++
 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +17 -0
index fd869b425f3a..d914bb43e8b6 100644
@@ -7222,6 +7222,21 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 	}
 
 	if (new_crtc_state->use_dsb) {
+		if (new_crtc_state->vrr.dc_balance.enable) {
+			/*
+			 * Pause the DMC DC balancing for the remainder of
+			 * the commit so that vmin/vmax won't change after
+			 * we've baked them into the DSB vblank evasion
+			 * commands.
+			 *
+			 * FIXME maybe need a small delay here to make sure
+			 * DMC has finished updating the values? Or we need
+			 * a better DMC<->driver protocol that gives is real
+			 * guarantees about that...
+			 */
+			intel_pipedmc_dcb_disable(NULL, crtc);
+		}
+
 		if (intel_crtc_needs_color_update(new_crtc_state))
 			intel_color_commit_noarm(new_crtc_state->dsb_commit,
 						 new_crtc_state);
@@ -7267,6 +7282,8 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 		intel_dsb_wait_vblank_delay(state, new_crtc_state->dsb_commit);
 		intel_vrr_check_push_sent(new_crtc_state->dsb_commit,
 					  new_crtc_state);
+		if (new_crtc_state->vrr.dc_balance.enable)
+			intel_pipedmc_dcb_enable(new_crtc_state->dsb_commit, crtc);
 		intel_dsb_interrupt(new_crtc_state->dsb_commit);
 	}
 
drivers/gpu/drm/i915/display/intel_vrr.c +7 -0
index 4ed517839567..c14bf75a18af 100644
@@ -9,6 +9,7 @@
 #include "i915_reg.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_dmc.h"
 #include "intel_dp.h"
 #include "intel_dmc_regs.h"
 #include "intel_vrr.h"
@@ -669,6 +670,9 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 		ctl |= VRR_CTL_CMRR_ENABLE;
 
 	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
+
+	if (crtc_state->vrr.dc_balance.enable)
+		intel_pipedmc_dcb_enable(NULL, crtc);
 }
 
 void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
@@ -682,6 +686,9 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 	if (!old_crtc_state->vrr.enable)
 		return;
 
+	if (old_crtc_state->vrr.dc_balance.enable)
+		intel_pipedmc_dcb_disable(NULL, crtc);
+
 	ctl = trans_vrr_ctl(old_crtc_state);
 	if (intel_vrr_always_use_vrr_tg(display))
 		ctl |= VRR_CTL_VRR_ENABLE;
Signature · 1 line
2.48.1
#16 lore raw

PATCH v6 15/17 drm/i915/vrr: Add function to check if DC Balance Possible

In reply to Mitul Golani

Add function to check if DC Balance possibile on requested PIPE and also validate along with DISPLAY_VER check.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +16 -0
index c14bf75a18af..9cc6898399e4 100644
@@ -256,6 +256,22 @@ void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state)
 	crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
 }
 
+static
+int intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
+
+	/*
+	 * FIXME: Currently Firmware supports DC Balancing on PIPE A
+	 * and PIPE B. Account those limitation while computing DC
+	 * Balance parameters.
+	 */
+	return (HAS_VRR_DC_BALANCE(display) &&
+		((pipe == PIPE_A) || (pipe == PIPE_B)));
+}
+
 static
 void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state)
 {
Signature · 1 line
2.48.1
#17 lore raw

PATCH v6 16/17 drm/i915/display: Add function to configure PIPEDMC_EVT_CTL

In reply to Mitul Golani

Configure PIPEDMC_EVT_CTL_3 register with required event flags.

---
 drivers/gpu/drm/i915/display/intel_dmc.c | 20 ++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dmc.h |  2 ++
 drivers/gpu/drm/i915/display/intel_vrr.c |  8 ++++++--
 3 files changed, 28 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +20 -0
index 13652dd1ed2a..7c55334814e7 100644
@@ -618,6 +618,26 @@ void intel_dmc_block_pkgc(struct intel_display *display, enum pipe pipe,
 		     PIPEDMC_BLOCK_PKGC_SW_BLOCK_PKGC_ALWAYS : 0);
 }
 
+void intel_dmc_configure_dc_balance_ctl_regs(struct intel_display *display,
+					     enum pipe pipe, bool enable)
+{
+	u32 val;
+
+	if (enable)
+		val = DMC_EVT_CTL_ENABLE | DMC_EVT_CTL_RECURRING |
+			REG_FIELD_PREP(DMC_EVT_CTL_TYPE_MASK,
+				       DMC_EVT_CTL_TYPE_EDGE_0_1) |
+			REG_FIELD_PREP(DMC_EVT_CTL_EVENT_ID_MASK,
+				       PIPEDMC_EVENT_ADAPTIVE_DCB_TRIGGER);
+	else
+		val = REG_FIELD_PREP(DMC_EVT_CTL_EVENT_ID_MASK,
+				     DMC_EVENT_FALSE) |
+		      REG_FIELD_PREP(DMC_EVT_CTL_TYPE_MASK,
+				     DMC_EVT_CTL_TYPE_EDGE_0_1);
+
+	intel_de_write(display, PIPEDMC_EVT_CTL_3(pipe), val);
+}
+
 /**
  * intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank() - start of PKG
  * C-state exit
drivers/gpu/drm/i915/display/intel_dmc.h +2 -0
index 12912e80bbc6..e7a46e00caf1 100644
@@ -22,6 +22,8 @@ void intel_dmc_enable_pipe(struct intel_display *display, enum pipe pipe);
 void intel_dmc_disable_pipe(struct intel_display *display, enum pipe pipe);
 void intel_dmc_block_pkgc(struct intel_display *display, enum pipe pipe,
 			  bool block);
+void intel_dmc_configure_dc_balance_ctl_regs(struct intel_display *display,
+					     enum pipe pipe, bool enable);
 void intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank(struct intel_display *display,
 							    enum pipe pipe, bool enable);
 void intel_dmc_fini(struct intel_display *display);
drivers/gpu/drm/i915/display/intel_vrr.c +6 -2
index 9cc6898399e4..068fa7e792ed 100644
@@ -687,8 +687,10 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 
 	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
 
-	if (crtc_state->vrr.dc_balance.enable)
+	if (crtc_state->vrr.dc_balance.enable) {
+		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, true);
 		intel_pipedmc_dcb_enable(NULL, crtc);
+	}
 }
 
 void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
@@ -702,8 +704,10 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 	if (!old_crtc_state->vrr.enable)
 		return;
 
-	if (old_crtc_state->vrr.dc_balance.enable)
+	if (old_crtc_state->vrr.dc_balance.enable) {
 		intel_pipedmc_dcb_disable(NULL, crtc);
+		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, false);
+	}
 
 	ctl = trans_vrr_ctl(old_crtc_state);
 	if (intel_vrr_always_use_vrr_tg(display))
Signature · 1 line
2.48.1
#18 lore raw

Re: [PATCH v6 16/17] drm/i915/display: Add function to configure PIPEDMC_EVT_CTL

Quoted 23 lines · Mitul Golani

Configure PIPEDMC_EVT_CTL_3 register with required event flags.

---
  drivers/gpu/drm/i915/display/intel_dmc.c | 20 ++++++++++++++++++++
  drivers/gpu/drm/i915/display/intel_dmc.h |  2 ++
  drivers/gpu/drm/i915/display/intel_vrr.c |  8 ++++++--
  3 files changed, 28 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +6 -0
index 13652dd1ed2a..7c55334814e7 100644
@@ -618,6 +618,26 @@ void intel_dmc_block_pkgc(struct intel_display *display, enum pipe pipe,
  		     PIPEDMC_BLOCK_PKGC_SW_BLOCK_PKGC_ALWAYS : 0);
  }
 
+void intel_dmc_configure_dc_balance_ctl_regs(struct intel_display *display,
+					     enum pipe pipe, bool enable)
+{
+	u32 val;
+
+	if (enable)

drivers/gpu/drm/i915/display/intel_dmc.c void intel_dmc_block_pkgc(struct intel_display *display, enum pipe pipe, · line 636

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dmc.c +10 -0
+		val = DMC_EVT_CTL_ENABLE | DMC_EVT_CTL_RECURRING |
+			REG_FIELD_PREP(DMC_EVT_CTL_TYPE_MASK,
+				       DMC_EVT_CTL_TYPE_EDGE_0_1) |
+			REG_FIELD_PREP(DMC_EVT_CTL_EVENT_ID_MASK,
+				       PIPEDMC_EVENT_ADAPTIVE_DCB_TRIGGER);
+	else
+		val = REG_FIELD_PREP(DMC_EVT_CTL_EVENT_ID_MASK,
+				     DMC_EVENT_FALSE) |
+		      REG_FIELD_PREP(DMC_EVT_CTL_TYPE_MASK,
+				     DMC_EVT_CTL_TYPE_EDGE_0_1);

Do we need to set bit DMC_EVT_CTL_TYPE_EDGE_0_1 for both enable/disable case.

If we do then perhaps val can be initialized with this value.

Regards,

Ankit

Quoted 48 lines
drivers/gpu/drm/i915/display/intel_dmc.c +4 -0
+
+	intel_de_write(display, PIPEDMC_EVT_CTL_3(pipe), val);
+}
+
  /**
   * intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank() - start of PKG
   * C-state exit
drivers/gpu/drm/i915/display/intel_dmc.h +2 -0
index 12912e80bbc6..e7a46e00caf1 100644
@@ -22,6 +22,8 @@ void intel_dmc_enable_pipe(struct intel_display *display, enum pipe pipe);
  void intel_dmc_disable_pipe(struct intel_display *display, enum pipe pipe);
  void intel_dmc_block_pkgc(struct intel_display *display, enum pipe pipe,
  			  bool block);
+void intel_dmc_configure_dc_balance_ctl_regs(struct intel_display *display,
+					     enum pipe pipe, bool enable);
  void intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank(struct intel_display *display,
  							    enum pipe pipe, bool enable);
  void intel_dmc_fini(struct intel_display *display);
drivers/gpu/drm/i915/display/intel_vrr.c +6 -2
index 9cc6898399e4..068fa7e792ed 100644
@@ -687,8 +687,10 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 
  	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
 
-	if (crtc_state->vrr.dc_balance.enable)
+	if (crtc_state->vrr.dc_balance.enable) {
+		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, true);
  		intel_pipedmc_dcb_enable(NULL, crtc);
+	}
  }
 
  void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
@@ -702,8 +704,10 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
  	if (!old_crtc_state->vrr.enable)
  		return;
 
-	if (old_crtc_state->vrr.dc_balance.enable)
+	if (old_crtc_state->vrr.dc_balance.enable) {
  		intel_pipedmc_dcb_disable(NULL, crtc);
+		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, false);
+	}
 
  	ctl = trans_vrr_ctl(old_crtc_state);
  	if (intel_vrr_always_use_vrr_tg(display))
#19 lore raw

PATCH v6 17/17 drm/i915/vrr: Enable DC Balance bit

In reply to Mitul Golani

Enable DC Balance from vrr compute config and also add enable/disable frame counters for DC Balance odd and even frame count calculation.

--v2:
Update commit message

--v3:
- Driver should not control adjustment enable bit, as that is already being controlled by firmware. Release bit from driver computation.
- Commit message update.

--v4:
- Configure PIPEDMC_EVT_CTL enable/disable call.

---
 drivers/gpu/drm/i915/display/intel_vrr.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +6 -0
index 068fa7e792ed..4f8fac77afce 100644
@@ -277,6 +277,9 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state)
 {
 	crtc_state->vrr.enable = true;
 	crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
+
+	if (intel_vrr_dc_balance_possible(crtc_state))
+		crtc_state->vrr.dc_balance.enable = true;
 }
 
 /*
@@ -688,6 +691,8 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
 	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), ctl);
 
 	if (crtc_state->vrr.dc_balance.enable) {
+		intel_de_write(display, TRANS_ADAPTIVE_SYNC_DCB_CTL(cpu_transcoder),
+			       ADAPTIVE_SYNC_COUNTER_EN);
 		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, true);
 		intel_pipedmc_dcb_enable(NULL, crtc);
 	}
@@ -707,6 +712,7 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
 	if (old_crtc_state->vrr.dc_balance.enable) {
 		intel_pipedmc_dcb_disable(NULL, crtc);
 		intel_dmc_configure_dc_balance_ctl_regs(display, pipe, false);
+		intel_de_write(display, TRANS_ADAPTIVE_SYNC_DCB_CTL(cpu_transcoder), 0);
 	}
 
 	ctl = trans_vrr_ctl(old_crtc_state);
Signature · 1 line
2.48.1
#20 lore raw

✗ Fi.CI.CHECKPATCH: warning for Enable/Disable DC balance along with VRR DSB (rev6)

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: Enable/Disable DC balance along with VRR DSB (rev6)
URL : https://patchwork.freedesktop.org/series/147799/
State : warning

== Summary ==

Error: dim checkpatch failed
7205544f3a4d drm/i915/vrr: Refactor vmin/vmax stuff
114313681d31 drm/i915/display: Add source param for dc balance 4cd5f566e378 drm/i915/display: Add pipe dmc registers and bits for DC Balance -:25: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#25:

total: 0 errors, 1 warnings, 0 checks, 55 lines checked b6f672b87053 drm/i915/display: Add VRR DC balance registers 959b752bae29 drm/i915/vrr: Add functions to read out vmin/vmax stuff 5dfcfb74b2ac drm/i915/vrr: Add DC Balance params to crtc_state 25ce655c9295 drm/i915/vrr: Add state dump for DC Balance params 527a1f73fa04 drm/i915/vrr: Add compute config for DC Balance params 6191be2a22e3 drm/i915/vrr: Write DC balance params to hw registers ae2e280d0b64 drm/i915: Extract vrr_vblank_start() c394fb479187 drm/i915/vrr: Implement vblank evasion with DC balancing c8e476e6f358 drm/i915/dsb: Add pipedmc dc balance enable/disable f087e41d8bff drm/i915/vrr: Restructure VRR enablement bit 93ed5e5b5fcb drm/i915/vrr: Pause DC Balancing for DSB commits db5ddb9ee23d drm/i915/vrr: Add function to check if DC Balance Possible 4eac36cb73ed drm/i915/display: Add function to configure PIPEDMC_EVT_CTL 4d412c0f198b drm/i915/vrr: Enable DC Balance bit

#22 lore raw

✓ CI.Patch_applied: success for Enable/Disable DC balance along with VRR DSB (rev7)

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: Enable/Disable DC balance along with VRR DSB (rev7)
URL : https://patchwork.freedesktop.org/series/148025/
State : success

== Summary ==

=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: ba486e3b10ce drm-tip: 2025y-06m-03d-16h-48m-17s UTC integration manifest === git am output follows ===
Applying: drm/i915/vrr: Refactor vmin/vmax stuff
Applying: drm/i915/display: Add source param for dc balance
Applying: drm/i915/display: Add pipe dmc registers and bits for DC Balance
Applying: drm/i915/display: Add VRR DC balance registers
Applying: drm/i915/vrr: Add functions to read out vmin/vmax stuff
Applying: drm/i915/vrr: Add DC Balance params to crtc_state
Applying: drm/i915/vrr: Add state dump for DC Balance params
Applying: drm/i915/vrr: Add compute config for DC Balance params
Applying: drm/i915/vrr: Write DC balance params to hw registers
Applying: drm/i915: Extract vrr_vblank_start()
Applying: drm/i915/vrr: Implement vblank evasion with DC balancing
Applying: drm/i915/dsb: Add pipedmc dc balance enable/disable
Applying: drm/i915/vrr: Restructure VRR enablement bit
Applying: drm/i915/vrr: Pause DC Balancing for DSB commits
Applying: drm/i915/vrr: Add function to check if DC Balance Possible
Applying: drm/i915/display: Add function to configure PIPEDMC_EVT_CTL
Applying: drm/i915/vrr: Enable DC Balance bit

CI Reviewed-by Ankit Nautiyal on the v6 series
#23 lore raw

✗ CI.checkpatch: warning for Enable/Disable DC balance along with VRR DSB (rev7)

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: Enable/Disable DC balance along with VRR DSB (rev7)
URL : https://patchwork.freedesktop.org/series/148025/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c248f804b440b59182382ed6d82022c16f1dfeae

Author: Mitul Golani <[email protected]>
Date:   Wed Jun 4 01:05:22 2025 +0530

drm/i915/vrr: Enable DC Balance bit

Enable DC Balance from vrr compute config and also add enable/disable frame counters for DC Balance odd and even frame count calculation.

--v2:
Update commit message

--v3:
- Driver should not control adjustment enable bit, as that is already being controlled by firmware. Release bit from driver computation.
- Commit message update.

--v4:
- Configure PIPEDMC_EVT_CTL enable/disable call.

+ /mt/dim checkpatch ba486e3b10ce5b4ee4d1ffc58aa4cc3b669c02a3 drm-intel 621d3b87f86b drm/i915/vrr: Refactor vmin/vmax stuff
5ab10dfdefc9 drm/i915/display: Add source param for dc balance 2c2a6d9a50da drm/i915/display: Add pipe dmc registers and bits for DC Balance -:25: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#25:

total: 0 errors, 1 warnings, 0 checks, 55 lines checked d9746b6acd08 drm/i915/display: Add VRR DC balance registers 7b821210dde4 drm/i915/vrr: Add functions to read out vmin/vmax stuff 2711afe1dd73 drm/i915/vrr: Add DC Balance params to crtc_state bbcede0d0c1d drm/i915/vrr: Add state dump for DC Balance params a974ee45c70f drm/i915/vrr: Add compute config for DC Balance params edb37dc13ce6 drm/i915/vrr: Write DC balance params to hw registers f20482e412c2 drm/i915: Extract vrr_vblank_start() 2f904f51f13a drm/i915/vrr: Implement vblank evasion with DC balancing 7c62a84d5685 drm/i915/dsb: Add pipedmc dc balance enable/disable 1c97467166ca drm/i915/vrr: Restructure VRR enablement bit 0a47431dd407 drm/i915/vrr: Pause DC Balancing for DSB commits c737d60f425b drm/i915/vrr: Add function to check if DC Balance Possible 299c3970f19d drm/i915/display: Add function to configure PIPEDMC_EVT_CTL c248f804b440 drm/i915/vrr: Enable DC Balance bit

#24 lore raw

✗ CI.KUnit: failure for Enable/Disable DC balance along with VRR DSB (rev7)

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: Enable/Disable DC balance along with VRR DSB (rev7)
URL : https://patchwork.freedesktop.org/series/148025/
State : failure

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [20:04:26] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[20:04:30] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:04:56] Starting KUnit Kernel (1/1)...
[20:04:56] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:04:57] ================== guc_buf (11 subtests) ===================
[20:04:57] [PASSED] test_smallest
[20:04:57] [PASSED] test_largest
[20:04:57] [PASSED] test_granular
[20:04:57] [PASSED] test_unique
[20:04:57] [PASSED] test_overlap
[20:04:57] [PASSED] test_reusable
[20:04:57] [PASSED] test_too_big
[20:04:57] [PASSED] test_flush
[20:04:57] [PASSED] test_lookup
[20:04:57] [PASSED] test_data
[20:04:57] [PASSED] test_class
[20:04:57] ===================== [PASSED] guc_buf =====================
[20:04:57] =================== guc_dbm (7 subtests) ===================
[20:04:57] [PASSED] test_empty
[20:04:57] [PASSED] test_default
[20:04:57] ======================== test_size  ========================
[20:04:57] [PASSED] 4
[20:04:57] [PASSED] 8
[20:04:57] [PASSED] 32
[20:04:57] [PASSED] 256
[20:04:57] ==================== [PASSED] test_size ====================
[20:04:57] ======================= test_reuse  ========================
[20:04:57] [PASSED] 4
[20:04:57] [PASSED] 8
[20:04:57] [PASSED] 32
[20:04:57] [PASSED] 256
[20:04:57] =================== [PASSED] test_reuse ====================
[20:04:57] =================== test_range_overlap  ====================
[20:04:57] [PASSED] 4
[20:04:57] [PASSED] 8
[20:04:57] [PASSED] 32
[20:04:57] [PASSED] 256
[20:04:57] =============== [PASSED] test_range_overlap ================
[20:04:57] =================== test_range_compact  ====================
[20:04:57] [PASSED] 4
[20:04:57] [PASSED] 8
[20:04:57] [PASSED] 32
[20:04:57] [PASSED] 256
[20:04:57] =============== [PASSED] test_range_compact ================
[20:04:57] ==================== test_range_spare  =====================
[20:04:57] [PASSED] 4
[20:04:57] [PASSED] 8
[20:04:57] [PASSED] 32
[20:04:57] [PASSED] 256
[20:04:57] ================ [PASSED] test_range_spare =================
[20:04:57] ===================== [PASSED] guc_dbm =====================
[20:04:57] =================== guc_idm (6 subtests) ===================
[20:04:57] [PASSED] bad_init
[20:04:57] [PASSED] no_init
[20:04:57] [PASSED] init_fini
[20:04:57] [PASSED] check_used
[20:04:57] [PASSED] check_quota
[20:04:57] [PASSED] check_all
[20:04:57] ===================== [PASSED] guc_idm =====================
[20:04:57] ================== no_relay (3 subtests) ===================
[20:04:57] [PASSED] xe_drops_guc2pf_if_not_ready
[20:04:57] [PASSED] xe_drops_guc2vf_if_not_ready
[20:04:57] [PASSED] xe_rejects_send_if_not_ready
[20:04:57] ==================== [PASSED] no_relay =====================
[20:04:57] ================== pf_relay (14 subtests) ==================
[20:04:57] [PASSED] pf_rejects_guc2pf_too_short
[20:04:57] [PASSED] pf_rejects_guc2pf_too_long
[20:04:57] [PASSED] pf_rejects_guc2pf_no_payload
[20:04:57] [PASSED] pf_fails_no_payload
[20:04:57] [PASSED] pf_fails_bad_origin
[20:04:57] [PASSED] pf_fails_bad_type
[20:04:57] [PASSED] pf_txn_reports_error
[20:04:57] [PASSED] pf_txn_sends_pf2guc
[20:04:57] [PASSED] pf_sends_pf2guc
[20:04:57] [SKIPPED] pf_loopback_nop
[20:04:57] [SKIPPED] pf_loopback_echo
[20:04:57] [SKIPPED] pf_loopback_fail
[20:04:57] [SKIPPED] pf_loopback_busy
[20:04:57] [SKIPPED] pf_loopback_retry
[20:04:57] ==================== [PASSED] pf_relay =====================
[20:04:57] ================== vf_relay (3 subtests) ===================
[20:04:57] [PASSED] vf_rejects_guc2vf_too_short
[20:04:57] [PASSED] vf_rejects_guc2vf_too_long
[20:04:57] [PASSED] vf_rejects_guc2vf_no_payload
[20:04:57] ==================== [PASSED] vf_relay =====================
[20:04:57] ================= pf_service (11 subtests) =================
[20:04:57] [PASSED] pf_negotiate_any
[20:04:57] [PASSED] pf_negotiate_base_match
[20:04:57] [PASSED] pf_negotiate_base_newer
[20:04:57] [PASSED] pf_negotiate_base_next
[20:04:57] [SKIPPED] pf_negotiate_base_older
[20:04:57] [PASSED] pf_negotiate_base_prev
[20:04:57] [PASSED] pf_negotiate_latest_match
[20:04:57] [PASSED] pf_negotiate_latest_newer
[20:04:57] [PASSED] pf_negotiate_latest_next
[20:04:57] [SKIPPED] pf_negotiate_latest_older
[20:04:57] [SKIPPED] pf_negotiate_latest_prev
[20:04:57] =================== [PASSED] pf_service ====================
[20:04:57] ===================== lmtt (1 subtest) =====================
[20:04:57] ======================== test_ops  =========================
[20:04:57] [PASSED] 2-level
[20:04:57] [PASSED] multi-level
[20:04:57] ==================== [PASSED] test_ops =====================
[20:04:57] ====================== [PASSED] lmtt =======================
[20:04:57] =================== xe_mocs (2 subtests) ===================
[20:04:57] ================ xe_live_mocs_kernel_kunit  ================
[20:04:57] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[20:04:57] ================ xe_live_mocs_reset_kunit  =================
[20:04:57] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[20:04:57] ==================== [SKIPPED] xe_mocs =====================
[20:04:57] ================= xe_migrate (2 subtests) ==================
[20:04:57] ================= xe_migrate_sanity_kunit  =================
[20:04:57] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[20:04:57] ================== xe_validate_ccs_kunit  ==================
[20:04:57] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[20:04:57] =================== [SKIPPED] xe_migrate ===================
[20:04:57] ================== xe_dma_buf (1 subtest) ==================
[20:04:57] ==================== xe_dma_buf_kunit  =====================
[20:04:57] ================ [SKIPPED] xe_dma_buf_kunit ================
[20:04:57] =================== [SKIPPED] xe_dma_buf ===================
[20:04:57] ================= xe_bo_shrink (1 subtest) =================
[20:04:57] =================== xe_bo_shrink_kunit  ====================
[20:04:57] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[20:04:57] ================== [SKIPPED] xe_bo_shrink ==================
[20:04:57] ==================== xe_bo (2 subtests) ====================
[20:04:57] ================== xe_ccs_migrate_kunit  ===================
[20:04:57] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[20:04:57] ==================== xe_bo_evict_kunit  ====================
[20:04:57] =============== [SKIPPED] xe_bo_evict_kunit ================
[20:04:57] ===================== [SKIPPED] xe_bo ======================
[20:04:57] ==================== args (11 subtests) ====================
[20:04:57] [PASSED] count_args_test
[20:04:57] [PASSED] call_args_example
[20:04:57] [PASSED] call_args_test
[20:04:57] [PASSED] drop_first_arg_example
[20:04:57] [PASSED] drop_first_arg_test
[20:04:57] [PASSED] first_arg_example
[20:04:57] [PASSED] first_arg_test
[20:04:57] [PASSED] last_arg_example
[20:04:57] [PASSED] last_arg_test
[20:04:57] [PASSED] pick_arg_example
[20:04:57] [PASSED] sep_comma_example
[20:04:57] ====================== [PASSED] args =======================
[20:04:57] =================== xe_pci (2 subtests) ====================
[20:04:57] [PASSED] xe_gmdid_graphics_ip
[20:04:57] [PASSED] xe_gmdid_media_ip
[20:04:57] ===================== [PASSED] xe_pci ======================
[20:04:57] =================== xe_rtp (2 subtests) ====================
[20:04:57] =============== xe_rtp_process_to_sr_tests  ================
[20:04:57] [PASSED] coalesce-same-reg
[20:04:57] [PASSED] no-match-no-add
[20:04:57] [PASSED] match-or
[20:04:57] [PASSED] match-or-xfail
[20:04:57] [PASSED] no-match-no-add-multiple-rules
[20:04:57] [PASSED] two-regs-two-entries
[20:04:57] [PASSED] clr-one-set-other
[20:04:57] [PASSED] set-field
[20:04:57] [PASSED] conflict-duplicate
[20:04:57] [PASSED] conflict-not-disjoint
stty: 'standard input': Inappropriate ioctl for device
[20:04:57] [PASSED] conflict-reg-type
[20:04:57] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[20:04:57] ================== xe_rtp_process_tests  ===================
[20:04:57] [PASSED] active1
[20:04:57] [PASSED] active2
[20:04:57] [PASSED] active-inactive
[20:04:57] [PASSED] inactive-active
[20:04:57] [PASSED] inactive-1st_or_active-inactive
[20:04:57] [PASSED] inactive-2nd_or_active-inactive
[20:04:57] [PASSED] inactive-last_or_active-inactive
[20:04:57] [PASSED] inactive-no_or_active-inactive
[20:04:57] ============== [PASSED] xe_rtp_process_tests ===============
[20:04:57] ===================== [PASSED] xe_rtp ======================
[20:04:57] ==================== xe_wa (1 subtest) =====================
[20:04:57] ======================== xe_wa_gt  =========================
[20:04:57] [PASSED] TIGERLAKE (B0)
[20:04:57] [PASSED] DG1 (A0)
[20:04:57] [PASSED] DG1 (B0)
[20:04:57] [PASSED] ALDERLAKE_S (A0)
[20:04:57] [PASSED] ALDERLAKE_S (B0)
[20:04:57] [PASSED] ALDERLAKE_S (C0)
[20:04:57] [PASSED] ALDERLAKE_S (D0)
[20:04:57] [PASSED] ALDERLAKE_P (A0)
[20:04:57] [PASSED] ALDERLAKE_P (B0)
[20:04:57] [PASSED] ALDERLAKE_P (C0)
[20:04:57] [PASSED] ALDERLAKE_S_RPLS (D0)
[20:04:57] [PASSED] ALDERLAKE_P_RPLU (E0)
[20:04:57] [PASSED] DG2_G10 (C0)
[20:04:57] [PASSED] DG2_G11 (B1)
[20:04:57] [PASSED] DG2_G12 (A1)
[20:04:57] [PASSED] METEORLAKE (g:A0, m:A0)
[20:04:57] [PASSED] METEORLAKE (g:A0, m:A0)
[20:04:57] [PASSED] METEORLAKE (g:A0, m:A0)
[20:04:57] [PASSED] LUNARLAKE (g:A0, m:A0)
[20:04:57] [PASSED] LUNARLAKE (g:B0, m:A0)
[20:04:57] [PASSED] BATTLEMAGE (g:A0, m:A1)
[20:04:57] ==================== [PASSED] xe_wa_gt =====================
[20:04:57] ====================== [PASSED] xe_wa ======================
[20:04:57] ============================================================
[20:04:57] Testing complete. Ran 133 tests: passed: 117, skipped: 16
[20:04:57] Elapsed time: 31.152s total, 4.193s configuring, 26.593s building, 0.314s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [20:04:57] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[20:04:59] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:05:20] Starting KUnit Kernel (1/1)...
[20:05:20] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:05:20] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[20:05:20] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[20:05:20] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[20:05:20] =========== drm_validate_clone_mode (2 subtests) ===========
[20:05:20] ============== drm_test_check_in_clone_mode  ===============
[20:05:20] [PASSED] in_clone_mode
[20:05:20] [PASSED] not_in_clone_mode
[20:05:20] ========== [PASSED] drm_test_check_in_clone_mode ===========
[20:05:20] =============== drm_test_check_valid_clones  ===============
[20:05:20] [PASSED] not_in_clone_mode
[20:05:20] [PASSED] valid_clone
[20:05:20] [PASSED] invalid_clone
[20:05:20] =========== [PASSED] drm_test_check_valid_clones ===========
[20:05:20] ============= [PASSED] drm_validate_clone_mode =============
[20:05:20] ============= drm_validate_modeset (1 subtest) =============
[20:05:20] [PASSED] drm_test_check_connector_changed_modeset
[20:05:20] ============== [PASSED] drm_validate_modeset ===============
[20:05:20] ====== drm_test_bridge_get_current_state (2 subtests) ======
[20:05:20] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[20:05:20] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[20:05:20] ======== [PASSED] drm_test_bridge_get_current_state ========
[20:05:20] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[20:05:20] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[20:05:20] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[20:05:20] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[20:05:20] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[20:05:20] ================== drm_buddy (7 subtests) ==================
[20:05:20] [PASSED] drm_test_buddy_alloc_limit
[20:05:20] [PASSED] drm_test_buddy_alloc_optimistic
[20:05:20] [PASSED] drm_test_buddy_alloc_pessimistic
[20:05:20] [PASSED] drm_test_buddy_alloc_pathological
[20:05:20] [PASSED] drm_test_buddy_alloc_contiguous
[20:05:20] [PASSED] drm_test_buddy_alloc_clear
[20:05:20] [PASSED] drm_test_buddy_alloc_range_bias
[20:05:20] ==================== [PASSED] drm_buddy ====================
[20:05:20] ============= drm_cmdline_parser (40 subtests) =============
[20:05:20] [PASSED] drm_test_cmdline_force_d_only
[20:05:20] [PASSED] drm_test_cmdline_force_D_only_dvi
[20:05:20] [PASSED] drm_test_cmdline_force_D_only_hdmi
[20:05:20] [PASSED] drm_test_cmdline_force_D_only_not_digital
[20:05:20] [PASSED] drm_test_cmdline_force_e_only
[20:05:20] [PASSED] drm_test_cmdline_res
[20:05:20] [PASSED] drm_test_cmdline_res_vesa
[20:05:20] [PASSED] drm_test_cmdline_res_vesa_rblank
[20:05:20] [PASSED] drm_test_cmdline_res_rblank
[20:05:20] [PASSED] drm_test_cmdline_res_bpp
[20:05:20] [PASSED] drm_test_cmdline_res_refresh
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[20:05:20] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[20:05:20] [PASSED] drm_test_cmdline_res_margins_force_on
[20:05:20] [PASSED] drm_test_cmdline_res_vesa_margins
[20:05:20] [PASSED] drm_test_cmdline_name
[20:05:20] [PASSED] drm_test_cmdline_name_bpp
[20:05:20] [PASSED] drm_test_cmdline_name_option
[20:05:20] [PASSED] drm_test_cmdline_name_bpp_option
[20:05:20] [PASSED] drm_test_cmdline_rotate_0
[20:05:20] [PASSED] drm_test_cmdline_rotate_90
[20:05:20] [PASSED] drm_test_cmdline_rotate_180
[20:05:20] [PASSED] drm_test_cmdline_rotate_270
[20:05:20] [PASSED] drm_test_cmdline_hmirror
[20:05:20] [PASSED] drm_test_cmdline_vmirror
[20:05:20] [PASSED] drm_test_cmdline_margin_options
[20:05:20] [PASSED] drm_test_cmdline_multiple_options
[20:05:20] [PASSED] drm_test_cmdline_bpp_extra_and_option
[20:05:20] [PASSED] drm_test_cmdline_extra_and_option
[20:05:20] [PASSED] drm_test_cmdline_freestanding_options
[20:05:20] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[20:05:20] [PASSED] drm_test_cmdline_panel_orientation
[20:05:20] ================ drm_test_cmdline_invalid  =================
[20:05:20] [PASSED] margin_only
[20:05:20] [PASSED] interlace_only
[20:05:20] [PASSED] res_missing_x
[20:05:20] [PASSED] res_missing_y
[20:05:20] [PASSED] res_bad_y
[20:05:20] [PASSED] res_missing_y_bpp
[20:05:20] [PASSED] res_bad_bpp
[20:05:20] [PASSED] res_bad_refresh
[20:05:20] [PASSED] res_bpp_refresh_force_on_off
[20:05:20] [PASSED] res_invalid_mode
[20:05:20] [PASSED] res_bpp_wrong_place_mode
[20:05:20] [PASSED] name_bpp_refresh
[20:05:20] [PASSED] name_refresh
[20:05:20] [PASSED] name_refresh_wrong_mode
[20:05:20] [PASSED] name_refresh_invalid_mode
[20:05:20] [PASSED] rotate_multiple
[20:05:20] [PASSED] rotate_invalid_val
[20:05:20] [PASSED] rotate_truncated
[20:05:20] [PASSED] invalid_option
[20:05:20] [PASSED] invalid_tv_option
[20:05:20] [PASSED] truncated_tv_option
[20:05:20] ============ [PASSED] drm_test_cmdline_invalid =============
[20:05:20] =============== drm_test_cmdline_tv_options  ===============
[20:05:20] [PASSED] NTSC
[20:05:20] [PASSED] NTSC_443
[20:05:20] [PASSED] NTSC_J
[20:05:20] [PASSED] PAL
[20:05:20] [PASSED] PAL_M
[20:05:20] [PASSED] PAL_N
[20:05:20] [PASSED] SECAM
[20:05:20] [PASSED] MONO_525
[20:05:20] [PASSED] MONO_625
[20:05:20] =========== [PASSED] drm_test_cmdline_tv_options ===========
[20:05:20] =============== [PASSED] drm_cmdline_parser ================
[20:05:20] ========== drmm_connector_hdmi_init (20 subtests) ==========
[20:05:20] [PASSED] drm_test_connector_hdmi_init_valid
[20:05:20] [PASSED] drm_test_connector_hdmi_init_bpc_8
[20:05:20] [PASSED] drm_test_connector_hdmi_init_bpc_10
[20:05:20] [PASSED] drm_test_connector_hdmi_init_bpc_12
[20:05:20] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[20:05:20] [PASSED] drm_test_connector_hdmi_init_bpc_null
[20:05:20] [PASSED] drm_test_connector_hdmi_init_formats_empty
[20:05:20] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[20:05:20] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[20:05:20] [PASSED] supported_formats=0x9 yuv420_allowed=1
[20:05:20] [PASSED] supported_formats=0x9 yuv420_allowed=0
[20:05:20] [PASSED] supported_formats=0x3 yuv420_allowed=1
[20:05:20] [PASSED] supported_formats=0x3 yuv420_allowed=0
[20:05:20] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[20:05:20] [PASSED] drm_test_connector_hdmi_init_null_ddc
[20:05:20] [PASSED] drm_test_connector_hdmi_init_null_product
[20:05:20] [PASSED] drm_test_connector_hdmi_init_null_vendor
[20:05:20] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[20:05:20] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[20:05:20] [PASSED] drm_test_connector_hdmi_init_product_valid
[20:05:20] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[20:05:20] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[20:05:20] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[20:05:20] ========= drm_test_connector_hdmi_init_type_valid  =========
[20:05:20] [PASSED] HDMI-A
[20:05:20] [PASSED] HDMI-B
[20:05:20] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[20:05:20] ======== drm_test_connector_hdmi_init_type_invalid  ========
[20:05:20] [PASSED] Unknown
[20:05:20] [PASSED] VGA
[20:05:20] [PASSED] DVI-I
[20:05:20] [PASSED] DVI-D
[20:05:20] [PASSED] DVI-A
[20:05:20] [PASSED] Composite
[20:05:20] [PASSED] SVIDEO
[20:05:20] [PASSED] LVDS
[20:05:20] [PASSED] Component
[20:05:20] [PASSED] DIN
[20:05:20] [PASSED] DP
[20:05:20] [PASSED] TV
[20:05:20] [PASSED] eDP
[20:05:20] [PASSED] Virtual
[20:05:20] [PASSED] DSI
[20:05:20] [PASSED] DPI
[20:05:20] [PASSED] Writeback
[20:05:20] [PASSED] SPI
[20:05:20] [PASSED] USB
[20:05:20] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[20:05:20] ============ [PASSED] drmm_connector_hdmi_init =============
[20:05:20] ============= drmm_connector_init (3 subtests) =============
[20:05:20] [PASSED] drm_test_drmm_connector_init
[20:05:20] [PASSED] drm_test_drmm_connector_init_null_ddc
[20:05:20] ========= drm_test_drmm_connector_init_type_valid  =========
[20:05:20] [PASSED] Unknown
[20:05:20] [PASSED] VGA
[20:05:20] [PASSED] DVI-I
[20:05:20] [PASSED] DVI-D
[20:05:20] [PASSED] DVI-A
[20:05:20] [PASSED] Composite
[20:05:20] [PASSED] SVIDEO
[20:05:20] [PASSED] LVDS
[20:05:20] [PASSED] Component
[20:05:20] [PASSED] DIN
[20:05:20] [PASSED] DP
[20:05:20] [PASSED] HDMI-A
[20:05:20] [PASSED] HDMI-B
[20:05:20] [PASSED] TV
[20:05:20] [PASSED] eDP
[20:05:20] [PASSED] Virtual
[20:05:20] [PASSED] DSI
[20:05:20] [PASSED] DPI
[20:05:20] [PASSED] Writeback
[20:05:20] [PASSED] SPI
[20:05:20] [PASSED] USB
[20:05:20] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[20:05:20] =============== [PASSED] drmm_connector_init ===============
[20:05:20] ========= drm_connector_dynamic_init (6 subtests) ==========
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_init
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_init_properties
[20:05:20] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[20:05:20] [PASSED] Unknown
[20:05:20] [PASSED] VGA
[20:05:20] [PASSED] DVI-I
[20:05:20] [PASSED] DVI-D
[20:05:20] [PASSED] DVI-A
[20:05:20] [PASSED] Composite
[20:05:20] [PASSED] SVIDEO
[20:05:20] [PASSED] LVDS
[20:05:20] [PASSED] Component
[20:05:20] [PASSED] DIN
[20:05:20] [PASSED] DP
[20:05:20] [PASSED] HDMI-A
[20:05:20] [PASSED] HDMI-B
[20:05:20] [PASSED] TV
[20:05:20] [PASSED] eDP
[20:05:20] [PASSED] Virtual
[20:05:20] [PASSED] DSI
[20:05:20] [PASSED] DPI
[20:05:20] [PASSED] Writeback
[20:05:20] [PASSED] SPI
[20:05:20] [PASSED] USB
[20:05:20] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[20:05:20] ======== drm_test_drm_connector_dynamic_init_name  =========
[20:05:20] [PASSED] Unknown
[20:05:20] [PASSED] VGA
[20:05:20] [PASSED] DVI-I
[20:05:20] [PASSED] DVI-D
[20:05:20] [PASSED] DVI-A
[20:05:20] [PASSED] Composite
[20:05:20] [PASSED] SVIDEO
[20:05:20] [PASSED] LVDS
[20:05:20] [PASSED] Component
[20:05:20] [PASSED] DIN
[20:05:20] [PASSED] DP
[20:05:20] [PASSED] HDMI-A
[20:05:20] [PASSED] HDMI-B
[20:05:20] [PASSED] TV
[20:05:20] [PASSED] eDP
[20:05:20] [PASSED] Virtual
[20:05:20] [PASSED] DSI
[20:05:20] [PASSED] DPI
[20:05:20] [PASSED] Writeback
[20:05:20] [PASSED] SPI
[20:05:20] [PASSED] USB
[20:05:20] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[20:05:20] =========== [PASSED] drm_connector_dynamic_init ============
[20:05:20] ==== drm_connector_dynamic_register_early (4 subtests) =====
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[20:05:20] ====== [PASSED] drm_connector_dynamic_register_early =======
[20:05:20] ======= drm_connector_dynamic_register (7 subtests) ========
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[20:05:20] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[20:05:20] ========= [PASSED] drm_connector_dynamic_register ==========
[20:05:20] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[20:05:20] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[20:05:20] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[20:05:20] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[20:05:20] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[20:05:20] ========== drm_test_get_tv_mode_from_name_valid  ===========
[20:05:20] [PASSED] NTSC
[20:05:20] [PASSED] NTSC-443
[20:05:20] [PASSED] NTSC-J
[20:05:20] [PASSED] PAL
[20:05:20] [PASSED] PAL-M
[20:05:20] [PASSED] PAL-N
[20:05:20] [PASSED] SECAM
[20:05:20] [PASSED] Mono
[20:05:20] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[20:05:20] [PASSED] drm_test_get_tv_mode_from_name_truncated
[20:05:20] ============ [PASSED] drm_get_tv_mode_from_name ============
[20:05:20] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[20:05:20] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[20:05:20] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[20:05:20] [PASSED] VIC 96
[20:05:20] [PASSED] VIC 97
[20:05:20] [PASSED] VIC 101
[20:05:20] [PASSED] VIC 102
[20:05:20] [PASSED] VIC 106
[20:05:20] [PASSED] VIC 107
[20:05:20] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[20:05:20] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[20:05:20] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[20:05:20] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[20:05:20] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[20:05:20] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[20:05:20] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[20:05:20] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[20:05:20] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[20:05:20] [PASSED] Automatic
[20:05:20] [PASSED] Full
[20:05:20] [PASSED] Limited 16:235
[20:05:20] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[20:05:20] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[20:05:20] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[20:05:20] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[20:05:20] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[20:05:20] [PASSED] RGB
[20:05:20] [PASSED] YUV 4:2:0
[20:05:20] [PASSED] YUV 4:2:2
[20:05:20] [PASSED] YUV 4:4:4
[20:05:20] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[20:05:20] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[20:05:20] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[20:05:20] ============= drm_damage_helper (21 subtests) ==============
[20:05:20] [PASSED] drm_test_damage_iter_no_damage
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_src_moved
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_not_visible
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[20:05:20] [PASSED] drm_test_damage_iter_no_damage_no_fb
[20:05:20] [PASSED] drm_test_damage_iter_simple_damage
[20:05:20] [PASSED] drm_test_damage_iter_single_damage
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_outside_src
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_src_moved
[20:05:20] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[20:05:20] [PASSED] drm_test_damage_iter_damage
[20:05:20] [PASSED] drm_test_damage_iter_damage_one_intersect
[20:05:20] [PASSED] drm_test_damage_iter_damage_one_outside
[20:05:20] [PASSED] drm_test_damage_iter_damage_src_moved
[20:05:20] [PASSED] drm_test_damage_iter_damage_not_visible
[20:05:20] ================ [PASSED] drm_damage_helper ================
[20:05:20] ============== drm_dp_mst_helper (3 subtests) ==============
[20:05:20] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[20:05:20] [PASSED] Clock 154000 BPP 30 DSC disabled
[20:05:20] [PASSED] Clock 234000 BPP 30 DSC disabled
[20:05:20] [PASSED] Clock 297000 BPP 24 DSC disabled
[20:05:20] [PASSED] Clock 332880 BPP 24 DSC enabled
[20:05:20] [PASSED] Clock 324540 BPP 24 DSC enabled
[20:05:20] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[20:05:20] ============== drm_test_dp_mst_calc_pbn_div  ===============
[20:05:20] [PASSED] Link rate 2000000 lane count 4
[20:05:20] [PASSED] Link rate 2000000 lane count 2
[20:05:20] [PASSED] Link rate 2000000 lane count 1
[20:05:20] [PASSED] Link rate 1350000 lane count 4
[20:05:20] [PASSED] Link rate 1350000 lane count 2
[20:05:20] [PASSED] Link rate 1350000 lane count 1
[20:05:20] [PASSED] Link rate 1000000 lane count 4
[20:05:20] [PASSED] Link rate 1000000 lane count 2
[20:05:20] [PASSED] Link rate 1000000 lane count 1
[20:05:20] [PASSED] Link rate 810000 lane count 4
[20:05:20] [PASSED] Link rate 810000 lane count 2
[20:05:20] [PASSED] Link rate 810000 lane count 1
[20:05:20] [PASSED] Link rate 540000 lane count 4
[20:05:20] [PASSED] Link rate 540000 lane count 2
[20:05:20] [PASSED] Link rate 540000 lane count 1
[20:05:20] [PASSED] Link rate 270000 lane count 4
[20:05:20] [PASSED] Link rate 270000 lane count 2
[20:05:20] [PASSED] Link rate 270000 lane count 1
[20:05:20] [PASSED] Link rate 162000 lane count 4
[20:05:20] [PASSED] Link rate 162000 lane count 2
[20:05:20] [PASSED] Link rate 162000 lane count 1
[20:05:20] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[20:05:20] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[20:05:20] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[20:05:20] [PASSED] DP_POWER_UP_PHY with port number
[20:05:20] [PASSED] DP_POWER_DOWN_PHY with port number
[20:05:20] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[20:05:20] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[20:05:20] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[20:05:20] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[20:05:20] [PASSED] DP_QUERY_PAYLOAD with port number
[20:05:20] [PASSED] DP_QUERY_PAYLOAD with VCPI
[20:05:20] [PASSED] DP_REMOTE_DPCD_READ with port number
[20:05:20] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[20:05:20] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[20:05:20] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[20:05:20] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[20:05:20] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[20:05:20] [PASSED] DP_REMOTE_I2C_READ with port number
[20:05:20] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[20:05:20] [PASSED] DP_REMOTE_I2C_READ with transactions array
[20:05:20] [PASSED] DP_REMOTE_I2C_WRITE with port number
[20:05:20] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[20:05:20] [PASSED] DP_REMOTE_I2C_WRITE with data array
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[20:05:20] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[20:05:20] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[20:05:20] ================ [PASSED] drm_dp_mst_helper ================
[20:05:20] ================== drm_exec (7 subtests) ===================
[20:05:20] [PASSED] sanitycheck
[20:05:20] [PASSED] test_lock
[20:05:20] [PASSED] test_lock_unlock
[20:05:20] [PASSED] test_duplicates
[20:05:20] [PASSED] test_prepare
[20:05:20] [PASSED] test_prepare_array
[20:05:20] [PASSED] test_multiple_loops
[20:05:20] ==================== [PASSED] drm_exec =====================
[20:05:20] =========== drm_format_helper_test (18 subtests) ===========
[20:05:20] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[20:05:20] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[20:05:20] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[20:05:20] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[20:05:20] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[20:05:20] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[20:05:20] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[20:05:20] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[20:05:20] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[20:05:20] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[20:05:20] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[20:05:20] ============== drm_test_fb_xrgb8888_to_mono  ===============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[20:05:20] ==================== drm_test_fb_swab  =====================
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ================ [PASSED] drm_test_fb_swab =================
[20:05:20] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[20:05:20] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[20:05:20] [PASSED] single_pixel_source_buffer
[20:05:20] [PASSED] single_pixel_clip_rectangle
[20:05:20] [PASSED] well_known_colors
[20:05:20] [PASSED] destination_pitch
[20:05:20] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[20:05:20] ================= drm_test_fb_clip_offset  =================
[20:05:20] [PASSED] pass through
[20:05:20] [PASSED] horizontal offset
[20:05:20] [PASSED] vertical offset
[20:05:20] [PASSED] horizontal and vertical offset
[20:05:20] [PASSED] horizontal offset (custom pitch)
[20:05:20] [PASSED] vertical offset (custom pitch)
[20:05:20] [PASSED] horizontal and vertical offset (custom pitch)
[20:05:20] ============= [PASSED] drm_test_fb_clip_offset =============
[20:05:20] ============== drm_test_fb_build_fourcc_list  ==============
[20:05:20] [PASSED] no native formats
[20:05:20] [PASSED] XRGB8888 as native format
[20:05:20] [PASSED] remove duplicates
[20:05:20] [PASSED] convert alpha formats
[20:05:20] [PASSED] random formats
[20:05:20] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[20:05:20] =================== drm_test_fb_memcpy  ====================
[20:05:20] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[20:05:20] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[20:05:20] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[20:05:20] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[20:05:20] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[20:05:20] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[20:05:20] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[20:05:20] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[20:05:20] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[20:05:20] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[20:05:20] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[20:05:20] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[20:05:20] =============== [PASSED] drm_test_fb_memcpy ================
[20:05:20] ============= [PASSED] drm_format_helper_test ==============
[20:05:20] ================= drm_format (18 subtests) =================
[20:05:20] [PASSED] drm_test_format_block_width_invalid
[20:05:20] [PASSED] drm_test_format_block_width_one_plane
[20:05:20] [PASSED] drm_test_format_block_width_two_plane
[20:05:20] [PASSED] drm_test_format_block_width_three_plane
[20:05:20] [PASSED] drm_test_format_block_width_tiled
[20:05:20] [PASSED] drm_test_format_block_height_invalid
[20:05:20] [PASSED] drm_test_format_block_height_one_plane
[20:05:20] [PASSED] drm_test_format_block_height_two_plane
[20:05:20] [PASSED] drm_test_format_block_height_three_plane
[20:05:20] [PASSED] drm_test_format_block_height_tiled
[20:05:20] [PASSED] drm_test_format_min_pitch_invalid
[20:05:20] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[20:05:20] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[20:05:20] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[20:05:20] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[20:05:20] [PASSED] drm_test_format_min_pitch_two_plane
[20:05:20] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[20:05:20] [PASSED] drm_test_format_min_pitch_tiled
[20:05:20] =================== [PASSED] drm_format ====================
[20:05:20] ============== drm_framebuffer (10 subtests) ===============
[20:05:20] ========== drm_test_framebuffer_check_src_coords  ==========
[20:05:20] [PASSED] Success: source fits into fb
[20:05:20] [PASSED] Fail: overflowing fb with x-axis coordinate
[20:05:20] [PASSED] Fail: overflowing fb with y-axis coordinate
[20:05:20] [PASSED] Fail: overflowing fb with source width
[20:05:20] [PASSED] Fail: overflowing fb with source height
[20:05:20] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[20:05:20] [PASSED] drm_test_framebuffer_cleanup
[20:05:20] =============== drm_test_framebuffer_create  ===============
[20:05:20] [PASSED] ABGR8888 normal sizes
[20:05:20] [PASSED] ABGR8888 max sizes
[20:05:20] [PASSED] ABGR8888 pitch greater than min required
[20:05:20] [PASSED] ABGR8888 pitch less than min required
[20:05:20] [PASSED] ABGR8888 Invalid width
[20:05:20] [PASSED] ABGR8888 Invalid buffer handle
[20:05:20] [PASSED] No pixel format
[20:05:20] [PASSED] ABGR8888 Width 0
[20:05:20] [PASSED] ABGR8888 Height 0
[20:05:20] [PASSED] ABGR8888 Out of bound height * pitch combination
[20:05:20] [PASSED] ABGR8888 Large buffer offset
[20:05:20] [PASSED] ABGR8888 Buffer offset for inexistent plane
[20:05:20] [PASSED] ABGR8888 Invalid flag
[20:05:20] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[20:05:20] [PASSED] ABGR8888 Valid buffer modifier
[20:05:20] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[20:05:20] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] NV12 Normal sizes
[20:05:20] [PASSED] NV12 Max sizes
[20:05:20] [PASSED] NV12 Invalid pitch
[20:05:20] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[20:05:20] [PASSED] NV12 different  modifier per-plane
[20:05:20] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[20:05:20] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] NV12 Modifier for inexistent plane
[20:05:20] [PASSED] NV12 Handle for inexistent plane
[20:05:20] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[20:05:20] [PASSED] YVU420 Normal sizes
[20:05:20] [PASSED] YVU420 Max sizes
[20:05:20] [PASSED] YVU420 Invalid pitch
[20:05:20] [PASSED] YVU420 Different pitches
[20:05:20] [PASSED] YVU420 Different buffer offsets/pitches
[20:05:20] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[20:05:20] [PASSED] YVU420 Valid modifier
[20:05:20] [PASSED] YVU420 Different modifiers per plane
[20:05:20] [PASSED] YVU420 Modifier for inexistent plane
[20:05:20] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[20:05:20] [PASSED] X0L2 Normal sizes
[20:05:20] [PASSED] X0L2 Max sizes
[20:05:20] [PASSED] X0L2 Invalid pitch
[20:05:20] [PASSED] X0L2 Pitch greater than minimum required
[20:05:20] [PASSED] X0L2 Handle for inexistent plane
[20:05:20] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[20:05:20] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[20:05:20] [PASSED] X0L2 Valid modifier
[20:05:20] [PASSED] X0L2 Modifier for inexistent plane
[20:05:20] =========== [PASSED] drm_test_framebuffer_create ===========
[20:05:20] [PASSED] drm_test_framebuffer_free
[20:05:20] [PASSED] drm_test_framebuffer_init
[20:05:20] [PASSED] drm_test_framebuffer_init_bad_format
[20:05:20] [PASSED] drm_test_framebuffer_init_dev_mismatch
[20:05:20] [PASSED] drm_test_framebuffer_lookup
[20:05:20] [PASSED] drm_test_framebuffer_lookup_inexistent
[20:05:20] [PASSED] drm_test_framebuffer_modifiers_not_supported
[20:05:20] ================= [PASSED] drm_framebuffer =================
[20:05:20] ================ drm_gem_shmem (8 subtests) ================
[20:05:20] [PASSED] drm_gem_shmem_test_obj_create
[20:05:20] [PASSED] drm_gem_shmem_test_obj_create_private
[20:05:20] [PASSED] drm_gem_shmem_test_pin_pages
[20:05:20] [PASSED] drm_gem_shmem_test_vmap
[20:05:20] [PASSED] drm_gem_shmem_test_get_pages_sgt
[20:05:20] [PASSED] drm_gem_shmem_test_get_sg_table
[20:05:20] [PASSED] drm_gem_shmem_test_madvise
[20:05:20] [PASSED] drm_gem_shmem_test_purge
[20:05:20] ================== [PASSED] drm_gem_shmem ==================
[20:05:20] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[20:05:20] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[20:05:20] [PASSED] Automatic
[20:05:20] [PASSED] Full
[20:05:20] [PASSED] Limited 16:235
[20:05:20] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[20:05:20] [PASSED] drm_test_check_disable_connector
[20:05:20] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[20:05:20] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[20:05:20] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[20:05:20] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[20:05:20] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[20:05:20] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[20:05:20] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[20:05:20] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[20:05:20] [PASSED] drm_test_check_output_bpc_dvi
[20:05:20] [PASSED] drm_test_check_output_bpc_format_vic_1
[20:05:20] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[20:05:20] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[20:05:20] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[20:05:20] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[20:05:20] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[20:05:20] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[20:05:20] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[20:05:20] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[20:05:20] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[20:05:20] [PASSED] drm_test_check_broadcast_rgb_value
[20:05:20] [PASSED] drm_test_check_bpc_8_value
[20:05:20] [PASSED] drm_test_check_bpc_10_value
[20:05:20] [PASSED] drm_test_check_bpc_12_value
[20:05:20] [PASSED] drm_test_check_format_value
[20:05:20] [PASSED] drm_test_check_tmds_char_value
[20:05:20] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[20:05:20] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[20:05:20] [PASSED] drm_test_check_mode_valid
[20:05:20] [PASSED] drm_test_check_mode_valid_reject
[20:05:20] [PASSED] drm_test_check_mode_valid_reject_rate
[20:05:20] [PASSED] drm_test_check_mode_valid_reject_max_clock
[20:05:20] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[20:05:20] ================= drm_managed (2 subtests) =================
[20:05:20] [PASSED] drm_test_managed_release_action
[20:05:20] [PASSED] drm_test_managed_run_action
[20:05:20] =================== [PASSED] drm_managed ===================
[20:05:20] =================== drm_mm (6 subtests) ====================
[20:05:20] [PASSED] drm_test_mm_init
[20:05:20] [PASSED] drm_test_mm_debug
[20:05:20] [PASSED] drm_test_mm_align32
[20:05:20] [PASSED] drm_test_mm_align64
[20:05:20] [PASSED] drm_test_mm_lowest
[20:05:20] [PASSED] drm_test_mm_highest
[20:05:20] ===================== [PASSED] drm_mm ======================
[20:05:20] ============= drm_modes_analog_tv (5 subtests) =============
[20:05:20] [PASSED] drm_test_modes_analog_tv_mono_576i
[20:05:20] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[20:05:20] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[20:05:20] [PASSED] drm_test_modes_analog_tv_pal_576i
[20:05:20] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[20:05:20] =============== [PASSED] drm_modes_analog_tv ===============
[20:05:20] ============== drm_plane_helper (2 subtests) ===============
[20:05:20] =============== drm_test_check_plane_state  ================
[20:05:20] [PASSED] clipping_simple
[20:05:20] [PASSED] clipping_rotate_reflect
[20:05:20] [PASSED] positioning_simple
[20:05:20] [PASSED] upscaling
[20:05:20] [PASSED] downscaling
[20:05:20] [PASSED] rounding1
[20:05:20] [PASSED] rounding2
[20:05:20] [PASSED] rounding3
[20:05:20] [PASSED] rounding4
[20:05:20] =========== [PASSED] drm_test_check_plane_state ============
[20:05:20] =========== drm_test_check_invalid_plane_state  ============
[20:05:20] [PASSED] positioning_invalid
[20:05:20] [PASSED] upscaling_invalid
[20:05:20] [PASSED] downscaling_invalid
[20:05:20] ======= [PASSED] drm_test_check_invalid_plane_state ========
[20:05:20] ================ [PASSED] drm_plane_helper =================
[20:05:20] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[20:05:20] ====== drm_test_connector_helper_tv_get_modes_check  =======
[20:05:20] [PASSED] None
[20:05:20] [PASSED] PAL
[20:05:20] [PASSED] NTSC
[20:05:20] [PASSED] Both, NTSC Default
[20:05:20] [PASSED] Both, PAL Default
[20:05:20] [PASSED] Both, NTSC Default, with PAL on command-line
[20:05:20] [PASSED] Both, PAL Default, with NTSC on command-line
[20:05:20] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[20:05:20] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[20:05:20] ================== drm_rect (9 subtests) ===================
[20:05:20] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[20:05:20] [PASSED] drm_test_rect_clip_scaled_not_clipped
[20:05:20] [PASSED] drm_test_rect_clip_scaled_clipped
[20:05:20] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[20:05:20] ================= drm_test_rect_intersect  =================
[20:05:20] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[20:05:20] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[20:05:20] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[20:05:20] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[20:05:20] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[20:05:20] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[20:05:20] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[20:05:20] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[20:05:20] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[20:05:20] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[20:05:20] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[20:05:20] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[20:05:20] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[20:05:20] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[20:05:20] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[20:05:20] ============= [PASSED] drm_test_rect_intersect =============
[20:05:20] ================ drm_test_rect_calc_hscale  ================
[20:05:20] [PASSED] normal use
[20:05:20] [PASSED] out of max range
[20:05:20] [PASSED] out of min range
[20:05:20] [PASSED] zero dst
[20:05:20] [PASSED] negative src
[20:05:20] [PASSED] negative dst
[20:05:20] ============ [PASSED] drm_test_rect_calc_hscale ============
[20:05:20] ================ drm_test_rect_calc_vscale  ================
[20:05:20] [PASSED] normal use
[20:05:20] [PASSED] out of max range
[20:05:20] [PASSED] out of min range
[20:05:20] [PASSED] zero dst
[20:05:20] [PASSED] negative src
[20:05:20] [PASSED] negative dst
[20:05:20] ============ [PASSED] drm_test_rect_calc_vscale ============
[20:05:20] ================== drm_test_rect_rotate  ===================
[20:05:20] [PASSED] reflect-x
[20:05:20] [PASSED] reflect-y
[20:05:20] [PASSED] rotate-0
[20:05:20] [PASSED] rotate-90
[20:05:20] [PASSED] rotate-180
stty: 'standard input': Inappropriate ioctl for device
[20:05:20] [PASSED] rotate-270
[20:05:20] ============== [PASSED] drm_test_rect_rotate ===============
[20:05:20] ================ drm_test_rect_rotate_inv  =================
[20:05:20] [PASSED] reflect-x
[20:05:20] [PASSED] reflect-y
[20:05:20] [PASSED] rotate-0
[20:05:20] [PASSED] rotate-90
[20:05:20] [PASSED] rotate-180
[20:05:20] [PASSED] rotate-270
[20:05:20] ============ [PASSED] drm_test_rect_rotate_inv =============
[20:05:20] ==================== [PASSED] drm_rect =====================
[20:05:20] ============================================================
[20:05:20] Testing complete. Ran 614 tests: passed: 614
[20:05:20] Elapsed time: 23.398s total, 1.692s configuring, 21.490s building, 0.199s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig ERROR:root:../drivers/gpu/drm/ttm/ttm_pool.c: In function ‘ttm_pool_mgr_init’:
../drivers/gpu/drm/ttm/ttm_pool.c:1335:30: error: ‘TTM_SHRINKER_BATCH’ undeclared (first use in this function)

 1335 |         mm_shrinker->batch = TTM_SHRINKER_BATCH;
      |                              ^~~~~~~~~~~~~~~~~~

../drivers/gpu/drm/ttm/ttm_pool.c:1335:30: note: each undeclared identifier is reported only once for each function it appears in make[7]: *** [../scripts/Makefile.build:203: drivers/gpu/drm/ttm/ttm_pool.o] Error 1
make[7]: *** Waiting for unfinished jobs....
make[6]: *** [../scripts/Makefile.build:461: drivers/gpu/drm/ttm] Error 2
make[5]: *** [../scripts/Makefile.build:461: drivers/gpu/drm] Error 2
make[4]: *** [../scripts/Makefile.build:461: drivers/gpu] Error 2
make[3]: *** [../scripts/Makefile.build:461: drivers] Error 2
make[2]: *** [/kernel/Makefile:2003: .] Error 2
make[1]: *** [/kernel/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2

[20:05:20] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[20:05:22] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
#25 lore raw

✗ i915.CI.BAT: failure for Enable/Disable DC balance along with VRR DSB (rev6)

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: Enable/Disable DC balance along with VRR DSB (rev6)
URL : https://patchwork.freedesktop.org/series/147799/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16640 -> Patchwork_147799v6
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_147799v6 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_147799v6, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/index.html

Participating hosts (42 -> 42)
------------------------------

Additional (1): bat-arlh-2
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_147799v6:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@guc_multi_lrc:
- bat-twl-2: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-twl-2/igt@i915_selftest@live@guc_multi_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-twl-2/igt@i915_selftest@live@guc_multi_lrc.html

Known issues
------------

Here are the changes found in Patchwork_147799v6 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([i915#12904]) +1 other test incomplete
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html

* igt@fbdev@eof:
- bat-arlh-2: NOTRUN -> [SKIP][5] ([i915#11345] / [i915#11346]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@fbdev@info:
- bat-arlh-2: NOTRUN -> [SKIP][6] ([i915#11346] / [i915#1849])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- bat-arlh-2: NOTRUN -> [SKIP][7] ([i915#10213] / [i915#11346] / [i915#11671]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@gem_mmap@basic:
- bat-arlh-2: NOTRUN -> [SKIP][8] ([i915#11343] / [i915#11346])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][9] ([i915#10197] / [i915#10211] / [i915#11346] / [i915#11725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@gem_tiled_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][10] ([i915#11346] / [i915#12637]) +4 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-arlh-2: NOTRUN -> [SKIP][11] ([i915#10206] / [i915#11346] / [i915#11724])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@gem_tiled_pread_basic.html

* igt@i915_pm_rps@basic-api:
- bat-arlh-2: NOTRUN -> [SKIP][12] ([i915#10209] / [i915#11346] / [i915#11681])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@i915_selftest@live:
- bat-twl-2: [PASS][13] -> [ABORT][14] ([i915#14357])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-twl-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-twl-2/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [PASS][15] -> [DMESG-FAIL][16] ([i915#12061]) +1 other test dmesg-fail
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-dg2-9/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-dg2-9/igt@i915_selftest@[email protected]

* igt@intel_hwmon@hwmon-read:
- bat-arlh-2: NOTRUN -> [SKIP][17] ([i915#11346] / [i915#11680] / [i915#7707]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-arlh-2: NOTRUN -> [SKIP][18] ([i915#10200] / [i915#11346] / [i915#11666] / [i915#12203])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-arlh-2: NOTRUN -> [SKIP][19] ([i915#10200] / [i915#11346] / [i915#11666]) +8 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@kms_psr@psr-primary-page-flip:
- bat-arlh-2: NOTRUN -> [SKIP][20] ([i915#11346]) +32 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-arlh-2: NOTRUN -> [SKIP][21] ([i915#10208] / [i915#11346] / [i915#8809])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-arlh-2: NOTRUN -> [SKIP][22] ([i915#10212] / [i915#11346] / [i915#11726])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@prime_vgem@basic-read:
- bat-arlh-2: NOTRUN -> [SKIP][23] ([i915#10214] / [i915#11346] / [i915#11726])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-arlh-2: NOTRUN -> [SKIP][24] ([i915#10216] / [i915#11346] / [i915#11723])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-arlh-2/igt@[email protected]

#### Possible fixes ####

* igt@core_auth@basic-auth:
- bat-twl-2: [DMESG-WARN][25] ([i915#13736]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-twl-2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-twl-2/igt@[email protected]

* igt@dmabuf@all-tests:
- bat-apl-1: [INCOMPLETE][27] ([i915#12904]) -> [PASS][28] +1 other test pass
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-apl-1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-apl-1/igt@[email protected]

* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-nick: [INCOMPLETE][29] ([i915#12904]) -> [PASS][30] +1 other test pass
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html

* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [DMESG-FAIL][31] ([i915#12061]) -> [PASS][32] +1 other test pass
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-mtlp-6/igt@i915_selftest@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-mtlp-6/igt@i915_selftest@[email protected]
- bat-dg2-11: [DMESG-FAIL][33] ([i915#12061]) -> [PASS][34] +1 other test pass
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-dg2-11/igt@i915_selftest@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-dg2-11/igt@i915_selftest@[email protected]
- bat-dg2-14: [DMESG-FAIL][35] ([i915#12061]) -> [PASS][36] +1 other test pass
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16640/bat-dg2-14/igt@i915_selftest@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/bat-dg2-14/igt@i915_selftest@[email protected]

[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
[i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
[i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
[i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
[i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
[i915#11680]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11680
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
[i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
[i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
[i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
[i915#12637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12637
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#13736]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13736
[i915#14357]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14357
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809

Build changes
-------------

* Linux: CI_DRM_16640 -> Patchwork_147799v6

CI-20190529: 20190529
CI_DRM_16640: ba486e3b10ce5b4ee4d1ffc58aa4cc3b669c02a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8392: 8392
Patchwork_147799v6: ba486e3b10ce5b4ee4d1ffc58aa4cc3b669c02a3 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_147799v6/index.html