perf annotate: Support --code-with-type on TUI
Namhyung Kim
maintainerv2 cover perf annotate: Support --code-with-type on TUI
Hello,
The --code-with-type option is to show normal annotate output with type information. It was supported only on --stdio, but this change adds it to TUI as well.
v2 changes)
* use 'T' key to toggle data type display (Arnaldo)
* display '[Type]' in the title line when it's enabled (Arnaldo)
* show warning when debug info is not available (Arnaldo)
* fix a typo (Arnaldo)
Actually the command line option sets the default behavior and users can change it by pressing 'T' key in the TUI annotate browser.
The code is also available at 'perf/annotate-code-type-tui-v2' branch at
https://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (7):
perf annotate: Rename to __hist_entry__tui_annotate()
perf annotate: Remove __annotation_line__write()
perf annotate: Pass annotation_print_data to annotation_line__write() perf annotate: Simplify width calculation in annotation_line__write() perf annotate: Add --code-with-type support for TUI
perf annotate: Add 'T' hot key to toggle data type display perf annotate: Show warning when debuginfo is not available
tools/perf/Documentation/perf-annotate.txt | 1 - tools/perf/builtin-annotate.c | 5 - tools/perf/ui/browsers/annotate.c | 66 +++++++--- tools/perf/ui/browsers/hists.c | 2 +- tools/perf/util/annotate.c | 146 ++++++++++++++------- tools/perf/util/annotate.h | 27 ++-- tools/perf/util/dso.h | 11 ++ tools/perf/util/hist.h | 12 +- 8 files changed, 180 insertions(+), 90 deletions(-)
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 1/7 perf annotate: Rename to __hist_entry__tui_annotate()
There are three different but similar functions for annotation on TUI. Rename it to __hist_entry__tui_annotate() and make sure it passes 'he'. It's not used for now but it'll be needed for later use.
Also remove map_symbol__tui_annotate() which was a simple wrapper.
--- tools/perf/ui/browsers/annotate.c | 17 +++++++---------- tools/perf/ui/browsers/hists.c | 2 +- tools/perf/util/annotate.h | 12 ------------ tools/perf/util/hist.h | 12 +++++++----- 4 files changed, 15 insertions(+), 28 deletions(-)
tools/perf/ui/browsers/annotate.c +7 -10
@@ -27,6 +27,7 @@ struct annotate_browser {struct rb_node *curr_hot;struct annotation_line *selection;struct arch *arch; +struct hist_entry *he;bool searching_backwards;char search_bf[128 ]; };
@@ -483,7 +484,7 @@ static bool annotate_browser__callq(struct annotate_browser *browser, target_ms.map = ms->map; target_ms.sym = dl->ops.target.sym;annotation__unlock (notes); -symbol__tui_annotate (&target_ms, evsel, hbt); +__hist_entry__tui_annotate (browser->he, &target_ms, evsel, hbt);sym_title (ms->sym, ms->map, title,sizeof (title), annotate_opts.percent_type);ui_browser__show_title (&browser->b, title);return true;
@@ -958,12 +959,6 @@ static int annotate_browser__run(struct annotate_browser *browser,return key; } -int map_symbol__tui_annotate (struct map_symbol *ms,struct evsel *evsel, -struct hist_browser_timer *hbt) -{ -return symbol__tui_annotate (ms, evsel, hbt); -} -int hist_entry__tui_annotate (struct hist_entry *he,struct evsel *evsel,struct hist_browser_timer *hbt) {
@@ -972,11 +967,12 @@ int hist_entry__tui_annotate(struct hist_entry *he, struct evsel *evsel,SLang_init_tty (0 ,0 ,0 );SLtty_set_suspend_state (true); -return map_symbol__tui_annotate (&he->ms, evsel, hbt); +return __hist_entry__tui_annotate (he, &he->ms, evsel, hbt); } -int symbol__tui_annotate (struct map_symbol *ms,struct evsel *evsel, -struct hist_browser_timer *hbt) +int __hist_entry__tui_annotate (struct hist_entry *he,struct map_symbol *ms, +struct evsel *evsel, +struct hist_browser_timer *hbt) {struct symbol *sym = ms->sym;struct annotation *notes =symbol__annotation (sym);
@@ -990,6 +986,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel, .priv = ms, .use_navkeypressed = true, }, + .he = he, };struct dso *dso;int ret =-1 , err;
tools/perf/ui/browsers/hists.c +1 -1
@@ -2484,8 +2484,8 @@ do_annotate(struct hist_browser *browser, struct popup_action *act)else evsel =hists_to_evsel (browser->hists); - err =map_symbol__tui_annotate (&act->ms, evsel, browser->hbt); he =hist_browser__selected_entry (browser); + err =__hist_entry__tui_annotate (he, &act->ms, evsel, browser->hbt);/* * offer option to annotate the other branch source or target * (if they exists) when returning from annotate
tools/perf/util/annotate.h +0 -12
@@ -470,18 +470,6 @@ int hist_entry__annotate_printf(struct hist_entry *he, struct evsel *evsel);int hist_entry__tty_annotate (struct hist_entry *he,struct evsel *evsel);int hist_entry__tty_annotate2 (struct hist_entry *he,struct evsel *evsel); -#ifdef HAVE_SLANG_SUPPORT -int symbol__tui_annotate (struct map_symbol *ms,struct evsel *evsel, -struct hist_browser_timer *hbt); -#else -static inline int symbol__tui_annotate (struct map_symbol *ms__maybe_unused , -struct evsel *evsel__maybe_unused , -struct hist_browser_timer *hbt__maybe_unused ) -{ -return 0 ; -} -#endif -void annotation_options__init (void );void annotation_options__exit (void );
tools/perf/util/hist.h +7 -5
@@ -712,8 +712,9 @@ struct block_hist {#include "../ui/keysyms.h" void attr_to_script (char *buf,struct perf_event_attr *attr); -int map_symbol__tui_annotate (struct map_symbol *ms,struct evsel *evsel, -struct hist_browser_timer *hbt); +int __hist_entry__tui_annotate (struct hist_entry *he,struct map_symbol *ms, +struct evsel *evsel, +struct hist_browser_timer *hbt);int hist_entry__tui_annotate (struct hist_entry *he,struct evsel *evsel,struct hist_browser_timer *hbt);
@@ -741,9 +742,10 @@ int evlist__tui_browse_hists(struct evlist *evlist __maybe_unused, {return 0 ; } -static inline int map_symbol__tui_annotate (struct map_symbol *ms__maybe_unused , -struct evsel *evsel__maybe_unused , -struct hist_browser_timer *hbt__maybe_unused ) +static inline int __hist_entry__tui_annotate (struct hist_entry *he__maybe_unused , +struct map_symbol *ms__maybe_unused , +struct evsel *evsel__maybe_unused , +struct hist_browser_timer *hbt__maybe_unused ) {return 0 ; }
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 2/7 perf annotate: Remove __annotation_line__write()
In reply to Namhyung KimGet rid of the internal function and convert function arguments into local variables if they are used more than once.
--- tools/perf/util/annotate.c | 46 ++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 27 deletions(-)
tools/perf/util/annotate.c +19 -27
@@ -1934,24 +1934,26 @@ int annotation_br_cntr_entry(char **str, int br_cntr_nr,return -ENOMEM ; } -static void __annotation_line__write (struct annotation_line *al,struct annotation *notes, -bool first_line,bool current_entry,bool change_color,int width, -void *obj,unsigned int percent_type, -int (*obj__set_color)(void *obj,int color), -void (*obj__set_percent_color)(void *obj,double percent,bool current), -int (*obj__set_jumps_percent_color)(void *obj,int nr,bool current), -void (*obj__printf)(void *obj,const char *fmt, ...), -void (*obj__write_graph)(void *obj,int graph)) - -{ -double percent_max =annotation_line__max_percent (al, percent_type); -int pcnt_width =annotation__pcnt_width (notes), - cycles_width =annotation__cycles_width (notes); +void annotation_line__write (struct annotation_line *al,struct annotation *notes, +struct annotation_write_ops *wops) +{ +bool current_entry = wops->current_entry; +bool change_color = wops->change_color; +double percent_max =annotation_line__max_percent (al, annotate_opts.percent_type); +int width = wops->width; +int pcnt_width =annotation__pcnt_width (notes); +int cycles_width =annotation__cycles_width (notes);bool show_title = false;char bf[256 ];int printed; - -if (first_line && (al->offset ==-1 || percent_max ==0.0 )) { +void *obj = wops->obj; +int (*obj__set_color)(void *obj,int color) = wops->set_color; +void (*obj__set_percent_color)(void *obj,double percent,bool current) = wops->set_percent_color; +int (*obj__set_jumps_percent_color)(void *obj,int nr,bool current) = wops->set_jumps_percent_color; +void (*obj__printf)(void *obj,const char *fmt, ...) = wops->printf; +void (*obj__write_graph)(void *obj,int graph) = wops->write_graph; + +if (wops->first_line && (al->offset ==-1 || percent_max ==0.0 )) {if (notes->branch && al->cycles) {if (al->cycles->ipc ==0.0 && al->cycles->avg ==0 ) show_title = true;
@@ -1965,7 +1967,8 @@ static void __annotation_line__write(struct annotation_line *al, struct annotatifor (i =0 ; i < al->data_nr; i++) {double percent; - percent =annotation_data__percent (&al->data[i], percent_type); + percent =annotation_data__percent (&al->data[i], + annotate_opts.percent_type);obj__set_percent_color (obj, percent, current_entry);if (symbol_conf.show_total_period) {
@@ -2114,17 +2117,6 @@ static void __annotation_line__write(struct annotation_line *al, struct annotati } -void annotation_line__write (struct annotation_line *al,struct annotation *notes, -struct annotation_write_ops *wops) -{ -__annotation_line__write (al, notes, wops->first_line, wops->current_entry, - wops->change_color, wops->width, wops->obj, - annotate_opts.percent_type, - wops->set_color, wops->set_percent_color, - wops->set_jumps_percent_color, wops->printf, - wops->write_graph); -} -int symbol__annotate2 (struct map_symbol *ms,struct evsel *evsel,struct arch **parch) {
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 3/7 perf annotate: Pass annotation_print_data to annotation_line__write()
In reply to Namhyung KimIt will be used for data type display later.
--- tools/perf/ui/browsers/annotate.c | 13 ++++++++++-- tools/perf/util/annotate.c | 35 +++++++++++++++++-------------- tools/perf/util/annotate.h | 15 +++++++++++-- 3 files changed, 43 insertions(+), 20 deletions(-)
tools/perf/ui/browsers/annotate.c +11 -2
@@ -28,6 +28,8 @@ struct annotate_browser {struct annotation_line *selection;struct arch *arch;struct hist_entry *he; +struct debuginfo *dbg; +struct evsel *evsel;bool searching_backwards;char search_bf[128 ]; };
@@ -108,12 +110,18 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int .printf = annotate_browser__printf, .write_graph = annotate_browser__write_graph, }; +struct annotation_print_data apd = { + .he = ab->he, + .arch = ab->arch, + .evsel = ab->evsel, + .dbg = ab->dbg, + };/* The scroll bar isn't being used */ if (!browser->navkeypressed) ops.width +=1 ; -annotation_line__write (al, notes, &ops); +annotation_line__write (al, notes, &ops, &apd);if (ops.current_entry) ab->selection = al;
@@ -902,7 +910,7 @@ static int annotate_browser__run(struct annotate_browser *browser,continue ; }case 'P' : -map_symbol__annotation_dump (ms, evsel); +map_symbol__annotation_dump (ms, evsel, browser->he);continue ;case 't' :if (symbol_conf.show_total_period) {
@@ -987,6 +995,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms, .use_navkeypressed = true, }, .he = he, + .evsel = evsel, };struct dso *dso;int ret =-1 , err;
tools/perf/util/annotate.c +19 -16
@@ -765,15 +765,6 @@ __hist_entry__get_data_type(struct hist_entry *he, struct arch *arch, struct debuginfo *dbg, struct disasm_line *dl, int *type_offset); -struct annotation_print_data { -struct hist_entry *he; -struct evsel *evsel; -struct arch *arch; -struct debuginfo *dbg; -u64 start; -int addr_fmt_width; -}; - static int annotation_line__print(struct annotation_line *al, struct annotation_print_data *apd, struct annotation_options *opts, int printed,
@@ -1230,7 +1221,6 @@ int hist_entry__annotate_printf(struct hist_entry *he, struct evsel *evsel)struct annotation_print_data apd = { .he = he, .evsel = evsel, - .start =map__rip_2objdump (map, sym->start), };int printed =2 , queue_len =0 ;int more =0 ;
@@ -1357,7 +1347,8 @@ static void FILE__write_graph(void *fp, int graph)fputs (s, fp); } -static int symbol__annotate_fprintf2 (struct symbol *sym,FILE *fp) +static int symbol__annotate_fprintf2 (struct symbol *sym,FILE *fp, +struct annotation_print_data *apd) {struct annotation *notes =symbol__annotation (sym);struct annotation_write_ops wops = {
@@ -1374,7 +1365,7 @@ static int symbol__annotate_fprintf2(struct symbol *sym, FILE *fp)list_for_each_entry (al, ¬es->src->source, node) {if (annotation_line__filter (al))continue ; -annotation_line__write (al, notes, &wops); +annotation_line__write (al, notes, &wops, apd);fputc ('\n' , fp); wops.first_line = false; }
@@ -1382,13 +1373,18 @@ static int symbol__annotate_fprintf2(struct symbol *sym, FILE *fp)return 0 ; } -int map_symbol__annotation_dump (struct map_symbol *ms,struct evsel *evsel) +int map_symbol__annotation_dump (struct map_symbol *ms,struct evsel *evsel, +struct hist_entry *he) {const char *ev_name =evsel__name (evsel);char buf[1024 ];char *filename;int err =-1 ;FILE *fp; +struct annotation_print_data apd = { + .he = he, + .evsel = evsel, + };if (asprintf (&filename,"%s.annotation" , ms->sym->name) <0 )return -1 ;
@@ -1404,7 +1400,7 @@ int map_symbol__annotation_dump(struct map_symbol *ms, struct evsel *evsel)fprintf (fp,"%s() %s\nEvent: %s\n\n" , ms->sym->name,dso__long_name (map__dso (ms->map)), ev_name); -symbol__annotate_fprintf2 (ms->sym, fp); +symbol__annotate_fprintf2 (ms->sym, fp, &apd);fclose (fp); err =0 ;
@@ -1655,6 +1651,10 @@ int hist_entry__tty_annotate2(struct hist_entry *he, struct evsel *evsel)struct symbol *sym = ms->sym;struct rb_root source_line =RB_ROOT ;struct hists *hists =evsel__hists (evsel); +struct annotation_print_data apd = { + .he = he, + .evsel = evsel, + };char buf[1024 ];int err;
@@ -1677,7 +1677,7 @@ int hist_entry__tty_annotate2(struct hist_entry *he, struct evsel *evsel)hists__scnprintf_title (hists, buf,sizeof (buf));fprintf (stdout,"%s, [percent: %s]\n%s() %s\n" , buf,percent_type_str (annotate_opts.percent_type), sym->name,dso__long_name (dso)); -symbol__annotate_fprintf2 (sym, stdout); +symbol__annotate_fprintf2 (sym, stdout, &apd);annotated_source__purge (symbol__annotation (sym)->src);
@@ -1935,7 +1935,8 @@ int annotation_br_cntr_entry(char **str, int br_cntr_nr, }void annotation_line__write (struct annotation_line *al,struct annotation *notes, -struct annotation_write_ops *wops) +struct annotation_write_ops *wops, +struct annotation_print_data *apd) {bool current_entry = wops->current_entry;bool change_color = wops->change_color;
@@ -2113,6 +2114,8 @@ void annotation_line__write(struct annotation_line *al, struct annotation *notesdisasm_line__write (disasm_line (al), notes, obj, bf,sizeof (bf), obj__printf, obj__write_graph);obj__printf (obj,"%-*s" , width - pcnt_width - cycles_width -3 - printed, bf); + + (void )apd; } }
tools/perf/util/annotate.h +13 -2
@@ -199,8 +199,18 @@ struct annotation_write_ops {void (*write_graph)(void *obj,int graph); }; +struct annotation_print_data { +struct hist_entry *he; +struct evsel *evsel; +struct arch *arch; +struct debuginfo *dbg; +u64 start; +int addr_fmt_width; +}; +void annotation_line__write (struct annotation_line *al,struct annotation *notes, -struct annotation_write_ops *ops); +struct annotation_write_ops *ops, +struct annotation_print_data *apd); int __annotation__scnprintf_samples_period(struct annotation *notes, char *bf, size_t size,
@@ -462,7 +472,8 @@ void symbol__annotate_zero_histogram(struct symbol *sym, struct evsel *evsel);void symbol__annotate_decay_histogram (struct symbol *sym,struct evsel *evsel);void annotated_source__purge (struct annotated_source *as); -int map_symbol__annotation_dump (struct map_symbol *ms,struct evsel *evsel); +int map_symbol__annotation_dump (struct map_symbol *ms,struct evsel *evsel, +struct hist_entry *he);bool ui__has_annotation (void );
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 4/7 perf annotate: Simplify width calculation in annotation_line__write()
In reply to Namhyung KimThe width is updated after each part is printed. It can skip the output processing if the total printed size is bigger than the width.
No function changes intended.
--- tools/perf/util/annotate.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
tools/perf/util/annotate.c +7 -3
@@ -1992,6 +1992,7 @@ void annotation_line__write(struct annotation_line *al, struct annotation *notes symbol_conf.show_nr_samples ? "Samples" : "Percent"); } } + width -= pcnt_width;if (notes->branch) {if (al->cycles && al->cycles->ipc)
@@ -2055,11 +2056,12 @@ void annotation_line__write(struct annotation_line *al, struct annotation *notesobj__printf (obj,"%*s" ,ANNOTATION__AVG_IPC_WIDTH , bf); } } + width -= cycles_width;obj__printf (obj," " );if (!*al->line) -obj__printf (obj,"%-*s" , width - pcnt_width - cycles_width," " ); +obj__printf (obj,"%-*s" , width," " );else if (al->offset ==-1 ) {if (al->line_nr && annotate_opts.show_linenr) printed = scnprintf(bf, sizeof(bf), "%-*d ",
@@ -2068,7 +2070,7 @@ void annotation_line__write(struct annotation_line *al, struct annotation *notes printed =scnprintf (bf,sizeof (bf),"%-*s " , notes->src->widths.addr," " );obj__printf (obj, bf); -obj__printf (obj,"%-*s" , width - printed - pcnt_width - cycles_width +1 , al->line); +obj__printf (obj,"%-*s" , width - printed +1 , al->line); }else {u64 addr = al->offset;int color =-1 ;
@@ -2111,9 +2113,11 @@ void annotation_line__write(struct annotation_line *al, struct annotation *notesif (change_color)obj__set_color (obj, color); + width -= printed +3 ; +disasm_line__write (disasm_line (al), notes, obj, bf,sizeof (bf), obj__printf, obj__write_graph); -obj__printf (obj,"%-*s" , width - pcnt_width - cycles_width -3 - printed, bf); +obj__printf (obj,"%-*s" , width, bf); (void )apd; }
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 5/7 perf annotate: Add --code-with-type support for TUI
In reply to Namhyung KimUntil now, the --code-with-type option is available only on stdio. But it was an artifical limitation because of an implemention issue.
Implement the same logic in annotation_line__write() for stdio2/TUI. Make disasm_line__write() return the number of printed characters so that it can skip unnecessary operations when the screen is full.
Remove the limitation and update the man page.
--- tools/perf/Documentation/perf-annotate.txt | 1 - tools/perf/builtin-annotate.c | 5 -- tools/perf/ui/browsers/annotate.c | 6 +++ tools/perf/util/annotate.c | 61 +++++++++++++++++++--- 4 files changed, 61 insertions(+), 12 deletions(-)
tools/perf/Documentation/perf-annotate.txt +0 -1
@@ -170,7 +170,6 @@ include::itrace.txt[] --code-with-type:: Show data type info in code annotation (for memory instructions only). - Currently it only works with --stdio option. SEE ALSO
tools/perf/builtin-annotate.c +0 -5
@@ -917,11 +917,6 @@ int cmd_annotate(int argc, const char **argv) symbol_conf.annotate_data_sample = true; }else if (annotate_opts.code_with_type) { symbol_conf.annotate_data_member = true; - -if (!annotate.use_stdio) { -pr_err ("--code-with-type only works with --stdio.\n" ); - goto out_delete; - } }setup_browser (true);
tools/perf/ui/browsers/annotate.c +6 -0
@@ -4,6 +4,7 @@#include "../ui.h" #include "../../util/annotate.h" #include "../../util/debug.h" +#include "../../util/debuginfo.h" #include "../../util/dso.h" #include "../../util/hist.h" #include "../../util/sort.h"
@@ -1021,6 +1022,9 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,ui_helpline__push ("Press ESC to exit" ); +if (annotate_opts.code_with_type) + browser.dbg =debuginfo__new (dso__long_name (dso)); + browser.b.width = notes->src->widths.max_line_len; browser.b.nr_entries = notes->src->nr_entries; browser.b.entries = ¬es->src->source;
@@ -1031,6 +1035,8 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms, ret =annotate_browser__run (&browser, evsel, hbt); +if (annotate_opts.code_with_type) +debuginfo__delete (browser.dbg);if (not_annotated)annotated_source__purge (notes->src);
tools/perf/util/annotate.c +55 -6
93 lines not on this page · raw message
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 6/7 perf annotate: Add 'T' hot key to toggle data type display
In reply to Namhyung KimSupport data type display with a key press so that users can toggle the output dynamically on TUI. Also display "[Type]" in the title line if it's enabled.
--- tools/perf/ui/browsers/annotate.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
tools/perf/ui/browsers/annotate.c +12 -5
@@ -451,9 +451,10 @@ static void ui_browser__init_asm_mode(struct ui_browser *browser)static int sym_title (struct symbol *sym,struct map *map,char *title,size_t sz,int percent_type) { -return snprintf (title, sz,"%s %s [Percent: %s]" , sym->name, +return snprintf (title, sz,"%s %s [Percent: %s] %s" , sym->name,dso__long_name (map__dso (map)), -percent_type_str (percent_type)); +percent_type_str (percent_type), + annotate_opts.code_with_type ?"[Type]" :"" ); }/*
@@ -827,7 +828,8 @@ static int annotate_browser__run(struct annotate_browser *browser,"b Toggle percent base [period/hits]\n" "B Branch counter abbr list (Optional)\n" "? Search string backwards\n" - "f Toggle showing offsets to full address\n"); +"f Toggle showing offsets to full address\n" + "T Toggle data type display\n");continue ;case 'r' :script_browse (NULL ,NULL );
@@ -947,6 +949,12 @@ static int annotate_browser__run(struct annotate_browser *browser,case 'f' :annotation__toggle_full_addr (notes, ms);continue ; +case 'T' : + annotate_opts.code_with_type ^=1 ; +if (browser->dbg ==NULL ) + browser->dbg =debuginfo__new (dso__long_name (map__dso (ms->map))); +annotate_browser__show (&browser->b, title, help); +continue ;case K_LEFT :case '<' :case '>' :
@@ -1035,8 +1043,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms, ret =annotate_browser__run (&browser, evsel, hbt); -if (annotate_opts.code_with_type) -debuginfo__delete (browser.dbg); +debuginfo__delete (browser.dbg);if (not_annotated)annotated_source__purge (notes->src);
Signature · 1 line
2.49.0
Namhyung Kim
maintainerPATCH v2 7/7 perf annotate: Show warning when debuginfo is not available
In reply to Namhyung KimWhen user requests data-type annotation but no DWARF info is available, show a warning message about it.
Warning:
DWARF debuginfo not found.
Data-type in this DSO will not be displayed.
Please make sure to have debug information.
Press any key...
--- tools/perf/ui/browsers/annotate.c | 17 +++++++++++++++++ tools/perf/util/dso.h | 11 +++++++++++ 2 files changed, 28 insertions(+)
tools/perf/ui/browsers/annotate.c +17 -0
@@ -730,6 +730,20 @@ static int annotate__scnprintf_title(struct hists *hists, char *bf, size_t size)return printed; } +static void annotate_browser__debuginfo_warning (struct annotate_browser *browser) +{ +struct map_symbol *ms = browser->b.priv; +struct dso *dso =map__dso (ms->map); + +if (browser->dbg ==NULL && annotate_opts.code_with_type && + !dso__debuginfo_warned (dso)) { +ui__warning ("DWARF debuginfo not found.\n\n" +"Data-type in this DSO will not be displayed.\n" +"Please make sure to have debug information." ); +dso__set_debuginfo_warned (dso); + } +} +static int annotate_browser__run (struct annotate_browser *browser,struct evsel *evsel,struct hist_browser_timer *hbt)
@@ -760,6 +774,8 @@ static int annotate_browser__run(struct annotate_browser *browser,annotation_br_cntr_abbr_list (&br_cntr_text, evsel, false); +annotate_browser__debuginfo_warning (browser); +while (1 ) { key =ui_browser__run (&browser->b, delay_secs);
@@ -954,6 +970,7 @@ static int annotate_browser__run(struct annotate_browser *browser,if (browser->dbg ==NULL ) browser->dbg =debuginfo__new (dso__long_name (map__dso (ms->map)));annotate_browser__show (&browser->b, title, help); +annotate_browser__debuginfo_warning (browser);continue ;case K_LEFT :case '<' :
tools/perf/util/dso.h +11 -0
@@ -282,6 +282,7 @@ DECLARE_RC_STRUCT(dso) { u8 hit:1; u8 annotate_warned:1; u8 auxtrace_warned:1; + u8 debuginfo_warned:1; u8 short_name_allocated:1; u8 long_name_allocated:1; u8 is_64_bit:1;
@@ -342,6 +343,16 @@ static inline void dso__set_annotate_warned(struct dso *dso)RC_CHK_ACCESS (dso)->annotate_warned =1 ; } +static inline bool dso__debuginfo_warned (const struct dso *dso) +{ +return RC_CHK_ACCESS (dso)->debuginfo_warned; +} + +static inline void dso__set_debuginfo_warned (struct dso *dso) +{ +RC_CHK_ACCESS (dso)->debuginfo_warned =1 ; +} +static inline bool dso__auxtrace_warned (const struct dso *dso) {return RC_CHK_ACCESS (dso)->auxtrace_warned;
Signature · 1 line
2.49.0