Skip to content

perf annotate: Support --code-with-type on TUI

Namhyung Kim linux-perf-users lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 11 repliesIn review
  2. v49 patches 16 repliesSuperseded
  3. v38 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches0 repliesSuperseded
v16 patches9 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12perf annotate: Rename to __hist_entry__tui_annotate()tools/perf/ui/browsers/annotate.c tools/perf/ui/browsers/hists.c tools/perf/util/annotate.h +1 more+38 -280 replies
2/12perf annotate: Remove annotation_print_data.starttools/perf/util/annotate.c+2 -40 replies
3/12perf annotate: Remove __annotation_line__write()tools/perf/util/annotate.c tools/perf/util/annotate.h+20 -280 replies
4/12perf annotate: Pass annotation_print_data to annotation_line__write()tools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+43 -180 replies
5/12perf annotate: Simplify width calculation in annotation_line__write()tools/perf/util/annotate.c+9 -30 replies
6/12perf annotate: Return printed number from disasm_line__write()tools/perf/util/annotate.c+3 -30 replies
7/12perf annotate: Add --code-with-type support for TUItools/perf/Documentation/perf-annotate.txt tools/perf/builtin-annotate.c tools/perf/ui/browsers/annotate.c +1 more+50 -92 replies
8/12perf annotate: Add 'T' hot key to toggle data type displaytools/perf/ui/browsers/annotate.c+12 -52 replies
9/12perf annotate: Show warning when debuginfo is not availabletools/perf/ui/browsers/annotate.c tools/perf/util/dso.h+28 -00 replies
10/12perf annotate: Hide data-type for stack operation and canarytools/perf/util/annotate.c+13 -22 replies
11/12perf annotate: Add dso__debuginfo() helpertools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/dso.h+15 -50 replies
12/12perf annotate: Use a hashmap to save type datatools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+60 -32 replies

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by.

PatchIan RogersArnaldo Carvalho de Melo
SeriesT-b
1/12R-b
2/12
3/12
4/12R-b
5/12
6/12
7/12
8/12
9/12
10/12R-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCHSET v5 00/12] perf annotate: Support --code-with-type on TUI

Hello,

The --code-with-type option is to show normal annotate output with type information. It was supported only on --stdio, but this change adds it to TUI as well.

Arnaldo, please tell me if you still don't like the __hist_entry__tui_annotate() but I don't have a better idea for now.

v5 changes)
* use a copy of hist entry for perf top (Ian)
* split disasm_line__write() change (Ian)
* constify annotation_write_ops parameter (Ian)
* update printed length calculation (Ian)
* remove annotation_print_data.start
* add a hashmap to skip duplicate processing

v4 changes)
* add dso__debuginfo() helper (Ian)

v3 changes)
* hide stack operation and stack canary by default

v2 changes)
* use 'T' key to toggle data type display (Arnaldo)
* display '[Type]' in the title line when it's enabled (Arnaldo)
* show warning when debug info is not available (Arnaldo)
* fix a typo (Arnaldo)

Actually the command line option sets the default behavior and users can change it by pressing 'T' key in the TUI annotate browser.

The code is also available at 'perf/annotate-code-type-tui-v5' branch at
https://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (12):
perf annotate: Rename to __hist_entry__tui_annotate()
perf annotate: Remove annotation_print_data.start
perf annotate: Remove __annotation_line__write()
perf annotate: Pass annotation_print_data to annotation_line__write() perf annotate: Simplify width calculation in annotation_line__write() perf annotate: Return printed number from disasm_line__write() perf annotate: Add --code-with-type support for TUI
perf annotate: Add 'T' hot key to toggle data type display perf annotate: Show warning when debuginfo is not available perf annotate: Hide data-type for stack operation and canary perf annotate: Add dso__debuginfo() helper
perf annotate: Use a hashmap to save type data

 tools/perf/Documentation/perf-annotate.txt |   1 -
 tools/perf/builtin-annotate.c              |   5 -
 tools/perf/ui/browsers/annotate.c          | 117 ++++++++++++--
 tools/perf/ui/browsers/hists.c             |   2 +-
 tools/perf/util/annotate.c                 | 178 +++++++++++++++------
 tools/perf/util/annotate.h                 |  29 ++--
 tools/perf/util/dso.h                      |  21 +++
 tools/perf/util/hist.h                     |  12 +-
 8 files changed, 273 insertions(+), 92 deletions(-)
Signature · 1 line
2.50.1