Skip to contentSkip to conversation

wifi: ath9k: add ahb OF support

PATCH Applied Rosen Penev 5 participants 14 messages Jun 9, 2025 – Jul 2, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v5 cover wifi: ath9k: add ahb OF support

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)
Signature · 1 line
2.49.0
#1 lore raw

PATCH v5 1/5 wifi: ath9k: ahb: reorder declarations

Easier to look at. Follows netdev style.

Also remove ret assignment. Because of all of these devm conversions, ret = 0 is a path that never gets hit. The first time it does it when request_irq fails, but that ends up reassigning it.

---
 drivers/net/wireless/ath/ath9k/ahb.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/ath/ath9k/ahb.c +5 -5
index 49b7ab26c477..d2a97e74f451 100644
@@ -71,14 +71,14 @@ static const struct ath_bus_ops ath_ahb_bus_ops  = {
 
 static int ath_ahb_probe(struct platform_device *pdev)
 {
-	void __iomem *mem;
-	struct ath_softc *sc;
-	struct ieee80211_hw *hw;
 	const struct platform_device_id *id = platform_get_device_id(pdev);
-	int irq;
-	int ret = 0;
+	struct ieee80211_hw *hw;
+	struct ath_softc *sc;
 	struct ath_hw *ah;
+	void __iomem *mem;
 	char hw_name[64];
+	int irq;
+	int ret;
 
 	if (!dev_get_platdata(&pdev->dev)) {
 		dev_err(&pdev->dev, "no platform data specified\n");
Signature · 1 line
2.49.0
#2 lore raw

PATCH v5 2/5 wifi: ath9k: ahb: reorder includes

In reply to Rosen Penev

Alphabetic includes are easier to look at and to make further changes to them.

---
 drivers/net/wireless/ath/ath9k/ahb.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/ahb.c +3 -2
index d2a97e74f451..1ffec827ed87 100644
@@ -16,10 +16,11 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
 #include <linux/nl80211.h>
 #include <linux/platform_device.h>
-#include <linux/module.h>
-#include <linux/mod_devicetable.h>
+
 #include "ath9k.h"
 
 static const struct platform_device_id ath9k_platform_id_table[] = {
Signature · 1 line
2.49.0
#3 lore raw

PATCH v5 3/5 dt-bindings: net: wireless: ath9k: add WIFI bindings

In reply to Rosen Penev

These are for the wireless chips that come built in with various Atheros/QCA SoCs. dts wise, the difference between pcie and the wmac is

AHB > PCIE > WIFI
AHB > WIFI

---
 .../bindings/net/wireless/qca,ath9k.yaml       | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml +17 -1
index 0e5412cff2bc..d16ca8e0a25d 100644
@@ -12,7 +12,7 @@ maintainers:
 description: |
   This node provides properties for configuring the ath9k wireless device.
   The node is expected to be specified as a child node of the PCI controller
-  to which the wireless chip is connected.
+  or AHB bus to which the wireless chip is connected.
 
 allOf:
   - $ref: ieee80211.yaml#
@@ -35,6 +35,12 @@ properties:
       - pci168c,0034  # AR9462
       - pci168c,0036  # AR9565
       - pci168c,0037  # AR1111 and AR9485
+      - qca,ar9130-wifi
+      - qca,ar9330-wifi
+      - qca,ar9340-wifi
+      - qca,qca9530-wifi
+      - qca,qca9550-wifi
+      - qca,qca9560-wifi
 
   reg:
     maxItems: 1
@@ -88,3 +94,13 @@ examples:
         nvmem-cell-names = "mac-address", "calibration";
       };
     };
+  - |
+    ahb {
+      #address-cells = <1>;
+      #size-cells = <1>;
+      wifi@180c0000 {
+        compatible = "qca,ar9130-wifi";
+        reg = <0x180c0000 0x230000>;
+        interrupts = <2>;
+      };
+    };
Signature · 1 line
2.49.0
#4 lore raw

PATCH v5 4/5 wifi: ath9k: ahb: replace id_table with of

In reply to Rosen Penev

Since 2b0996c7646 , all of this platform code became no-op with no OF replacement. Not only that, there are no users of AHB here. Add an OF match table that mostly mirrors the original platform device id table. Use a qca prefix as is done for the only other property: qca,no-eeprom. Also used qca prefix for ar9530 as the latter seems to be a mistake.

This will be used to add ath9k support for the various ath79 devices here.

---
 drivers/net/wireless/ath/ath9k/ahb.c | 47 ++++++++--------------------
 1 file changed, 13 insertions(+), 34 deletions(-)
drivers/net/wireless/ath/ath9k/ahb.c +13 -34
index 1ffec827ed87..802e6596a6a8 100644
@@ -19,35 +19,18 @@
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/nl80211.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 
 #include "ath9k.h"
 
-static const struct platform_device_id ath9k_platform_id_table[] = {
-	{
-		.name = "ath9k",
-		.driver_data = AR5416_AR9100_DEVID,
-	},
-	{
-		.name = "ar933x_wmac",
-		.driver_data = AR9300_DEVID_AR9330,
-	},
-	{
-		.name = "ar934x_wmac",
-		.driver_data = AR9300_DEVID_AR9340,
-	},
-	{
-		.name = "qca955x_wmac",
-		.driver_data = AR9300_DEVID_QCA955X,
-	},
-	{
-		.name = "qca953x_wmac",
-		.driver_data = AR9300_DEVID_AR953X,
-	},
-	{
-		.name = "qca956x_wmac",
-		.driver_data = AR9300_DEVID_QCA956X,
-	},
+static const struct of_device_id ath9k_of_match_table[] = {
+	{ .compatible = "qca,ar9130-wifi", .data = (void *)AR5416_AR9100_DEVID },
+	{ .compatible = "qca,ar9330-wifi", .data = (void *)AR9300_DEVID_AR9330 },
+	{ .compatible = "qca,ar9340-wifi", .data = (void *)AR9300_DEVID_AR9340 },
+	{ .compatible = "qca,qca9530-wifi", .data = (void *)AR9300_DEVID_AR953X },
+	{ .compatible = "qca,qca9550-wifi", .data = (void *)AR9300_DEVID_QCA955X },
+	{ .compatible = "qca,qca9560-wifi", .data = (void *)AR9300_DEVID_QCA956X },
 	{},
 };
 
@@ -72,20 +55,15 @@ static const struct ath_bus_ops ath_ahb_bus_ops  = {
 
 static int ath_ahb_probe(struct platform_device *pdev)
 {
-	const struct platform_device_id *id = platform_get_device_id(pdev);
 	struct ieee80211_hw *hw;
 	struct ath_softc *sc;
 	struct ath_hw *ah;
 	void __iomem *mem;
 	char hw_name[64];
+	u16 dev_id;
 	int irq;
 	int ret;
 
-	if (!dev_get_platdata(&pdev->dev)) {
-		dev_err(&pdev->dev, "no platform data specified\n");
-		return -EINVAL;
-	}
-
 	mem = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mem)) {
 		dev_err(&pdev->dev, "ioremap failed\n");
@@ -118,7 +96,8 @@ static int ath_ahb_probe(struct platform_device *pdev)
 		goto err_free_hw;
 	}
 
-	ret = ath9k_init_device(id->driver_data, sc, &ath_ahb_bus_ops);
+	dev_id = (u16)(kernel_ulong_t)of_device_get_match_data(&pdev->dev);
+	ret = ath9k_init_device(dev_id, sc, &ath_ahb_bus_ops);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to initialize device\n");
 		goto err_irq;
@@ -156,11 +135,11 @@ static struct platform_driver ath_ahb_driver = {
 	.remove = ath_ahb_remove,
 	.driver = {
 		.name = "ath9k",
+		.of_match_table = ath9k_of_match_table,
 	},
-	.id_table = ath9k_platform_id_table,
 };
 
-MODULE_DEVICE_TABLE(platform, ath9k_platform_id_table);
+MODULE_DEVICE_TABLE(of, ath9k_of_match_table);
 
 int ath_ahb_init(void)
 {
Signature · 1 line
2.49.0
#5 lore raw

PATCH v5 5/5 mips: dts: qca: add wmac support

In reply to Rosen Penev

Now that OF ahb support was added to the ath9k driver, we can use it to enable and use the SoC wireless found in these chipsets.

---
 arch/mips/boot/dts/qca/ar9132.dtsi                       | 9 +++++++++
 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts         | 4 ++++
 arch/mips/boot/dts/qca/ar9331.dtsi                       | 9 +++++++++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts             | 4 ++++
 arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts           | 4 ++++
 arch/mips/boot/dts/qca/ar9331_omega.dts                  | 4 ++++
 .../mips/boot/dts/qca/ar9331_openembed_som9331_board.dts | 4 ++++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts              | 4 ++++
 8 files changed, 42 insertions(+)
arch/mips/boot/dts/qca/ar9132.dtsi +9 -0
index aa148d51ab68..682072371bd3 100644
@@ -155,6 +155,15 @@ spi: spi@1f000000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 		};
+
+		wifi: wifi@180c0000 {
+			compatible = "qca,ar9130-wifi";
+			reg = <0x180c0000 0x230000>;
+
+			interrupts = <2>;
+
+			status = "disabled";
+		};
 	};
 
 	usb_phy: usb-phy {
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts +4 -0
index f894fe17816b..a7901bb040ce 100644
@@ -108,3 +108,7 @@ partition@2 {
 		};
 	};
 };
+
+&wifi {
+	status = "okay";
+};
arch/mips/boot/dts/qca/ar9331.dtsi +9 -0
index 768ac0f869b1..6eb84a26a20f 100644
@@ -285,6 +285,15 @@ spi: spi@1f000000 {
 
 			status = "disabled";
 		};
+
+		wifi: wifi@18100000 {
+			compatible = "qca,ar9330-wifi";
+			reg = <0x18100000 0x20000>;
+
+			interrupts = <2>;
+
+			status = "disabled";
+		};
 	};
 
 	usb_phy: usb-phy {
arch/mips/boot/dts/qca/ar9331_dpt_module.dts +4 -0
index c857cd22f7db..08e728b8ced8 100644
@@ -97,3 +97,7 @@ &phy_port0 {
 &phy_port4 {
 	status = "okay";
 };
+
+&wifi {
+	status = "okay";
+};
arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts +4 -0
index 7affa58d4fa6..37a74aabe4b4 100644
@@ -98,3 +98,7 @@ spiflash: w25q128@0 {
 		reg = <0>;
 	};
 };
+
+&wifi {
+	status = "okay";
+};
arch/mips/boot/dts/qca/ar9331_omega.dts +4 -0
index 8904aa917a6e..1450419024cb 100644
@@ -74,3 +74,7 @@ spiflash: w25q128@0 {
 		reg = <0>;
 	};
 };
+
+&wifi {
+	status = "okay";
+};
arch/mips/boot/dts/qca/ar9331_openembed_som9331_board.dts +4 -0
index dc65ebd60bbc..5786a827c000 100644
@@ -106,3 +106,7 @@ &phy_port2 {
 &phy_port4 {
 	status = "okay";
 };
+
+&wifi {
+	status = "okay";
+};
arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts +4 -0
index 10b9759228b7..a7108c803eb3 100644
@@ -114,3 +114,7 @@ spiflash: s25sl032p@0 {
 		reg = <0>;
 	};
 };
+
+&wifi {
+	status = "okay";
+};
Signature · 1 line
2.49.0
maintainer Applied
#6 lore raw

Re: [PATCHv5 5/5] mips: dts: qca: add wmac support

Quoted 5 lines · Rosen Penev

Now that OF ahb support was added to the ath9k driver, we can use it to enable and use the SoC wireless found in these chipsets.

Quoted 10 lines
---
 arch/mips/boot/dts/qca/ar9132.dtsi                       | 9 +++++++++
 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts         | 4 ++++
 arch/mips/boot/dts/qca/ar9331.dtsi                       | 9 +++++++++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts             | 4 ++++
 arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts           | 4 ++++
 arch/mips/boot/dts/qca/ar9331_omega.dts                  | 4 ++++
 .../mips/boot/dts/qca/ar9331_openembed_som9331_board.dts | 4 ++++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts              | 4 ++++
 8 files changed, 42 insertions(+)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#7 lore raw
In reply to Rosen Penev
Quoted 17 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

Quoted 12 lines
 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)

DT team, should I take this series through my tree? Toke, Ack?

/jeff

#8 lore raw
Quoted 31 lines · Jeff Johnson
Quoted 17 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

Quoted 12 lines
 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)
Quoted 2 lines

DT team, should I take this series through my tree? Toke, Ack?

No, of course not. The same as you asked some time ago: DTS never, NEVER goes via driver subsystem tree.

Best regards,
Krzysztof

#9 lore raw
Quoted 32 lines · Krzysztof Kozlowski
Quoted 31 lines · Jeff Johnson
Quoted 29 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)
Quoted 5 lines
Quoted 2 lines

DT team, should I take this series through my tree? Toke, Ack?

No, of course not. The same as you asked some time ago: DTS never, NEVER goes via driver subsystem tree.

Heh, you do not have any subsystem maintainers acks or reviews on DTS, so this should not be considered. It's like me taking wireless patches without your acks.

Best regards,
Krzysztof

#10 lore raw
Quoted 35 lines · Krzysztof Kozlowski
Quoted 34 lines · Krzysztof Kozlowski
Quoted 33 lines · Jeff Johnson
Quoted 17 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

Quoted 12 lines
 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)

DT team, should I take this series through my tree? Toke, Ack?

Quoted 7 lines
Quoted 3 lines

No, of course not. The same as you asked some time ago: DTS never, NEVER goes via driver subsystem tree.

Heh, you do not have any subsystem maintainers acks or reviews on DTS, so this should not be considered. It's like me taking wireless patches without your acks.

That is why I was looking for clarification.
All the DT stuff had your R-B and hence why I asked Toke for his Ack. Will DT team take the entire series (I'm ok with that)?
Or just the DTS and I should take the rest?

/jeff

#11 lore raw
Quoted 40 lines · Jeff Johnson
Quoted 39 lines · Krzysztof Kozlowski
Quoted 37 lines · Krzysztof Kozlowski
Quoted 31 lines · Jeff Johnson
Quoted 17 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

Quoted 12 lines
 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)
Quoted 2 lines

DT team, should I take this series through my tree? Toke, Ack?

No, of course not. The same as you asked some time ago: DTS never, NEVER goes via driver subsystem tree.

Quoted 8 lines
Quoted 3 lines

Heh, you do not have any subsystem maintainers acks or reviews on DTS, so this should not be considered. It's like me taking wireless patches without your acks.

That is why I was looking for clarification.
All the DT stuff had your R-B and hence why I asked Toke for his Ack. Will DT team take the entire series (I'm ok with that)?
Or just the DTS and I should take the rest?

It's not the DT team, we are not taking any DTS patches ever but platform or SoC maintainers are taking DTS for their platform. So please take only your subsystem - wireless drivers and wireless DT bindings - leaving DTS for platform/SoC maintainers.

Best regards,
Krzysztof

maintainer Acked-by on the v5 series
#12 lore raw
In reply to Rosen Penev
Quoted 17 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
wifi: ath9k: ahb: reorder declarations
wifi: ath9k: ahb: reorder includes
wifi: ath9k: ahb: replace id_table with of
dt-bindings: net: wireless: ath9k: add OF bindings
mips: dts: qca: add wmac support

Quoted 14 lines
 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)
Signature · 1 line
2.49.0

For the ath9k bits:

Applied
#13 lore raw

Re: (subset) [PATCHv5 0/5] wifi: ath9k: add ahb OF support

In reply to Rosen Penev
Quoted 11 lines · Rosen Penev

First two commits are small cleanups to make the changes of the third simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between all the other drivers for MIPS based qualcomm devices. qcom as a prefix is used for Quallcomm's ARM(64) stuff.

[...]

Applied, thanks!

[1/5] wifi: ath9k: ahb: reorder declarations

      commit: 5cbfef9039f61691c87f522f8761d628033bc392
[2/5] wifi: ath9k: ahb: reorder includes
      commit: c8123302c01936d297e22adbd75cad38c5049f92
[3/5] dt-bindings: net: wireless: ath9k: add WIFI bindings
      commit: f902f2c39a807382353b4c6b8d8d4ac1f03aade9
[4/5] wifi: ath9k: ahb: replace id_table with of
      commit: 2fa490c0d7591918bed267059700f1c9e505e881

Best regards,

Signature · 1 line
Jeff Johnson <[email protected]>