Improve user feedback in case of FPGA bitstream load failure
Subsystems (2)
v4 cover Improve user feedback in case of FPGA bitstream load failure
From: Pieter Van Trappen <[email protected]>
The main motivation for this patch series is to make the fpga * commands' return message more explicit because simply returning the command usage without indicating the root cause is not helpful.
In addition, the sandbox_defconfig was amended to facilitate compiling fpga-based sources and various style, compiler errors and warnings have been fixed.
v4:
* make better use of prefixes in commit subjects
* change patches' order to ensure no commit introduces compiler warnings or errors i.e. defconfig is now patch 5/5
* add new patch 4/5 to remove compiler Werror=unused-function
* add an additional Kconfig dependency to patch 2/5
v3: https://lore.kernel.org/all/[email protected]/
* enable FPGA configs in sandbox_defconfig instead of new one
v2: https://lore.kernel.org/all/[email protected]/
* use log_* instead of puts() which is now preferred
* harmonize user feedback format; remove useless strings
* add a sandbox_fpga_defconfig; amend fpga Kconfig
* fix various compiler errors and warnings
v1: https://lore.kernel.org/all/[email protected]/
Pieter Van Trappen (5):
cmd: fpga: improve user feedback in case of bitstream load failure
drivers: fpga/firmware: add Kconfig dependencies
drivers: fpga: correct compiler errors and warnings
drivers: fpga: cleanup printf usage
configs: enable FPGA commands and drivers at sandbox_defconfig
cmd/fpga.c | 101 ++++++++++++++--------------- configs/sandbox_defconfig | 20 ++++++ drivers/firmware/Kconfig | 1 + drivers/fpga/ACEX1K.c | 1 + drivers/fpga/Kconfig | 1 + drivers/fpga/fpga.c | 103 ++++++++++++------------------ drivers/fpga/ivm_core.c | 1 + drivers/fpga/lattice.c | 4 +- drivers/fpga/spartan2.c | 1 + drivers/fpga/stratixII.c | 131 +++++++++++++++++--------------------- drivers/fpga/stratixv.c | 2 +- drivers/fpga/versalpl.c | 1 - drivers/fpga/virtex2.c | 2 + drivers/fpga/xilinx.c | 2 +- drivers/fpga/zynqmppl.c | 4 +- drivers/fpga/zynqpl.c | 4 +- include/fpga.h | 2 +- include/stratixII.h | 6 +- 18 files changed, 192 insertions(+), 195 deletions(-)
base-commit: 7598b469c16d97128d9c22839b06d94c5c331a7e
Signature · 1 line
2.48.1
PATCH v4 1/5 cmd: fpga: improve user feedback in case of bitstream load failure
From: Pieter Van Trappen <[email protected]>
In cmd/fpga.c, change some debug calls to log_err for important user feedback and use CMD_RET_FAILURE in favor of CMD_RET_USAGE due to its long output which hides the actual, useful return message. Change the remaining debug calls to log_debug. Remove all 'fpga:' and __func__ strings as log_* has this covered.
For do_fpga_loads, move up the do_fpga_check_params call for more consistent command output; use a constant instead of multiple '5' use.
In drivers/fpga/zynq*.c, change 'up to' to 'above' which corrects this confusing/wrong statement.
--- cmd/fpga.c | 99 +++++++++++++++++++++-------------------- drivers/fpga/zynqmppl.c | 4 +- drivers/fpga/zynqpl.c | 4 +- 3 files changed, 54 insertions(+), 53 deletions(-)
cmd/fpga.c +50 -49
@@ -28,7 +28,7 @@ static long do_fpga_get_device(char *arg)if (dev ==FPGA_INVALID_DEVICE && arg) dev =simple_strtol (arg,NULL ,16 ); -debug ("%s: device = %ld\n" , __func__, dev); +log_debug ("device = %ld\n" , dev);return dev; }
@@ -40,26 +40,26 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,size_t local_data_size;long local_fpga_data; -debug ("%s %d, %d\n" , __func__, argc, cmdtp->maxargs); +log_debug ("%d, %d\n" , argc, cmdtp->maxargs);if (argc != cmdtp->maxargs) { -debug ("fpga: incorrect parameters passed\n" ); -return CMD_RET_USAGE ; +log_err ("Incorrect number of parameters passed\n" ); +return CMD_RET_FAILURE ; } *dev =do_fpga_get_device (argv[0 ]); local_fpga_data =simple_strtol (argv[1 ],NULL ,16 );if (!local_fpga_data) { -debug ("fpga: zero fpga_data address\n" ); -return CMD_RET_USAGE ; +log_err ("Zero fpga_data address\n" ); +return CMD_RET_FAILURE ; } *fpga_data = local_fpga_data; local_data_size =hextoul (argv[2 ],NULL );if (!local_data_size) { -debug ("fpga: zero size\n" ); -return CMD_RET_USAGE ; +log_err ("Zero size\n" ); +return CMD_RET_FAILURE ; } *data_size = local_data_size;
@@ -70,51 +70,52 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,static int do_fpga_loads (struct cmd_tbl *cmdtp,int flag,int argc,char *const argv[]) { +struct fpga_secure_info fpga_sec_info; +const int pos_userkey =5 ;size_t data_size =0 ;long fpga_data, dev;int ret; -struct fpga_secure_info fpga_sec_info;memset (&fpga_sec_info,0 ,sizeof (fpga_sec_info)); -if (argc <5 ) { -debug ("fpga: incorrect parameters passed\n" ); -return CMD_RET_USAGE ; +if (argc < pos_userkey) { +log_err ("Too few parameters passed\n" ); +return CMD_RET_FAILURE ; } -if (argc ==6 ) +if (argc == pos_userkey +1 ) fpga_sec_info.userkey_addr = (u8 *)(uintptr_t ) -simple_strtoull (argv[5 ], +simple_strtoull (argv[pos_userkey],NULL ,16 );else /* * If 6th parameter is not passed then do_fpga_check_params * will get 5 instead of expected 6 which means that function -* return CMD_RET_USAGE. Increase number of params +1 to pass +* return CMD_RET_FAILURE. Increase number of params +1 to pass * this. */ argc++; + ret =do_fpga_check_params (&dev, &fpga_data, &data_size, + cmdtp, argc, argv); +if (ret) +return ret; + fpga_sec_info.encflag = (u8 )hextoul (argv[4 ],NULL ); fpga_sec_info.authflag = (u8 )hextoul (argv[3 ],NULL );if (fpga_sec_info.authflag >=FPGA_NO_ENC_OR_NO_AUTH && fpga_sec_info.encflag >=FPGA_NO_ENC_OR_NO_AUTH ) { -debug ("fpga: Use <fpga load> for NonSecure bitstream\n" ); -return CMD_RET_USAGE ; +log_err ("Use <fpga load> for NonSecure bitstream\n" ); +return CMD_RET_FAILURE ; }if (fpga_sec_info.encflag ==FPGA_ENC_USR_KEY && !fpga_sec_info.userkey_addr) { -debug ("fpga: User key not provided\n" ); -return CMD_RET_USAGE ; +log_err ("User key not provided\n" ); +return CMD_RET_FAILURE ; } - ret =do_fpga_check_params (&dev, &fpga_data, &data_size, - cmdtp, argc, argv); -if (ret) -return ret; -return fpga_loads (dev, (void *)fpga_data, data_size, &fpga_sec_info); }#endif
@@ -245,23 +246,23 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,ulong dev =do_fpga_get_device (argv[0 ]);char *datastr =env_get ("fpgadata" ); -debug ("fpga: argc %x, dev %lx, datastr %s\n" , argc, dev, datastr); +log_debug ("argc %x, dev %lx, datastr %s\n" , argc, dev, datastr);if (dev ==FPGA_INVALID_DEVICE ) { -debug ("fpga: Invalid fpga device\n" ); -return CMD_RET_USAGE ; +log_err ("Invalid fpga device\n" ); +return CMD_RET_FAILURE ; }if (argc ==0 && !datastr) { -debug ("fpga: No datastr passed\n" ); -return CMD_RET_USAGE ; +log_err ("No datastr passed\n" ); +return CMD_RET_FAILURE ; }if (argc ==2 ) { datastr = argv[1 ]; -debug ("fpga: Full command with two args\n" ); +log_debug ("Full command with two args\n" ); }else if (argc ==1 && !datastr) { -debug ("fpga: Dev is setup - fpgadata passed\n" ); +log_debug ("Dev is setup - fpgadata passed\n" ); datastr = argv[0 ]; }
@@ -269,20 +270,20 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,if (fit_parse_subimage (datastr, (ulong )fpga_data, &fit_addr, &fit_uname)) { fpga_data = (void *)fit_addr; -debug ("* fpga: subimage '%s' from FIT image " , - fit_uname); -debug ("at 0x%08lx\n" , fit_addr); +log_debug ("* fpga: subimage '%s' from FIT image " , + fit_uname); +log_debug ("at 0x%08lx\n" , fit_addr); } else#endif { fpga_data = (void *)hextoul (datastr,NULL ); -debug ("* fpga: cmdline image address = 0x%08lx\n" , - (ulong )fpga_data); +log_debug ("* fpga: cmdline image address = 0x%08lx\n" , + (ulong )fpga_data); } -debug ("%s: fpga_data = 0x%lx\n" , __func__, (ulong )fpga_data); +log_debug ("fpga_data = 0x%lx\n" , (ulong )fpga_data);if (!fpga_data) { -puts ("Zero fpga_data address\n" ); -return CMD_RET_USAGE ; +log_err ("Zero fpga_data address\n" ); +return CMD_RET_FAILURE ; }switch (genimg_get_format (fpga_data)) {
@@ -303,13 +304,13 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,if (gunzip ((void *)data, ~0UL , (void *)image_buf, &image_size) !=0 ) { -puts ("GUNZIP: error\n" ); +log_err ("Gunzip error\n" );return CMD_RET_FAILURE ; } data_size = image_size;#else -puts ("Gunzip image is not supported\n" ); -return 1 ; +log_err ("Gunzip image is not supported\n" ); +return CMD_RET_FAILURE ;#endif }else { data = (ulong )image_get_data (hdr);
@@ -327,12 +328,12 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,const void *fit_data;if (!fit_uname) { -puts ("No FIT subimage unit name\n" ); +log_err ("No FIT subimage unit name\n" );return CMD_RET_FAILURE ; }if (fit_check_format (fit_hdr,IMAGE_SIZE_INVAL )) { -puts ("Bad FIT image format\n" ); +log_err ("Bad FIT image format\n" );return CMD_RET_FAILURE ; }
@@ -348,7 +349,7 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc, }#endif default : -puts ("** Unknown image type\n" ); +log_err ("Unknown image type\n" );return CMD_RET_FAILURE ; } }
@@ -390,16 +391,16 @@ static int do_fpga_wrapper(struct cmd_tbl *cmdtp, int flag, int argc, fpga_cmd =find_cmd_tbl (argv[1 ], fpga_commands,ARRAY_SIZE (fpga_commands));if (!fpga_cmd) { -debug ("fpga: non existing command\n" ); -return CMD_RET_USAGE ; +log_err ("Non existing command\n" ); +return CMD_RET_FAILURE ; } argc -=2 ; argv +=2 ;if (argc > fpga_cmd->maxargs) { -debug ("fpga: more parameters passed\n" ); -return CMD_RET_USAGE ; +log_err ("Too many parameters passed\n" ); +return CMD_RET_FAILURE ; } ret = fpga_cmd->cmd (fpga_cmd, flag, argc, argv);
drivers/fpga/zynqmppl.c +2 -2
@@ -191,8 +191,8 @@ static int zynqmp_validate_bitstream(xilinx_desc *desc, const void *buf, }if ((ulong )buf <SZ_1M ) { -printf ("%s: Bitstream has to be placed up to 1MB (%px)\n" , - __func__, buf); +log_err ("Bitstream has to be placed above 1MB (%px)\n" , + buf);return FPGA_FAIL ; }
drivers/fpga/zynqpl.c +2 -2
@@ -360,8 +360,8 @@ static int zynq_validate_bitstream(xilinx_desc *desc, const void *buf, }if ((u32 )buf <SZ_1M ) { -printf ("%s: Bitstream has to be placed up to 1MB (%x)\n" , - __func__, (u32 )buf); +log_err ("Bitstream has to be placed above 1MB (%px)\n" , + (u32 )buf);return FPGA_FAIL ; }
Signature · 1 line
2.48.1
Michal Simek
maintainerRe: [PATCH v4 1/5] cmd: fpga: improve user feedback in case of bitstream load failure
Quoted 279 lines · On 7/5/25 22:57, [email protected] wrote:
From: Pieter Van Trappen <[email protected]>
In
cmd/fpga.c, change somedebugcalls tolog_errfor important user feedback and useCMD_RET_FAILUREin favor ofCMD_RET_USAGEdue to its long output which hides the actual, useful return message. Change the remainingdebugcalls tolog_debug. Remove all 'fpga:' and__func__strings as log_* has this covered.For
do_fpga_loads, move up thedo_fpga_check_paramscall for more consistent command output; use a constant instead of multiple '5' use.In
drivers/fpga/zynq*.c, change 'up to' to 'above' which corrects this confusing/wrong statement.Signed-off-by Pieter Van Trappen <[email protected]>--- cmd/fpga.c | 99 +++++++++++++++++++++-------------------- drivers/fpga/zynqmppl.c | 4 +- drivers/fpga/zynqpl.c | 4 +- 3 files changed, 54 insertions(+), 53 deletions(-)cmd/fpga.c +50
-49@@ -28,7 +28,7 @@ static long do_fpga_get_device(char *arg)if (dev ==FPGA_INVALID_DEVICE && arg) dev =simple_strtol (arg,NULL ,16 ); -debug ("%s: device = %ld\n" , __func__, dev); +log_debug ("device = %ld\n" , dev);return dev; }@@ -40,26 +40,26 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,size_t local_data_size;long local_fpga_data; -debug ("%s %d, %d\n" , __func__, argc, cmdtp->maxargs); +log_debug ("%d, %d\n" , argc, cmdtp->maxargs);if (argc != cmdtp->maxargs) { -debug ("fpga: incorrect parameters passed\n" ); -return CMD_RET_USAGE ; +log_err ("Incorrect number of parameters passed\n" ); +return CMD_RET_FAILURE ; } *dev =do_fpga_get_device (argv[0 ]); local_fpga_data =simple_strtol (argv[1 ],NULL ,16 );if (!local_fpga_data) { -debug ("fpga: zero fpga_data address\n" ); -return CMD_RET_USAGE ; +log_err ("Zero fpga_data address\n" ); +return CMD_RET_FAILURE ; } *fpga_data = local_fpga_data; local_data_size =hextoul (argv[2 ],NULL );if (!local_data_size) { -debug ("fpga: zero size\n" ); -return CMD_RET_USAGE ; +log_err ("Zero size\n" ); +return CMD_RET_FAILURE ; } *data_size = local_data_size;@@ -70,51 +70,52 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,static int do_fpga_loads (struct cmd_tbl *cmdtp,int flag,int argc,char *const argv[]) { +struct fpga_secure_info fpga_sec_info; +const int pos_userkey =5 ;size_t data_size =0 ;long fpga_data, dev;int ret; -struct fpga_secure_info fpga_sec_info;memset (&fpga_sec_info,0 ,sizeof (fpga_sec_info)); -if (argc <5 ) { -debug ("fpga: incorrect parameters passed\n" ); -return CMD_RET_USAGE ; +if (argc < pos_userkey) { +log_err ("Too few parameters passed\n" ); +return CMD_RET_FAILURE ; } -if (argc ==6 ) +if (argc == pos_userkey +1 ) fpga_sec_info.userkey_addr = (u8 *)(uintptr_t ) -simple_strtoull (argv[5 ], +simple_strtoull (argv[pos_userkey],NULL ,16 );else /* * If 6th parameter is not passed then do_fpga_check_params * will get 5 instead of expected 6 which means that function -* return CMD_RET_USAGE. Increase number of params +1 to pass +* return CMD_RET_FAILURE. Increase number of params +1 to pass * this. */ argc++; + ret =do_fpga_check_params (&dev, &fpga_data, &data_size, + cmdtp, argc, argv); +if (ret) +return ret; + fpga_sec_info.encflag = (u8 )hextoul (argv[4 ],NULL ); fpga_sec_info.authflag = (u8 )hextoul (argv[3 ],NULL );if (fpga_sec_info.authflag >=FPGA_NO_ENC_OR_NO_AUTH && fpga_sec_info.encflag >=FPGA_NO_ENC_OR_NO_AUTH ) { -debug ("fpga: Use <fpga load> for NonSecure bitstream\n" ); -return CMD_RET_USAGE ; +log_err ("Use <fpga load> for NonSecure bitstream\n" ); +return CMD_RET_FAILURE ; }if (fpga_sec_info.encflag ==FPGA_ENC_USR_KEY && !fpga_sec_info.userkey_addr) { -debug ("fpga: User key not provided\n" ); -return CMD_RET_USAGE ; +log_err ("User key not provided\n" ); +return CMD_RET_FAILURE ; } - ret =do_fpga_check_params (&dev, &fpga_data, &data_size, - cmdtp, argc, argv); -if (ret) -return ret; -return fpga_loads (dev, (void *)fpga_data, data_size, &fpga_sec_info); }#endif @@ -245,23 +246,23 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,ulong dev =do_fpga_get_device (argv[0 ]);char *datastr =env_get ("fpgadata" ); -debug ("fpga: argc %x, dev %lx, datastr %s\n" , argc, dev, datastr); +log_debug ("argc %x, dev %lx, datastr %s\n" , argc, dev, datastr);if (dev ==FPGA_INVALID_DEVICE ) { -debug ("fpga: Invalid fpga device\n" ); -return CMD_RET_USAGE ; +log_err ("Invalid fpga device\n" ); +return CMD_RET_FAILURE ; }if (argc ==0 && !datastr) { -debug ("fpga: No datastr passed\n" ); -return CMD_RET_USAGE ; +log_err ("No datastr passed\n" ); +return CMD_RET_FAILURE ; }if (argc ==2 ) { datastr = argv[1 ]; -debug ("fpga: Full command with two args\n" ); +log_debug ("Full command with two args\n" ); }else if (argc ==1 && !datastr) { -debug ("fpga: Dev is setup - fpgadata passed\n" ); +log_debug ("Dev is setup - fpgadata passed\n" ); datastr = argv[0 ]; }@@ -269,20 +270,20 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,if (fit_parse_subimage (datastr, (ulong )fpga_data, &fit_addr, &fit_uname)) { fpga_data = (void *)fit_addr; -debug ("* fpga: subimage '%s' from FIT image " , - fit_uname); -debug ("at 0x%08lx\n" , fit_addr); +log_debug ("* fpga: subimage '%s' from FIT image " , + fit_uname); +log_debug ("at 0x%08lx\n" , fit_addr); } else#endif { fpga_data = (void *)hextoul (datastr,NULL ); -debug ("* fpga: cmdline image address = 0x%08lx\n" , - (ulong )fpga_data); +log_debug ("* fpga: cmdline image address = 0x%08lx\n" , + (ulong )fpga_data); } -debug ("%s: fpga_data = 0x%lx\n" , __func__, (ulong )fpga_data); +log_debug ("fpga_data = 0x%lx\n" , (ulong )fpga_data);if (!fpga_data) { -puts ("Zero fpga_data address\n" ); -return CMD_RET_USAGE ; +log_err ("Zero fpga_data address\n" ); +return CMD_RET_FAILURE ; }switch (genimg_get_format (fpga_data)) {@@ -303,13 +304,13 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,if (gunzip ((void *)data, ~0UL , (void *)image_buf, &image_size) !=0 ) { -puts ("GUNZIP: error\n" ); +log_err ("Gunzip error\n" );return CMD_RET_FAILURE ; } data_size = image_size;#else -puts ("Gunzip image is not supported\n" ); -return 1 ; +log_err ("Gunzip image is not supported\n" ); +return CMD_RET_FAILURE ;#endif }else { data = (ulong )image_get_data (hdr);@@ -327,12 +328,12 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,const void *fit_data;if (!fit_uname) { -puts ("No FIT subimage unit name\n" ); +log_err ("No FIT subimage unit name\n" );return CMD_RET_FAILURE ; }if (fit_check_format (fit_hdr,IMAGE_SIZE_INVAL )) { -puts ("Bad FIT image format\n" ); +log_err ("Bad FIT image format\n" );return CMD_RET_FAILURE ; }@@ -348,7 +349,7 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc, }#endif default : -puts ("** Unknown image type\n" ); +log_err ("Unknown image type\n" );return CMD_RET_FAILURE ; } }@@ -390,16 +391,16 @@ static int do_fpga_wrapper(struct cmd_tbl *cmdtp, int flag, int argc, fpga_cmd =find_cmd_tbl (argv[1 ], fpga_commands,ARRAY_SIZE (fpga_commands));if (!fpga_cmd) { -debug ("fpga: non existing command\n" ); -return CMD_RET_USAGE ; +log_err ("Non existing command\n" ); +return CMD_RET_FAILURE ; } argc -=2 ; argv +=2 ;if (argc > fpga_cmd->maxargs) { -debug ("fpga: more parameters passed\n" ); -return CMD_RET_USAGE ; +log_err ("Too many parameters passed\n" ); +return CMD_RET_FAILURE ; } ret = fpga_cmd->cmd (fpga_cmd, flag, argc, argv);drivers/fpga/zynqmppl.c +2
-2@@ -191,8 +191,8 @@ static int zynqmp_validate_bitstream(xilinx_desc *desc, const void *buf, }if ((ulong )buf <SZ_1M ) { -printf ("%s: Bitstream has to be placed up to 1MB (%px)\n" , - __func__, buf); +log_err ("Bitstream has to be placed above 1MB (%px)\n" , + buf);return FPGA_FAIL ; }drivers/fpga/zynqpl.c +0
-0
drivers/fpga/zynqpl.c static int zynq_validate_bitstream(xilinx_desc *desc, const void *buf, · line 367
Quoted 10 lines
drivers/fpga/zynqpl.c +2
-2@@ -360,8 +360,8 @@ static int zynq_validate_bitstream(xilinx_desc *desc, const void *buf, }if ((u32 )buf <SZ_1M ) { -printf ("%s: Bitstream has to be placed up to 1MB (%x)\n" , - __func__, (u32 )buf); +log_err ("Bitstream has to be placed above 1MB (%px)\n" , + (u32 )buf);return FPGA_FAIL ; }
it is not 1:1 conversion which generates this error
In file included from drivers/fpga/zynqpl.c:12:drivers/fpga/zynqpl.c: In function 'zynq_validate_bitstream':drivers/fpga/zynqpl.c:363:25: warning: format '%p' expects argument of type 'void *', but argument 2 has type 'unsigned int' [-Wformat=]
363 | log_err("Bitstream has to be placed above 1MB (%px)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
364 | (u32)buf);
| ~~~~~~~~
| |
| unsigned intinclude/log.h:234:24: note: in definition of macro 'log'
234 | printf(_fmt, ##_args); \
| ^~~~drivers/fpga/zynqpl.c:363:17: note: in expansion of macro 'log_err'
363 | log_err("Bitstream has to be placed above 1MB (%px)\n",
| ^~~~~~~
drivers/fpga/zynqpl.c:363:65: note: format string is defined here
363 | log_err("Bitstream has to be placed above 1MB (%px)\n",
| ~^
| |
| void *
| %d CC boot/image-fdt.o
CC drivers/core/device-remove.o
M
PATCH v4 2/5 drivers: fpga/firmware: add Kconfig dependencies
In reply to [email protected]From: Pieter Van Trappen <[email protected]>
FPGA_SOCFPGA requires ARCH_SOCFPGA cause socfpga.c contains arch/arm/mach-socfpga/* include macros.
ZYNQMP_FIRMWARE requires ARCH_ZYNQMP cause firmware-zynqmp.c contains arch/arm/mach-zynqmp/* include macros.
--- drivers/firmware/Kconfig | 1 + drivers/fpga/Kconfig | 1 + 2 files changed, 2 insertions(+)
drivers/firmware/Kconfig +1 -0
@@ -29,6 +29,7 @@ config TI_SCI_PROTOCOL config ZYNQMP_FIRMWARE bool "ZynqMP Firmware interface" + depends on ARCH_ZYNQMP select FIRMWARE help Firmware interface driver is used by different
drivers/fpga/Kconfig +1 -0
@@ -15,6 +15,7 @@ config FPGA_ALTERA config FPGA_SOCFPGA bool "Enable Gen5 and Arria10 common FPGA drivers" + depends on ARCH_SOCFPGA select FPGA_ALTERA help Say Y here to enable the Gen5 and Arria10 common FPGA driver
Signature · 1 line
2.48.1
Michal Simek
maintainerRe: [PATCH v4 2/5] drivers: fpga/firmware: add Kconfig dependencies
Quoted 19 lines · On 7/5/25 22:57, [email protected] wrote:
From: Pieter Van Trappen <[email protected]>
FPGA_SOCFPGArequiresARCH_SOCFPGAcausesocfpga.ccontainsarch/arm/mach-socfpga/*include macros.
ZYNQMP_FIRMWARErequiresARCH_ZYNQMPcausefirmware-zynqmp.ccontainsarch/arm/mach-zynqmp/*include macros.Signed-off-by Pieter Van Trappen <[email protected]>--- drivers/firmware/Kconfig | 1 + drivers/fpga/Kconfig | 1 + 2 files changed, 2 insertions(+)drivers/firmware/Kconfig +0
-0
drivers/firmware/Kconfig config TI_SCI_PROTOCOL · line 32
Quoted 4 lines
drivers/firmware/Kconfig +1
-0@@ -29,6 +29,7 @@ config TI_SCI_PROTOCOL config ZYNQMP_FIRMWARE bool "ZynqMP Firmware interface" + depends on ARCH_ZYNQMP
This has been already fixed by
https://lore.kernel.org/all/[email protected]/
M
Re: [PATCH v4 2/5] drivers: fpga/firmware: add Kconfig dependencies
Quoted 29 lines · Michal Simek
Quoted 19 lines · On 7/5/25 22:57, [email protected] wrote:
From: Pieter Van Trappen <[email protected]>
FPGA_SOCFPGArequiresARCH_SOCFPGAcausesocfpga.ccontainsarch/arm/mach-socfpga/*include macros.
ZYNQMP_FIRMWARErequiresARCH_ZYNQMPcausefirmware-zynqmp.ccontainsarch/arm/mach-zynqmp/*include macros.Signed-off-by Pieter Van Trappen <[email protected]>---
drivers/firmware/Kconfig| 1 +
drivers/fpga/Kconfig | 1 +2 files changed, 2 insertions(+)drivers/firmware/Kconfig +0
-0@@ -29,6 +29,7 @@ config TI_SCI_PROTOCOLQuoted 3 lines
config
ZYNQMP_FIRMWARE
bool "ZynqMP Firmware interface"
+ depends onARCH_ZYNQMPThis has been already fixed by
https://lore.kernel.org/all/[email protected]/
Quoted 1 line
M
Right I see, also my dependencies are not complete. I rebased on next but I guess that commit didn't make it yet to the next tree.
I'll amend this and the other patches after your comments for a v5 patch set.
Thanks, Pieter
PATCH v4 3/5 drivers: fpga: correct compiler errors and warnings
In reply to [email protected]From: Pieter Van Trappen <[email protected]>
Errors reported by GCC 14.2 when enabling FPGA commands and drivers. Also many style fixes as reported by checkpatch.pl on the diffs. Most changes in stratixII.c which has been reorganized as well to avoid the top function prototypes.
No functional changes.
--- cmd/fpga.c | 2 +- drivers/fpga/ACEX1K.c | 1 + drivers/fpga/ivm_core.c | 1 + drivers/fpga/lattice.c | 4 +- drivers/fpga/spartan2.c | 1 + drivers/fpga/stratixII.c | 131 ++++++++++++++++++--------------------- drivers/fpga/stratixv.c | 2 +- drivers/fpga/versalpl.c | 1 - drivers/fpga/virtex2.c | 2 + include/stratixII.h | 6 +- 10 files changed, 72 insertions(+), 79 deletions(-)
cmd/fpga.c +1 -1
@@ -302,7 +302,7 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc, data =image_get_load (hdr); -if (gunzip ((void *)data, ~0UL , (void *)image_buf, +if (gunzip ((void *)data, ~0U , (void *)image_buf, &image_size) !=0 ) {log_err ("Gunzip error\n" );return CMD_RET_FAILURE ;
drivers/fpga/ACEX1K.c +1 -0
@@ -14,6 +14,7 @@#include <log.h> #include <ACEX1K.h> /* ACEX device family */ #include <linux/delay.h> +#include <time.h> /* Note: The assumption is that we cannot possibly run fast enough to * overrun the device (the Slave Parallel mode can free run at 50MHz).
drivers/fpga/ivm_core.c +1 -0
@@ -33,6 +33,7 @@#include <linux/string.h> #include <malloc.h> #include <lattice.h> +#include <vsprintf.h> #define vme_out_char (c) printf("%c", c)#define vme_out_hex (c) printf("%x", c)
drivers/fpga/lattice.c +2 -2
@@ -350,8 +350,8 @@ int lattice_info(Lattice_desc *desc)printf ("Unsupported interface type, %d\n" , desc->iface); } -printf ("Device Size: \t%d bytes\n" , - desc->size); +printf ("Device Size: \t%zu bytes\n" , + desc->size);if (desc->iface_fns) { printf("Device Function Table @ 0x%p\n",
drivers/fpga/spartan2.c +1 -0
@@ -9,6 +9,7 @@#include <config.h> /* core U-Boot definitions */ #include <log.h> #include <spartan2.h> /* Spartan-II device family */ +#include <time.h> /* Note: The assumption is that we cannot possibly run fast enough to * overrun the device (the Slave Parallel mode can free run at 50MHz).
drivers/fpga/stratixII.c +60 -71
193 lines not on this page · raw message
drivers/fpga/stratixv.c +1 -1
@@ -48,7 +48,7 @@ int stratixv_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size)int spi_dev;int ret =0 ; -if ((u32 )rbf_data &0x3 ) { +if ((size_t )rbf_data &0x3 ) {puts ("FPGA: Unaligned data, realign to 32bit boundary.\n" );return -EINVAL ; }
drivers/fpga/versalpl.c +0 -1
@@ -6,7 +6,6 @@#include <cpu_func.h> #include <log.h> -#include <asm/arch/sys_proto.h> #include <memalign.h> #include <versalpl.h> #include <zynqmp_firmware.h>
drivers/fpga/virtex2.c +2 -0
@@ -19,6 +19,7 @@#include <log.h> #include <virtex2.h> #include <linux/delay.h> +#include <time.h> /* * If the SelectMap interface can be overrun by the processor, enable
@@ -301,6 +302,7 @@ static int virtex2_ssm_load(xilinx_desc *desc, const void *buf, size_t bsize)size_t bytecount =0 ;unsigned char *data = (unsigned char *)buf;int cookie = desc->cookie; +unsigned long ts; ret_val =virtex2_slave_pre (fn, cookie);if (ret_val !=FPGA_SUCCESS )
include/stratixII.h +3 -3
@@ -6,8 +6,8 @@#ifndef _STRATIXII_H_#define _STRATIXII_H_ -extern int StratixII_load (Altera_desc * desc,void *image,size_t size); -extern int StratixII_dump (Altera_desc * desc,void *buf,size_t bsize); -extern int StratixII_info (Altera_desc * desc); +int StratixII_load (Altera_desc *desc,const void *buf,size_t size); +int StratixII_dump (Altera_desc *desc,const void *buf,size_t bsize); +int StratixII_info (Altera_desc *desc);#endif /* _STRATIXII_H_ */
Signature · 1 line
2.48.1
PATCH v4 4/5 drivers: fpga: cleanup printf usage
In reply to [email protected]From: Pieter Van Trappen <[email protected]>
Remove fpga_no_sup to get rid of Werror=unused-function when all FPGA configurations are enabled.
Swap all printf calls to log_* as this is now preferred and includes the calling __func__.
--- drivers/fpga/fpga.c | 103 +++++++++++++++++------------------------- drivers/fpga/xilinx.c | 2 +- include/fpga.h | 2 +- 3 files changed, 44 insertions(+), 63 deletions(-)
drivers/fpga/fpga.c +42 -61
@@ -16,20 +16,6 @@static int next_desc =FPGA_INVALID_DEVICE ;static fpga_desc desc_table[CONFIG_MAX_FPGA_DEVICES ]; -/* -* fpga_no_sup -* 'no support' message function -*/ -static void fpga_no_sup (char *fn,char *msg) -{ -if (fn && msg) -printf ("%s: No support for %s.\n" , fn, msg); -else if (msg) -printf ("No support for %s.\n" , msg); -else -printf ("No FPGA support!\n" ); -} -/* fpga_get_desc * map a device number to a descriptor */
@@ -39,8 +25,8 @@ const fpga_desc *fpga_get_desc(int devnum)if ((devnum >=0 ) && (devnum < next_desc)) { desc = &desc_table[devnum]; -debug ("%s: found fpga descriptor #%d @ 0x%p\n" , - __func__, devnum, desc); +log_debug ("found fpga descriptor #%d @ 0x%p\n" , + devnum, desc); }return desc;
@@ -51,15 +37,15 @@ const fpga_desc *fpga_get_desc(int devnum)* generic parameter checking code */ const fpga_desc *fpga_validate (int devnum,const void *buf, -size_t bsize,char *fn) +size_t bsize) {const fpga_desc *desc =fpga_get_desc (devnum);if (!desc) -printf ("%s: Invalid device number %d\n" , fn, devnum); +log_err ("Invalid device number %d\n" , devnum);if (!buf) { -printf ("%s: Null buffer.\n" , fn); +log_err ("Null buffer.\n" );return NULL ; }return desc;
@@ -75,40 +61,40 @@ static int fpga_dev_info(int devnum)const fpga_desc *desc =fpga_get_desc (devnum);if (desc) { -debug ("%s: Device Descriptor @ 0x%p\n" , - __func__, desc->devdesc); +log_info ("Device Descriptor @ 0x%p\n" , + desc->devdesc);switch (desc->devtype) {case fpga_xilinx:#if defined(CONFIG_FPGA_XILINX ) -printf ("Xilinx Device\nDescriptor @ 0x%p\n" , desc); +log_info ("Xilinx Device\nDescriptor @ 0x%p\n" , desc); ret_val =xilinx_info (desc->devdesc);#else -fpga_no_sup ((char *)__func__,"Xilinx devices" ); +log_err ("No support for Xilinx devices.\n" );#endif break ;case fpga_altera:#if defined(CONFIG_FPGA_ALTERA ) -printf ("Altera Device\nDescriptor @ 0x%p\n" , desc); +log_info ("Altera Device\nDescriptor @ 0x%p\n" , desc); ret_val =altera_info (desc->devdesc);#else -fpga_no_sup ((char *)__func__,"Altera devices" ); +log_err ("No support for Altera devices.\n" );#endif break ;case fpga_lattice:#if defined(CONFIG_FPGA_LATTICE ) -printf ("Lattice Device\nDescriptor @ 0x%p\n" , desc); +log_info ("Lattice Device\nDescriptor @ 0x%p\n" , desc); ret_val =lattice_info (desc->devdesc);#else -fpga_no_sup ((char *)__func__,"Lattice devices" ); +log_err ("No support for Lattice devices.\n" );#endif break ;default : -printf ("%s: Invalid or unsupported device type %d\n" , - __func__, desc->devtype); +log_err ("Invalid or unsupported device type %d\n" , + desc->devtype); } }else { -printf ("%s: Invalid device number %d\n" , __func__, devnum); +log_err ("Invalid device number %d\n" , devnum); }return ret_val;
@@ -144,23 +130,22 @@ int fpga_add(fpga_type devtype, void *desc)int devnum =FPGA_INVALID_DEVICE ;if (!desc) { -printf ("%s: NULL device descriptor\n" , __func__); +log_err ("NULL device descriptor\n" );return devnum; }if (next_desc <0 ) { -printf ("%s: FPGA support not initialized!\n" , __func__); +log_err ("FPGA support not initialized!\n" ); }else if ((devtype > fpga_min_type) && (devtype < fpga_undefined)) {if (next_desc <CONFIG_MAX_FPGA_DEVICES ) { devnum = next_desc; desc_table[next_desc].devtype = devtype; desc_table[next_desc++].devdesc = desc; }else { -printf ("%s: Exceeded Max FPGA device count\n" , - __func__); +log_err ("Exceeded Max FPGA device count\n" ); } }else { -printf ("%s: Unsupported FPGA type %d\n" , __func__, devtype); +log_err ("Unsupported FPGA type %d\n" , devtype); }return devnum;
@@ -181,7 +166,7 @@ int __weak fpga_is_partial_data(int devnum, size_t img_len)int __weak fpga_loadbitstream (int devnum,char *fpgadata,size_t size,bitstream_type bstype) { -printf ("Bitstream support not implemented for this FPGA device\n" ); +log_err ("Bitstream support not implemented for this FPGA device\n" );return FPGA_FAIL ; }
@@ -190,8 +175,7 @@ int fpga_fsload(int devnum, const void *buf, size_t size, fpga_fs_info *fpga_fsinfo) {int ret_val =FPGA_FAIL ;/* assume failure */ -const fpga_desc *desc =fpga_validate (devnum, buf, size, - (char *)__func__); +const fpga_desc *desc =fpga_validate (devnum, buf, size);if (desc) {switch (desc->devtype) {
@@ -200,12 +184,12 @@ int fpga_fsload(int devnum, const void *buf, size_t size, ret_val =xilinx_loadfs (desc->devdesc, buf, size, fpga_fsinfo);#else -fpga_no_sup ((char *)__func__,"Xilinx devices" ); +log_err ("No support for Xilinx devices.\n" );#endif break ;default : -printf ("%s: Invalid or unsupported device type %d\n" , - __func__, desc->devtype); +log_err ("Invalid or unsupported device type %d\n" , + desc->devtype); } }
@@ -219,8 +203,7 @@ int fpga_loads(int devnum, const void *buf, size_t size, {int ret_val =FPGA_FAIL ; -const fpga_desc *desc =fpga_validate (devnum, buf, size, - (char *)__func__); +const fpga_desc *desc =fpga_validate (devnum, buf, size);if (desc) {switch (desc->devtype) {
@@ -229,12 +212,12 @@ int fpga_loads(int devnum, const void *buf, size_t size, ret_val =xilinx_loads (desc->devdesc, buf, size, fpga_sec_info);#else -fpga_no_sup ((char *)__func__,"Xilinx devices" ); +log_err ("No support for Xilinx devices.\n" );#endif break ;default : -printf ("%s: Invalid or unsupported device type %d\n" , - __func__, desc->devtype); +log_err ("Invalid or unsupported device type %d\n" , + desc->devtype); } }
@@ -265,8 +248,7 @@ int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype, {int ret_val =FPGA_FAIL ;/* assume failure */ int ret_notify; -const fpga_desc *desc =fpga_validate (devnum, buf, bsize, - (char *)__func__); +const fpga_desc *desc =fpga_validate (devnum, buf, bsize);if (desc) {switch (desc->devtype) {
@@ -275,26 +257,26 @@ int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype, ret_val =xilinx_load (desc->devdesc, buf, bsize, bstype, flags);#else -fpga_no_sup ((char *)__func__,"Xilinx devices" ); +log_err ("No support for Xilinx devices.\n" );#endif break ;case fpga_altera:#if defined(CONFIG_FPGA_ALTERA ) ret_val =altera_load (desc->devdesc, buf, bsize);#else -fpga_no_sup ((char *)__func__,"Altera devices" ); +log_err ("No support for Altera devices.\n" );#endif break ;case fpga_lattice:#if defined(CONFIG_FPGA_LATTICE ) ret_val =lattice_load (desc->devdesc, buf, bsize);#else -fpga_no_sup ((char *)__func__,"Lattice devices" ); +log_err ("No support for Lattice devices.\n" );#endif break ;default : -printf ("%s: Invalid or unsupported device type %d\n" , - __func__, desc->devtype); +log_err ("Invalid or unsupported device type %d\n" , + desc->devtype); } }
@@ -312,8 +294,7 @@ int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype,int fpga_dump (int devnum,const void *buf,size_t bsize) {int ret_val =FPGA_FAIL ;/* assume failure */ -const fpga_desc *desc =fpga_validate (devnum, buf, bsize, - (char *)__func__); +const fpga_desc *desc =fpga_validate (devnum, buf, bsize);if (desc) {switch (desc->devtype) {
@@ -321,26 +302,26 @@ int fpga_dump(int devnum, const void *buf, size_t bsize)#if defined(CONFIG_FPGA_XILINX ) ret_val =xilinx_dump (desc->devdesc, buf, bsize);#else -fpga_no_sup ((char *)__func__,"Xilinx devices" ); +log_err ("No support for Xilinx devices.\n" );#endif break ;case fpga_altera:#if defined(CONFIG_FPGA_ALTERA ) ret_val =altera_dump (desc->devdesc, buf, bsize);#else -fpga_no_sup ((char *)__func__,"Altera devices" ); +log_err ("No support for Altera devices.\n" );#endif break ;case fpga_lattice:#if defined(CONFIG_FPGA_LATTICE ) ret_val =lattice_dump (desc->devdesc, buf, bsize);#else -fpga_no_sup ((char *)__func__,"Lattice devices" ); +log_err ("No support for Lattice devices.\n" );#endif break ;default : -printf ("%s: Invalid or unsupported device type %d\n" , - __func__, desc->devtype); +log_err ("Invalid or unsupported device type %d\n" , + desc->devtype); } }
@@ -363,7 +344,7 @@ int fpga_info(int devnum)return FPGA_SUCCESS ; }else { -printf ("%s: No FPGA devices available.\n" , __func__); +log_err ("No FPGA devices available.\n" );return FPGA_FAIL ; } }
drivers/fpga/xilinx.c +1 -1
@@ -49,7 +49,7 @@ int fpga_loadbitstream(int devnum, char *fpgadata, size_t size, dataptr = (unsigned char *)fpgadata;/* Find out fpga_description */ - desc =fpga_validate (devnum, dataptr,0 , (char *)__func__); + desc =fpga_validate (devnum, dataptr,0 );/* Assign xilinx device description */ xdesc = desc->devdesc;
include/fpga.h +1 -1
@@ -79,7 +79,7 @@ int fpga_loadbitstream(int devnum, char *fpgadata, size_t size,int fpga_dump (int devnum,const void *buf,size_t bsize);int fpga_info (int devnum);const fpga_desc *fpga_validate (int devnum,const void *buf, -size_t bsize,char *fn); +size_t bsize);int fpga_compatible2flag (int devnum,const char *compatible);#endif /* _FPGA_H_ */
Signature · 1 line
2.48.1
PATCH v4 5/5 configs: enable FPGA commands and drivers at sandbox_defconfig
In reply to [email protected]From: Pieter Van Trappen <[email protected]>
Enable to facilitate compiler checks on most FPGA-related sources.
--- configs/sandbox_defconfig | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
configs/sandbox_defconfig +20 -0
@@ -78,6 +78,11 @@ CONFIG_CMD_MX_CYCLIC=y CONFIG_CMD_MEMTEST=y CONFIG_CMD_CLK=y CONFIG_CMD_DEMO=y +CONFIG_CMD_FPGA_LOADP=y +CONFIG_CMD_FPGA_LOADBP=y +CONFIG_CMD_FPGA_LOADFS=y +CONFIG_CMD_FPGA_LOADMK=y +CONFIG_CMD_FPGA_LOAD_SECURE=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPIO_READ=y CONFIG_CMD_PWM=y
@@ -196,6 +201,21 @@ CONFIG_SANDBOX_DMA=y CONFIG_FASTBOOT_FLASH=y CONFIG_FASTBOOT_FLASH_MMC_DEV=0 CONFIG_ARM_FFA_TRANSPORT=y +CONFIG_FPGA_ALTERA=y +CONFIG_FPGA_STRATIX_II=y +CONFIG_FPGA_STRATIX_V=y +CONFIG_FPGA_ACEX1K=y +CONFIG_FPGA_CYCLON2=y +CONFIG_FPGA_LATTICE=y +CONFIG_FPGA_XILINX=y +CONFIG_FPGA_VERSALPL=y +CONFIG_FPGA_SPARTAN2=y +CONFIG_FPGA_SPARTAN3=y +CONFIG_FPGA_VIRTEX2=y +CONFIG_SYS_FPGA_CHECK_BUSY=y +CONFIG_SYS_FPGA_CHECK_CTRLC=y +CONFIG_DM_FPGA=y +CONFIG_SANDBOX_FPGA=y CONFIG_GPIO_HOG=y CONFIG_DM_GPIO_LOOKUP_LABEL=y CONFIG_QCOM_PMIC_GPIO=y
Signature · 1 line
2.48.1
Michal Simek
maintainerRe: [PATCH v4 5/5] configs: enable FPGA commands and drivers at sandbox_defconfig
Quoted 26 lines · On 7/5/25 22:57, [email protected] wrote:
From: Pieter Van Trappen <[email protected]>
Enable to facilitate compiler checks on most FPGA-related sources.
Signed-off-by Pieter Van Trappen <[email protected]>--- configs/sandbox_defconfig | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)configs/sandbox_defconfig +5
-0@@ -78,6 +78,11 @@ CONFIG_CMD_MX_CYCLIC=y CONFIG_CMD_MEMTEST=y CONFIG_CMD_CLK=y CONFIG_CMD_DEMO=y +CONFIG_CMD_FPGA_LOADP=y +CONFIG_CMD_FPGA_LOADBP=y +CONFIG_CMD_FPGA_LOADFS=y +CONFIG_CMD_FPGA_LOADMK=y +CONFIG_CMD_FPGA_LOAD_SECURE=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPIO_READ=y CONFIG_CMD_PWM=y
configs/sandbox_defconfig CONFIG_SANDBOX_DMA=y · line 209
Quoted 9 lines
configs/sandbox_defconfig +6
-0@@ -196,6 +201,21 @@ CONFIG_SANDBOX_DMA=y CONFIG_FASTBOOT_FLASH=y CONFIG_FASTBOOT_FLASH_MMC_DEV=0 CONFIG_ARM_FFA_TRANSPORT=y +CONFIG_FPGA_ALTERA=y +CONFIG_FPGA_STRATIX_II=y +CONFIG_FPGA_STRATIX_V=y +CONFIG_FPGA_ACEX1K=y +CONFIG_FPGA_CYCLON2=y +CONFIG_FPGA_LATTICE=y
CI is reporting issues with clang.
make sandbox_defconfig
make -j HOSTCC=clang CC=clang
CC drivers/fpga/lattice.o
AR drivers/usb/eth/built-in.odrivers/fpga/ivm_core.c:593:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
593 | long int ispVMDataSize()
| ^
| voiddrivers/fpga/ivm_core.c:618:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
618 | signed char ispVM CC drivers/i2c/i2c-gpio.oCode()
| ^
| voiddrivers/fpga/ivm_core.c:1117:26: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
1117 | signed char ispVMDataCode()
| ^
| void
CC drivers/gpio/qcom_pmic_gpio.o
drivers/fpga/ivm_core.c:2479:16: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
2479 | void ispVMStart()
| ^
| void
drivers/fpga/ivm_core.c:2508:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
2508 | void ispVMEnd()
| ^
| void CC cmd/iotrace.o
5 errors generated.
make[3]: *** [scripts/Makefile.build:249: drivers/fpga/ivm_core.o] Error 1 make[3]: *** Waiting for unfinished jobs....
CC cmd/hash.o
M