Improve user feedback in case of FPGA bitstream load failure
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 1 replyApplied
- v45 patches 4 repliesSuperseded
- v34 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 1 reply | Superseded | |
| v1 | 1 patch | 7 replies | Superseded |
Changes in v5 from the cover letter
* add new patch 5/6 to fix Wstrict-prototypes error, reported by clang
* revert sprintf format to original in patch 1/6 zynqpl.c
* remove Kconfig new dependency in patch 2/6, fixed upstream already
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | cmd: fpga: improve user feedback in case of bitstream load failurecmd/ drivers/ drivers/ | +54 | 0 replies | |
| 2/6 | drivers: fpga: add Kconfig dependencydrivers/ | +1 | 0 replies | |
| 3/6 | drivers: fpga: correct compiler errors and warningscmd/ drivers/ drivers/ +7 more | +73 | 0 replies | |
| 4/6 | drivers: fpga: cleanup printf usagedrivers/ drivers/ include/ | +44 | 0 replies | |
| 5/6 | drivers: fpga: fix function declaration without a prototypedrivers/ | +6 | 0 replies | |
| 6/6 | configs: enable FPGA commands and drivers at sandbox_defconfigconfigs/ | +20 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/6] Improve user feedback in case of FPGA bitstream load failure
From: Pieter Van Trappen <[email protected]>
The main motivation for this patch series is to make the fpga * commands' return message more explicit because simply returning the command usage without indicating the root cause is not helpful.
In addition, the sandbox_defconfig was amended to facilitate compiling fpga-based sources and various style, compiler errors and warnings have been fixed.
v5:
* add new patch 5/6 to fix Wstrict-prototypes error, reported by clang
* revert sprintf format to original in patch 1/6 zynqpl.c
* remove Kconfig new dependency in patch 2/6, fixed upstream already
v4: https://lore.kernel.org/u-boot/[email protected]/
* make better use of prefixes in commit subjects
* change patches' order to ensure no commit introduces compiler warnings or errors i.e. defconfig is now patch 5/5
* add new patch 4/5 to remove compiler Werror=unused-function
* add an additional Kconfig dependency to patch 2/5
v3: https://lore.kernel.org/all/[email protected]/
* enable FPGA configs in sandbox_defconfig instead of new one
v2: https://lore.kernel.org/all/[email protected]/
* use log_* instead of puts() which is now preferred
* harmonize user feedback format; remove useless strings
* add a sandbox_fpga_defconfig; amend fpga Kconfig
* fix various compiler errors and warnings
v1: https://lore.kernel.org/all/[email protected]/
Pieter Van Trappen (6):
cmd: fpga: improve user feedback in case of bitstream load failure
drivers: fpga: add Kconfig dependency
drivers: fpga: correct compiler errors and warnings
drivers: fpga: cleanup printf usage
drivers: fpga: fix function declaration without a prototype
configs: enable FPGA commands and drivers at sandbox_defconfig
cmd/fpga.c | 101 ++++++++++++++--------------- configs/sandbox_defconfig | 20 ++++++ drivers/fpga/ACEX1K.c | 1 + drivers/fpga/Kconfig | 1 + drivers/fpga/fpga.c | 103 ++++++++++++----------------- drivers/fpga/ivm_core.c | 13 ++-- drivers/fpga/lattice.c | 4 +- drivers/fpga/spartan2.c | 1 + drivers/fpga/stratixII.c | 132 ++++++++++++++++++-------------------- drivers/fpga/stratixv.c | 2 +- drivers/fpga/versalpl.c | 1 - drivers/fpga/virtex2.c | 2 + drivers/fpga/xilinx.c | 2 +- drivers/fpga/zynqmppl.c | 4 +- drivers/fpga/zynqpl.c | 4 +- include/fpga.h | 2 +- include/stratixII.h | 6 +- 17 files changed, 198 insertions(+), 201 deletions(-)
base-commit: 1323b480a6fc053475901a90bdaece2ddcc47310
prerequisite-patch-id: d13ffa9f16b79939ca26d5334d15c077c11427af
prerequisite-patch-id: cf4d9931473e7f673dad6a4e7c23fc3fe4678408
prerequisite-patch-id: e6885654262d1a9ddbb8d33e988be9c7c04a95cf
Signature · 1 line
2.48.1