efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target
cover efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target
Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.
Ying-Chun Liu (PaulLiu) (1):
efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.39.5
PATCH 1/1 efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target
Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.
--- configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +1 -0
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000 CONFIG_PCI=y CONFIG_DEBUG_UART=y CONFIG_AHCI=y +CONFIG_EFI_DEBUG_SUPPORT=y CONFIG_EFI_HTTP_BOOT=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=y
configs/qemu_arm_defconfig +1 -0
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000 CONFIG_PCI=y CONFIG_DEBUG_UART=y CONFIG_AHCI=y +CONFIG_EFI_DEBUG_SUPPORT=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=y CONFIG_FIT_VERBOSE=y
lib/efi_loader/Kconfig +0 -1
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT config EFI_DEBUG_SUPPORT bool "EFI Debug Support" - default y if !HAS_BOARD_SIZE_LIMIT help Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug
Signature · 1 line
2.39.5
Thanks Paul
Quoted 11 lines · Ying-Chun Liu (PaulLiu)
Previously,
EFI_DEBUG_SUPPORTwas enabled across all platforms for CI build testing. With this commit, we are limiting its activation toqemu_arm64_defconfigandqemu_arm_defconfigonly, which is sufficient for our current needs.Signed-off-by Ying-Chun Liu (PaulLiu) <[email protected]>Cc Heinrich Schuchardt <[email protected]>Cc Ilias Apalodimas <[email protected]>Cc Tom Rini <[email protected]>---
Quoted 44 lines
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)configs/qemu_arm64_defconfig +1
-0@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000 CONFIG_PCI=y CONFIG_DEBUG_UART=y CONFIG_AHCI=y +CONFIG_EFI_DEBUG_SUPPORT=y CONFIG_EFI_HTTP_BOOT=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=yconfigs/qemu_arm_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000 CONFIG_PCI=y CONFIG_DEBUG_UART=y CONFIG_AHCI=y +CONFIG_EFI_DEBUG_SUPPORT=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=y CONFIG_FIT_VERBOSE=ylib/efi_loader/Kconfig +0
-2@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT config EFI_DEBUG_SUPPORT bool "EFI Debug Support" - default y if !HAS_BOARD_SIZE_LIMIT help Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug --2.39.5
Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:
Quoted 4 lines
Previously,
EFI_DEBUG_SUPPORTwas enabled across all platforms for CI build testing. With this commit, we are limiting its activation toqemu_arm64_defconfigandqemu_arm_defconfigonly, which is sufficient for our current needs.
Was there a request to turn it off on other platforms?
Best regards
Heinrich
Quoted 47 lines
Signed-off-by Ying-Chun Liu (PaulLiu) <[email protected]>Cc Heinrich Schuchardt <[email protected]>Cc Ilias Apalodimas <[email protected]>Cc Tom Rini <[email protected]>---
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)configs/qemu_arm64_defconfig +0
-0@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_EFI_HTTP_BOOT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yconfigs/qemu_arm_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yCONFIG_FIT_VERBOSE=ylib/efi_loader/Kconfig +0
-0@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORTconfig
EFI_DEBUG_SUPPORT
bool "EFI Debug Support"lib/efi_loader/Kconfig +0
-1- default y if !HAS_BOARD_SIZE_LIMIThelp
Select this option if you want to setup the EFI Debug Support Table and theEFI_SYSTEM_TABLE_POINTERwhich is used by the debug
Hi Heinrich
Quoted 8 lines · Heinrich Schuchardt
Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:
Quoted 4 lines
Previously,
EFI_DEBUG_SUPPORTwas enabled across all platforms for CI build testing. With this commit, we are limiting its activation toqemu_arm64_defconfigandqemu_arm_defconfigonly, which is sufficient for our current needs.Was there a request to turn it off on other platforms?
I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?
Thanks
/Ilias
Quoted 54 lines
Best regards
Heinrich
Quoted 47 lines
Signed-off-by Ying-Chun Liu (PaulLiu) <[email protected]>Cc Heinrich Schuchardt <[email protected]>Cc Ilias Apalodimas <[email protected]>Cc Tom Rini <[email protected]>---
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)configs/qemu_arm64_defconfig +0
-0@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_EFI_HTTP_BOOT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yconfigs/qemu_arm_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yCONFIG_FIT_VERBOSE=ylib/efi_loader/Kconfig +0
-0@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORTconfig
EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and theEFI_SYSTEM_TABLE_POINTERwhich is used by the debug
Quoted 10 lines · Ilias Apalodimas
Hi Heinrich
Quoted 7 lines · Heinrich Schuchardt
Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:
Quoted 4 lines
Previously,
EFI_DEBUG_SUPPORTwas enabled across all platforms for CI build testing. With this commit, we are limiting its activation toqemu_arm64_defconfigandqemu_arm_defconfigonly, which is sufficient for our current needs.
Quoted 6 lines
Quoted 1 line
Was there a request to turn it off on other platforms?
I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?
The protocol is typically needed when things fail on real hardware. Having to reflash U-Boot may not be desired especially if the U-Boot binary is signed. Isn't !HAS_BOARD_SIZE_LIMIT is enough of a safeguard for now?
Best regards
Heinrich
Quoted 57 lines
Thanks
/IliasQuoted 54 lines
Best regards
Heinrich
Quoted 47 lines
Signed-off-by Ying-Chun Liu (PaulLiu) <[email protected]>Cc Heinrich Schuchardt <[email protected]>Cc Ilias Apalodimas <[email protected]>Cc Tom Rini <[email protected]>---
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)configs/qemu_arm64_defconfig +0
-0@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_EFI_HTTP_BOOT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yconfigs/qemu_arm_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yCONFIG_FIT_VERBOSE=ylib/efi_loader/Kconfig +0
-0@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORTconfig
EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and theEFI_SYSTEM_TABLE_POINTERwhich is used by the debug
Quoted 19 lines · Heinrich Schuchardt
Quoted 10 lines · Ilias Apalodimas
Hi Heinrich
Quoted 7 lines · Heinrich Schuchardt
Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:
Quoted 4 lines
Previously,
EFI_DEBUG_SUPPORTwas enabled across all platforms for CI build testing. With this commit, we are limiting its activation toqemu_arm64_defconfigandqemu_arm_defconfigonly, which is sufficient for our current needs.Quoted 6 lines
Quoted 1 line
Was there a request to turn it off on other platforms?
I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?
Quoted 4 lines
The protocol is typically needed when things fail on real hardware. Having to reflash U-Boot may not be desired especially if the U-Boot binary is signed. Isn't !HAS_BOARD_SIZE_LIMIT is enough of a safeguard for now?
Well I assume that people use it for debugging and not production, so refreshing shouldn't be a big deal.
I don't mind if you prefer it as is. I just assumed we wanted it off by default, since it's a debug protocol
Regards
/Ilias
Quoted 63 lines
Best regards
Heinrich
Quoted 57 lines
Thanks
/IliasQuoted 54 lines
Best regards
Heinrich
Quoted 47 lines
Signed-off-by Ying-Chun Liu (PaulLiu) <[email protected]>Cc Heinrich Schuchardt <[email protected]>Cc Ilias Apalodimas <[email protected]>Cc Tom Rini <[email protected]>---
configs/qemu_arm64_defconfig | 1 + configs/qemu_arm_defconfig | 1 + lib/efi_loader/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-)configs/qemu_arm64_defconfig +0
-0@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_EFI_HTTP_BOOT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yconfigs/qemu_arm_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
CONFIG_PCI=yCONFIG_DEBUG_UART=yCONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=yCONFIG_FIT=yCONFIG_FIT_SIGNATURE=yCONFIG_FIT_VERBOSE=ylib/efi_loader/Kconfig +0
-0@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORTconfig
EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and theEFI_SYSTEM_TABLE_POINTERwhich is used by the debug