Skip to contentSkip to conversation

efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

PATCH In review Ying-Chun Liu (PaulLiu) 3 participants 7 messages Jul 7, 2025 – Jul 8, 2025

lore
Share & tools
lore
#0 lore raw

cover efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Ying-Chun Liu (PaulLiu) (1):
efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

 configs/qemu_arm64_defconfig | 1 +
 configs/qemu_arm_defconfig   | 1 +
 lib/efi_loader/Kconfig       | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.39.5
#1 lore raw

PATCH 1/1 efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>
---
 configs/qemu_arm64_defconfig | 1 +
 configs/qemu_arm_defconfig   | 1 +
 lib/efi_loader/Kconfig       | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +1 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
 CONFIG_PCI=y
 CONFIG_DEBUG_UART=y
 CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
 CONFIG_EFI_HTTP_BOOT=y
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
configs/qemu_arm_defconfig +1 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
 CONFIG_PCI=y
 CONFIG_DEBUG_UART=y
 CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_FIT_VERBOSE=y
lib/efi_loader/Kconfig +0 -1
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 
 config EFI_DEBUG_SUPPORT
 	bool "EFI Debug Support"
-	default y if !HAS_BOARD_SIZE_LIMIT
 	help
 	  Select this option if you want to setup the EFI Debug Support
 	  Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#2 lore raw

Thanks Paul

Quoted 11 lines · Ying-Chun Liu (PaulLiu)

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>

---

Quoted 44 lines
 configs/qemu_arm64_defconfig | 1 +
 configs/qemu_arm_defconfig   | 1 +
 lib/efi_loader/Kconfig       | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +1 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000
 CONFIG_PCI=y
 CONFIG_DEBUG_UART=y
 CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
 CONFIG_EFI_HTTP_BOOT=y
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
configs/qemu_arm_defconfig +1 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000
 CONFIG_PCI=y
 CONFIG_DEBUG_UART=y
 CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_FIT_VERBOSE=y
lib/efi_loader/Kconfig +0 -2
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 
 config EFI_DEBUG_SUPPORT
        bool "EFI Debug Support"
-       default y if !HAS_BOARD_SIZE_LIMIT
        help
          Select this option if you want to setup the EFI Debug Support
          Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug
--

2.39.5

#3 lore raw
In reply to Ying-Chun Liu (PaulLiu)

Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:

Quoted 4 lines

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Was there a request to turn it off on other platforms?

Best regards

Heinrich

Quoted 47 lines
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>

---

configs/qemu_arm64_defconfig | 1 +
configs/qemu_arm_defconfig   | 1 +
lib/efi_loader/Kconfig       | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +0 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_EFI_HTTP_BOOT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y

configs/qemu_arm_defconfig +0 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y

lib/efi_loader/Kconfig +0 -0
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 

config EFI_DEBUG_SUPPORT
bool "EFI Debug Support"

lib/efi_loader/Kconfig +0 -1
-	default y if !HAS_BOARD_SIZE_LIMIT

help
Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug

#4 lore raw

Hi Heinrich

Quoted 8 lines · Heinrich Schuchardt

Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:

Quoted 4 lines

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Was there a request to turn it off on other platforms?

I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?

Thanks
/Ilias

Quoted 54 lines

Best regards

Heinrich

Quoted 47 lines
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>

---

configs/qemu_arm64_defconfig | 1 +
configs/qemu_arm_defconfig   | 1 +
lib/efi_loader/Kconfig       | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +0 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_EFI_HTTP_BOOT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y

configs/qemu_arm_defconfig +0 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y

lib/efi_loader/Kconfig +0 -0
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 

config EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug

#5 lore raw
Quoted 10 lines · Ilias Apalodimas

Hi Heinrich

Quoted 7 lines · Heinrich Schuchardt

Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:

Quoted 4 lines

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Quoted 6 lines
Quoted 1 line

Was there a request to turn it off on other platforms?

I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?

The protocol is typically needed when things fail on real hardware. Having to reflash U-Boot may not be desired especially if the U-Boot binary is signed. Isn't !HAS_BOARD_SIZE_LIMIT is enough of a safeguard for now?

Best regards

Heinrich

Quoted 57 lines

Thanks
/Ilias

Quoted 54 lines

Best regards

Heinrich

Quoted 47 lines
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>

---

configs/qemu_arm64_defconfig | 1 +
configs/qemu_arm_defconfig   | 1 +
lib/efi_loader/Kconfig       | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +0 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_EFI_HTTP_BOOT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y

configs/qemu_arm_defconfig +0 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y

lib/efi_loader/Kconfig +0 -0
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 

config EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug

#6 lore raw
Quoted 19 lines · Heinrich Schuchardt
Quoted 10 lines · Ilias Apalodimas

Hi Heinrich

Quoted 7 lines · Heinrich Schuchardt

Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" <[email protected]>:

Quoted 4 lines

Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for CI build testing. With this commit, we are limiting its activation to qemu_arm64_defconfig and qemu_arm_defconfig only, which is sufficient for our current needs.

Quoted 6 lines
Quoted 1 line

Was there a request to turn it off on other platforms?

I asked Paul to send this, because it grows the binary size a bit. Since it a debug protocol, I thought we could only enable it for QEMU to test it.
If you want that on for risc-v we can turn it on for QEMU as well?

Quoted 4 lines

The protocol is typically needed when things fail on real hardware. Having to reflash U-Boot may not be desired especially if the U-Boot binary is signed. Isn't !HAS_BOARD_SIZE_LIMIT is enough of a safeguard for now?

Well I assume that people use it for debugging and not production, so refreshing shouldn't be a big deal.
I don't mind if you prefer it as is. I just assumed we wanted it off by default, since it's a debug protocol

Regards
/Ilias

Quoted 63 lines

Best regards

Heinrich

Quoted 57 lines

Thanks
/Ilias

Quoted 54 lines

Best regards

Heinrich

Quoted 47 lines
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Tom Rini <[email protected]>

---

configs/qemu_arm64_defconfig | 1 +
configs/qemu_arm_defconfig   | 1 +
lib/efi_loader/Kconfig       | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
configs/qemu_arm64_defconfig +0 -0
index 39afb837e41..54bf4646382 100644
@@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_EFI_HTTP_BOOT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y

configs/qemu_arm_defconfig +0 -0
index 92ba48f6af9..b1c277a86c0 100644
@@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000

CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
+CONFIG_EFI_DEBUG_SUPPORT=y
CONFIG_FIT=y
CONFIG_FIT_SIGNATURE=y
CONFIG_FIT_VERBOSE=y

lib/efi_loader/Kconfig +0 -0
index 077466f01f0..fdabe9cc278 100644
@@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT
 

config EFI_DEBUG_SUPPORT
bool "EFI Debug Support"
- default y if !HAS_BOARD_SIZE_LIMIT
help
Select this option if you want to setup the EFI Debug Support Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug