Skip to contentSkip to conversation

soc: imx8ulp: Add celsius unit for temperature

PATCH Superseded David Zang 2 participants 5 messages Jul 10, 2025 – Jul 12, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

David Zang

author
#0 lore raw

PATCH 1/1 soc: imx8ulp: Add celsius unit for temperature

---
 arch/arm/mach-imx/imx8ulp/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx8ulp/soc.c +1 -1
index bbcd862caa3..5de15b59b96 100644
@@ -400,7 +400,7 @@ int print_cpuinfo(void)
 	if (!ret) {
 		ret = thermal_get_temp(udev, &temp);
 		if (!ret)
-			printf("CPU current temperature: %d\n", temp);
+			printf("CPU current temperature: %dC\n", temp);
 		else
 			debug(" - failed to get CPU current temperature\n");
 	} else {
Signature · 1 line
2.34.1
reviewer
#1 lore raw

Hi David,

Quoted 11 lines · David Zang
---
 arch/arm/mach-imx/imx8ulp/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx8ulp/soc.c +0 -0
index bbcd862caa3..5de15b59b96 100644

arch/arm/mach-imx/imx8ulp/soc.c int print_cpuinfo(void) · line 403

Quoted 5 lines
arch/arm/mach-imx/imx8ulp/soc.c +1 -1
@@ -400,7 +400,7 @@ int print_cpuinfo(void)
        if (!ret) {
                ret = thermal_get_temp(udev, &temp);
                if (!ret)
-                       printf("CPU current temperature: %d\n", temp);
+                       printf("CPU current temperature: %dC\n", temp);

Your change looks good, but please add a short commit log and send a v2.

Thanks

author
#2 lore raw
Quoted 23 lines · Fabio Estevam

Hi David,

Review

Quoted 7 lines · David Zang
---
 arch/arm/mach-imx/imx8ulp/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/mach-imx/imx8ulp/soc.c

arch/arm/mach-imx/imx8ulp/soc.c int print_cpuinfo(void) · line 403

Quoted 9 lines

index bbcd862caa3..5de15b59b96 100644

arch/arm/mach-imx/imx8ulp/soc.c +1 -1
@@ -400,7 +400,7 @@ int print_cpuinfo(void)
        if (!ret) {
                ret = thermal_get_temp(udev, &temp);
                if (!ret)
-                       printf("CPU current temperature: %d\n", temp);
+                       printf("CPU current temperature: %dC\n", temp);

Your change looks good, but please add a short commit log and send a v2.

Quoted 1 line

Since it is a simple fix, do I really need a commit log?

David

reviewer
#3 lore raw
Quoted 1 line · David Zang

Since it is a simple fix, do I really need a commit log?

Yes, even a single line is better than nothing.

author
#4 lore raw
Quoted 6 lines · Fabio Estevam
Quoted 1 line · David Zang

Since it is a simple fix, do I really need a commit log?

Yes, even a single line is better than nothing.

I sent out the v2.

David