soc: imx8ulp: Add celsius unit for temperature
Subsystems (3)
PATCH 1/1 soc: imx8ulp: Add celsius unit for temperature
Signed-off-by David Zang <[email protected]>
--- arch/arm/mach-imx/imx8ulp/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx8ulp/soc.c +1 -1
@@ -400,7 +400,7 @@ int print_cpuinfo(void)if (!ret) { ret =thermal_get_temp (udev, &temp);if (!ret) -printf ("CPU current temperature: %d\n" , temp); +printf ("CPU current temperature: %dC\n" , temp);else debug (" - failed to get CPU current temperature\n" ); }else {
Signature · 1 line
2.34.1
Fabio Estevam
reviewerHi David,
Quoted 11 lines · David Zang
Signed-off-by David Zang <[email protected]>--- arch/arm/mach-imx/imx8ulp/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-imx/imx8ulp/soc.c +0
-0
arch/arm/mach-imx/imx8ulp/soc.c int print_cpuinfo(void) · line 403
Quoted 5 lines
arch/arm/mach-imx/imx8ulp/soc.c +1
-1@@ -400,7 +400,7 @@ int print_cpuinfo(void)if (!ret) { ret =thermal_get_temp (udev, &temp);if (!ret) -printf ("CPU current temperature: %d\n" , temp); +printf ("CPU current temperature: %dC\n" , temp);
Your change looks good, but please add a short commit log and send a v2.
Thanks
Quoted 23 lines · Fabio Estevam
Hi David,
Review
Quoted 7 lines · David Zang
Signed-off-by David Zang <[email protected]>--- arch/arm/mach-imx/imx8ulp/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/mach-imx/imx8ulp/soc.carch/arm/mach-imx/imx8ulp/soc.c int print_cpuinfo(void) · line 403
Quoted 9 lines
index
bbcd862caa3..5de15b59b96100644arch/arm/mach-imx/imx8ulp/soc.c +1
-1@@ -400,7 +400,7 @@ int print_cpuinfo(void)if (!ret) { ret =thermal_get_temp (udev, &temp);if (!ret) -printf ("CPU current temperature: %d\n" , temp); +printf ("CPU current temperature: %dC\n" , temp);Your change looks good, but please add a short commit log and send a v2.
Quoted 1 line
Since it is a simple fix, do I really need a commit log?
David
Fabio Estevam
reviewerQuoted 1 line · David Zang
Since it is a simple fix, do I really need a commit log?
Yes, even a single line is better than nothing.
Quoted 6 lines · Fabio Estevam
Quoted 1 line · David Zang
Since it is a simple fix, do I really need a commit log?
Yes, even a single line is better than nothing.
I sent out the v2.
David