Skip to contentSkip to conversation

Change in openvpn[master]: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedo...

Openvpn-devel In review cron2 (Code Review) 2 participants 7 messages Jul 28, 2025 – Jul 29, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1753697277000.I2ab13767b5aa858e024b45be3d161bf6090de763@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email

to review the following change.

Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................

unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

add <stdint.h> to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared")

Change-Id I2ab13767b5aa858e024b45be3d161bf6090de763

---
M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/1118/1

tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +1 -0
index d40467f..50b241d 100644
@@ -2,6 +2,7 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <string.h>
 #include <setjmp.h>
 #include <cmocka.h>

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: cron2, plaisthos.

flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email )

Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: cron2 <[email protected]...>
Gerrit-Comment-Date: Mon, 28 Jul 2025 10:38:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

In reply to a message not in the archive

add <stdint.h> to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared")

Change-Id I2ab13767b5aa858e024b45be3d161bf6090de763

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1118
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>

tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +1 -0
index d40467f..50b241d 100644
@@ -2,6 +2,7 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <string.h>
 #include <setjmp.h>
 #include <cmocka.h>
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

It seems this would also affect feodora-42 on amd64, we just missed on the "updates that bring in the breaking change" - but now we are prepared ;-)

Patch has been applied to the master branch.

commit 035d47e6d80996a4cde8af1b35f9ba40b676c825

Author: Gert Doering
Date:   Mon Jul 28 12:42:29 2025 +0200
     unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Frank Lichtenheld <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg32384.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw

Re: [Openvpn-devel] [PATCH applied] Re: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

Hi,

(uh, forgot to send this - push has been done yesterday already)

Quoted 8 lines · Gert Doering

It seems this would also affect feodora-42 on amd64, we just missed on the "updates that bring in the breaking change" - but now we are prepared ;-)

Patch has been applied to the master branch.

commit 035d47e6d80996a4cde8af1b35f9ba40b676c825

Author: Gert Doering
Date:   Mon Jul 28 12:42:29 2025 +0200

Frank has pointed out that this is the sort of maintenance fixes we
do want in release/2.6 as well, so here we go... tested via GHA and
local fedora42/arm64 VM

commit 5c968a361fba7362306fcd977acdff52ccb4c884 (release/2.6)

Author: Gert Doering <[email protected]...>
Date:   Mon Jul 28 12:42:29 2025 +0200

unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

gert
-
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany [email protected]...

#6 lore raw
In reply to a message not in the archive

Hello flichtenheld, plaisthos,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld

Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................

unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

add <stdint.h> to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared")

Change-Id I2ab13767b5aa858e024b45be3d161bf6090de763

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32384.html

---
M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/1118/2

tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +1 -0
index d40467f..50b241d 100644
@@ -2,6 +2,7 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <string.h>
 #include <setjmp.h>
 #include <cmocka.h>

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#7 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email )

Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................

unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

add <stdint.h> to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared")

Change-Id I2ab13767b5aa858e024b45be3d161bf6090de763

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32384.html

---
M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c

1 file changed, 1 insertion(+), 0 deletions(-)
tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +1 -0
index d40467f..50b241d 100644
@@ -2,6 +2,7 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <string.h>
 #include <setjmp.h>
 #include <cmocka.h>

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged