ASoC: dt-bindings: realtek,alc5623: convert to DT schema
Subsystems (3)
PATCH v4 1/1 ASoC: dt-bindings: realtek,alc5623: convert to DT schema
Convert alc5623 audio codec binding to DT schema.
---
Changes in v4:
- Add "realtek,alc5621" and "realtek,alc5622" to compatible list
Changes in v3:
- Drop allOf, just use $ref for uint32
- Remove stray '>' in descriptions
- Fix subject to "to DT schema"
Changes in v2:
- Add dai-common ref
- Switch add-ctrl/jack-det-ctrl to allOf uint32
- Use unevaluatedProperties
- Fix example compatible
--- .../devicetree/bindings/sound/alc5623.txt | 25 --------- .../bindings/sound/realtek,alc5623.yaml | 55 +++++++++++++++++++ 2 files changed, 55 insertions(+), 25 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/alc5623.txt create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5623.yaml
Documentation/devicetree/bindings/sound/alc5623.txt deleted +0 -25
@@ -1,25 +0,0 @@ -ALC5621/ALC5622/ALC5623 audio Codec - -Required properties: - - - compatible: "realtek,alc5623" - - reg: the I2C address of the device. - -Optional properties: - - - add-ctrl: Default register value for Reg-40h, Additional Control - Register. If absent or has the value of 0, the - register is untouched. - - - jack-det-ctrl: Default register value for Reg-5Ah, Jack Detect - Control Register. If absent or has value 0, the - register is untouched. - -Example: - - alc5621: alc5621@1a { - compatible = "alc5621"; - reg = <0x1a>; - add-ctrl = <0x3700>; - jack-det-ctrl = <0x4810>; - };
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +55 -0
55 lines not on this page · raw message
Signature · 1 line
2.50.1
Quoted 1 line · Mahdi Khosravi
Convert alc5623 audio codec binding to DT schema.
...
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 18
Quoted 5 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +5
-0+ +properties: + compatible: + enum: + - realtek,alc5621
This was not in the original binding. Any changes should be explained in the commit msg.
Quoted 1 line
+ - realtek,alc5622
Why adding this? Where is it used?
Review
Quoted 2 lines
(quoted diff) +2
-0+ - realtek,alc5623 +
Best regards,
Krzysztof