Skip to contentSkip to conversation

futex: Use user_write_access_begin() in futex_put_value()

PATCH Superseded Waiman Long 2 participants 2 messages Aug 9, 2025 – Aug 11, 2025 Futex

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 futex: Use user_write_access_begin() in futex_put_value()

Commit cec199c5e39b ("futex: Implement FUTEX2_NUMA") introduces a new futex_put_value() helper function to write a value to the given user address. However, it uses user_read_access_begin() before the write. For arches that differentiate between read and write accesses, like powerpc, futex_put_value() fails with a -EFAULT return value. Fix that by using user_write_access_begin().

Fixes cec199c5e39b ("futex: Implement FUTEX2_NUMA")
---
 kernel/futex/futex.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/futex/futex.h +1 -1
index c74eac572acd..2b6ae6a2b2a2 100644
@@ -319,7 +319,7 @@ static __always_inline int futex_put_value(u32 val, u32 __user *to)
 {
 	if (can_do_masked_user_access())
 		to = masked_user_access_begin(to);
-	else if (!user_read_access_begin(to, sizeof(*to)))
+	else if (!user_write_access_begin(to, sizeof(*to)))
 		return -EFAULT;
 	unsafe_put_user(val, to, Efault);
 	user_read_access_end();
Signature · 1 line
2.50.1
#1 lore raw
Quoted 18 lines · Waiman Long

Commit cec199c5e39b ("futex: Implement FUTEX2_NUMA") introduces a new futex_put_value() helper function to write a value to the given user address. However, it uses user_read_access_begin() before the write. For arches that differentiate between read and write accesses, like powerpc, futex_put_value() fails with a -EFAULT return value. Fix that by using user_write_access_begin().

Fixes cec199c5e39b ("futex: Implement FUTEX2_NUMA")
---
  kernel/futex/futex.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/futex/futex.h +0 -0
index c74eac572acd..2b6ae6a2b2a2 100644

kernel/futex/futex.h static __always_inline int futex_put_value(u32 val, u32 __user *to) · line 325

Quoted 8 lines
kernel/futex/futex.h +1 -1
@@ -319,7 +319,7 @@ static __always_inline int futex_put_value(u32 val, u32 __user *to)
  {
  	if (can_do_masked_user_access())
  		to = masked_user_access_begin(to);
-	else if (!user_read_access_begin(to, sizeof(*to)))
+	else if (!user_write_access_begin(to, sizeof(*to)))
  		return -EFAULT;
  	unsafe_put_user(val, to, Efault);
  	user_read_access_end();

Sorry, I forgot to use a matching user_write_access_end(). Will send out a v2.

Cheers,
Longman