futex: Use user_write_access_begin() in futex_put_value()
PATCH 1/1 futex: Use user_write_access_begin() in futex_put_value()
Commit cec199c5e39b ("futex: Implement FUTEX2_NUMA") introduces a new futex_put_value() helper function to write a value to the given user address. However, it uses user_read_access_begin() before the write. For arches that differentiate between read and write accesses, like powerpc, futex_put_value() fails with a -EFAULT return value. Fix that by using user_write_access_begin().
--- kernel/futex/futex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/futex/futex.h +1 -1
@@ -319,7 +319,7 @@ static __always_inline int futex_put_value(u32 val, u32 __user *to) {if (can_do_masked_user_access ()) to =masked_user_access_begin (to); -else if (!user_read_access_begin (to,sizeof (*to))) +else if (!user_write_access_begin (to,sizeof (*to)))return -EFAULT ;unsafe_put_user (val, to, Efault);user_read_access_end ();
Signature · 1 line
2.50.1
Quoted 18 lines · Waiman Long
Commit
cec199c5e39b("futex: ImplementFUTEX2_NUMA") introduces a newfutex_put_value()helper function to write a value to the given user address. However, it usesuser_read_access_begin()before the write. For arches that differentiate between read and write accesses, like powerpc,futex_put_value()fails with a-EFAULTreturn value. Fix that by usinguser_write_access_begin().Fixes cec199c5e39b ("futex: Implement FUTEX2_NUMA")Signed-off-by Waiman Long <[email protected]>--- kernel/futex/futex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/futex/futex.h +0
-0
kernel/futex/futex.h static __always_inline int futex_put_value(u32 val, u32 __user *to) · line 325
Quoted 8 lines
kernel/futex/futex.h +1
-1@@ -319,7 +319,7 @@ static __always_inline int futex_put_value(u32 val, u32 __user *to) {if (can_do_masked_user_access ()) to =masked_user_access_begin (to); -else if (!user_read_access_begin (to,sizeof (*to))) +else if (!user_write_access_begin (to,sizeof (*to)))return -EFAULT ;unsafe_put_user (val, to, Efault);user_read_access_end ();
Sorry, I forgot to use a matching user_write_access_end(). Will send out a v2.
Cheers,
Longman