Skip to contentSkip to conversation

ALSA: usb-audio: us144mkii: Use le16_to_cpu() for product ID comparison

PATCH In review Šerif Rami 2 participants 2 messages Aug 19, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: us144mkii: Use le16_to_cpu() for product ID comparison

The us144mkii.c driver was generating sparse warnings due to direct comparisons of dev->descriptor.idProduct (a __le16 type) with integer constants. This commit resolves these warnings by explicitly converting idProduct to a CPU-endian integer using le16_to_cpu() before comparison.

This ensures correct handling of endianness and eliminates the sparse warnings:
- restricted __le16 degrades to integer

---
 sound/usb/usx2y/us144mkii.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/usx2y/us144mkii.c +2 -2
index da53c1908..3127a3206 100644
@@ -514,10 +514,10 @@ static int tascam_probe(struct usb_interface *intf,
 	}
 
 	strscpy(card->driver, DRIVER_NAME, sizeof(card->driver));
-	if (dev->descriptor.idProduct == USB_PID_TASCAM_US144) {
+	if (le16_to_cpu(dev->descriptor.idProduct) == USB_PID_TASCAM_US144) {
 		strscpy(card->shortname, "TASCAM US-144",
 			sizeof(card->shortname));
-	} else if (dev->descriptor.idProduct == USB_PID_TASCAM_US144MKII) {
+	} else if (le16_to_cpu(dev->descriptor.idProduct) == USB_PID_TASCAM_US144MKII) {
 		strscpy(card->shortname, "TASCAM US-144MKII",
 			sizeof(card->shortname));
 	} else {
Signature · 1 line
2.50.1
#1 lore raw
Quoted 7 lines · Šerif Rami

The us144mkii.c driver was generating sparse warnings due to direct comparisons of dev->descriptor.idProduct (a __le16 type) with integer constants. This commit resolves these warnings by explicitly converting idProduct to a CPU-endian integer using le16_to_cpu() before comparison.

Quoted 7 lines

This ensures correct handling of endianness and eliminates the sparse warnings:
- restricted __le16 degrades to integer

Thanks, I applied now with Fixes tag.

Takashi