ALSA: usb-audio: us144mkii: Use le16_to_cpu() for product ID comparison
PATCH 1/1 ALSA: usb-audio: us144mkii: Use le16_to_cpu() for product ID comparison
The us144mkii.c driver was generating sparse warnings due to direct comparisons of dev->descriptor.idProduct (a __le16 type) with integer constants. This commit resolves these warnings by explicitly converting idProduct to a CPU-endian integer using le16_to_cpu() before comparison.
This ensures correct handling of endianness and eliminates the sparse warnings:
- restricted __le16 degrades to integer
--- sound/usb/usx2y/us144mkii.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/usx2y/us144mkii.c +2 -2
@@ -514,10 +514,10 @@ static int tascam_probe(struct usb_interface *intf, }strscpy (card->driver,DRIVER_NAME ,sizeof (card->driver)); -if (dev->descriptor.idProduct ==USB_PID_TASCAM_US144 ) { +if (le16_to_cpu (dev->descriptor.idProduct) ==USB_PID_TASCAM_US144 ) {strscpy (card->shortname,"TASCAM US-144" ,sizeof (card->shortname)); - }else if (dev->descriptor.idProduct ==USB_PID_TASCAM_US144MKII ) { + }else if (le16_to_cpu (dev->descriptor.idProduct) ==USB_PID_TASCAM_US144MKII ) {strscpy (card->shortname,"TASCAM US-144MKII" ,sizeof (card->shortname)); }else {
Signature · 1 line
2.50.1
Quoted 7 lines · Šerif Rami
The
us144mkii.cdriver was generating sparse warnings due to direct comparisons ofdev->descriptor.idProduct(a__le16type) with integer constants. This commit resolves these warnings by explicitly convertingidProductto a CPU-endian integer usingle16_to_cpu()before comparison.
Quoted 7 lines
This ensures correct handling of endianness and eliminates the sparse warnings:
-restricted __le16 degrades to integerReported-by kernel test robot <[email protected]>Signed-off-by Šerif Rami <[email protected]>
Thanks, I applied now with Fixes tag.
Takashi