Skip to contentSkip to conversation

ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()

PATCH Superseded Šerif Rami 2 participants 3 messages Aug 19, 2025 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()

The smatch tool reported a potential null pointer dereference in tascam_midi_in_urb_complete(). The 'tascam' variable, derived from 'urb->context', was checked for nullity in one place, but dereferenced without a check in several other places.

This patch fixes the issue by adding a null check at the beginning of the function. If 'tascam' is null, the function now safely exits. This prevents any potential crashes from null pointer dereferences.

It also fixes a latent bug where 'usb_put_urb()' could be called twice for the same URB on submission failure, which would lead to a use-after-free error.

---
 sound/usb/usx2y/us144mkii_midi.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
sound/usb/usx2y/us144mkii_midi.c +7 -1
index 5759f6010..1aca38f38 100644
@@ -41,6 +41,9 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 	struct tascam_card *tascam = urb->context;
 	int ret;
 
+	if (!tascam)
+		goto out;
+
 	if (urb->status) {
 		if (urb->status != -ENOENT && urb->status != -ECONNRESET &&
 		    urb->status != -ESHUTDOWN && urb->status != -EPROTO) {
@@ -51,7 +54,7 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 		goto out;
 	}
 
-	if (tascam && atomic_read(&tascam->midi_in_active) &&
+	if (atomic_read(&tascam->midi_in_active) &&
 	    urb->actual_length > 0) {
 		kfifo_in_spinlocked(&tascam->midi_in_fifo, urb->transfer_buffer,
 				    urb->actual_length, &tascam->midi_in_lock);
@@ -66,11 +69,14 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 			"Failed to resubmit MIDI IN URB: error %d\n", ret);
 		usb_unanchor_urb(urb);
 		usb_put_urb(urb);
+		goto out;
 	}
+
 out:
 	usb_put_urb(urb);
 }
 
+
 /**
  * tascam_midi_in_open() - Opens the MIDI input substream.
  * @substream: The ALSA rawmidi substream to open.
Signature · 1 line
2.50.1
#1 lore raw
Quoted 45 lines · Šerif Rami

The smatch tool reported a potential null pointer dereference in tascam_midi_in_urb_complete(). The 'tascam' variable, derived from 'urb->context', was checked for nullity in one place, but dereferenced without a check in several other places.

This patch fixes the issue by adding a null check at the beginning of the function. If 'tascam' is null, the function now safely exits. This prevents any potential crashes from null pointer dereferences.

It also fixes a latent bug where 'usb_put_urb()' could be called twice for the same URB on submission failure, which would lead to a use-after-free error.

---
 sound/usb/usx2y/us144mkii_midi.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
sound/usb/usx2y/us144mkii_midi.c +4 -1
index 5759f6010..1aca38f38 100644
@@ -41,6 +41,9 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 	struct tascam_card *tascam = urb->context;
 	int ret;
 
+	if (!tascam)
+		goto out;
+
 	if (urb->status) {
 		if (urb->status != -ENOENT && urb->status != -ECONNRESET &&
 		    urb->status != -ESHUTDOWN && urb->status != -EPROTO) {
@@ -51,7 +54,7 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 		goto out;
 	}
 
-	if (tascam && atomic_read(&tascam->midi_in_active) &&
+	if (atomic_read(&tascam->midi_in_active) &&
 	    urb->actual_length > 0) {
 		kfifo_in_spinlocked(&tascam->midi_in_fifo, urb->transfer_buffer,
 				    urb->actual_length, &tascam->midi_in_lock);

sound/usb/usx2y/us144mkii_midi.c void tascam_midi_in_urb_complete(struct urb *urb) · line 71

Quoted 3 lines
sound/usb/usx2y/us144mkii_midi.c +0 -0
@@ -66,11 +69,14 @@ void tascam_midi_in_urb_complete(struct urb *urb)
 			"Failed to resubmit MIDI IN URB: error %d\n", ret);
 		usb_unanchor_urb(urb);
 		usb_put_urb(urb);

usb_put_urb() is still called twice, though?

sound/usb/usx2y/us144mkii_midi.c void tascam_midi_in_urb_complete(struct urb *urb) · line 79

Quoted 8 lines
sound/usb/usx2y/us144mkii_midi.c +3 -0
+		goto out;
 	}
+
 out:
 	usb_put_urb(urb);
 }
 
+

You accidentally added a double blank line here.

sound/usb/usx2y/us144mkii_midi.c void tascam_midi_in_urb_complete(struct urb *urb) · line 82

Quoted 3 lines
sound/usb/usx2y/us144mkii_midi.c +0 -0
 /**
  * tascam_midi_in_open() - Opens the MIDI input substream.
  * @substream: The ALSA rawmidi substream to open.

regards,
dan carpenter

#2 lore raw

Re: [PATCH] ALSA: usb-audio: usx2y: Fix null-deref in tascam_midi_in_urb_complete()

Hi Dan,

Thanks for the review and for spotting these issues. You are correct.

I'll send a v2 shortly that addresses these points.

Thanks,
Šerif