Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO
Subsystems (2)
Ian Rogers
reviewerv5 cover Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO
Linking against libcapstone and libLLVM can be a significant increase in dependencies and file size if building statically. For something like perf record the disassembler and addr2line functionality won't be used. Support dynamically loading these libraries using dlopen and then calling the appropriate functions found using dlsym.
BUILD_NONDISTRO is used to build perf against the license incompatible libbfd and libiberty libraries. As this has been opt-in for nearly 2 years, commit dd317df07207 ("perf build: Make binutil libraries opt in"), remove the code to simplify the code base.
The patch series:
1) does some initial clean up;
2) moves the capstone and LLVM code to their own C files,
3) simplifies a little the capstone code;
4) adds perf_ variants of the functions that will either directly call the function or use dlsym to discover it;
5) adds BPF JIT disassembly support to LLVM and capstone disassembly;
6) removes the BUILD_NONDISTRO code, reduces scope and removes what's possible;
7) adds fallback to srcline's addr2line so that llvm_addr2line is tried first and then the forked command tried next, moving the code for forking out of the main srcline.c file in the process.
The addr2line LLVM functionality is written in C++. To avoid linking against libLLVM for this, a new LIBLLVM_DYNAMIC option is added where the C++ code with the libLLVM dependency will be built into a libperf-llvm.so and that dlsym-ed and called against. Ideally LLVM would extend their C API to avoid this.
The libbfd BPF disassembly supported source lines, this wasn't ported to the capstone and LLVM disassembly.
v5: Rebase and comment typo fix.
v4: Rebase and addition of a patch removing an unused struct variable.
v3: Add srcline addr2line fallback trying LLVM first then forking a
process. This came up in conversation with Steinar Gunderson <[email protected]>.
Tweak the cover letter message to try to address Andi Kleen's <[email protected]> feedback that the series doesn't really achieve anything.
v2: Add mangling of the function names in libperf-llvm.so to avoid
potential infinite recursion. Add BPF JIT disassembly support to LLVM and capstone. Add/rebase the BUILD_NONDISTRO cleanup onto the series from:
https://lore.kernel.org/lkml/[email protected]/
Some other minor additional clean up.
Ian Rogers (19):
perf build: Remove libtracefs configuration
perf map: Constify objdump offset/address conversion APIs perf capstone: Move capstone functionality into its own file perf llvm: Move llvm functionality into its own file perf capstone: Remove open_capstone_handle
perf capstone: Support for dlopen-ing libcapstone.so perf llvm: Support for dlopen-ing libLLVM.so
perf llvm: Mangle libperf-llvm.so function names perf dso: Move read_symbol from llvm/capstone to dso perf dso: Support BPF programs in dso__read_symbol perf llvm: Disassemble cleanup
perf dso: Clean up read_symbol error handling
perf build: Remove libbfd support
perf build: Remove libiberty support
perf build: Remove unused defines
perf disasm: Remove disasm_bpf
perf disasm: Make ins__scnprintf and ins__is_nop static perf srcline: Fallback between addr2line implementations perf disasm: Remove unused evsel from annotate_args
tools/perf/Documentation/perf-check.txt | 1 - tools/perf/Makefile.config | 95 +-- tools/perf/Makefile.perf | 35 +- tools/perf/builtin-check.c | 1 - tools/perf/builtin-script.c | 2 - tools/perf/tests/Build | 1 - tools/perf/tests/builtin-test.c | 1 - tools/perf/tests/make | 4 +- tools/perf/tests/pe-file-parsing.c | 101 ---- tools/perf/tests/tests.h | 1 - tools/perf/util/Build | 6 +- tools/perf/util/addr2line.c | 439 ++++++++++++++ tools/perf/util/addr2line.h | 20 + tools/perf/util/annotate.c | 1 - tools/perf/util/annotate.h | 1 - tools/perf/util/capstone.c | 682 +++++++++++++++++++++ tools/perf/util/capstone.h | 24 + tools/perf/util/config.c | 2 +- tools/perf/util/demangle-cxx.cpp | 22 +- tools/perf/util/disasm.c | 628 +------------------ tools/perf/util/disasm.h | 6 +- tools/perf/util/disasm_bpf.c | 195 ------ tools/perf/util/disasm_bpf.h | 12 - tools/perf/util/dso.c | 98 +++ tools/perf/util/dso.h | 4 + tools/perf/util/llvm-c-helpers.cpp | 120 +++- tools/perf/util/llvm-c-helpers.h | 24 +- tools/perf/util/llvm.c | 484 +++++++++++++++ tools/perf/util/llvm.h | 21 + tools/perf/util/map.c | 19 +- tools/perf/util/map.h | 6 +- tools/perf/util/print_insn.c | 117 +--- tools/perf/util/srcline.c | 772 +----------------------- tools/perf/util/srcline.h | 7 +- tools/perf/util/symbol-elf.c | 85 --- tools/perf/util/symbol.c | 145 ----- tools/perf/util/symbol.h | 4 - 37 files changed, 2020 insertions(+), 2166 deletions(-) delete mode 100644 tools/perf/tests/pe-file-parsing.c create mode 100644 tools/perf/util/addr2line.c create mode 100644 tools/perf/util/addr2line.h create mode 100644 tools/perf/util/capstone.c create mode 100644 tools/perf/util/capstone.h delete mode 100644 tools/perf/util/disasm_bpf.c delete mode 100644 tools/perf/util/disasm_bpf.h create mode 100644 tools/perf/util/llvm.c create mode 100644 tools/perf/util/llvm.h
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 1/19 perf build: Remove libtracefs configuration
libtracefs isn't used by perf but not having it installed causes build warnings. Given the library isn't used, there is no need for the configuration or warnings so remove.
--- tools/perf/Makefile.config | 14 -------------- 1 file changed, 14 deletions(-)
tools/perf/Makefile.config +0 -14
@@ -1181,20 +1181,6 @@ ifneq ($(NO_LIBTRACEEVENT),1) else $(error ERROR: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel and/or set LIBTRACEEVENT_DIR or build with NO_LIBTRACEEVENT=1) endif - - ifeq ($(feature-libtracefs), 1) - CFLAGS += $(shell $(PKG_CONFIG) --cflags libtracefs) - LDFLAGS += $(shell $(PKG_CONFIG) --libs-only-L libtracefs) - EXTLIBS += $(shell $(PKG_CONFIG) --libs-only-l libtracefs) - LIBTRACEFS_VERSION := $(shell $(PKG_CONFIG) --modversion libtracefs).0.0 - LIBTRACEFS_VERSION_1 := $(word 1, $(subst ., ,$(LIBTRACEFS_VERSION))) - LIBTRACEFS_VERSION_2 := $(word 2, $(subst ., ,$(LIBTRACEFS_VERSION))) - LIBTRACEFS_VERSION_3 := $(word 3, $(subst ., ,$(LIBTRACEFS_VERSION))) - LIBTRACEFS_VERSION_CPP := $(shell expr $(LIBTRACEFS_VERSION_1) \* 255 \* 255 + $(LIBTRACEFS_VERSION_2) \* 255 + $(LIBTRACEFS_VERSION_3)) - CFLAGS += -DLIBTRACEFS_VERSION=$(LIBTRACEFS_VERSION_CPP) - else - $(warning libtracefs is missing. Please install libtracefs-dev/libtracefs-devel) - endif endif # Among the variables below, these:
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 2/19 perf map: Constify objdump offset/address conversion APIs
In reply to Ian RogersMake the map argument const as the conversion act won't modify the map and this allows other callers to use a const struct map.
--- tools/perf/util/map.c | 19 +++++++++++++++---- tools/perf/util/map.h | 6 +++--- 2 files changed, 18 insertions(+), 7 deletions(-)
tools/perf/util/map.c +15 -4
@@ -513,6 +513,8 @@ void srccode_state_free(struct srccode_state *state) state->line =0 ; } +static const struct kmap *__map__const_kmap (const struct map *map); +/** * map__rip_2objdump - convert symbol start address to objdump address. * @map: memory map
@@ -524,9 +526,9 @@ void srccode_state_free(struct srccode_state *state)* * Return: Address suitable for passing to "objdump --start-address=" */ -u64 map__rip_2objdump (struct map *map,u64 rip) +u64 map__rip_2objdump (const struct map *map,u64 rip) { -struct kmap *kmap =__map__kmap (map); +const struct kmap *kmap =__map__const_kmap (map);const struct dso *dso =map__dso (map);/*
@@ -569,7 +571,7 @@ u64 map__rip_2objdump(struct map *map, u64 rip)* * Return: Memory address. */ -u64 map__objdump_2mem (struct map *map,u64 ip) +u64 map__objdump_2mem (const struct map *map,u64 ip) {const struct dso *dso =map__dso (map);
@@ -586,7 +588,7 @@ u64 map__objdump_2mem(struct map *map, u64 ip) }/* convert objdump address to relative address. (To be removed) */ -u64 map__objdump_2rip (struct map *map,u64 ip) +u64 map__objdump_2rip (const struct map *map,u64 ip) {const struct dso *dso =map__dso (map);
@@ -618,6 +620,15 @@ struct kmap *__map__kmap(struct map *map)return (struct kmap *)(&RC_CHK_ACCESS (map)[1 ]); } +static const struct kmap *__map__const_kmap (const struct map *map) +{ +const struct dso *dso =map__dso (map); + +if (!dso || !dso__kernel (dso)) +return NULL ; +return (struct kmap *)(&RC_CHK_ACCESS (map)[1 ]); +} +struct kmap *map__kmap (struct map *map) {struct kmap *kmap =__map__kmap (map);
tools/perf/util/map.h +3 -3
@@ -133,13 +133,13 @@ static inline u64 map__unmap_ip(const struct map *map, u64 ip_or_rip) }/* rip/ip <-> addr suitable for passing to `objdump --start-address=` */ -u64 map__rip_2objdump (struct map *map,u64 rip); +u64 map__rip_2objdump (const struct map *map,u64 rip);/* objdump address -> memory address */ -u64 map__objdump_2mem (struct map *map,u64 ip); +u64 map__objdump_2mem (const struct map *map,u64 ip);/* objdump address -> rip */ -u64 map__objdump_2rip (struct map *map,u64 ip); +u64 map__objdump_2rip (const struct map *map,u64 ip);struct symbol ;struct thread ;
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 3/19 perf capstone: Move capstone functionality into its own file
In reply to Ian RogersCapstone disassembly support was split between disasm.c and print_insn.c. Move support out of these files into capstone.[ch] and remove include capstone/capstone.h from those files. As disassembly routines can fail, make failure the only option without HAVE_LIBCAPSTONE_SUPPORT. For simplicity's sake, duplicate the read_symbol utility function.
The intent with moving capstone support into a single file is that dynamic support, using dlopen for libcapstone, can be added in later patches. This can potentially always succeed or fail, so relying on ifdefs isn't sufficient. Using dlopen is a useful option to minimize the perf tools dependencies and potentially size.
--- tools/perf/builtin-script.c | 2 - tools/perf/util/Build | 1 + tools/perf/util/capstone.c | 536 +++++++++++++++++++++++++++++++++++ tools/perf/util/capstone.h | 24 ++ tools/perf/util/disasm.c | 356 +---------------------- tools/perf/util/print_insn.c | 117 +------- 6 files changed, 569 insertions(+), 467 deletions(-) create mode 100644 tools/perf/util/capstone.c create mode 100644 tools/perf/util/capstone.h
tools/perf/builtin-script.c +0 -2
@@ -1224,7 +1224,6 @@ static int any_dump_insn(struct evsel *evsel __maybe_unused, u8 *inbuf, int inlen, int *lenp, FILE *fp) { -#ifdef HAVE_LIBCAPSTONE_SUPPORT if (PRINT_FIELD(BRSTACKDISASM)) { int printed = fprintf_insn_asm(x->machine, x->thread, x->cpumode, x->is64bit, (uint8_t *)inbuf, inlen, ip, lenp,
@@ -1233,7 +1232,6 @@ static int any_dump_insn(struct evsel *evsel __maybe_unused,if (printed >0 )return printed; } -#endif return fprintf (fp,"%s" ,dump_insn (x, ip, inbuf, inlen, lenp)); }
tools/perf/util/Build +1 -0
@@ -8,6 +8,7 @@ perf-util-y += block-info.o perf-util-y += block-range.o perf-util-y += build-id.o perf-util-y += cacheline.o +perf-util-y += capstone.o perf-util-y += config.o perf-util-y += copyfile.o perf-util-y += ctype.o
tools/perf/util/capstone.c new file +536 -0
536 lines not on this page · raw message
tools/perf/util/capstone.h new file +24 -0
@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_CAPSTONE_H +#define __PERF_CAPSTONE_H + +#include <stdbool.h> +#include <stdint.h> +#include <stdio.h> +#include <stdlib.h> +#include <linux/types.h> + +struct annotate_args ; +struct machine ; +struct symbol ; +struct thread ; + +ssize_t capstone__fprintf_insn_asm (struct machine *machine,struct thread *thread,u8 cpumode, +bool is64bit,const uint8_t *code,size_t code_size, +uint64_t ip,int *lenp,int print_opts,FILE *fp); +int symbol__disassemble_capstone (const char *filename,struct symbol *sym, +struct annotate_args *args); +int symbol__disassemble_capstone_powerpc (const char *filename,struct symbol *sym, +struct annotate_args *args); + +#endif /* __PERF_CAPSTONE_H */
tools/perf/util/disasm.c +5 -351
382 lines not on this page · raw message
tools/perf/util/print_insn.c +3 -114
138 lines not on this page · raw message
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 4/19 perf llvm: Move llvm functionality into its own file
In reply to Ian RogersLLVM disassembly support was in disasm.c and addr2line support in srcline.c. Move support out of these files into llvm.[ch] and remove LLVM includes from those files. As disassembl routines can fail, make failure the only option without HAVE_LIBLLVM_SUPPORT. For simplicity's sake, duplicate the read_symbol utility function.
The intent with moving LLVM support into a single file is that dynamic support, using dlopen for libllvm, can be added in later patches. This can potentially always succeed or fail, so relying on ifdefs isn't sufficient. Using dlopen is a useful option to minimize the perf tools dependencies and potentially size.
--- tools/perf/util/Build | 1 + tools/perf/util/disasm.c | 260 +----------------------------- tools/perf/util/disasm.h | 2 + tools/perf/util/llvm.c | 326 ++++++++++++++++++++++++++++++++++++++ tools/perf/util/llvm.h | 24 +++ tools/perf/util/srcline.c | 65 ++------ tools/perf/util/srcline.h | 6 + 7 files changed, 373 insertions(+), 311 deletions(-) create mode 100644 tools/perf/util/llvm.c create mode 100644 tools/perf/util/llvm.h
tools/perf/util/Build +1 -0
@@ -26,6 +26,7 @@ perf-util-y += evswitch.o perf-util-y += find_bit.o perf-util-y += get_current_dir_name.o perf-util-y += levenshtein.o +perf-util-y += llvm.o perf-util-y += mmap.o perf-util-y += memswap.o perf-util-y += parse-events.o
tools/perf/util/disasm.c +2 -258
289 lines not on this page · raw message
tools/perf/util/disasm.h +2 -0
@@ -128,4 +128,6 @@ int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size,int symbol__disassemble (struct symbol *sym,struct annotate_args *args); +char *expand_tabs (char *line,char **storage,size_t *storage_len); +#endif /* __PERF_UTIL_DISASM_H */
tools/perf/util/llvm.c new file +326 -0
326 lines not on this page · raw message
tools/perf/util/llvm.h new file +24 -0
@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_LLVM_H +#define __PERF_LLVM_H + +#include <stdbool.h> +#include <linux/types.h> + +struct annotate_args ; +struct dso ; +struct inline_node ; +struct symbol ; + +int llvm__addr2line (const char *dso_name,u64 addr, +char **file,unsigned int *line,struct dso *dso, +bool unwind_inlines,struct inline_node *node, +struct symbol *sym); + + +void dso__free_a2l_llvm (struct dso *dso); + +int symbol__disassemble_llvm (const char *filename,struct symbol *sym, +struct annotate_args *args); + +#endif /* __PERF_LLVM_H */
tools/perf/util/srcline.c +12 -53
103 lines not on this page · raw message
tools/perf/util/srcline.h +6 -0
@@ -55,4 +55,10 @@ struct inline_node *inlines__tree_find(struct rb_root_cached *tree, u64 addr);/* delete all nodes within the tree of inline_node s */ void inlines__tree_delete (struct rb_root_cached *tree); +int inline_list__append (struct symbol *symbol,char *srcline,struct inline_node *node); +char *srcline_from_fileline (const char *file,unsigned int line); +struct symbol *new_inline_sym (struct dso *dso, +struct symbol *base_sym, +const char *funcname); +#endif /* PERF_SRCLINE_H */
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 5/19 perf capstone: Remove open_capstone_handle
In reply to Ian Rogersopen_capstone_handle is similar to capstone_init and used only by symbol__disassemble_capstone. symbol__disassemble_capstone_powerpc already uses capstone_init, transition symbol__disassemble_capstone and eliminate open_capstone_handle.
--- tools/perf/util/capstone.c | 34 ++++++---------------------------- 1 file changed, 6 insertions(+), 28 deletions(-)
tools/perf/util/capstone.c +6 -28
@@ -137,33 +137,6 @@ ssize_t capstone__fprintf_insn_asm(struct machine *machine __maybe_unused,#endif } -#ifdef HAVE_LIBCAPSTONE_SUPPORT -static int open_capstone_handle (struct annotate_args *args,bool is_64bit,csh *handle) -{ -struct annotation_options *opt = args->options; -cs_mode mode = is_64bit ?CS_MODE_64 :CS_MODE_32 ; - -/* TODO: support more architectures */ -if (!arch__is (args->arch,"x86" )) -return -1 ; - -if (cs_open (CS_ARCH_X86 , mode, handle) !=CS_ERR_OK ) -return -1 ; - -if (!opt->disassembler_style || - !strcmp (opt->disassembler_style,"att" )) -cs_option (*handle,CS_OPT_SYNTAX ,CS_OPT_SYNTAX_ATT ); - -/* -* Resolving address operands to symbols is implemented -* on x86 by investigating instruction details. -*/ -cs_option (*handle,CS_OPT_DETAIL ,CS_OPT_ON ); - -return 0 ; -} -#endif -#ifdef HAVE_LIBCAPSTONE_SUPPORT static void print_capstone_detail (cs_insn *insn,char *buf,size_t len,struct annotate_args *args,u64 addr)
@@ -309,6 +282,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,cs_insn *insn =NULL ;char disasm_buf[512 ];struct disasm_line *dl; +bool disassembler_style = false;if (args->options->objdump_path)return -1 ;
@@ -333,7 +307,11 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,annotation_line__add (&dl->al, ¬es->src->source); -if (open_capstone_handle (args, is_64bit, &handle) <0 ) +if (!args->options->disassembler_style || + !strcmp (args->options->disassembler_style,"att" )) + disassembler_style = true; + +if (capstone_init (maps__machine (args->ms.maps), &handle, is_64bit, disassembler_style) <0 ) goto err; needs_cs_close = true;
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 6/19 perf capstone: Support for dlopen-ing libcapstone.so
In reply to Ian RogersIf perf wasn't built against libcapstone, no HAVE_LIBCAPSTONE_SUPPORT, support dlopen-ing libcapstone.so and then calling the necessary functions by looking them up using dlsym. Reverse engineer the types in the API using pahole, adding only what's used in the perf code or necessary for the sake of struct size and alignment.
--- tools/perf/util/capstone.c | 287 ++++++++++++++++++++++++++++++++----- 1 file changed, 248 insertions(+), 39 deletions(-)
tools/perf/util/capstone.c +248 -39
@@ -11,19 +11,249 @@#include "print_insn.h" #include "symbol.h" #include "thread.h" +#include <dlfcn.h> #include <fcntl.h> +#include <inttypes.h> #include <string.h> #ifdef HAVE_LIBCAPSTONE_SUPPORT #include <capstone/capstone.h> +#else +typedef size_t csh ; +enum cs_arch { +CS_ARCH_ARM =0 , +CS_ARCH_ARM64 =1 , +CS_ARCH_X86 =3 , +CS_ARCH_SYSZ =6 , +}; +enum cs_mode { +CS_MODE_ARM =0 , +CS_MODE_32 =1 <<2 , +CS_MODE_64 =1 <<3 , +CS_MODE_V8 =1 <<6 , +CS_MODE_BIG_ENDIAN =1 <<31 , +}; +enum cs_opt_type { +CS_OPT_SYNTAX =1 , +CS_OPT_DETAIL =2 , +}; +enum cs_opt_value { +CS_OPT_SYNTAX_ATT =2 , +CS_OPT_ON =3 , +}; +enum cs_err { +CS_ERR_OK =0 , +CS_ERR_HANDLE =3 , +}; +enum x86_op_type { +X86_OP_IMM =2 , +X86_OP_MEM =3 , +}; +enum x86_reg { +X86_REG_RIP =41 , +}; +typedef int32_t x86_avx_bcast ; +struct x86_op_mem { +enum x86_reg segment; +enum x86_reg base; +enum x86_reg index; +int scale; +int64_t disp; +}; + +struct cs_x86_op { +enum x86_op_type type; +union { +enum x86_reg reg; +int64_t imm; +struct x86_op_mem mem; + }; +uint8_t size; +uint8_t access; +x86_avx_bcast avx_bcast; +bool avx_zero_opmask; +}; +struct cs_x86_encoding { +uint8_t modrm_offset; +uint8_t disp_offset; +uint8_t disp_size; +uint8_t imm_offset; +uint8_t imm_size; +}; +typedef int32_t x86_xop_cc ; +typedef int32_t x86_sse_cc ; +typedef int32_t x86_avx_cc ; +typedef int32_t x86_avx_rm ; +struct cs_x86 { +uint8_t prefix[4 ]; +uint8_t opcode[4 ]; +uint8_t rex; +uint8_t addr_size; +uint8_t modrm; +uint8_t sib; +int64_t disp; +enum x86_reg sib_index; +int8_t sib_scale; +enum x86_reg sib_base; +x86_xop_cc xop_cc; +x86_sse_cc sse_cc; +x86_avx_cc avx_cc; +bool avx_sae; +x86_avx_rm avx_rm; +union { +uint64_t eflags; +uint64_t fpu_flags; + }; +uint8_t op_count; +struct cs_x86_op operands[8 ]; +struct cs_x86_encoding encoding; +}; +struct cs_detail { +uint16_t regs_read[12 ]; +uint8_t regs_read_count; +uint16_t regs_write[20 ]; +uint8_t regs_write_count; +uint8_t groups[8 ]; +uint8_t groups_count; + +union { +struct cs_x86 x86; + }; +}; +struct cs_insn { +unsigned int id; +uint64_t address; +uint16_t size; +uint8_t bytes[16 ]; +char mnemonic[32 ]; +char op_str[160 ]; +struct cs_detail *detail; +}; +#endif + +#ifndef HAVE_LIBCAPSTONE_SUPPORT +static void *perf_cs_dll_handle (void ) +{ +static bool dll_handle_init; +static void *dll_handle; + +if (!dll_handle_init) { + dll_handle_init = true; + dll_handle =dlopen ("libcapstone.so" ,RTLD_LAZY ); +if (!dll_handle) +pr_debug ("dlopen failed for libcapstone.so\n" ); + } +return dll_handle; +} +#endif + +static enum cs_err perf_cs_open (enum cs_arch arch,enum cs_mode mode,csh *handle) +{ +#ifdef HAVE_LIBCAPSTONE_SUPPORT +return cs_open (arch, mode, handle); +#else +static bool fn_init; +static enum cs_err (*fn)(enum cs_arch arch,enum cs_mode mode,csh *handle); + +if (!fn_init) { + fn =dlsym (perf_cs_dll_handle (),"cs_open" ); +if (!fn) +pr_debug ("dlsym failed for cs_open\n" ); + fn_init = true; + } +if (!fn) +return CS_ERR_HANDLE ; +return fn (arch, mode, handle); +#endif +} + +static enum cs_err perf_cs_option (csh handle,enum cs_opt_type type,size_t value) +{ +#ifdef HAVE_LIBCAPSTONE_SUPPORT +return cs_option (handle, type, value); +#else +static bool fn_init; +static enum cs_err (*fn)(csh handle,enum cs_opt_type type,size_t value); + +if (!fn_init) { + fn =dlsym (perf_cs_dll_handle (),"cs_option" ); +if (!fn) +pr_debug ("dlsym failed for cs_option\n" ); + fn_init = true; + } +if (!fn) +return CS_ERR_HANDLE ; +return fn (handle, type, value); +#endif +} + +static size_t perf_cs_disasm (csh handle,const uint8_t *code,size_t code_size, +uint64_t address,size_t count,struct cs_insn **insn) +{ +#ifdef HAVE_LIBCAPSTONE_SUPPORT +return cs_disasm (handle, code, code_size, address, count, insn); +#else +static bool fn_init; +static enum cs_err (*fn)(csh handle,const uint8_t *code,size_t code_size, +uint64_t address,size_t count,struct cs_insn **insn); + +if (!fn_init) { + fn =dlsym (perf_cs_dll_handle (),"cs_disasm" ); +if (!fn) +pr_debug ("dlsym failed for cs_disasm\n" ); + fn_init = true; + } +if (!fn) +return CS_ERR_HANDLE ; +return fn (handle, code, code_size, address, count, insn);#endif +} +static void perf_cs_free (struct cs_insn *insn,size_t count) +{#ifdef HAVE_LIBCAPSTONE_SUPPORT +cs_free (insn, count); +#else +static bool fn_init; +static void (*fn)(struct cs_insn *insn,size_t count); + +if (!fn_init) { + fn =dlsym (perf_cs_dll_handle (),"cs_free" ); +if (!fn) +pr_debug ("dlsym failed for cs_free\n" ); + fn_init = true; + } +if (!fn) +return ; +fn (insn, count); +#endif +} + +static enum cs_err perf_cs_close (csh *handle) +{ +#ifdef HAVE_LIBCAPSTONE_SUPPORT +return cs_close (handle); +#else +static bool fn_init; +static enum cs_err (*fn)(csh *handle); + +if (!fn_init) { + fn =dlsym (perf_cs_dll_handle (),"cs_close" ); +if (!fn) +pr_debug ("dlsym failed for cs_close\n" ); + fn_init = true; + } +if (!fn) +return CS_ERR_HANDLE ; +return fn (handle); +#endif +} +static int capstone_init (struct machine *machine,csh *cs_handle,bool is64,bool disassembler_style) { -cs_arch arch; -cs_mode mode; +enum cs_arch arch; +enum cs_mode mode;if (machine__is (machine,"x86_64" ) && is64) { arch =CS_ARCH_X86 ;
@@ -44,7 +274,7 @@ static int capstone_init(struct machine *machine, csh *cs_handle, bool is64,return -1 ; } -if (cs_open (arch, mode, cs_handle) !=CS_ERR_OK ) { +if (perf_cs_open (arch, mode, cs_handle) !=CS_ERR_OK ) {pr_warning_once ("cs_open failed\n" );return -1 ; }
@@ -56,27 +286,25 @@ static int capstone_init(struct machine *machine, csh *cs_handle, bool is64,* is set via annotation args */ if (disassembler_style) -cs_option (*cs_handle,CS_OPT_SYNTAX ,CS_OPT_SYNTAX_ATT ); +perf_cs_option (*cs_handle,CS_OPT_SYNTAX ,CS_OPT_SYNTAX_ATT );/* * Resolving address operands to symbols is implemented * on x86 by investigating instruction details. */ - cs_option(*cs_handle, CS_OPT_DETAIL, CS_OPT_ON); +perf_cs_option (*cs_handle,CS_OPT_DETAIL ,CS_OPT_ON ); }return 0 ; } -#endif -#ifdef HAVE_LIBCAPSTONE_SUPPORT -static size_t print_insn_x86 (struct thread *thread,u8 cpumode,cs_insn *insn, +static size_t print_insn_x86 (struct thread *thread,u8 cpumode,struct cs_insn *insn,int print_opts,FILE *fp) {struct addr_location al;size_t printed =0 ;if (insn->detail && insn->detail->x86.op_count ==1 ) { -cs_x86_op *op = &insn->detail->x86.operands[0 ]; +struct cs_x86_op *op = &insn->detail->x86.operands[0 ];addr_location__init (&al); if (op->type == X86_OP_IMM &&
@@ -94,7 +322,6 @@ static size_t print_insn_x86(struct thread *thread, u8 cpumode, cs_insn *insn, printed +=fprintf (fp,"%s %s" , insn[0 ].mnemonic, insn[0 ].op_str);return printed; } -#endif ssize_t capstone__fprintf_insn_asm(struct machine *machine __maybe_unused,
@@ -105,9 +332,8 @@ ssize_t capstone__fprintf_insn_asm(struct machine *machine __maybe_unused, uint64_t ip __maybe_unused, int *lenp __maybe_unused, int print_opts __maybe_unused, FILE *fp __maybe_unused) { -#ifdef HAVE_LIBCAPSTONE_SUPPORT size_t printed; -cs_insn *insn; +struct cs_insn *insn;csh cs_handle;size_t count;int ret;
@@ -117,7 +343,7 @@ ssize_t capstone__fprintf_insn_asm(struct machine *machine __maybe_unused,if (ret <0 )return ret; - count =cs_disasm (cs_handle, code, code_size, ip,1 , &insn); + count =perf_cs_disasm (cs_handle, code, code_size, ip,1 , &insn);if (count >0 ) {if (machine__normalized_is (machine,"x86" )) printed =print_insn_x86 (thread, cpumode, &insn[0 ], print_opts, fp);
@@ -125,20 +351,16 @@ ssize_t capstone__fprintf_insn_asm(struct machine *machine __maybe_unused, printed =fprintf (fp,"%s %s" , insn[0 ].mnemonic, insn[0 ].op_str);if (lenp) *lenp = insn->size; - cs_free(insn, count); +perf_cs_free (insn, count); }else { printed =-1 ; } -cs_close (&cs_handle); +perf_cs_close (&cs_handle);return printed; -#else -return -1 ; -#endif } -#ifdef HAVE_LIBCAPSTONE_SUPPORT -static void print_capstone_detail (cs_insn *insn,char *buf,size_t len, +static void print_capstone_detail (struct cs_insn *insn,char *buf,size_t len,struct annotate_args *args,u64 addr) {int i;
@@ -153,7 +375,7 @@ static void print_capstone_detail(cs_insn *insn, char *buf, size_t len,return ;for (i =0 ; i < insn->detail->x86.op_count; i++) { -cs_x86_op *op = &insn->detail->x86.operands[i]; +struct cs_x86_op *op = &insn->detail->x86.operands[i];u64 orig_addr;if (op->type !=X86_OP_MEM )
@@ -194,9 +416,7 @@ static void print_capstone_detail(cs_insn *insn, char *buf, size_t len,break ; } } -#endif -#ifdef HAVE_LIBCAPSTONE_SUPPORTstruct find_file_offset_data {u64 ip;u64 offset;
@@ -213,9 +433,7 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg) }return 0 ; } -#endif -#ifdef HAVE_LIBCAPSTONE_SUPPORT static u8 *read_symbol (const char *filename,struct map *map,struct symbol *sym,u64 *len,bool *is_64bit)
@@ -262,13 +480,11 @@ read_symbol(const char *filename, struct map *map, struct symbol *sym,free (buf);return NULL ; } -#endif int symbol__disassemble_capstone (const char *filename__maybe_unused ,struct symbol *sym__maybe_unused ,struct annotate_args *args__maybe_unused ) { -#ifdef HAVE_LIBCAPSTONE_SUPPORT struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms.map;u64 start =map__rip_2objdump (map, sym->start);
@@ -279,7 +495,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,bool needs_cs_close = false;u8 *buf =NULL ;csh handle; -cs_insn *insn =NULL ; +struct cs_insn *insn =NULL ;char disasm_buf[512 ];struct disasm_line *dl;bool disassembler_style = false;
@@ -316,7 +532,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, needs_cs_close = true; - free_count = count =cs_disasm (handle, buf, len, start, len, &insn); + free_count = count =perf_cs_disasm (handle, buf, len, start, len, &insn);for (i =0 , offset =0 ; i < count; i++) {int printed;
@@ -355,9 +571,9 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, out:if (needs_cs_close) { -cs_close (&handle); +perf_cs_close (&handle);if (free_count >0 ) -cs_free (insn, free_count); +perf_cs_free (insn, free_count); }free (buf);return count <0 ? count :0 ;
@@ -377,16 +593,12 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, } count =-1 ; goto out; -#else -return -1 ; -#endif }int symbol__disassemble_capstone_powerpc (const char *filename__maybe_unused ,struct symbol *sym__maybe_unused ,struct annotate_args *args__maybe_unused ) { -#ifdef HAVE_LIBCAPSTONE_SUPPORT struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms.map;struct dso *dso =map__dso (map);
@@ -499,7 +711,7 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused, out:if (needs_cs_close) -cs_close (&handle); +perf_cs_close (&handle);free (buf);return count <0 ? count :0 ;
@@ -508,7 +720,4 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused,close (fd); count =-1 ; goto out; -#else -return -1 ; -#endif }
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 7/19 perf llvm: Support for dlopen-ing libLLVM.so
In reply to Ian RogersIf perf wasn't built against libLLVM, no HAVE_LIBLLVM_SUPPORT, support dlopen-ing libLLVM.so and then calling the necessary functions by looking them up using dlsym. As the C++ code in llvm-c-helpers used for addr2line is problematic to call using dlsym, build that C++ code against libLLVM.so as a separate shared object, and support dynamic loading of it. This build option is enabled with LIBLLVM_DYNAMIC=1
--- tools/perf/Makefile.config | 13 ++ tools/perf/Makefile.perf | 23 ++- tools/perf/tests/make | 2 + tools/perf/util/Build | 2 +- tools/perf/util/llvm-c-helpers.cpp | 113 +++++++++++- tools/perf/util/llvm.c | 271 +++++++++++++++++++++++++---- 6 files changed, 386 insertions(+), 38 deletions(-)
tools/perf/Makefile.config +13 -0
@@ -973,6 +973,19 @@ ifndef NO_LIBLLVM NO_LIBLLVM := 1 endif endif +ifdef LIBLLVM_DYNAMIC + ifndef NO_LIBLLVM + $(error LIBLLVM_DYNAMIC should be used with NO_LIBLLVM) + endif + $(call feature_check,llvm-perf) + ifneq ($(feature-llvm-perf), 1) + $(warning LIBLLVM_DYNAMIC requires libLLVM.so which wasn't feature detected) + endif + CFLAGS += -DHAVE_LIBLLVM_DYNAMIC + CFLAGS += $(shell $(LLVM_CONFIG) --cflags) + CXXFLAGS += -DHAVE_LIBLLVM_DYNAMIC + CXXFLAGS += $(shell $(LLVM_CONFIG) --cxxflags) +endif ifndef NO_DEMANGLE $(call feature_check,cxa-demangle)
tools/perf/Makefile.perf +22 -1
@@ -423,6 +423,12 @@ ifndef NO_JVMTI PROGRAMS += $(OUTPUT)$(LIBJVMTI) endif +LIBPERF_LLVM = libperf-llvm.so + +ifdef LIBLLVM_DYNAMIC +PROGRAMS += $(OUTPUT)$(LIBPERF_LLVM) +endif + DLFILTERS := dlfilter-test-api-v0.so dlfilter-test-api-v2.so dlfilter-show-cycles.so DLFILTERS := $(patsubst %,$(OUTPUT)dlfilters/%,$(DLFILTERS))
@@ -995,6 +1001,16 @@ $(LIBSYMBOL)-clean: $(call QUIET_CLEAN, libsymbol) $(Q)$(RM) -r -- $(LIBSYMBOL_OUTPUT) +ifdef LIBLLVM_DYNAMIC +LIBPERF_LLVM_CXXFLAGS := $(call filter-out,-DHAVE_LIBLLVM_DYNAMIC,$(CXXFLAGS)) -DHAVE_LIBLLVM_SUPPORT +LIBPERF_LLVM_LIBS = -L$(shell $(LLVM_CONFIG) --libdir) $(LIBLLVM) -lstdc++ + +$(OUTPUT)$(LIBPERF_LLVM): util/llvm-c-helpers.cpp + $(QUIET_LINK)$(CXX) $(LIBPERF_LLVM_CXXFLAGS) $(LIBPERF_LLVM_LIBS) -shared -o $@ $< + +$(OUTPUT)perf: $(OUTPUT)$(LIBPERF_LLVM) +endif + help: @echo 'Perf make targets:' @echo ' doc - make *all* documentation (see below)'
@@ -1096,6 +1112,11 @@ ifndef NO_JVMTI $(call QUIET_INSTALL, $(LIBJVMTI)) \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(libdir_SQ)'; \ $(INSTALL) $(OUTPUT)$(LIBJVMTI) '$(DESTDIR_SQ)$(libdir_SQ)'; +endif +ifdef LIBLLVM_DYNAMIC + $(call QUIET_INSTALL, $(LIBPERF_LLVM)) \ + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(libdir_SQ)'; \ + $(INSTALL) $(OUTPUT)$(LIBPERF_LLVM) '$(DESTDIR_SQ)$(libdir_SQ)'; endif $(call QUIET_INSTALL, libexec) \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)'
@@ -1281,7 +1302,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( -name '\.*.cmd' -delete -o -name '\.*.d' -delete -o -name '*.shellcheck_log' -delete $(Q)$(RM) $(OUTPUT).config-detected $(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 \ - perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so + perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI) $(OUTPUT)$(LIBPERF_LLVM) $(call QUIET_CLEAN, core-gen) $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo \ $(OUTPUT)common-cmds.h TAGS tags cscope* $(OUTPUT)PERF-VERSION-FILE \ $(OUTPUT)FEATURE-DUMP $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex* \
tools/perf/tests/make +2 -0
@@ -93,6 +93,7 @@ make_no_libbpf := NO_LIBBPF=1 make_libbpf_dynamic := LIBBPF_DYNAMIC=1 make_no_libbpf_DEBUG := NO_LIBBPF=1 DEBUG=1 make_no_libllvm := NO_LIBLLVM=1 +make_libllvm_dynamic := NO_LIBLLVM=1 LIBLLVM_DYNAMIC=1 make_with_babeltrace:= LIBBABELTRACE=1 make_with_coresight := CORESIGHT=1 make_no_sdt := NO_SDT=1
@@ -162,6 +163,7 @@ run += make_no_auxtrace run += make_no_libbpf run += make_no_libbpf_DEBUG run += make_no_libllvm +run += make_libllvm_dynamic run += make_no_sdt run += make_no_syscall_tbl run += make_with_babeltrace
tools/perf/util/Build +1 -1
@@ -27,6 +27,7 @@ perf-util-y += find_bit.o perf-util-y += get_current_dir_name.o perf-util-y += levenshtein.o perf-util-y += llvm.o +perf-util-y += llvm-c-helpers.o perf-util-y += mmap.o perf-util-y += memswap.o perf-util-y += parse-events.o
@@ -248,7 +249,6 @@ perf-util-$(CONFIG_CXX_DEMANGLE) += demangle-cxx.o perf-util-y += demangle-ocaml.o perf-util-y += demangle-java.o perf-util-y += demangle-rust-v0.o -perf-util-$(CONFIG_LIBLLVM) += llvm-c-helpers.o CFLAGS_demangle-rust-v0.o += -Wno-shadow -Wno-declaration-after-statement \ -Wno-switch-default -Wno-switch-enum -Wno-missing-field-initializers
tools/perf/util/llvm-c-helpers.cpp +107 -6
192 lines not on this page · raw message
tools/perf/util/llvm.c +241 -30
372 lines not on this page · raw message
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 8/19 perf llvm: Mangle libperf-llvm.so function names
In reply to Ian RogersFor a function like llvm_addr2line having the libperf-llvm.so exported symbol named llvm_addr2line meant that the perf llvm_addr2line could sometimes erroneously be returned. This led to infinite recursion and eventual stack overflow. To avoid this conflict add a new BUILDING_PERF_LLVMSO when libperf-llvm.so is being built and use it to alter the behavior of MANGLE_PERF_LLVM_API, a macro that prefixes the name when libperf-llvm.so is being built. The prefixed named avoids the name collision.
--- tools/perf/Makefile.perf | 3 ++- tools/perf/util/llvm-c-helpers.cpp | 29 ++++++++++++++++++----------- tools/perf/util/llvm-c-helpers.h | 24 ++++++++++++++++-------- 3 files changed, 36 insertions(+), 20 deletions(-)
tools/perf/Makefile.perf +2 -1
@@ -1002,7 +1002,8 @@ $(LIBSYMBOL)-clean: $(Q)$(RM) -r -- $(LIBSYMBOL_OUTPUT) ifdef LIBLLVM_DYNAMIC -LIBPERF_LLVM_CXXFLAGS := $(call filter-out,-DHAVE_LIBLLVM_DYNAMIC,$(CXXFLAGS)) -DHAVE_LIBLLVM_SUPPORT +LIBPERF_LLVM_CXXFLAGS := $(call filter-out,-DHAVE_LIBLLVM_DYNAMIC,$(CXXFLAGS)) +LIBPERF_LLVM_CXXFLAGS += -DHAVE_LIBLLVM_SUPPORT -DBUILDING_PERF_LLVMSO LIBPERF_LLVM_LIBS = -L$(shell $(LLVM_CONFIG) --libdir) $(LIBLLVM) -lstdc++ $(OUTPUT)$(LIBPERF_LLVM): util/llvm-c-helpers.cpp
tools/perf/util/llvm-c-helpers.cpp +18 -11
@@ -99,10 +99,12 @@ static int extract_file_and_line(const DILineInfo &line_info, char **file, #endif extern "C" -int llvm_addr2line(const char *dso_name __maybe_unused, u64 addr __maybe_unused, - char **file __maybe_unused, unsigned int *line __maybe_unused, - bool unwind_inlines __maybe_unused, - llvm_a2l_frame **inline_frames __maybe_unused) +int MANGLE_PERF_LLVM_API(llvm_addr2line)(const char *dso_name __maybe_unused, + u64 addr __maybe_unused, + char **file __maybe_unused, + unsigned int *line __maybe_unused, + bool unwind_inlines __maybe_unused, + llvm_a2l_frame **inline_frames __maybe_unused) { #if defined(HAVE_LIBLLVM_SUPPORT) && !defined(HAVE_LIBLLVM_DYNAMIC) LLVMSymbolizer *symbolizer = get_symbolizer();
@@ -177,7 +179,8 @@ int llvm_addr2line(const char *dso_name __maybe_unused, u64 addr __maybe_unused, if (!handle) return 0; - fn = reinterpret_cast<decltype(fn)>(dlsym(handle, "llvm_addr2line")); + fn = reinterpret_cast<decltype(fn)>( + dlsym(handle, MANGLE_PERF_LLVM_API_STR(llvm_addr2line))); if (!fn) pr_debug("dlsym failed for llvm_addr2line\n"); fn_init = true;
@@ -215,8 +218,9 @@ make_symbol_relative_string(struct dso *dso, const char *sym_name, #endif extern "C" -char *llvm_name_for_code(struct dso *dso __maybe_unused, const char *dso_name __maybe_unused, - u64 addr __maybe_unused) +char *MANGLE_PERF_LLVM_API(llvm_name_for_code)(struct dso *dso __maybe_unused, + const char *dso_name __maybe_unused, + u64 addr __maybe_unused) { #if defined(HAVE_LIBLLVM_SUPPORT) && !defined(HAVE_LIBLLVM_DYNAMIC) LLVMSymbolizer *symbolizer = get_symbolizer();
@@ -242,7 +246,8 @@ char *llvm_name_for_code(struct dso *dso __maybe_unused, const char *dso_name __ if (!handle) return NULL; - fn = reinterpret_cast<decltype(fn)>(dlsym(handle, "llvm_name_for_code")); + fn = reinterpret_cast<decltype(fn)>( + dlsym(handle, MANGLE_PERF_LLVM_API_STR(llvm_name_for_code))); if (!fn) pr_debug("dlsym failed for llvm_name_for_code\n"); fn_init = true;
@@ -256,8 +261,9 @@ char *llvm_name_for_code(struct dso *dso __maybe_unused, const char *dso_name __ } extern "C" -char *llvm_name_for_data(struct dso *dso __maybe_unused, const char *dso_name __maybe_unused, - u64 addr __maybe_unused) +char *MANGLE_PERF_LLVM_API(llvm_name_for_data)(struct dso *dso __maybe_unused, + const char *dso_name __maybe_unused, + u64 addr __maybe_unused) { #if defined(HAVE_LIBLLVM_SUPPORT) && !defined(HAVE_LIBLLVM_DYNAMIC) LLVMSymbolizer *symbolizer = get_symbolizer();
@@ -283,7 +289,8 @@ char *llvm_name_for_data(struct dso *dso __maybe_unused, const char *dso_name __ if (!handle) return NULL; - fn = reinterpret_cast<decltype(fn)>(dlsym(handle, "llvm_name_for_data")); + fn = reinterpret_cast<decltype(fn)>( + dlsym(handle, MANGLE_PERF_LLVM_API_STR(llvm_name_for_data))); if (!fn) pr_debug("dlsym failed for llvm_name_for_data\n"); fn_init = true;
tools/perf/util/llvm-c-helpers.h +16 -8
@@ -13,6 +13,14 @@ extern "C" { #endif +/* Support name mangling so that libperf_llvm.so's names don't match those in perf. */ +#ifdef BUILDING_PERF_LLVMSO +#define MANGLE_PERF_LLVM_API(x) PERF_LLVM_SO_ ## x +#else +#define MANGLE_PERF_LLVM_API(x) x +#endif +#define MANGLE_PERF_LLVM_API_STR(x) "PERF_LLVM_SO_" #x + struct dso; struct llvm_a2l_frame {
@@ -37,12 +45,12 @@ struct llvm_a2l_frame {* a newly allocated array with that length. The caller is then responsible * for freeing both the strings and the array itself. */ -int llvm_addr2line (const char * dso_name, -u64 addr, -char ** file, -unsigned int * line, -bool unwind_inlines, -struct llvm_a2l_frame ** inline_frames); +int MANGLE_PERF_LLVM_API (llvm_addr2line )(const char *dso_name, +u64 addr, +char **file, +unsigned int *line, +bool unwind_inlines, +struct llvm_a2l_frame **inline_frames);/* * Simple symbolizers for addresses; will convert something like
@@ -50,8 +58,8 @@ int llvm_addr2line(const char* dso_name,* * The returned value must be freed by the caller, with free(). */ -char *llvm_name_for_code (struct dso *dso,const char *dso_name,u64 addr); -char *llvm_name_for_data (struct dso *dso,const char *dso_name,u64 addr); +char *MANGLE_PERF_LLVM_API (llvm_name_for_code )(struct dso *dso,const char *dso_name,u64 addr); +char *MANGLE_PERF_LLVM_API (llvm_name_for_data )(struct dso *dso,const char *dso_name,u64 addr); #ifdef __cplusplus }
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 9/19 perf dso: Move read_symbol from llvm/capstone to dso
In reply to Ian RogersMove the read_symbol function to dso.h, make the return type const and add a mutable out_buf out parameter. In future changes this will allow a code pointer to be returned without necessary allocating memory.
--- tools/perf/util/capstone.c | 64 +++++----------------------- tools/perf/util/dso.c | 67 +++++++++++++++++++++++++++++ tools/perf/util/dso.h | 4 ++ tools/perf/util/llvm.c | 87 +++++++------------------------------- 4 files changed, 97 insertions(+), 125 deletions(-)
tools/perf/util/capstone.c +11 -53
@@ -434,66 +434,23 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg)return 0 ; } -static u8 * -read_symbol (const char *filename,struct map *map,struct symbol *sym, -u64 *len,bool *is_64bit) -{ -struct dso *dso =map__dso (map); -struct nscookie nsc; -u64 start =map__rip_2objdump (map, sym->start); -u64 end =map__rip_2objdump (map, sym->end); -int fd, count; -u8 *buf =NULL ; -struct find_file_offset_data data = { - .ip = start, - }; - - *is_64bit = false; - -nsinfo__mountns_enter (dso__nsinfo (dso), &nsc); - fd =open (filename,O_RDONLY ); -nsinfo__mountns_exit (&nsc); -if (fd <0 ) -return NULL ; - -if (file__read_maps (fd,/*exe=*/ true, find_file_offset, &data, - is_64bit) ==0 ) - goto err; - - *len = end - start; - buf =malloc (*len); -if (buf ==NULL ) - goto err; - - count =pread (fd, buf, *len, data.offset); -close (fd); - fd =-1 ; - -if ((u64 )count != *len) - goto err; - -return buf; - -err: -if (fd >=0 ) -close (fd); -free (buf); -return NULL ; -} -int symbol__disassemble_capstone (const char *filename__maybe_unused ,struct symbol *sym__maybe_unused ,struct annotate_args *args__maybe_unused ) {struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms.map; +struct dso *dso =map__dso (map);u64 start =map__rip_2objdump (map, sym->start); -u64 len;u64 offset;int i, count, free_count;bool is_64bit = false;bool needs_cs_close = false; -u8 *buf =NULL ; +/* Malloc-ed buffer containing instructions read from disk. */ +u8 *code_buf =NULL ; +/* Pointer to code to be disassembled. */ +const u8 *buf; +u64 buf_len;csh handle;struct cs_insn *insn =NULL ;char disasm_buf[512 ];
@@ -503,7 +460,8 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,if (args->options->objdump_path)return -1 ; - buf =read_symbol (filename, map, sym, &len, &is_64bit); + buf =dso__read_symbol (dso, filename, map, sym, + &code_buf, &buf_len, &is_64bit);if (buf ==NULL )return -1 ;
@@ -532,7 +490,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, needs_cs_close = true; - free_count = count =perf_cs_disasm (handle, buf, len, start, len, &insn); + free_count = count =perf_cs_disasm (handle, buf, buf_len, start, buf_len, &insn);for (i =0 , offset =0 ; i < count; i++) {int printed;
@@ -556,7 +514,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, }/* It failed in the middle: probably due to unknown instructions */ -if (offset != len) { +if (offset != buf_len) {struct list_head *list = ¬es->src->source;/* Discard all lines and fallback to objdump */
@@ -575,7 +533,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,if (free_count >0 )perf_cs_free (insn, free_count); } -free (buf); +free (code_buf);return count <0 ? count :0 ; err:
tools/perf/util/dso.c +67 -0
70 lines not on this page · raw message
tools/perf/util/dso.h +4 -0
@@ -903,4 +903,8 @@ u64 dso__findnew_global_type(struct dso *dso, u64 addr, u64 offset);bool perf_pid_map_tid (const char *dso_name,int *tid);bool is_perf_pid_map_name (const char *dso_name); +const u8 *dso__read_symbol (struct dso *dso,const char *symfs_filename, +const struct map *map,const struct symbol *sym, +u8 **out_buf,u64 *out_buf_len,bool *is_64bit); +#endif /* __PERF_DSO */
tools/perf/util/llvm.c +15 -72
122 lines not on this page · raw message
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 10/19 perf dso: Support BPF programs in dso__read_symbol
In reply to Ian RogersSet the buffer to the code in the BPF linear info. This enables BPF JIT code disassembly by LLVM and capstone. Move the disassmble_bpf calls to disassemble_objdump so that they are only called after falling back to the objdump option.
--- tools/perf/util/disasm.c | 12 +++--- tools/perf/util/dso.c | 85 +++++++++++++++++++++++++--------------- 2 files changed, 60 insertions(+), 37 deletions(-)
tools/perf/util/disasm.c +7 -5
@@ -1501,6 +1501,12 @@ static int symbol__disassemble_objdump(const char *filename, struct symbol *sym,struct child_process objdump_process;int err; +if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_PROG_INFO ) +return symbol__disassemble_bpf (sym, args); + +if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_IMAGE ) +return symbol__disassemble_bpf_image (sym, args); + err =asprintf (&command,"%s %s%s --start-address=0x%016" PRIx64 " --stop-address=0x%016" PRIx64
@@ -1635,11 +1641,7 @@ int symbol__disassemble(struct symbol *sym, struct annotate_args *args)pr_debug ("annotating [%p] %30s : [%p] %30s\n" , dso,dso__long_name (dso), sym, sym->name); -if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_PROG_INFO ) { -return symbol__disassemble_bpf (sym, args); - }else if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_IMAGE ) { -return symbol__disassemble_bpf_image (sym, args); - }else if (dso__binary_type (dso) ==DSO_BINARY_TYPE__NOT_FOUND ) { +if (dso__binary_type (dso) ==DSO_BINARY_TYPE__NOT_FOUND ) {return SYMBOL_ANNOTATE_ERRNO__COULDNT_DETERMINE_FILE_TYPE ; }else if (dso__is_kcore (dso)) { kce.addr =map__rip_2objdump (map, sym->start);
tools/perf/util/dso.c +53 -32
101 lines not on this page · raw message
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 11/19 perf llvm: Disassemble cleanup
In reply to Ian RogersMove the 3 LLVM initialization routines to be called in a single init_llvm function that has its own bool to avoid repeated initialization. Reduce the scope of triplet and avoid copying strings for x86.
--- tools/perf/util/llvm.c | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-)
tools/perf/util/llvm.c +20 -12
@@ -244,6 +244,17 @@ static void perf_LLVMDisasmDispose(LLVMDisasmContextRef context)#endif } +static void init_llvm (void ) +{ +static bool init; + +if (!init) { +perf_LLVMInitializeAllTargetInfos (); +perf_LLVMInitializeAllTargetMCs (); +perf_LLVMInitializeAllDisassemblers (); + init = true; + } +}static void free_llvm_inline_frames (struct llvm_a2l_frame *inline_frames,int num_frames)
@@ -339,7 +350,6 @@ int symbol__disassemble_llvm(const char *filename, struct symbol *sym,u64 buf_len;u64 pc;bool is_64bit; -char triplet[64 ];char disasm_buf[2048 ];size_t disasm_len;struct disasm_line *dl;
@@ -352,27 +362,25 @@ int symbol__disassemble_llvm(const char *filename, struct symbol *sym,if (args->options->objdump_path)return -1 ; -perf_LLVMInitializeAllTargetInfos (); -perf_LLVMInitializeAllTargetMCs (); -perf_LLVMInitializeAllDisassemblers (); - buf =dso__read_symbol (dso, filename, map, sym, &code_buf, &buf_len, &is_64bit);if (buf ==NULL )return -1 ; +init_llvm ();if (arch__is (args->arch,"x86" )) { -if (is_64bit) -scnprintf (triplet,sizeof (triplet),"x86_64-pc-linux" ); -else -scnprintf (triplet,sizeof (triplet),"i686-pc-linux" ); +const char *triplet = is_64bit ?"x86_64-pc-linux" :"i686-pc-linux" ; + + disasm =perf_LLVMCreateDisasm (triplet, &storage,/*tag_type=*/ 0 , +/*get_op_info=*/ NULL , symbol_lookup_callback); }else { +char triplet[64 ]; +scnprintf (triplet,sizeof (triplet),"%s-linux-gnu" , args->arch->name); + disasm =perf_LLVMCreateDisasm (triplet, &storage,/*tag_type=*/ 0 , +/*get_op_info=*/ NULL , symbol_lookup_callback); } - - disasm =perf_LLVMCreateDisasm (triplet, &storage,0 ,NULL , - symbol_lookup_callback);if (disasm ==NULL ) goto err;
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 12/19 perf dso: Clean up read_symbol error handling
In reply to Ian RogersEnsure errno is set and return to caller for error handling. Unusually for perf the value isn't negated as expected by symbol__strerror_disassemble.
--- tools/perf/util/capstone.c | 3 ++- tools/perf/util/dso.c | 14 ++++++++++++-- tools/perf/util/llvm.c | 3 ++- 3 files changed, 16 insertions(+), 4 deletions(-)
tools/perf/util/capstone.c +2 -1
@@ -12,6 +12,7 @@#include "symbol.h" #include "thread.h" #include <dlfcn.h> +#include <errno.h> #include <fcntl.h> #include <inttypes.h> #include <string.h>
@@ -463,7 +464,7 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, buf =dso__read_symbol (dso, filename, map, sym, &code_buf, &buf_len, &is_64bit);if (buf ==NULL ) -return -1 ; +return errno;/* add the function address and name */ scnprintf(disasm_buf, sizeof(disasm_buf), "%#"PRIx64" <%s>:",
tools/perf/util/dso.c +12 -2
@@ -1831,6 +1831,7 @@ const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename,if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_IMAGE ) {pr_debug ("No BPF image disassembly support\n" ); + errno =EOPNOTSUPP ;return NULL ; }else if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_PROG_INFO ) {#ifdef HAVE_LIBBPF_SUPPORT
@@ -1849,6 +1850,7 @@ const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename,assert (len <= info_linear->info.jited_prog_len);#else pr_debug ("No BPF program disassembly support\n" ); + errno =EOPNOTSUPP ;return NULL ;#endif }else {
@@ -1859,26 +1861,34 @@ const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename, .ip = start, };u8 *code_buf =NULL ; +int saved_errno;nsinfo__mountns_enter (dso__nsinfo (dso), &nsc); fd =open (symfs_filename,O_RDONLY ); + saved_errno = errno;nsinfo__mountns_exit (&nsc); -if (fd <0 ) +if (fd <0 ) { + errno = saved_errno;return NULL ; + } -if (file__read_maps (fd,/*exe=*/ true, find_file_offset, &data, is_64bit) ==0 ) { +if (file__read_maps (fd,/*exe=*/ true, find_file_offset, &data, is_64bit) <=0 ) {close (fd); + errno =ENOENT ;return NULL ; } buf = code_buf =malloc (len);if (buf ==NULL ) {close (fd); + errno =ENOMEM ;return NULL ; } count =pread (fd, code_buf, len, data.offset); + saved_errno = errno;close (fd);if ((u64 )count != len) {free (code_buf); + errno = saved_errno;return NULL ; } *out_buf = code_buf;
tools/perf/util/llvm.c +2 -1
@@ -9,6 +9,7 @@#include "srcline.h" #include "symbol.h" #include <dlfcn.h> +#include <errno.h> #include <fcntl.h> #include <inttypes.h> #include <unistd.h>
@@ -365,7 +366,7 @@ int symbol__disassemble_llvm(const char *filename, struct symbol *sym, buf =dso__read_symbol (dso, filename, map, sym, &code_buf, &buf_len, &is_64bit);if (buf ==NULL ) -return -1 ; +return errno;init_llvm ();if (arch__is (args->arch,"x86" )) {
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 13/19 perf build: Remove libbfd support
In reply to Ian Rogerslibbfd is license incompatible with perf and building requires the BUILD_NONDISTRO=1 build flag. Remove the code to simplify the code base.
--- tools/perf/Documentation/perf-check.txt | 1 - tools/perf/Makefile.config | 43 +---- tools/perf/builtin-check.c | 1 - tools/perf/tests/Build | 1 - tools/perf/tests/builtin-test.c | 1 - tools/perf/tests/pe-file-parsing.c | 101 ---------- tools/perf/tests/tests.h | 1 - tools/perf/util/demangle-cxx.cpp | 13 +- tools/perf/util/disasm_bpf.c | 166 ---------------- tools/perf/util/srcline.c | 243 +----------------------- tools/perf/util/symbol-elf.c | 80 +------- tools/perf/util/symbol.c | 141 +------------- tools/perf/util/symbol.h | 4 - 13 files changed, 7 insertions(+), 789 deletions(-) delete mode 100644 tools/perf/tests/pe-file-parsing.c
tools/perf/Documentation/perf-check.txt +0 -1
@@ -51,7 +51,6 @@ feature:: dwarf_getlocations / HAVE_LIBDW_SUPPORT dwarf-unwind / HAVE_DWARF_UNWIND_SUPPORT auxtrace / HAVE_AUXTRACE_SUPPORT - libbfd / HAVE_LIBBFD_SUPPORT libbpf-strings / HAVE_LIBBPF_STRINGS_SUPPORT libcapstone / HAVE_LIBCAPSTONE_SUPPORT libdw-dwarf-unwind / HAVE_LIBDW_SUPPORT
tools/perf/Makefile.config +1 -42
54 lines not on this page · raw message
tools/perf/builtin-check.c +0 -1
@@ -42,7 +42,6 @@ struct feature_status supported_features[] = {FEATURE_STATUS ("dwarf_getlocations" ,HAVE_LIBDW_SUPPORT ),FEATURE_STATUS ("dwarf-unwind" ,HAVE_DWARF_UNWIND_SUPPORT ),FEATURE_STATUS ("auxtrace" ,HAVE_AUXTRACE_SUPPORT ), -FEATURE_STATUS_TIP ("libbfd" ,HAVE_LIBBFD_SUPPORT ,"Deprecated, license incompatibility, use BUILD_NONDISTRO=1 and install binutils-dev[el]" ),FEATURE_STATUS ("libbpf-strings" ,HAVE_LIBBPF_STRINGS_SUPPORT ),FEATURE_STATUS ("libcapstone" ,HAVE_LIBCAPSTONE_SUPPORT ), FEATURE_STATUS("libdw-dwarf-unwind", HAVE_LIBDW_SUPPORT),
tools/perf/tests/Build +0 -1
@@ -59,7 +59,6 @@ perf-test-y += demangle-ocaml-test.o perf-test-y += demangle-rust-v0-test.o perf-test-y += pfm.o perf-test-y += parse-metric.o -perf-test-y += pe-file-parsing.o perf-test-y += expand-cgroup.o perf-test-y += perf-time-to-tsc.o perf-test-y += dlfilter-test.o
tools/perf/tests/builtin-test.c +0 -1
@@ -132,7 +132,6 @@ static struct test_suite *generic_tests[] = { &suite__demangle_ocaml, &suite__demangle_rust, &suite__parse_metric, - &suite__pe_file_parsing, &suite__expand_cgroup_events, &suite__perf_time_to_tsc, &suite__dlfilter,
tools/perf/tests/pe-file-parsing.c deleted +0 -101
101 lines not on this page · raw message
tools/perf/tests/tests.h +0 -1
@@ -170,7 +170,6 @@ DECLARE_SUITE(demangle_ocaml);DECLARE_SUITE (demangle_rust);DECLARE_SUITE (pfm);DECLARE_SUITE (parse_metric); -DECLARE_SUITE (pe_file_parsing);DECLARE_SUITE (expand_cgroup_events);DECLARE_SUITE (perf_time_to_tsc);DECLARE_SUITE (dlfilter);
tools/perf/util/demangle-cxx.cpp +2 -11
@@ -4,16 +4,11 @@ #include <string.h> #include <linux/compiler.h> -#ifdef HAVE_LIBBFD_SUPPORT -#define PACKAGE 'perf' -#include <bfd.h> -#endif - #ifdef HAVE_CXA_DEMANGLE_SUPPORT #include <cxxabi.h> #endif -#if defined(HAVE_LIBBFD_SUPPORT) || defined(HAVE_CPLUS_DEMANGLE_SUPPORT) +#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT) #ifndef DMGL_PARAMS #define DMGL_PARAMS (1 << 0) /* Include function args */ #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */
@@ -29,11 +24,7 @@ extern "C" char *cxx_demangle_sym(const char *str, bool params __maybe_unused, bool modifiers __maybe_unused) { -#ifdef HAVE_LIBBFD_SUPPORT - int flags = (params ? DMGL_PARAMS : 0) | (modifiers ? DMGL_ANSI : 0); - - return bfd_demangle(NULL, str, flags); -#elif defined(HAVE_CPLUS_DEMANGLE_SUPPORT) +#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT) int flags = (params ? DMGL_PARAMS : 0) | (modifiers ? DMGL_ANSI : 0); return cplus_demangle(str, flags);
tools/perf/util/disasm_bpf.c +0 -166
176 lines not on this page · raw message
tools/perf/util/srcline.c +2 -241
256 lines not on this page · raw message
tools/perf/util/symbol-elf.c +1 -79
110 lines not on this page · raw message
tools/perf/util/symbol.c +1 -140
159 lines not on this page · raw message
tools/perf/util/symbol.h +0 -4
@@ -174,10 +174,6 @@ int symbol__config_symfs(const struct option *opt __maybe_unused,struct symsrc ; -#ifdef HAVE_LIBBFD_SUPPORT -int dso__load_bfd_symbols (struct dso *dso,const char *debugfile); -#endif -int dso__load_sym (struct dso *dso,struct map *map,struct symsrc *syms_ss,struct symsrc *runtime_ss,int kmodule);int dso__synthesize_plt_symbols (struct dso *dso,struct symsrc *ss);
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 14/19 perf build: Remove libiberty support
In reply to Ian Rogerslibiberty is license incompatible with perf and building requires the BUILD_NONDISTRO=1 build flag. libiberty is used for HAVE_CPLUS_DEMANGLE_SUPPORT. Remove the code to simplify the code base as it can't be distributed. Remove the BUILD_NONDISTRO build flag and test as they no longer enable/disable support.
--- tools/perf/Makefile.config | 12 ------------ tools/perf/Makefile.perf | 11 ++++------- tools/perf/tests/make | 2 -- tools/perf/util/demangle-cxx.cpp | 13 +------------ tools/perf/util/symbol-elf.c | 7 ------- tools/perf/util/symbol.c | 6 ------ 6 files changed, 5 insertions(+), 46 deletions(-)
tools/perf/Makefile.config +0 -12
@@ -954,18 +954,6 @@ ifndef NO_DEMANGLE CXXFLAGS += -DHAVE_CXA_DEMANGLE_SUPPORT $(call detected,CONFIG_CXX_DEMANGLE) endif - ifdef BUILD_NONDISTRO - ifeq ($(filter -liberty,$(EXTLIBS)),) - $(call feature_check,cplus-demangle) - ifeq ($(feature-cplus-demangle), 1) - EXTLIBS += -liberty - endif - endif - ifneq ($(filter -liberty,$(EXTLIBS)),) - CFLAGS += -DHAVE_CPLUS_DEMANGLE_SUPPORT - CXXFLAGS += -DHAVE_CPLUS_DEMANGLE_SUPPORT - endif - endif endif ifndef NO_LZMA
tools/perf/Makefile.perf +4 -7
@@ -120,9 +120,6 @@ include ../scripts/utilities.mak # # Set BUILD_BPF_SKEL to 0 to override BUILD_BPF_SKEL and not build BPF skeletons # -# Define BUILD_NONDISTRO to enable building an linking against libbfd and -# libiberty distribution license incompatible libraries. -# # Define EXTRA_TESTS to enable building extra tests useful mainly to perf # developers, such as: # x86 instruction decoder - new instructions test
@@ -297,10 +294,10 @@ LIBSYMBOL_DIR = $(srctree)/tools/lib/symbol/ LIBPERF_DIR = $(srctree)/tools/lib/perf/ DOC_DIR = $(srctree)/tools/perf/Documentation/ -# Set FEATURE_TESTS to 'all' so all possible feature checkers are executed. -# Without this setting the output feature dump file misses some features, for -# example, liberty. Select all checkers so we won't get an incomplete feature -# dump file. +# Set FEATURE_TESTS to 'all' so all possible feature checkers are +# executed. Without this setting the output feature dump file misses +# some features. Select all checkers so we won't get an incomplete +# feature dump file. ifeq ($(config),1) ifdef MAKECMDGOALS ifeq ($(filter feature-dump,$(MAKECMDGOALS)),feature-dump)
tools/perf/tests/make +0 -2
@@ -68,7 +68,6 @@ python_perf_so := $(shell $(MAKE) python_perf_target|grep "Target is:"|awk '{pri make_clean_all := clean all make_python_perf_so := $(python_perf_so) make_debug := DEBUG=1 -make_nondistro := BUILD_NONDISTRO=1 make_extra_tests := EXTRA_TESTS=1 make_jevents_all := JEVENTS_ARCH=all make_no_bpf_skel := BUILD_BPF_SKEL=0
@@ -139,7 +138,6 @@ MAKE_F := $(MAKE) -f $(MK) endif run += make_python_perf_so run += make_debug -run += make_nondistro run += make_extra_tests run += make_jevents_all run += make_no_bpf_skel
tools/perf/util/demangle-cxx.cpp +1 -12
@@ -8,13 +8,6 @@ #include <cxxabi.h> #endif -#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT) -#ifndef DMGL_PARAMS -#define DMGL_PARAMS (1 << 0) /* Include function args */ -#define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */ -#endif -#endif - /* * Demangle C++ function signature *
@@ -24,11 +17,7 @@ extern "C" char *cxx_demangle_sym(const char *str, bool params __maybe_unused, bool modifiers __maybe_unused) { -#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT) - int flags = (params ? DMGL_PARAMS : 0) | (modifiers ? DMGL_ANSI : 0); - - return cplus_demangle(str, flags); -#elif defined(HAVE_CXA_DEMANGLE_SUPPORT) +#if defined(HAVE_CXA_DEMANGLE_SUPPORT) char *output; int status;
tools/perf/util/symbol-elf.c +0 -7
@@ -24,13 +24,6 @@#include <symbol/kallsyms.h> #include <internal/lib.h> -#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT ) -#ifndef DMGL_PARAMS -#define DMGL_PARAMS (1 << 0)/* Include function args */ -#define DMGL_ANSI (1 << 1)/* Include const, volatile, etc */ -#endif -#endif -#ifndef EM_AARCH64 #define EM_AARCH64 183/* ARM 64 bit */ #endif
tools/perf/util/symbol.c +0 -6
@@ -2535,13 +2535,7 @@ static bool want_demangle(bool is_kernel_sym)char *cxx_demangle_sym (const char *str__maybe_unused ,bool params__maybe_unused ,bool modifiers__maybe_unused ) { -#if defined(HAVE_CPLUS_DEMANGLE_SUPPORT ) -int flags = (params ?DMGL_PARAMS :0 ) | (modifiers ?DMGL_ANSI :0 ); - -return cplus_demangle (str, flags); -#else return NULL ; -#endif }#endif /* !HAVE_CXA_DEMANGLE_SUPPORT */
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 15/19 perf build: Remove unused defines
In reply to Ian RogersDISASM_FOUR_ARGS_SIGNATURE and DISASM_INIT_STYLED were used with libbfd support. Remove now that libbfd support is removed.
--- tools/perf/Makefile.config | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
tools/perf/Makefile.config +2 -13
@@ -323,9 +323,6 @@ FEATURE_CHECK_LDFLAGS-libpython := $(PYTHON_EMBED_LDOPTS) FEATURE_CHECK_LDFLAGS-libaio = -lrt -FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes -ldl -FEATURE_CHECK_LDFLAGS-disassembler-init-styled = -lbfd -lopcodes -ldl - CORE_CFLAGS += -fno-omit-frame-pointer CORE_CFLAGS += -Wall CORE_CFLAGS += -Wextra
@@ -352,7 +349,7 @@ endif ifeq ($(FEATURES_DUMP),) # We will display at the end of this Makefile.config, using $(call feature_display_entries) -# As we may retry some feature detection here, see the disassembler-four-args case, for instance +# As we may retry some feature detection here. FEATURE_DISPLAY_DEFERRED := 1 include $(srctree)/tools/build/Makefile.feature else
@@ -1006,14 +1003,6 @@ ifdef HAVE_KVM_STAT_SUPPORT CFLAGS += -DHAVE_KVM_STAT_SUPPORT endif -ifeq ($(feature-disassembler-four-args), 1) - CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE -endif - -ifeq ($(feature-disassembler-init-styled), 1) - CFLAGS += -DDISASM_INIT_STYLED -endif - ifeq (${IS_64_BIT}, 1) ifndef NO_PERF_READ_VDSO32 $(call feature_check,compile-32)
@@ -1288,6 +1277,6 @@ endif # re-generate FEATURE-DUMP as we may have called feature_check, found out # extra libraries to add to LDFLAGS of some other test and then redo those -# tests, see the block about disassembler-four-args, for instance. +# tests. $(shell rm -f $(FEATURE_DUMP_FILENAME)) $(foreach feat,$(FEATURE_TESTS),$(shell echo "$(call feature_assign,$(feat))" >> $(FEATURE_DUMP_FILENAME)))
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 16/19 perf disasm: Remove disasm_bpf
In reply to Ian RogersBPF disassembly was handled in here by libbfd. The LLVM and capstone disassemblers now support BPF JIT disassembly. As libbfd support was removed the functions here no longer did anything remove them and associated error values.
--- tools/perf/util/Build | 1 - tools/perf/util/annotate.h | 1 - tools/perf/util/disasm.c | 12 +++--------- tools/perf/util/disasm_bpf.c | 29 ----------------------------- tools/perf/util/disasm_bpf.h | 12 ------------ 5 files changed, 3 insertions(+), 52 deletions(-) delete mode 100644 tools/perf/util/disasm_bpf.c delete mode 100644 tools/perf/util/disasm_bpf.h
tools/perf/util/Build +0 -1
@@ -14,7 +14,6 @@ perf-util-y += copyfile.o perf-util-y += ctype.o perf-util-y += db-export.o perf-util-y += disasm.o -perf-util-y += disasm_bpf.o perf-util-y += env.o perf-util-y += event.o perf-util-y += evlist.o
tools/perf/util/annotate.h +0 -1
@@ -447,7 +447,6 @@ enum symbol_disassemble_errno { __SYMBOL_ANNOTATE_ERRNO__START =-10000 ,SYMBOL_ANNOTATE_ERRNO__NO_VMLINUX = __SYMBOL_ANNOTATE_ERRNO__START, -SYMBOL_ANNOTATE_ERRNO__NO_LIBOPCODES_FOR_BPF ,SYMBOL_ANNOTATE_ERRNO__ARCH_INIT_CPUID_PARSING ,SYMBOL_ANNOTATE_ERRNO__ARCH_INIT_REGEXP , SYMBOL_ANNOTATE_ERRNO__BPF_INVALID_FILE,
tools/perf/util/disasm.c +3 -9
@@ -17,7 +17,6 @@#include "capstone.h" #include "debug.h" #include "disasm.h" -#include "disasm_bpf.h" #include "dso.h" #include "dwarf-regs.h" #include "env.h"
@@ -1231,9 +1230,6 @@ int symbol__strerror_disassemble(struct map_symbol *ms, int errnum, char *buf, s " --vmlinux vmlinux\n", build_id_msg ?: ""); }break ; -case SYMBOL_ANNOTATE_ERRNO__NO_LIBOPCODES_FOR_BPF : -scnprintf (buf, buflen,"Please link with binutils's libopcode to enable BPF annotation" ); -break ;case SYMBOL_ANNOTATE_ERRNO__ARCH_INIT_REGEXP :scnprintf (buf, buflen,"Problems with arch specific instruction name regular expressions." );break ;
@@ -1501,11 +1497,9 @@ static int symbol__disassemble_objdump(const char *filename, struct symbol *sym,struct child_process objdump_process;int err; -if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_PROG_INFO ) -return symbol__disassemble_bpf (sym, args); - -if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_IMAGE ) -return symbol__disassemble_bpf_image (sym, args); +if (dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_PROG_INFO || +dso__binary_type (dso) ==DSO_BINARY_TYPE__BPF_IMAGE ) +return -1 ; err =asprintf (&command, "%s %s%s --start-address=0x%016" PRIx64
tools/perf/util/disasm_bpf.c deleted +0 -29
@@ -1,29 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only - -#include "util/annotate.h" -#include "util/disasm_bpf.h" -#include "util/symbol.h" -#include <linux/zalloc.h> -#include <string.h> - -int symbol__disassemble_bpf (struct symbol *sym__maybe_unused ,struct annotate_args *args__maybe_unused ) -{ -return SYMBOL_ANNOTATE_ERRNO__NO_LIBOPCODES_FOR_BPF ; -} - -int symbol__disassemble_bpf_image (struct symbol *sym,struct annotate_args *args) -{ -struct annotation *notes =symbol__annotation (sym); -struct disasm_line *dl; - - args->offset =-1 ; - args->line =strdup ("to be implemented" ); - args->line_nr =0 ; - args->fileloc =NULL ; - dl =disasm_line__new (args); -if (dl) -annotation_line__add (&dl->al, ¬es->src->source); - -zfree (&args->line); -return 0 ; -}
tools/perf/util/disasm_bpf.h deleted +0 -12
@@ -1,12 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only - -#ifndef __PERF_DISASM_BPF_H -#define __PERF_DISASM_BPF_H - -struct symbol ; -struct annotate_args ; - -int symbol__disassemble_bpf (struct symbol *sym,struct annotate_args *args); -int symbol__disassemble_bpf_image (struct symbol *sym,struct annotate_args *args); - -#endif /* __PERF_DISASM_BPF_H */
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 17/19 perf disasm: Make ins__scnprintf and ins__is_nop static
In reply to Ian RogersReduce the scope of ins__scnprintf and ins__is_nop that aren't used outside of disasm.c.
--- tools/perf/util/disasm.c | 6 +++--- tools/perf/util/disasm.h | 3 --- 2 files changed, 3 insertions(+), 6 deletions(-)
tools/perf/util/disasm.c +3 -3
@@ -246,8 +246,8 @@ static int ins__raw_scnprintf(struct ins *ins, char *bf, size_t size,return scnprintf (bf, size,"%-*s %s" , max_ins_name, ins->name, ops->raw); } -int ins__scnprintf (struct ins *ins,char *bf,size_t size, -struct ins_operands *ops,int max_ins_name) +static int ins__scnprintf (struct ins *ins,char *bf,size_t size, +struct ins_operands *ops,int max_ins_name) {if (ins->ops->scnprintf)return ins->ops->scnprintf (ins, bf, size, ops, max_ins_name);
@@ -824,7 +824,7 @@ static struct ins_ops ret_ops = { .scnprintf = ins__raw_scnprintf, }; -bool ins__is_nop (const struct ins *ins) +static bool ins__is_nop (const struct ins *ins) {return ins->ops == &nop_ops; }
tools/perf/util/disasm.h +0 -3
@@ -110,13 +110,10 @@ struct arch *arch__find(const char *name);bool arch__is (struct arch *arch,const char *name);struct ins_ops *ins__find (struct arch *arch,const char *name,struct disasm_line *dl); -int ins__scnprintf (struct ins *ins,char *bf,size_t size, -struct ins_operands *ops,int max_ins_name);bool ins__is_call (const struct ins *ins);bool ins__is_jump (const struct ins *ins);bool ins__is_fused (struct arch *arch,const char *ins1,const char *ins2); -bool ins__is_nop (const struct ins *ins);bool ins__is_ret (const struct ins *ins);bool ins__is_lock (const struct ins *ins);
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 18/19 perf srcline: Fallback between addr2line implementations
In reply to Ian RogersFactor the addr2line function implementation into separate source files (addr2line.[ch]) and rename the addr2line function cmd__addr2line. In srcline replace the ifdef-ed addr2line implementations with one that first tries the llvm__addr2line implementation and on failure uses cmd__addr2line.
If HAVE_LIBLLVM_SUPPORT is enabled the llvm__addr2line will execute against the libLLVM.so it is linked against.
If HAVE_LIBLLVM_DYNAMIC is enabled then libperf-llvm.so (that links against libLLVM.so) will be dlopened. If the dlopen succeeds then the behavior should match HAVE_LIBLLVM_SUPPORT. On failure cmd__addr2line is used. The dlopen is only tried once.
If HAVE_LIBLLVM_DYNAMIC isn't enabled then llvm__addr2line immediately fails and cmd__addr2line is used.
Clean up the dso__free_a2l logic, which is only needed in the non-LLVM version and moved to addr2line.c.
--- tools/perf/util/Build | 1 + tools/perf/util/addr2line.c | 439 ++++++++++++++++++++++++++++++++ tools/perf/util/addr2line.h | 20 ++ tools/perf/util/config.c | 2 +- tools/perf/util/llvm.c | 5 - tools/perf/util/llvm.h | 3 - tools/perf/util/srcline.c | 482 ++---------------------------------- tools/perf/util/srcline.h | 1 - 8 files changed, 484 insertions(+), 469 deletions(-) create mode 100644 tools/perf/util/addr2line.c create mode 100644 tools/perf/util/addr2line.h
tools/perf/util/Build +1 -0
@@ -2,6 +2,7 @@ include $(srctree)/tools/scripts/Makefile.include include $(srctree)/tools/scripts/utilities.mak perf-util-y += arm64-frame-pointer-unwind-support.o +perf-util-y += addr2line.o perf-util-y += addr_location.o perf-util-y += annotate.o perf-util-y += block-info.o
tools/perf/util/addr2line.c new file +439 -0
439 lines not on this page · raw message
tools/perf/util/addr2line.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_ADDR2LINE_H +#define __PERF_ADDR2LINE_H + +#include <linux/types.h> + +struct dso ; +struct inline_node ; +struct symbol ; + +extern int addr2line_timeout_ms; + +int cmd__addr2line (const char *dso_name,u64 addr, +char **file,unsigned int *line_nr, +struct dso *dso, +bool unwind_inlines, +struct inline_node *node, +struct symbol *sym); + +#endif /* __PERF_ADDR2LINE_H */
tools/perf/util/config.c +1 -1
@@ -19,7 +19,7 @@#include "util/hist.h" /* perf_hist_config */ #include "util/stat.h" /* perf_stat__set_big_num */ #include "util/evsel.h" /* evsel__hw_names, evsel__use_bpf_counters */ -#include "util/srcline.h" /* addr2line_timeout_ms */ +#include "util/addr2line.h" /* addr2line_timeout_ms */ #include "build-id.h" #include "debug.h" #include "config.h"
tools/perf/util/llvm.c +0 -5
@@ -303,11 +303,6 @@ int llvm__addr2line(const char *dso_name __maybe_unused, u64 addr __maybe_unusedreturn num_frames; } -void dso__free_a2l_llvm (struct dso *dso__maybe_unused ) -{ -/* Nothing to free. */ -} -/* * Whenever LLVM wants to resolve an address into a symbol, it calls this * callback. We don't ever actually _return_ anything (in particular, because
tools/perf/util/llvm.h +0 -3
@@ -15,9 +15,6 @@ int llvm__addr2line(const char *dso_name, u64 addr, bool unwind_inlines, struct inline_node *node, struct symbol *sym); - -void dso__free_a2l_llvm (struct dso *dso); -int symbol__disassemble_llvm (const char *filename,struct symbol *sym,struct annotate_args *args);
tools/perf/util/srcline.c +23 -459
519 lines not on this page · raw message
tools/perf/util/srcline.h +0 -1
@@ -9,7 +9,6 @@struct dso ;struct symbol ; -extern int addr2line_timeout_ms;extern bool srcline_full_filename;char *get_srcline (struct dso *dso,u64 addr,struct symbol *sym,bool show_sym,bool show_addr,u64 ip);
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Ian Rogers
reviewerPATCH v5 19/19 perf disasm: Remove unused evsel from annotate_args
In reply to Ian RogersSet in symbol__annotate but never used.
--- tools/perf/util/annotate.c | 1 - tools/perf/util/disasm.h | 1 - 2 files changed, 2 deletions(-)
tools/perf/util/annotate.c +0 -1
@@ -1013,7 +1013,6 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,struct symbol *sym = ms->sym;struct annotation *notes =symbol__annotation (sym);struct annotate_args args = { - .evsel = evsel, .options = &annotate_opts, };struct arch *arch =NULL ;
tools/perf/util/disasm.h +0 -1
@@ -98,7 +98,6 @@ struct ins_ops {struct annotate_args {struct arch *arch;struct map_symbol ms; -struct evsel *evsel;struct annotation_options *options;s64 offset;char *line;
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Quoted 2 lines
As this has been opt-in for nearly 2 years, commit
dd317df07207("perf build: Make binutil libraries opt in"), remove the code to simplify the code base.
I don't think this is a reason to remove it by itself. We've been enabling it in Gentoo and happily using it.
Anyway, my main concern (though I have a few) is that annotate support will be lacking. A few months ago, objdump was the only way to get source line support [0]. Is that still the case?
Quoted 2 lines
A few months ago, objdump was the only way to get
source line support [0]. Is that still the case?
... or is this perhaps handled by "[PATCH v5 18/19] perf srcline:
Fallback between addr2line implementations", in which case, shouldn't that really land first so people can try the LLVM impl and use the binutils one if it fails?
Ian Rogers
reviewerQuoted 8 lines · Sam James
Quoted 3 lines
A few months ago, objdump was the only way to get
source line support [0]. Is that still the case?... or is this perhaps handled by "[PATCH v5 18/19] perf srcline:
Fallback between addr2line implementations", in which case, shouldn't that really land first so people can try the LLVM impl and use the binutils one if it fails?
So my opinion, BUILD_NON_DISTRO isn't supported and the code behind it should go away. Please don't do anything to the contrary or enable it for your distribution - this was supposed to be implied by the name. The forking and running addr2line gets around the license issue that is GPLv3* but comes with a performance overhead. It also has a maintenance overhead supporting llvm and binutil addr2line, when the addr2line output changes things break, etc. (LLVM has been evolving their output but I'm not aware of it breaking things yet). We should (imo) delete the forking and running addr2line support, it fits the billing of something we can do when capstone and libLLVM support aren't there but the code is a hot mess and we don't do exhaustive testing against the many addr2line flavors, the best case is buyer beware. Capstone is derived from libLLVM, I'm not sure it makes sense having 2 libraries for this stuff. There's libLLVM but what it provides through a C API is a mess requiring the C++ shimming. Tbh, I think most of what these libraries provide we should just get over ourselves and provide in perf itself. For example, does it make sense to be trying to add type annotations to objdump output, to just update objdump or have a disassembler library where we can annotate things as we see fit? Library bindings don't break when text output formats get tweaked. Given we're doing so much dwarf processing, do we need a library for that or should that just be in-house? We can side step most of this mess by starting again in python as is being shown in the textual changes that bring with it stuff like console flame graphs:
https://lore.kernel.org/lkml/CAP-5=fU=z8kcY4zjezoxSwYf9vczYzHztiMSBvJxdwwBPVWv2Q@mail.gmail.com/
So I think long term we make the perf tool minimal with minimal dependencies (ie no addr2line, libLLVM, etc.), we work on having nice stuff in the python stuff where we can reuse or build new libraries for addr2line, objdump-ing, etc. Use >1 thread, use asyncio, etc.
For where we are now, ie no python stuff, BUILD_NON_DISTRO should go away as nobody is maintaining it and hasn't for 2 years (what happens when libbfd and libiberty change?). We should focus on making the best of what we have via libraries/tools that are supported - while not forcing the libraries to be there or making the perf binary massive by dragging in say libLLVM. The patch series pushes in that direction and I commend it to the reader.
No, reordering the patches to compare performance of binutils doesn't make sense, just build with and without the patch series if you want to do this, but also don't do this as BUILD_NON_DISTRO should go away.
Thanks,
Ian
* (As I understand the issue IANAL) GPLv3 and GPLv2 can't be linked together. Why not just use GPLv3? A major issue for me is that GPLv3 adds a requirement for “Installation Information” to be provided, which means placing a binary in a cryptographically signed OS partition you'd need to reveal the signing key which defeats the purpose of signing the partition to ensure you aren't hacked. I like open source and using the code, I don't want to be hacked by giving to the hackers my signing keys.
Quoted 5 lines · Ian Rogers
Quoted 4 lines · Sam James
Quoted 3 lines
A few months ago, objdump was the only way to get
source line support [0]. Is that still the case?
Quoted 8 lines
Quoted 4 lines
... or is this perhaps handled by "[PATCH v5 18/19] perf srcline:
Fallback between addr2line implementations", in which case, shouldn't that really land first so people can try the LLVM impl and use the binutils one if it fails?So my opinion,
BUILD_NON_DISTROisn't supported and the code behind it should go away. Please don't do anything to the contrary or enable it for your distribution - this was supposed to be implied by the name.
We're principally a source-based distribution, so it's not as much of an issue.
Quoted 18 lines
The forking and running addr2line gets around the license issue that is GPLv3* but comes with a performance overhead. It also has a maintenance overhead supporting llvm and binutil addr2line, when the addr2line output changes things break, etc. (LLVM has been evolving their output but I'm not aware of it breaking things yet). We should (imo) delete the forking and running addr2line support, it fits the billing of something we can do when capstone and libLLVM support aren't there but the code is a hot mess and we don't do exhaustive testing against the many addr2line flavors, the best case is buyer beware. Capstone is derived from libLLVM, I'm not sure it makes sense having 2 libraries for this stuff. There's libLLVM but what it provides through a C API is a mess requiring the C++ shimming. Tbh, I think most of what these libraries provide we should just get over ourselves and provide in perf itself. For example, does it make sense to be trying to add type annotations to objdump output, to just update objdump or have a disassembler library where we can annotate things as we see fit? Library bindings don't break when text output formats get tweaked. Given we're doing so much dwarf processing, do we need a
Quoted 8 lines
library for that or should that just be in-house? We can side step most of this mess by starting again in python as is being shown in the textual changes that bring with it stuff like console flame graphs:
https://lore.kernel.org/lkml/CAP-5=fU=z8kcY4zjezoxSwYf9vczYzHztiMSBvJxdwwBPVWv2Q@mail.gmail.com/
So I think long term we make the perf tool minimal with minimal dependencies (ie no addr2line, libLLVM, etc.), we work on having nice stuff in the python stuff where we can reuse or build new libraries for addr2line, objdump-ing, etc. Use >1 thread, use asyncio, etc.
Yeah, this absolutely sounds like the right direction indeed. I'm glad to hear it.
Quoted 4 lines
For where we are now, ie no python stuff,
BUILD_NON_DISTROshould go away as nobody is maintaining it and hasn't for 2 years (what happens when libbfd and libiberty change?)
They don't change often, though. The fixes are usually trivial when they do arise.
Quoted 9 lines
We should focus on making the best
of what we have via libraries/tools that are supported - while not forcing the libraries to be there or making the perf binary massive by dragging in say libLLVM. The patch series pushes in that direction and I commend it to the reader.No, reordering the patches to compare performance of binutils doesn't make sense, just build with and without the patch series if you want to do this, but also don't do this as
BUILD_NON_DISTROshould go away.
I was asking purely because of the *functionality loss*, though, not performance. In the thread I linked from just a few months ago with Ingo Molnar, there was a real issue with llvm or capstone-based disassembly not showing source information. I'd hit the same problem. Is that fixed now?
This is my principal concern rather than the LLVM dependency (even if I'd love to avoid that, I understand and appreciate the arguments you're making above and intent on future direction).
Quoted 4 lines
Thanks,
Ian
Quoted 8 lines
* (As I understand the issue IANAL) GPLv3 and GPLv2 can't be linked together. Why not just use GPLv3? A major issue for me is that GPLv3 adds a requirement for “Installation Information” to be provided, which means placing a binary in a cryptographically signed OS partition you'd need to reveal the signing key which defeats the purpose of signing the partition to ensure you aren't hacked. I like open source and using the code, I don't want to be hacked by giving to the hackers my signing keys.
I think the way people usually handle this is allowing a custom key to be added, but then it taints the device. That's how I think routers seem to handle it often anyway.
Ian Rogers
reviewerQuoted 13 lines · Sam James
Quoted 10 lines · Ian Rogers
Quoted 8 lines · Sam James
Quoted 3 lines
A few months ago, objdump was the only way to get
source line support [0]. Is that still the case?... or is this perhaps handled by "[PATCH v5 18/19] perf srcline:
Fallback between addr2line implementations", in which case, shouldn't that really land first so people can try the LLVM impl and use the binutils one if it fails?
Quoted 6 lines
Quoted 3 lines
So my opinion,
BUILD_NON_DISTROisn't supported and the code behind it should go away. Please don't do anything to the contrary or enable it for your distribution - this was supposed to be implied by the name.We're principally a source-based distribution, so it's not as much of an issue.
Agreed, but I don't think the perf tool should be made to be a source only distribution :-)
Quoted 27 lines
Quoted 18 lines
The forking and running addr2line gets around the license issue that is GPLv3* but comes with a performance overhead. It also has a maintenance overhead supporting llvm and binutil addr2line, when the addr2line output changes things break, etc. (LLVM has been evolving their output but I'm not aware of it breaking things yet). We should (imo) delete the forking and running addr2line support, it fits the billing of something we can do when capstone and libLLVM support aren't there but the code is a hot mess and we don't do exhaustive testing against the many addr2line flavors, the best case is buyer beware. Capstone is derived from libLLVM, I'm not sure it makes sense having 2 libraries for this stuff. There's libLLVM but what it provides through a C API is a mess requiring the C++ shimming. Tbh, I think most of what these libraries provide we should just get over ourselves and provide in perf itself. For example, does it make sense to be trying to add type annotations to objdump output, to just update objdump or have a disassembler library where we can annotate things as we see fit? Library bindings don't break when text output formats get tweaked. Given we're doing so much dwarf processing, do we need a
Quoted 8 lines
library for that or should that just be in-house? We can side step most of this mess by starting again in python as is being shown in the textual changes that bring with it stuff like console flame graphs:
https://lore.kernel.org/lkml/CAP-5=fU=z8kcY4zjezoxSwYf9vczYzHztiMSBvJxdwwBPVWv2Q@mail.gmail.com/
So I think long term we make the perf tool minimal with minimal dependencies (ie no addr2line, libLLVM, etc.), we work on having nice stuff in the python stuff where we can reuse or build new libraries for addr2line, objdump-ing, etc. Use >1 thread, use asyncio, etc.
Quoted 2 lines
Yeah, this absolutely sounds like the right direction indeed. I'm glad to hear it.
Well it takes effort and what drags against that is supporting things that can't be distributed.
Quoted 7 lines
Quoted 4 lines
For where we are now, ie no python stuff,
BUILD_NON_DISTROshould go away as nobody is maintaining it and hasn't for 2 years (what happens when libbfd and libiberty change?)They don't change often, though. The fixes are usually trivial when they do arise.
So just taking the feature tests as an example of the burden, we have:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/feature/test-disassembler-four-args.c?h=perf-tools-next
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/feature/test-disassembler-init-styled.c?h=perf-tools-next
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/feature/test-libbfd-buildid.c?h=perf-tools-next
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/feature/test-libbfd.c?h=perf-tools-next
so it isn't just supporting a small libbfd wrapper, it is maintaining addr2line, objdump, etc. functionality for all these configurations. As it doesn't get tested, or tested with these features both true and false, it is liable to bitrot. However, the biggest issue/drag is in improving/refactoring the tool and having to make sure these new things work for a situation that in most distributions really, really doesn't matter.
Quoted 6 lines
Quoted 6 lines
We should focus on making the best
of what we have via libraries/tools that are supported - while not forcing the libraries to be there or making the perf binary massive by dragging in say libLLVM. The patch series pushes in that direction and I commend it to the reader.
Quoted 8 lines
Quoted 3 lines
No, reordering the patches to compare performance of binutils doesn't make sense, just build with and without the patch series if you want to do this, but also don't do this as
BUILD_NON_DISTROshould go away.I was asking purely because of the *functionality loss*, though, not performance. In the thread I linked from just a few months ago with Ingo Molnar, there was a real issue with llvm or capstone-based disassembly not showing source information. I'd hit the same problem. Is that fixed now?
Can you link to the issue? Capstone and LLVM don't replace objdump, in perf there is a list of disassemblers and in your ~/.perfconfig and you can always set LLVM and capstone to be your least preferred if they lack a feature you need:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/Documentation/perf-config.txt?h=perf-tools-next#n250
Quoted 3 lines
This is my principal concern rather than the LLVM dependency (even if I'd love to avoid that, I understand and appreciate the arguments you're making above and intent on future direction).
I think adding a missing feature to the LLVM disassembler is forward progress, like fixing the BPF disassembly for LLVM done in this series. I need to know more about the issue but it sounds less of a libbfd thing and more an objdump -S thing.
This patch series was reposted as I carry it in:
https://github.com/googleprodkernel/linux-perf
to avoid the cost of linking in libLLVM/libcapstone in contexts (data centers) where that functionality isn't used.
Thanks,
Ian
Quoted 4 lines
BUILD_NONDISTROis used to build perf against the license incompatible libbfd and libiberty libraries. As this has been opt-in for nearly 2 years, commitdd317df07207("perf build: Make binutil libraries opt in"), remove the code to simplify the code base.
The last time I tried the LLVM stuff was totally broken, couldn't resolve many things. The only workaround was to go back to the actually working libbfd. Please don't remove the only working option.
Thanks,
-Andi
Ian Rogers
reviewerQuoted 9 lines · Andi Kleen
Quoted 5 lines
BUILD_NONDISTROis used to build perf against the license incompatible libbfd and libiberty libraries. As this has been opt-in for nearly 2 years, commitdd317df07207("perf build: Make binutil libraries opt in"), remove the code to simplify the code base.The last time I tried the LLVM stuff was totally broken, couldn't resolve many things. The only workaround was to go back to the actually working libbfd. Please don't remove the only working option.
Andi, did you report a bug? Does the non-libbfd stuff work? Yes, as every distribution has shipped it since binutils went to GPLv3 (in 2007?). While I don't want LLVM stuff not to work, bugs happen, libbfd is license incompatible with GPLv2 and maintaining it in the source tree is a burden. When something doesn't work, create a test to repeat the issue and then we can make it work and ensure it doesn't break again. In general I've not had issues with the LLVM code.
Thanks,
Ian