Skip to contentSkip to conversation

Use correct LDO5 control registers for PCA9450

PATCH Applied Frieder Schrempf 6 participants 14 messages Aug 11, 2025 – Sep 1, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Use correct LDO5 control registers for PCA9450

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/

This aligns the PMIC driver with current Linux and allows to use upstream devicetrees in U-Boot.

Frieder Schrempf (6):
Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
pmic: pca9450: Fix enable register for LDO5
pmic: pca9450: Fix control register for LDO5
pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios
arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts |  1 -
 arch/arm/dts/imx8mp-dhcom-som.dtsi         |  1 -
 drivers/power/pmic/pca9450.c               | 22 -------------
 drivers/power/regulator/pca9450.c          | 37 ++++++++++++++++++++--
 4 files changed, 34 insertions(+), 27 deletions(-)
Signature · 1 line
2.50.1
#1 lore raw

PATCH 1/6 Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"

From: Frieder Schrempf <[email protected]>

This reverts commit 2add0511757e2c5897a88b57c5ea8c912140e60f.

It turns out that all boards using the PCA9450 actually have the SD_VSEL input connected to the VSELECT signal of the SoCs SD/MMC interface. Therefore we don't need manual control for this signal via GPIO and there aren't any users.

This is equivalent to the following change in Linux:

c73be62caabb ("Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5"")

---
 drivers/power/pmic/pca9450.c | 22 ----------------------
 1 file changed, 22 deletions(-)
drivers/power/pmic/pca9450.c +0 -22
index 9d875f8bdbe..0e3d14abf15 100644
@@ -6,12 +6,9 @@
 #include <fdtdec.h>
 #include <errno.h>
 #include <dm.h>
-#include <dm/device_compat.h>
 #include <i2c.h>
-#include <linux/err.h>
 #include <log.h>
 #include <asm/global_data.h>
-#include <asm-generic/gpio.h>
 #include <linux/printk.h>
 #include <power/pmic.h>
 #include <power/regulator.h>
@@ -29,10 +26,6 @@ static const struct pmic_child_info pmic_children_info[] = {
 	{ },
 };
 
-struct pca9450_priv {
-	struct gpio_desc *sd_vsel_gpio;
-};
-
 static int pca9450_reg_count(struct udevice *dev)
 {
 	return PCA9450_REG_NUM;
@@ -85,21 +78,7 @@ static int pca9450_bind(struct udevice *dev)
 
 static int pca9450_probe(struct udevice *dev)
 {
-	struct pca9450_priv *priv = dev_get_priv(dev);
 	unsigned int reset_ctrl;
-	int ret = 0;
-
-	if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
-		priv->sd_vsel_gpio = devm_gpiod_get_optional(dev, "sd-vsel",
-							     GPIOD_IS_OUT |
-							     GPIOD_IS_OUT_ACTIVE);
-		if (IS_ERR(priv->sd_vsel_gpio)) {
-			ret = PTR_ERR(priv->sd_vsel_gpio);
-			dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
-			if (ret)
-				return ret;
-		}
-	}
 
 	if (ofnode_read_bool(dev_ofnode(dev), "nxp,wdog_b-warm-reset"))
 		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_WARM;
@@ -132,5 +111,4 @@ U_BOOT_DRIVER(pmic_pca9450) = {
 	.bind = pca9450_bind,
 	.probe = pca9450_probe,
 	.ops = &pca9450_ops,
-	.priv_auto = sizeof(struct pca9450_priv),
 };
Signature · 1 line
2.50.1
#2 lore raw

PATCH 2/6 pmic: pca9450: Fix enable register for LDO5

In reply to Frieder Schrempf

From: Frieder Schrempf <[email protected]>

The LDO5 regulator has two configuration registers, but only LDO5CTRL_L contains the bits for enabling/disabling the regulator.

This is equivalent to the following change in Linux:

f5aab0438ef1 ("regulator: pca9450: Fix enable register for LDO5")

Fixes 326337fb005f ("pmic: pca9450: Add regulator driver")
---
 drivers/power/regulator/pca9450.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/regulator/pca9450.c +1 -1
index a2a34244723..27db55e688d 100644
@@ -144,7 +144,7 @@ static struct pca9450_plat pca9450_reg_data[] = {
 	PCA_DATA("LDO4", PCA9450_LDO4CTRL, HW_STATE_CONTROL,
 		 PCA9450_LDO4CTRL, PCA9450_LDO34_MASK,
 		 pca9450_ldo34_vranges),
-	PCA_DATA("LDO5", PCA9450_LDO5CTRL_H, HW_STATE_CONTROL,
+	PCA_DATA("LDO5", PCA9450_LDO5CTRL_L, HW_STATE_CONTROL,
 		 PCA9450_LDO5CTRL_H, PCA9450_LDO5_MASK,
 		 pca9450_ldo5_vranges),
 };
Signature · 1 line
2.50.1
#3 lore raw

PATCH 3/6 pmic: pca9450: Fix control register for LDO5

In reply to Frieder Schrempf

From: Frieder Schrempf <[email protected]>

For LDO5 we need to be able to check the status of the SD_VSEL input in order to know which control register is used. Read the status of the SD_VSEL signal via GPIO and use the correct register accordingly.

To use this, the LDO5 node in the devicetree needs the sd-vsel-gpios property to reference the GPIO that is used to read back the SD_VSEL status internally. Please note that the SION bit in the IOMUX must be set if the signal is muxed as VSELECT and controlled by the USDHC controller.

This is equivalent to the following change in Linux:

3ce6f4f943dd ("regulator: pca9450: Fix control register for LDO5")

---
 drivers/power/regulator/pca9450.c | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)
drivers/power/regulator/pca9450.c +29 -2
index 27db55e688d..9d8d142b464 100644
@@ -7,9 +7,12 @@
  * ROHM BD71837 regulator driver
  */
 
+#include <asm-generic/gpio.h>
 #include <dm.h>
+#include <dm/device_compat.h>
 #include <log.h>
 #include <linux/bitops.h>
+#include <linux/err.h>
 #include <power/pca9450.h>
 #include <power/pmic.h>
 #include <power/regulator.h>
@@ -52,6 +55,7 @@ struct pca9450_plat {
 	u8			volt_mask;
 	struct pca9450_vrange	*ranges;
 	unsigned int		numranges;
+	struct gpio_desc	*sd_vsel_gpio;
 };
 
 #define PCA_RANGE(_min, _vstep, _sel_low, _sel_hi) \
@@ -222,13 +226,23 @@ static int pca9450_set_enable(struct udevice *dev, bool enable)
 			       val);
 }
 
+static u8 pca9450_get_vsel_reg(struct pca9450_plat *plat)
+{
+	if (!strcmp(plat->name, "LDO5") &&
+	    (plat->sd_vsel_gpio && !dm_gpio_get_value(plat->sd_vsel_gpio)) {
+		return PCA9450_LDO5CTRL_L;
+	}
+
+	return plat->volt_reg;
+}
+
 static int pca9450_get_value(struct udevice *dev)
 {
 	struct pca9450_plat *plat = dev_get_plat(dev);
 	unsigned int reg, tmp;
 	int i, ret;
 
-	ret = pmic_reg_read(dev->parent, plat->volt_reg);
+	ret = pmic_reg_read(dev->parent, pca9450_get_vsel_reg(plat));
 	if (ret < 0)
 		return ret;
 
@@ -274,7 +288,7 @@ static int pca9450_set_value(struct udevice *dev, int uvolt)
 	if (!found)
 		return -EINVAL;
 
-	return pmic_clrsetbits(dev->parent, plat->volt_reg,
+	return pmic_clrsetbits(dev->parent, pca9450_get_vsel_reg(plat),
 			       plat->volt_mask, sel);
 }
 
@@ -335,6 +349,19 @@ static int pca9450_regulator_probe(struct udevice *dev)
 
 		*plat = pca9450_reg_data[i];
 
+		if (!strcmp(plat->name, "LDO5")) {
+			if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
+				plat->sd_vsel_gpio = devm_gpiod_get_optional(dev, "sd-vsel",
+									     GPIOD_IS_IN);
+				if (IS_ERR(plat->sd_vsel_gpio)) {
+					ret = PTR_ERR(plat->sd_vsel_gpio);
+					dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
+					if (ret)
+						return ret;
+				}
+			}
+		}
+
 		return 0;
 	}
 
Signature · 1 line
2.50.1
#4 lore raw

PATCH 4/6 pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5

In reply to Frieder Schrempf

From: Frieder Schrempf <[email protected]>

There are two ways to set the output voltage of the LD05 regulator. First by writing to the voltage selection registers and second by toggling the SD_VSEL signal.

Usually board designers connect SD_VSEL to the VSELECT signal controlled by the USDHC controller, but in some cases the signal is hardwired to a fixed low level (therefore selecting 3.3V as initial value for allowing to boot from the SD card).

In these cases, the voltage is only determined by the value of the LDO5CTRL_L register. Introduce a property nxp,sd-vsel-fixed-low to let the driver know that SD_VSEL is low and there is no GPIO to actually get that information from dynamically.

This is equivalent to the following change in Linux:

c8c1ab2c5cb7 ("regulator: pca9450: Handle hardware with fixed SD_VSEL for LDO5")

---
 drivers/power/regulator/pca9450.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/power/regulator/pca9450.c +5 -1
index 9d8d142b464..3bb0c71dde7 100644
@@ -56,6 +56,7 @@ struct pca9450_plat {
 	struct pca9450_vrange	*ranges;
 	unsigned int		numranges;
 	struct gpio_desc	*sd_vsel_gpio;
+	bool			sd_vsel_fixed_low;
 };
 
 #define PCA_RANGE(_min, _vstep, _sel_low, _sel_hi) \
@@ -229,7 +230,8 @@ static int pca9450_set_enable(struct udevice *dev, bool enable)
 static u8 pca9450_get_vsel_reg(struct pca9450_plat *plat)
 {
 	if (!strcmp(plat->name, "LDO5") &&
-	    (plat->sd_vsel_gpio && !dm_gpio_get_value(plat->sd_vsel_gpio)) {
+	    ((plat->sd_vsel_gpio && !dm_gpio_get_value(plat->sd_vsel_gpio)) ||
+	     plat->sd_vsel_fixed_low)) {
 		return PCA9450_LDO5CTRL_L;
 	}
 
@@ -360,6 +362,8 @@ static int pca9450_regulator_probe(struct udevice *dev)
 						return ret;
 				}
 			}
+
+			plat->sd_vsel_fixed_low = dev_read_bool(dev, "nxp,sd-vsel-fixed-low");
 		}
 
 		return 0;
Signature · 1 line
2.50.1
#5 lore raw

PATCH 5/6 arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios

In reply to Frieder Schrempf

From: Frieder Schrempf <[email protected]>

The sd-vsel-gpios property in the root of the PMIC node is deprecated and therefore not parsed by the driver anymore. We can safely remove this as it wasn't used anyway due to the pad not having the correct pinmux settings.

---
 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/imx8mp-data-modul-edm-sbc.dts +0 -1
index 8066f7fb649..6b40106e3bd 100644
@@ -344,7 +344,6 @@
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
-		sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
 
 		/*
 		 * i.MX 8M Plus Data Sheet for Consumer Products
Signature · 1 line
2.50.1
Reviewed-by on v1 5/6
#6 lore raw

Re: [PATCH 5/6] arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios

Quoted 8 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

The sd-vsel-gpios property in the root of the PMIC node is deprecated and therefore not parsed by the driver anymore. We can safely remove this as it wasn't used anyway due to the pad not having the correct pinmux settings.

#7 lore raw

PATCH 6/6 arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

In reply to Frieder Schrempf

From: Frieder Schrempf <[email protected]>

The sd-vsel-gpios property in the root of the PMIC node is deprecated and therefore not parsed by the driver anymore. We can safely remove this as it wasn't used anyway due to the pad not having the correct pinmux settings.

---
 arch/arm/dts/imx8mp-dhcom-som.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/imx8mp-dhcom-som.dtsi +0 -1
index f2d99d05854..c1ca3805737 100644
@@ -245,7 +245,6 @@
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
-		sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
 
 		/*
 		 * i.MX 8M Plus Data Sheet for Consumer Products
Signature · 1 line
2.50.1
Reviewed-by on v1 6/6
#8 lore raw

Re: [PATCH 6/6] arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

Quoted 8 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

The sd-vsel-gpios property in the root of the PMIC node is deprecated and therefore not parsed by the driver anymore. We can safely remove this as it wasn't used anyway due to the pad not having the correct pinmux settings.

I'll eventually finish switch of two leftover boards to OF_UPSTREAM and drop this whole file, thanks for the reminder.

#9 lore raw
In reply to Frieder Schrempf

Hi Jaehoon,

Am 11.08.25 um 15:11 schrieb Frieder Schrempf:

Quoted 18 lines

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/

This aligns the PMIC driver with current Linux and allows to use upstream devicetrees in U-Boot.

Frieder Schrempf (6):
Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
pmic: pca9450: Fix enable register for LDO5
pmic: pca9450: Fix control register for LDO5
pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios
arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

Quoted 6 lines
 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts |  1 -
 arch/arm/dts/imx8mp-dhcom-som.dtsi         |  1 -
 drivers/power/pmic/pca9450.c               | 22 -------------
 drivers/power/regulator/pca9450.c          | 37 ++++++++++++++++++++--
 4 files changed, 34 insertions(+), 27 deletions(-)

I saw that there are several patches on the mailing list for /drivers/power that have received no reply from a maintainer for several weeks (see [1]). I just wanted to make sure that you are aware of this and kindly ask to have a look.

Thanks
Frieder

[1]
https://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=1&q=&archive=both&delegate=12423

#10 lore raw
Quoted 49 lines

Subject: Re: [PATCH 0/6] Use correct LDO5 control registers for PCA9450

Hi Jaehoon,

Am 11.08.25 um 15:11 schrieb Frieder Schrempf:

Quoted 6 lines

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
patc

Quoted 1 line

hwork.kernel.org%2Fproject%2Flinux-arm-

kernel%2Fcover%2F20241218152842

Quoted 1 line

.97483-1-

frieder%40fris.de%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7C51 6d

Quoted 1 line

65c0706c4d71292d08dde3b31d9d%7C686ea1d3bc2b4c6fa92cd99c5c 301635%7C0%7C

Quoted 1 line

0%7C638917080648452454%7CUnknown%7CTWFpbGZsb3d8eyJFbXB 0eU1hcGkiOnRydWU

Quoted 1 line

sIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ% 3D%3D%

Quoted 1 line

7C0%7C%7C%7C&sdata=neJx6WZU4iZWjSUcsnzOVQvFiaCTKLChE8srEx 6cwEQ%3D&rese

Quoted 11 lines

rved=0

This aligns the PMIC driver with current Linux and allows to use upstream devicetrees in U-Boot.

Frieder Schrempf (6):
Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
pmic: pca9450: Fix enable register for LDO5
pmic: pca9450: Fix control register for LDO5
pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-

vsel-gpios

Quoted 6 lines

arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts |  1 -
 arch/arm/dts/imx8mp-dhcom-som.dtsi         |  1 -
 drivers/power/pmic/pca9450.c               | 22 -------------
 drivers/power/regulator/pca9450.c          | 37
Quoted 8 lines

++++++++++++++++++++--

Quoted 2 lines
 4 files changed, 34 insertions(+), 27 deletions(-)

I saw that there are several patches on the mailing list for /drivers/power that have received no reply from a maintainer for several weeks (see [1]). I just wanted to make sure that you are aware of this and kindly ask to have a look.

I could help handle that via mmc tree, if Tom and you are ok.

Regards
Peng.

Quoted 5 lines

Thanks
Frieder

[1]

#11 lore raw

Am 27.08.25 um 07:46 schrieb Peng Fan:

Quoted 53 lines
Quoted 53 lines

Subject: Re: [PATCH 0/6] Use correct LDO5 control registers for PCA9450

Hi Jaehoon,

Am 11.08.25 um 15:11 schrieb Frieder Schrempf:

Quoted 6 lines

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
patc

Quoted 1 line

hwork.kernel.org%2Fproject%2Flinux-arm-

kernel%2Fcover%2F20241218152842

Quoted 1 line

.97483-1-

frieder%40fris.de%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7C51 6d

Quoted 1 line

65c0706c4d71292d08dde3b31d9d%7C686ea1d3bc2b4c6fa92cd99c5c 301635%7C0%7C

Quoted 1 line

0%7C638917080648452454%7CUnknown%7CTWFpbGZsb3d8eyJFbXB 0eU1hcGkiOnRydWU

Quoted 1 line

sIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ% 3D%3D%

Quoted 1 line

7C0%7C%7C%7C&sdata=neJx6WZU4iZWjSUcsnzOVQvFiaCTKLChE8srEx 6cwEQ%3D&rese

Quoted 11 lines

rved=0

This aligns the PMIC driver with current Linux and allows to use upstream devicetrees in U-Boot.

Frieder Schrempf (6):
Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
pmic: pca9450: Fix enable register for LDO5
pmic: pca9450: Fix control register for LDO5
pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-

vsel-gpios

Quoted 6 lines

arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts |  1 -
 arch/arm/dts/imx8mp-dhcom-som.dtsi         |  1 -
 drivers/power/pmic/pca9450.c               | 22 -------------
 drivers/power/regulator/pca9450.c          | 37

++++++++++++++++++++--

Quoted 2 lines
 4 files changed, 34 insertions(+), 27 deletions(-)
Quoted 6 lines
Quoted 4 lines

I saw that there are several patches on the mailing list for /drivers/power that have received no reply from a maintainer for several weeks (see [1]). I just wanted to make sure that you are aware of this and kindly ask to have a look.

I could help handle that via mmc tree, if Tom and you are ok.

I don't mind. If Tom agrees to take power patches through the mmc tree from you that's fine.

#12 lore raw
Quoted 59 lines · Frieder Schrempf

Am 27.08.25 um 07:46 schrieb Peng Fan:

Quoted 58 lines
Quoted 57 lines

Subject: Re: [PATCH 0/6] Use correct LDO5 control registers for PCA9450

Hi Jaehoon,

Am 11.08.25 um 15:11 schrieb Frieder Schrempf:

Quoted 6 lines

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
patc

Quoted 1 line

hwork.kernel.org%2Fproject%2Flinux-arm-

kernel%2Fcover%2F20241218152842

Quoted 1 line

.97483-1-

frieder%40fris.de%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7C51 6d

Quoted 1 line

65c0706c4d71292d08dde3b31d9d%7C686ea1d3bc2b4c6fa92cd99c5c 301635%7C0%7C

Quoted 1 line

0%7C638917080648452454%7CUnknown%7CTWFpbGZsb3d8eyJFbXB 0eU1hcGkiOnRydWU

Quoted 1 line

sIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ% 3D%3D%

Quoted 1 line

7C0%7C%7C%7C&sdata=neJx6WZU4iZWjSUcsnzOVQvFiaCTKLChE8srEx 6cwEQ%3D&rese

Quoted 11 lines

rved=0

This aligns the PMIC driver with current Linux and allows to use upstream devicetrees in U-Boot.

Frieder Schrempf (6):
Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
pmic: pca9450: Fix enable register for LDO5
pmic: pca9450: Fix control register for LDO5
pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-

vsel-gpios

Quoted 6 lines

arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios

 arch/arm/dts/imx8mp-data-modul-edm-sbc.dts |  1 -
 arch/arm/dts/imx8mp-dhcom-som.dtsi         |  1 -
 drivers/power/pmic/pca9450.c               | 22 -------------
 drivers/power/regulator/pca9450.c          | 37

++++++++++++++++++++--

Quoted 2 lines
 4 files changed, 34 insertions(+), 27 deletions(-)

I saw that there are several patches on the mailing list for /drivers/power that have received no reply from a maintainer for several weeks (see [1]). I just wanted to make sure that you are aware of this and kindly ask to have a look.

Quoted 4 lines
Quoted 1 line

I could help handle that via mmc tree, if Tom and you are ok.

I don't mind. If Tom agrees to take power patches through the mmc tree from you that's fine.

This would be helpful, thanks!

Signature · 1 line
Tom
#13 lore raw
In reply to Frieder Schrempf

From: Peng Fan <[email protected]>

Quoted 8 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

This is a port for the following series in Linux, which is already available in mainline:

https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/

[...]

Applied, thanks!

[1/6] Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"

      commit: b7360bd9e8e05dcfd1b4e5fd1c996aabf919e180
[2/6] pmic: pca9450: Fix enable register for LDO5
      commit: 8a04fbd9afd635d37c9afc1b56d014d134861e29
[3/6] pmic: pca9450: Fix control register for LDO5
      commit: addfe4544630a96a1cd03daf822a196af42b7a73
[4/6] pmic: pca9450: Handle hardware with fixed SD_VSEL for LDO5
      commit: 281829f5ca1645c3bffa130d04753a1a76b64dfb
[5/6] arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios
      commit: 925f63b0209483cd04b014cc8b5deab1f20267b7
[6/6] arm: dts: imx8mp-dhcom-som: Remove deprecated sd-vsel-gpios
      commit: dc0a12fecea789de83015319f3e9aeddd0a824a2

Best regards,

Signature · 1 line
Peng Fan <[email protected]>