powerpc/pasemi: Fix PCI device reference leak on error path
PATCH 1/1 powerpc/pasemi: Fix PCI device reference leak on error path
Fix iob_pdev reference leak in pasemi_dma_init() when dma_pdev allocation fails. Ensure pci_dev_put(iob_pdev) is called on both success and error paths.
--- arch/powerpc/platforms/pasemi/dma_lib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pasemi/dma_lib.c +5 -1
@@ -530,7 +530,7 @@ int pasemi_dma_init(void)BUG ();pr_warn ("Can't find DMA controller\n" ); err = -ENODEV ; - goto out; + goto out_put_iob; } dma_regs =map_onedev (dma_pdev,0 ); base_hw_irq =virq_to_hw (dma_pdev->irq);
@@ -617,5 +617,9 @@ int pasemi_dma_init(void) out:spin_unlock (&init_lock);return err; + +out_put_iob: +pci_dev_put (iob_pdev); + goto out; }EXPORT_SYMBOL (pasemi_dma_init);
Signature · 1 line
2.35.1
Quoted 3 lines
Fix
iob_pdevreference leak inpasemi_dma_init()whendma_pdevallocation fails. Ensurepci_dev_put(iob_pdev)is called on both success and error paths.
How do you think about to increase the application of scope-based resource management?
…
arch/powerpc/platforms/pasemi/dma_lib.c int pasemi_dma_init(void) · line 533
Quoted 6 lines
+++
b/arch/powerpc/platforms/pasemi/dma_lib.carch/powerpc/platforms/pasemi/dma_lib.c +0
-1@@ -530,7 +530,7 @@ int pasemi_dma_init(void)BUG ();pr_warn ("Can't find DMA controller\n" ); err = -ENODEV ; - goto out;
Is it sufficient to add the function call “pci_dev_put(iob_pdev)” in this if branch?
arch/powerpc/platforms/pasemi/dma_lib.c int pasemi_dma_init(void) · line 535
Quoted 3 lines
arch/powerpc/platforms/pasemi/dma_lib.c +1
-0+ goto out_put_iob; } dma_regs =map_onedev (dma_pdev,0 );
…
Regards,
Markus