Skip to contentSkip to conversation

powerpc/pasemi: Fix PCI device reference leak on error path

PATCH In review Miaoqian Lin 2 participants 2 messages Aug 29, 2025 – Sep 2, 2025 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/pasemi: Fix PCI device reference leak on error path

Fix iob_pdev reference leak in pasemi_dma_init() when dma_pdev allocation fails. Ensure pci_dev_put(iob_pdev) is called on both success and error paths.

Fixes 8ee9d8577935 ("pasemi: DMA engine management library")
---
 arch/powerpc/platforms/pasemi/dma_lib.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pasemi/dma_lib.c +5 -1
index 1be1f18f6f09..0ba05c39c276 100644
@@ -530,7 +530,7 @@ int pasemi_dma_init(void)
 		BUG();
 		pr_warn("Can't find DMA controller\n");
 		err = -ENODEV;
-		goto out;
+		goto out_put_iob;
 	}
 	dma_regs = map_onedev(dma_pdev, 0);
 	base_hw_irq = virq_to_hw(dma_pdev->irq);
@@ -617,5 +617,9 @@ int pasemi_dma_init(void)
 out:
 	spin_unlock(&init_lock);
 	return err;
+
+out_put_iob:
+	pci_dev_put(iob_pdev);
+	goto out;
 }
 EXPORT_SYMBOL(pasemi_dma_init);
Signature · 1 line
2.35.1
#1 lore raw
Quoted 3 lines

Fix iob_pdev reference leak in pasemi_dma_init() when dma_pdev allocation fails. Ensure pci_dev_put(iob_pdev) is called on both success and error paths.

How do you think about to increase the application of scope-based resource management?

…

arch/powerpc/platforms/pasemi/dma_lib.c int pasemi_dma_init(void) · line 533

Quoted 6 lines

+++ b/arch/powerpc/platforms/pasemi/dma_lib.c

arch/powerpc/platforms/pasemi/dma_lib.c +0 -1
@@ -530,7 +530,7 @@ int pasemi_dma_init(void)
 		BUG();
 		pr_warn("Can't find DMA controller\n");
 		err = -ENODEV;
-		goto out;

Is it sufficient to add the function call “pci_dev_put(iob_pdev)” in this if branch?

arch/powerpc/platforms/pasemi/dma_lib.c int pasemi_dma_init(void) · line 535

Quoted 3 lines
arch/powerpc/platforms/pasemi/dma_lib.c +1 -0
+		goto out_put_iob;
 	}
 	dma_regs = map_onedev(dma_pdev, 0);

…

Regards,
Markus