Skip to contentSkip to conversation

Add driver support for Eswin EIC7700 SoC PCIe controller

PATCH Superseded [email protected] 4 participants 16 messages Aug 29, 2025 – Sep 19, 2025

Subsystems (3)

v2 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add driver support for Eswin EIC7700 SoC PCIe controller

From: Senchuan Zhang <[email protected]>

This series depends on the vendor prefix [1] and config option patch [2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250825&id=ac29e4487aa20a21b7c3facbd1f14f5093835dc9
[2] https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Updates: eswin,eic7700-pcie.yaml
- Optimize the naming of "clock-names" and "reset-names".
- Add a reference to "$ref: /schemas/pci/pci-host-bridge.yaml#". (The name of the reset attribute in the "snps,dw-pcie-common.yaml" file is different from our reset attribute and "snps,dw-pcie.yaml" file cannot be directly referenced)
- Follow DTS coding style to optimize yaml attributes.
- Remove status = "disabled" from yaml.

- Updates: pcie-eic7700.c
- Remove unnecessary imported header files.
- Use dev_err instead of pr_err and remove the WARN_ON function.
- The eswin_evb_socket_power_on function is removed and not supported.
- The eswin_pcie_remove function is placed after the probe function.
- Optimize function alignment.
- Manage the clock using the devm_clk_bulk_get_all_enabled function.
- Handle the release of resources after the dw_pcie_host_init function
call fails.
- Remove the dev_dbg function and remove __exit_p.
- Add support for the system pm function.
- Link to V1: https://lore.kernel.org/all/[email protected]/

Senchuan Zhang (2):
dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller
PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 +++++++
 drivers/pci/controller/dwc/Kconfig            |  12 +
 drivers/pci/controller/dwc/Makefile           |   1 +
 drivers/pci/controller/dwc/pcie-eic7700.c     | 350 ++++++++++++++++++
 4 files changed, 505 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
 create mode 100644 drivers/pci/controller/dwc/pcie-eic7700.c

--
2.25.1

#1 lore raw

PATCH v2 1/2 dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +142 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;
+        };
+    };

--
2.25.1

Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 11 lines · On Fri, Aug 29, 2025 at 04:22:37PM +0800, [email protected]…
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +11 -0
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 36

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4

If that's const, you do not need it. It's implied by the compatible. I see some other bindings do similarly and I think that's not the correct choice.

Well, maybe @Rob knows if PCI is different here anyhow?

Quoted 94 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +94 -0
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;

That's not a hex number, but decimal.

Best regards,
Krzysztof

#3 lore raw

Re: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 37 lines

-----Original Messages-----
From: "Krzysztof Kozlowski" <[email protected]>
Send time:Monday, 01/09/2025 13:19:04
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 11 lines · On Fri, Aug 29, 2025 at 04:22:37PM +0800, [email protected]…
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +11 -0
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 36

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4

If that's const, you do not need it. It's implied by the compatible. I see some other bindings do similarly and I think that's not the correct choice.

Quoted 1 line

Well, maybe @Rob knows if PCI is different here anyhow?

Dear Krzysztof

Thank you very much for your review.
You're right,If that's const, I don't think it's necessary either. After investigation, the description of the "num-lanes" attribute here is incorrect. The correct one should be the following description:
num-lanes:
maximum: 4
If so, the num-lanes attribute should need to be described here. What do you think?

Quoted 108 lines
Quoted 95 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +94 -0
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;

That's not a hex number, but decimal.

Quoted 1 line

Manivannan and Bjorn have provided me with some excellent suggestions for my yaml. My yaml will be refactored in the next patch, and I might need you to review it again for me in the next patch. I'm a little wondering if I need to add "Reviewed-by: Krzysztof Kozlowski <[email protected]>" in next patch. May I ask for your opinion?

Best regards,
Senchuan zhang

#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 9 lines · zhangsenchuan
Quoted 8 lines

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 36

Quoted 2 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +2 -0
+  num-lanes:
+    const: 4

If that's const, you do not need it. It's implied by the compatible. I see some other bindings do similarly and I think that's not the correct choice.

Well, maybe @Rob knows if PCI is different here anyhow?

Quoted 8 lines

Dear Krzysztof

Thank you very much for your review.
You're right,If that's const, I don't think it's necessary either. After investigation, the description of the "num-lanes" attribute here is incorrect. The correct one should be the following description:
num-lanes:
maximum: 4

If 1, 2 or 4 lanes are correct, for this compatible, then yes.

Quoted 3 lines

If so, the num-lanes attribute should need to be described here. What do you think?

...

Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +12 -0
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;
Quoted 8 lines
Quoted 3 lines

That's not a hex number, but decimal.

Manivannan and Bjorn have provided me with some excellent suggestions for my yaml. My yaml will be refactored in the next patch, and I might need you to review it again for me in the next patch. I'm a little wondering if I need to add "Reviewed-by: Krzysztof Kozlowski <[email protected]>" in next patch.

If you are changing it significantly, then drop/ignore my tag and write in the changelog reasons why the tag was dropped. Usually adding new properties is a significant change. Changing some clock name from A to B is not a significant change. Other cases vary. More important is to explain the differences and reason of dropping tag.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

In reply to [email protected]
Quoted 64 lines · On Fri, Aug 29, 2025 at 04:22:37PM GMT, [email protected] wrote:

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +44 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 54

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth

What? Are these standard INTx or something elese? PCI(e) spec defines only INT{A-D}.

Quoted 53 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +53 -0
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 117

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,

I/O CPU range starts from 0x0

Also, I don't think you need to set the relocatable flag (bit 31) for any regions.

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 124

Quoted 7 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +7 -0
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;

Don't you have clock definitions for these values?

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 128

Quoted 4 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +4 -0
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;

Same here.

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 12 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +12 -0
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;

nit: Most of the bindings define num-lanes as decimal.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#6 lore raw

Re: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 80 lines

-----Original Messages-----
From: "Manivannan Sadhasivam" <[email protected]>
Send time:Monday, 01/09/2025 14:04:50
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 69 lines · On Fri, Aug 29, 2025 at 04:22:37PM GMT, [email protected] wrote:

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +49 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
Quoted 9 lines

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 54

Quoted 5 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +5 -0
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth

What? Are these standard INTx or something elese? PCI(e) spec defines only INT{A-D}.

Dear Manivannan

Thank you for your thorough review .
You are right, the PCI(e) spec defines only four legacy INTx interrupts (INTA#, INTB#, INTC#, INTD#). PCI(e) spec defines also mentions that INTX interrupts have two control states (Assert_INTx/Deassert_INTx Message). In our yaml, inta~intd corresponds to Assert_INTA~Assert_INTD, and inte~inth corresponds to Deassert_INTA~Deassert_INTD. May I ask if inte~inth needs to be removed or if the naming needs to be standardized?
I saw that in "sifive,fu740-pcie.yaml", interrupt-names only retain inta to intd.

Quoted 66 lines
Quoted 53 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +53 -0
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 117

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,

I/O CPU range starts from 0x0

Quoted 2 lines

Also, I don't think you need to set the relocatable flag (bit 31) for any regions.

if cannot set the relocatable flag (bit 31) for any regions.Is it appropriate to write it this way: ranges = <0x01000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,

         <0x02000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
         <0x43000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
Quoted 11 lines

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 124

Quoted 8 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +7 -0
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;

Don't you have clock definitions for these values?

Our clock and reset drivers have the definitions of these values, but the clock and reset drivers are under review. Currently, these values can only be replaced by constants.

Quoted 20 lines

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 128

Quoted 4 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +4 -0
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;

Same here.

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 12 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +12 -0
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;
Quoted 2 lines

nit: Most of the bindings define num-lanes as decimal.

Best Regards,

Senchuan Zhang

#7 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 90 lines · zhangsenchuan
Quoted 80 lines

-----Original Messages-----
From: "Manivannan Sadhasivam" <[email protected]>
Send time:Monday, 01/09/2025 14:04:50
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 69 lines · On Fri, Aug 29, 2025 at 04:22:37PM GMT, [email protected] wrote:

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +49 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
Quoted 9 lines

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 54

Quoted 5 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +5 -0
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth

What? Are these standard INTx or something elese? PCI(e) spec defines only INT{A-D}.

Quoted 9 lines

Dear Manivannan

Thank you for your thorough review .
You are right, the PCI(e) spec defines only four legacy INTx interrupts (INTA#, INTB#, INTC#, INTD#). PCI(e) spec defines also mentions that INTX interrupts have two control states (Assert_INTx/Deassert_INTx Message). In our yaml, inta~intd corresponds to Assert_INTA~Assert_INTD, and inte~inth corresponds to Deassert_INTA~Deassert_INTD. May I ask if inte~inth needs to be removed or if the naming needs to be standardized?
I saw that in "sifive,fu740-pcie.yaml", interrupt-names only retain inta to intd.

If these are actual interrupts and these names align with the interrupt names in the hardware IP, then you can keep it as it is and should add a comment for inte-inth:

		- const: inte /* INTA_Deassert */
		...

If not, then you should remove inte-inth.

Quoted 66 lines
Quoted 66 lines
Quoted 53 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +53 -0
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 117

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,

I/O CPU range starts from 0x0

Quoted 8 lines
Quoted 2 lines

Also, I don't think you need to set the relocatable flag (bit 31) for any regions.

if cannot set the relocatable flag (bit 31) for any regions.Is it appropriate to write it this way: ranges = <0x01000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,

         <0x02000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
         <0x43000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;

Yes.

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +7 -0
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
Quoted 6 lines
Quoted 2 lines

Don't you have clock definitions for these values?

Our clock and reset drivers have the definitions of these values, but the clock and reset drivers are under review. Currently, these values can only be replaced by constants.

Ok, you should also mention this in description or cover letter.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#8 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

In reply to [email protected]
Quoted 150 lines · On Fri, Aug 29, 2025 at 04:22:37PM +0800, [email protected]…

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +130 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;

num-lanes and perst are per-Root Port items. Please put anything related specifically to the Root Port in its own stanza to make it easier to support multiple Root Ports in future versions of the hardware.

See
https://lore.kernel.org/linux-pci/20250625221653.GA1590146@bhelgaas/
for examples of how to do this.

Quoted 5 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +2 -1
+        };
+    };
--

2.25.1

#9 lore raw

Re: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 177 lines

-----Original Messages-----
From: "Bjorn Helgaas" <[email protected]>
Send time:Friday, 05/09/2025 00:06:00
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 150 lines · On Fri, Aug 29, 2025 at 04:22:37PM +0800, [email protected]…

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

---
 .../bindings/pci/eswin,eic7700-pcie.yaml      | 142 ++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +130 -0
new file mode 100644
index 000000000000..65f640902b11
@@ -0,0 +1,142 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 PCIe host controller
+
+maintainers:
+  - Yu Ning <[email protected]>
+  - Senchuan Zhang <[email protected]>
+
+description:
+  The PCIe controller on EIC7700 SoC.
+
+allOf:
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
+
+properties:
+  compatible:
+    const: eswin,eic7700-pcie
+
+  reg:
+    maxItems: 3
+
+  reg-names:
+    items:
+      - const: dbi
+      - const: config
+      - const: mgmt
+
+  ranges:
+    maxItems: 3
+
+  num-lanes:
+    const: 4
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 9
+
+  interrupt-names:
+    items:
+      - const: msi
+      - const: inta
+      - const: intb
+      - const: intc
+      - const: intd
+      - const: inte
+      - const: intf
+      - const: intg
+      - const: inth
+
+  interrupt-map:
+    maxItems: 4
+
+  interrupt-map-mask:
+    items:
+      - const: 0
+      - const: 0
+      - const: 0
+      - const: 7
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: mstr
+      - const: dbi
+      - const: pclk
+      - const: aux
+
+  resets:
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: cfg
+      - const: powerup
+      - const: pwren
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - num-lanes
+  - interrupts
+  - interrupt-names
+  - interrupt-map-mask
+  - interrupt-map
+  - '#interrupt-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie@54000000 {
+            compatible = "eswin,eic7700-pcie";
+            reg = <0x0 0x54000000 0x0 0x4000000>,
+                  <0x0 0x40000000 0x0 0x800000>,
+                  <0x0 0x50000000 0x0 0x100000>;
+            reg-names = "dbi", "config", "mgmt";
+            #address-cells = <3>;
+            #size-cells = <2>;
+            #interrupt-cells = <1>;
+            ranges = <0x81000000 0x0 0x40800000 0x0 0x40800000 0x0 0x800000>,
+                     <0x82000000 0x0 0x41000000 0x0 0x41000000 0x0 0xf000000>,
+                     <0xc3000000 0x80 0x00000000 0x80 0x00000000 0x2 0x00000000>;
+            bus-range = <0x0 0xff>;
+            clocks = <&clock 562>,
+                     <&clock 563>,
+                     <&clock 564>,
+                     <&clock 565>;
+            clock-names = "mstr", "dbi", "pclk", "aux";
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;

num-lanes and perst are per-Root Port items. Please put anything related specifically to the Root Port in its own stanza to make it easier to support multiple Root Ports in future versions of the hardware.

Quoted 3 lines

See
https://lore.kernel.org/linux-pci/20250625221653.GA1590146@bhelgaas/
for examples of how to do this.

Dear Bjorn

Thank you very much for your review.
I think the suggestions you put forward are very good,I placed perst in the root port as per your suggestion.

I'm a bit confused about the "num-lanes" attribute.
The "num-lanes" attribute will be parsed in the "pcie-designware.c" file. In the "pcie-designware-host.c" file, When our driver calls the dw_pcie_host_init function for initialization, the attribute "num_lanes" will be judged. If the attribute is available, use the value parsed from the device tree. If the attribute cannot be obtained from the node, the lanes supported by the hardware default will be obtained by reading the register.Can I avoid reparsing the num-lanes attribute?

I saw vendors based on Synopsys implementation. They separated the root port node and did not place "num-lanes" in the root port node.
For examples:
hisilicon,kirin-pcie.yaml
qcom,pcie-sc7280.yaml
qcom,pcie-sa8255p.yaml

Is it allowed for me not to place "num-lanes" in the root port node? Looking forward to your reply, thanks!

Best regards,
Senchuan zhang

#10 lore raw

Re: Re: [PATCH v2 1/2] dt-bindings: PCI: eic7700: Add Eswin eic7700 PCIe host controller

Quoted 49 lines · zhangsenchuan
Quoted 26 lines

-----Original Messages-----
From: "Bjorn Helgaas" <[email protected]>

Quoted 12 lines · On Fri, Aug 29, 2025 at 04:22:37PM +0800, [email protected]…

From: Senchuan Zhang <[email protected]>

Add Device Tree binding documentation for the ESWIN EIC7700 PCIe controller module,the PCIe controller enables the core to correctly initialize and manage the PCIe bus and connected devices.

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +5 -0
+            resets = <&reset 8 (1 << 0)>,
+                     <&reset 8 (1 << 1)>,
+                     <&reset 8 (1 << 2)>;
+            reset-names = "cfg", "powerup", "pwren";
+            interrupts = <220>, <179>, <180>, <181>, <182>, <183>, <184>, <185>, <186>;

Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml line 140

Quoted 10 lines
Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml new file +10 -0
+            interrupt-names = "msi", "inta", "intb", "intc", "intd",
+                              "inte", "intf", "intg", "inth";
+            interrupt-parent = <&plic>;
+            interrupt-map-mask = <0x0 0x0 0x0 0x7>;
+            interrupt-map = <0x0 0x0 0x0 0x1 &plic 179>,
+                            <0x0 0x0 0x0 0x2 &plic 180>,
+                            <0x0 0x0 0x0 0x3 &plic 181>,
+                            <0x0 0x0 0x0 0x4 &plic 182>;
+            device_type = "pci";
+            num-lanes = <0x4>;
Quoted 8 lines

num-lanes and perst are per-Root Port items. Please put anything related specifically to the Root Port in its own stanza to make it easier to support multiple Root Ports in future versions of the hardware.

See
https://lore.kernel.org/linux-pci/20250625221653.GA1590146@bhelgaas/
for examples of how to do this.

Thank you very much for your review.
I think the suggestions you put forward are very good,I placed perst in the root port as per your suggestion.

I'm a bit confused about the "num-lanes" attribute. The "num-lanes" attribute will be parsed in the "pcie-designware.c" file. In the "pcie-designware-host.c" file, When our driver calls the dw_pcie_host_init function for initialization, the attribute "num_lanes" will be judged. If the attribute is available, use the value parsed from the device tree. If the attribute cannot be obtained from the node, the lanes supported by the hardware default will be obtained by reading the register.Can I avoid reparsing the num-lanes attribute?

Quoted 6 lines

I saw vendors based on Synopsys implementation. They separated the root port node and did not place "num-lanes" in the root port node. For examples:
hisilicon,kirin-pcie.yaml
qcom,pcie-sc7280.yaml
qcom,pcie-sa8255p.yaml

This is currently a problem because the DWC core doesn't know to look for "num-lanes" in a Root Port node. Similar situation in the NXP
driver: https://lore.kernel.org/r/20250917212833.GA1873293@bhelgaas

Would it work for you to add a Root Port parser in eic7700, similar to mvebu_pcie_parse_port() or qcom_pcie_parse_port() that would get "num-lanes"?

It looks like that would keep the DWC core from setting num-lanes.

Eventually the DWC core should look first for a Root Port node before falling back to the current behavior of looking in the host bridge node. If/when that happens, we should be able to remove the num-lanes parsing in eic7700 and similar drivers.

I'd like to separate the per-Root Port things in the devicetree from the beginning because once devicetrees are out in the world, we basically have to support their structure forever.

Bjorn

#11 lore raw

PATCH v2 2/2 PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

In reply to [email protected]

From: Senchuan Zhang <[email protected]>

Add driver for the Eswin EIC7700 PCIe host controller. The controller is based on the DesignWare PCIe core.

---
 drivers/pci/controller/dwc/Kconfig        |  12 +
 drivers/pci/controller/dwc/Makefile       |   1 +
 drivers/pci/controller/dwc/pcie-eic7700.c | 350 ++++++++++++++++++++++
 3 files changed, 363 insertions(+)
 create mode 100644 drivers/pci/controller/dwc/pcie-eic7700.c
drivers/pci/controller/dwc/Kconfig +12 -0
index ff6b6d9e18ec..1c4063107a8a 100644
@@ -492,4 +492,16 @@ config PCIE_VISCONTI_HOST
 	  Say Y here if you want PCIe controller support on Toshiba Visconti SoC.
 	  This driver supports TMPV7708 SoC.
 
+config PCIE_EIC7700
+	tristate "ESWIN PCIe host controller"
+	depends on PCI_MSI
+	depends on ARCH_ESWIN || COMPILE_TEST
+	select PCIE_DW_HOST
+	help
+	  Enables support for the PCIe controller in the Eswin SoC
+	  The PCI controller on Eswin is based on DesignWare hardware
+	  It is a high-speed hardware bus standard used to connect
+	  processors with external devices. Say Y here if you want
+	  PCIe controller support for the ESWIN.
+
 endmenu
drivers/pci/controller/dwc/Makefile +1 -0
index 6919d27798d1..0717fe73a2a9 100644
@@ -31,6 +31,7 @@ obj-$(CONFIG_PCIE_UNIPHIER) += pcie-uniphier.o
 obj-$(CONFIG_PCIE_UNIPHIER_EP) += pcie-uniphier-ep.o
 obj-$(CONFIG_PCIE_VISCONTI_HOST) += pcie-visconti.o
 obj-$(CONFIG_PCIE_RCAR_GEN4) += pcie-rcar-gen4.o
+obj-$(CONFIG_PCIE_EIC7700) += pcie-eic7700.o
 
 # The following drivers are for devices that use the generic ACPI
 # pci_root.c driver but don't support standard ECAM config access.
drivers/pci/controller/dwc/pcie-eic7700.c new file +350 -0

350 lines not on this page · raw message

--
2.25.1

#12 lore raw

Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

Quoted 5 lines · On Fri, Aug 29, 2025 at 04:24:05PM GMT, [email protected] wrote:

From: Senchuan Zhang <[email protected]>

Add driver for the Eswin EIC7700 PCIe host controller. The controller is based on the DesignWare PCIe core.

Add more info about the controller: DWC IP revision, data rate, lanes etc...

Quoted 17 lines
---
 drivers/pci/controller/dwc/Kconfig        |  12 +
 drivers/pci/controller/dwc/Makefile       |   1 +
 drivers/pci/controller/dwc/pcie-eic7700.c | 350 ++++++++++++++++++++++
 3 files changed, 363 insertions(+)
 create mode 100644 drivers/pci/controller/dwc/pcie-eic7700.c
drivers/pci/controller/dwc/Kconfig +0 -0
index ff6b6d9e18ec..1c4063107a8a 100644
@@ -492,4 +492,16 @@ config PCIE_VISCONTI_HOST
 	  Say Y here if you want PCIe controller support on Toshiba Visconti SoC.
 	  This driver supports TMPV7708 SoC.
 

drivers/pci/controller/dwc/Kconfig config PCIE_VISCONTI_HOST · line 504

Quoted 10 lines
drivers/pci/controller/dwc/Kconfig +10 -0
+config PCIE_EIC7700
+	tristate "ESWIN PCIe host controller"
+	depends on PCI_MSI
+	depends on ARCH_ESWIN || COMPILE_TEST
+	select PCIE_DW_HOST
+	help
+	  Enables support for the PCIe controller in the Eswin SoC
+	  The PCI controller on Eswin is based on DesignWare hardware
+	  It is a high-speed hardware bus standard used to connect
+	  processors with external devices.

No need to explain what PCIe bus is.

Quoted 90 lines

Say Y here if you want

drivers/pci/controller/dwc/Kconfig +2 -0
+	  PCIe controller support for the ESWIN.
+
 endmenu
drivers/pci/controller/dwc/Makefile +1 -0
index 6919d27798d1..0717fe73a2a9 100644
@@ -31,6 +31,7 @@ obj-$(CONFIG_PCIE_UNIPHIER) += pcie-uniphier.o
 obj-$(CONFIG_PCIE_UNIPHIER_EP) += pcie-uniphier-ep.o
 obj-$(CONFIG_PCIE_VISCONTI_HOST) += pcie-visconti.o
 obj-$(CONFIG_PCIE_RCAR_GEN4) += pcie-rcar-gen4.o
+obj-$(CONFIG_PCIE_EIC7700) += pcie-eic7700.o
 
 # The following drivers are for devices that use the generic ACPI
 # pci_root.c driver but don't support standard ECAM config access.
drivers/pci/controller/dwc/pcie-eic7700.c new file +68 -0
new file mode 100644
index 000000000000..bf942154d971
@@ -0,0 +1,350 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * ESWIN PCIe root complex driver
+ *
+ * Copyright 2025, Beijing ESWIN Computing Technology Co., Ltd.
+ *
+ * Authors: Yu Ning <[email protected]>
+ *          Senchuan Zhang <[email protected]>
+ */
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/platform_device.h>
+#include <linux/resource.h>
+#include <linux/types.h>
+#include <linux/interrupt.h>
+#include <linux/iopoll.h>
+#include <linux/reset.h>
+#include <linux/pm_runtime.h>
+
+#include "pcie-designware.h"
+
+struct eswin_pcie {
+	struct dw_pcie pci;
+	void __iomem *mgmt_base;
+	struct clk_bulk_data *clks;
+	struct reset_control *powerup_rst;
+	struct reset_control *cfg_rst;
+	struct reset_control *perst;
+
+	int num_clks;
+};
+
+#define PCIE_PM_SEL_AUX_CLK BIT(16)
+#define PCIEMGMT_APP_LTSSM_ENABLE BIT(5)
+
+#define PCIEMGMT_CTRL0_OFFSET 0x0
+#define PCIEMGMT_STATUS0_OFFSET 0x100
+
+#define PCIE_TYPE_DEV_VEND_ID 0x0
+#define PCIE_DSP_PF0_MSI_CAP 0x50
+#define PCIE_NEXT_CAP_PTR 0x70
+#define DEVICE_CONTROL_DEVICE_STATUS 0x78
+
+#define PCIE_MSI_MULTIPLE_MSG_32 (0x5 << 17)
+#define PCIE_MSI_MULTIPLE_MSG_MASK (0x7 << 17)
+
+#define PCIEMGMT_LINKUP_STATE_VALIDATE ((0x11 << 2) | 0x3)
+#define PCIEMGMT_LINKUP_STATE_MASK 0xff
+
+static int eswin_pcie_start_link(struct dw_pcie *pci)
+{
+	struct device *dev = pci->dev;
+	struct eswin_pcie *pcie = dev_get_drvdata(dev);
+	u32 val;
+
+	/* Enable LTSSM */
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+	val |= PCIEMGMT_APP_LTSSM_ENABLE;
+	writel_relaxed(val, pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+
+	return 0;
+}
+
+static bool eswin_pcie_link_up(struct dw_pcie *pci)
+{
+	struct device *dev = pci->dev;
+	struct eswin_pcie *pcie = dev_get_drvdata(dev);
+	u32 val;

drivers/pci/controller/dwc/pcie-eic7700.c line 78

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_STATUS0_OFFSET);
+
+	return ((val & PCIEMGMT_LINKUP_STATE_MASK) ==
+		     PCIEMGMT_LINKUP_STATE_VALIDATE);
+}
+
+static int eswin_pcie_power_on(struct eswin_pcie *pcie)
+{
+	int ret = 0;

Don't initialize ret.

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+
+	/* pciet_cfg_rstn */
+	ret = reset_control_deassert(pcie->cfg_rst);
+	if (ret) {
+		dev_err(pcie->pci.dev, "cfg signal is invalid");
+		return ret;

drivers/pci/controller/dwc/pcie-eic7700.c line 94

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+	}
+
+	/* pciet_powerup_rstn */
+	ret = reset_control_deassert(pcie->powerup_rst);
+	if (ret) {
+		dev_err(pcie->pci.dev, "powerup signal is invalid");
+		goto err_deassert_powerup;
+	}
+
+	return ret;
	return 0;
Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+
+err_deassert_powerup:
+	reset_control_assert(pcie->cfg_rst);
+
+	return ret;
+}
+
+static void eswin_pcie_power_off(struct eswin_pcie *eswin_pcie)
+{
+	reset_control_assert(eswin_pcie->powerup_rst);
+	reset_control_assert(eswin_pcie->cfg_rst);
+}

drivers/pci/controller/dwc/pcie-eic7700.c line 116

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+
+static int eswin_pcie_host_init(struct dw_pcie_rp *pp)
+{
+	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
+	struct eswin_pcie *pcie = dev_get_drvdata(pci->dev);
+	int ret;
+	u32 val;
+	u32 retries;
+
+	/* Fetch clocks */

Drop the comment.

drivers/pci/controller/dwc/pcie-eic7700.c line 128

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+	pcie->num_clks = devm_clk_bulk_get_all_enabled(pci->dev, &pcie->clks);
+	if (pcie->num_clks < 0)
+		return dev_err_probe(pci->dev, pcie->num_clks,
+				     "failed to get pcie clocks\n");
+
+	ret = eswin_pcie_power_on(pcie);
+	if (ret)
+		return ret;
+
+	/* set device type : rc */
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+	val &= 0xfffffff0;

Can you add bitfield definition for the mask?

drivers/pci/controller/dwc/pcie-eic7700.c line 129

Quoted 1 line
drivers/pci/controller/dwc/pcie-eic7700.c new file +1 -0
+	writel_relaxed(val | 0x4, pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);

Also for 0x4.

drivers/pci/controller/dwc/pcie-eic7700.c line 133

Quoted 4 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +4 -0
+
+	ret = reset_control_assert(pcie->perst);
+	if (ret) {
+		dev_err(pci->dev, "perst assert signal is invalid");

'Failed to assert PERST#'

drivers/pci/controller/dwc/pcie-eic7700.c line 139

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+		goto err_perst;
+	}
+	msleep(100);
+	ret = reset_control_deassert(pcie->perst);
+	if (ret) {
+		dev_err(pci->dev, "perst deassert signal is invalid");

'Failed to deassert PERST#'

drivers/pci/controller/dwc/pcie-eic7700.c line 145

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+		goto err_perst;
+	}
+
+	/* app_hold_phy_rst */
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+	val &= ~(0x40);

Add definition here and everywhere.

drivers/pci/controller/dwc/pcie-eic7700.c line 150

Quoted 5 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +5 -0
+	writel_relaxed(val, pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+
+	/*
+	 * It takes at least 20ms to wait for the pcie
+	 * status register to be 0.

Make use of 80 columns for comments.

drivers/pci/controller/dwc/pcie-eic7700.c line 162

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+	 */
+	retries = 30;
+	do {
+		val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_STATUS0_OFFSET);
+		if (!(val & PCIE_PM_SEL_AUX_CLK))
+			break;
+		usleep_range(1000, 1100);
+		retries--;
+	} while (retries);
+
+	if (!retries) {
+		dev_err(pci->dev, "No clock exist.\n");

What does this error mean exactly? "No clock exist" is not a valid error. Error has something to do with PCIE_PM_SEL_AUX_CLK, no?

drivers/pci/controller/dwc/pcie-eic7700.c line 163

Quoted 1 line
drivers/pci/controller/dwc/pcie-eic7700.c new file +1 -0
+		ret = -ENODEV;

-ETIMEDOUT?

drivers/pci/controller/dwc/pcie-eic7700.c line 168

Quoted 5 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +5 -0
+		goto err_clock;
+	}
+
+	/* config eswin vendor id and eic7700 device id */
+	dw_pcie_writel_dbi(pci, PCIE_TYPE_DEV_VEND_ID, 0x20301fe1);

Does it need to be configured all the time?

drivers/pci/controller/dwc/pcie-eic7700.c line 170

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+
+	/* lane fix config, real driver NOT need, default x4 */

What do you mean by 'readl driver NOT need'?

Quoted 7 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +7 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL);
+	val &= 0xffffff80;
+	val |= 0x44;
+	dw_pcie_writel_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL, val);
+
+	val = dw_pcie_readl_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS);
+	val &= ~(0x7 << 5);

drivers/pci/controller/dwc/pcie-eic7700.c line 187

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+	val |= (0x2 << 5);
+	dw_pcie_writel_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS, val);
+
+	/*  config support 32 msi vectors */
+	val = dw_pcie_readl_dbi(pci, PCIE_DSP_PF0_MSI_CAP);
+	val &= ~PCIE_MSI_MULTIPLE_MSG_MASK;
+	val |= PCIE_MSI_MULTIPLE_MSG_32;
+	dw_pcie_writel_dbi(pci, PCIE_DSP_PF0_MSI_CAP, val);
+
+	/* disable msix cap */

Why? Hw doesn't support MSI-X but it advertises MSI-X capability?

Quoted 17 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +17 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_NEXT_CAP_PTR);
+	val &= 0xffff00ff;
+	dw_pcie_writel_dbi(pci, PCIE_NEXT_CAP_PTR, val);
+
+	return 0;
+
+err_clock:
+	reset_control_assert(pcie->perst);
+err_perst:
+	eswin_pcie_power_off(pcie);
+	return ret;
+}
+
+static const struct dw_pcie_host_ops eswin_pcie_host_ops = {
+	.init = eswin_pcie_host_init,
+};
+

drivers/pci/controller/dwc/pcie-eic7700.c line 214

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+static const struct dw_pcie_ops dw_pcie_ops = {
+	.start_link = eswin_pcie_start_link,
+	.link_up = eswin_pcie_link_up,
+};
+
+static int eswin_pcie_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct dw_pcie *pci;
+	struct eswin_pcie *pcie;

Use reverse Xmas order for all local variables in this driver.

drivers/pci/controller/dwc/pcie-eic7700.c line 226

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+	int ret;
+
+	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
+	if (!pcie)
+		return -ENOMEM;
+
+	pci = &pcie->pci;
+	pci->dev = dev;
+	pci->ops = &dw_pcie_ops;
+	pci->pp.ops = &eswin_pcie_host_ops;
+
+	/* SiFive specific region: mgmt */

So the DWC glue wrapper belongs to SiFive?

drivers/pci/controller/dwc/pcie-eic7700.c line 232

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+	pcie->mgmt_base = devm_platform_ioremap_resource_byname(pdev, "mgmt");
+	if (IS_ERR(pcie->mgmt_base))
+		return dev_err_probe(dev, PTR_ERR(pcie->mgmt_base),
+				     "failed to map mgmt memory\n");
+
+	/* Fetch reset */

Drop the comment.

Quoted 5 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +5 -0
+	pcie->powerup_rst = devm_reset_control_get_optional(&pdev->dev,
+							    "powerup");
+	if (IS_ERR_OR_NULL(pcie->powerup_rst))
+		return dev_err_probe(dev, PTR_ERR(pcie->powerup_rst),
+				     "unable to get powerup reset\n");

drivers/pci/controller/dwc/pcie-eic7700.c line 247

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+
+	pcie->cfg_rst = devm_reset_control_get_optional(&pdev->dev, "cfg");
+	if (IS_ERR_OR_NULL(pcie->cfg_rst))
+		return dev_err_probe(dev, PTR_ERR(pcie->cfg_rst),
+				     "unable to get cfg reset\n");
+
+	pcie->perst = devm_reset_control_get_optional(&pdev->dev, "pwren");
+	if (IS_ERR_OR_NULL(pcie->perst))
+		return dev_err_probe(dev, PTR_ERR(pcie->perst),
+				     "unable to get perst reset\n");

All 3 resets are optional? Even the ones you were using to power on the controller?

drivers/pci/controller/dwc/pcie-eic7700.c line 252

Quoted 5 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +5 -0
+
+	platform_set_drvdata(pdev, pcie);
+
+	pm_runtime_set_active(dev);
+	pm_runtime_enable(dev);

So by this time controller is powered on? I don't think so, as eswin_pcie_power_on() is called from host_init() callback. If I'm right, then these should be moved below dw_pcie_host_init().

drivers/pci/controller/dwc/pcie-eic7700.c line 253

Quoted 1 line
drivers/pci/controller/dwc/pcie-eic7700.c new file +1 -0
+	ret = pm_runtime_get_sync(dev);

Why do you need get_sync? Are you depending on any parent to power on any resource?

drivers/pci/controller/dwc/pcie-eic7700.c line 265

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+	if (ret < 0) {
+		dev_err(dev, "pm_runtime_get_sync failed: %d\n", ret);
+		goto err_get_sync;
+	}
+
+	ret = dw_pcie_host_init(&pci->pp);
+	if (ret) {
+		dev_err(dev, "failed to initialize host: %d\n", ret);
+		goto err_host_init;
+	}
+
+	return ret;
	return 0;
Quoted 15 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +15 -0
+
+err_host_init:
+	pm_runtime_put_sync(dev);
+err_get_sync:
+	pm_runtime_disable(dev);
+	return ret;
+}
+
+static void eswin_pcie_remove(struct platform_device *pdev)
+{
+	struct eswin_pcie *pcie = platform_get_drvdata(pdev);
+
+	dw_pcie_host_deinit(&pcie->pci.pp);
+	pm_runtime_put_sync(&pdev->dev);
+	pm_runtime_disable(&pdev->dev);

drivers/pci/controller/dwc/pcie-eic7700.c line 290

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+
+	reset_control_assert(pcie->perst);
+	eswin_pcie_power_off(pcie);
+}
+
+static void eswin_pcie_shutdown(struct platform_device *pdev)
+{
+	struct eswin_pcie *pcie = platform_get_drvdata(pdev);
+
+	/* Bring down link, so bootloader gets clean state in case of reboot */

Asserting PERST# won't bring down the device. It just provides indication that the device might get powered off and it needs to be prepared for that.

Also, I don't get what you mean by 'bootloder'. Is it the host system bootloader or device? Usually, shutdown callback is needed to power off the device when the host powers down/reboots so that the device will be reset to a clean state.

drivers/pci/controller/dwc/pcie-eic7700.c line 299

Quoted 9 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +9 -0
+	reset_control_assert(pcie->perst);
+}
+
+static int eswin_pcie_suspend(struct device *dev)
+{
+	struct eswin_pcie *pcie = dev_get_drvdata(dev);
+
+	reset_control_assert(pcie->perst);
+	eswin_pcie_power_off(pcie);

So you want to power off the device even if it intends to be in D0? Like NVMe.

drivers/pci/controller/dwc/pcie-eic7700.c line 311

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+	clk_bulk_disable_unprepare(pcie->num_clks, pcie->clks);
+
+	return 0;
+}
+
+static int eswin_pcie_resume(struct device *dev)
+{
+	int ret;
+	struct eswin_pcie *pcie = dev_get_drvdata(dev);
+
+	ret = eswin_pcie_host_init(&pcie->pci.pp);
+	if (ret < 0) {

if (ret)

Quoted 19 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +19 -0
+		dev_err(dev, "Failed to init host: %d\n", ret);
+		return ret;
+	}
+
+	dw_pcie_setup_rc(&pcie->pci.pp);
+	eswin_pcie_start_link(&pcie->pci);
+	dw_pcie_wait_for_link(&pcie->pci);
+
+	return 0;
+}
+
+static const struct dev_pm_ops eswin_pcie_pm_ops = {
+	NOIRQ_SYSTEM_SLEEP_PM_OPS(eswin_pcie_suspend, eswin_pcie_resume)
+};
+
+static const struct of_device_id eswin_pcie_of_match[] = {
+	{ .compatible = "eswin,eic7700-pcie" },
+	{},
+};

drivers/pci/controller/dwc/pcie-eic7700.c line 340

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+
+static struct platform_driver eswin_pcie_driver = {
+	.driver = {
+		.name = "eic7700-pcie",
+		.of_match_table = eswin_pcie_of_match,
+		.suppress_bind_attrs = true,
+		.pm = &eswin_pcie_pm_ops,
+	},
+	.probe = eswin_pcie_probe,
+	.remove = eswin_pcie_remove,

Since this controller implements irqchip using the DWC core driver, it is not safe to remove it during runtime.

drivers/pci/controller/dwc/pcie-eic7700.c line 344

Quoted 4 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +4 -0
+	.shutdown = eswin_pcie_shutdown,
+};
+
+module_platform_driver(eswin_pcie_driver);

builtin_platform_driver()

drivers/pci/controller/dwc/pcie-eic7700.c line 346

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+
+MODULE_DEVICE_TABLE(of, eswin_pcie_of_match);

Move it below eswin_pcie_of_match[].

drivers/pci/controller/dwc/pcie-eic7700.c line 347

Quoted 1 line
drivers/pci/controller/dwc/pcie-eic7700.c new file +1 -0
+MODULE_DESCRIPTION("PCIe host controller driver for eic7700 SoCs");

EIC7700?

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#13 lore raw

Re: Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

Dear Manivannan

Thank you for your thorough review.Here are some of my clarifications and questions. Looking forward to your answer, Thank you very much.

Quoted 8 lines

-----Original Messages-----
From: "Manivannan Sadhasivam" <[email protected]>
Send time:Monday, 01/09/2025 14:40:41
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

Quoted 4 lines

drivers/pci/controller/dwc/pcie-eic7700.c line 168

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+	/* config eswin vendor id and eic7700 device id */
+	dw_pcie_writel_dbi(pci, PCIE_TYPE_DEV_VEND_ID, 0x20301fe1);

Does it need to be configured all the time?

Clarification:
Our hardware initialization did not configure the device Id and vendor Id. Now, we can only rewrite the device Id and vendor Id in the code.

Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+	/* lane fix config, real driver NOT need, default x4 */

What do you mean by 'readl driver NOT need'?

Clarification:
Sorry, this was added during the compatibility platform test. It is not needed for real devices. I will remove it later.

Quoted 11 lines
Quoted 11 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +11 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL);
+	val &= 0xffffff80;
+	val |= 0x44;
+	dw_pcie_writel_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL, val);
+
+	val = dw_pcie_readl_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS);
+	val &= ~(0x7 << 5);
+	val |= (0x2 << 5);
+	dw_pcie_writel_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS, val);
+
+	/*  config support 32 msi vectors */
Quoted 9 lines

drivers/pci/controller/dwc/pcie-eic7700.c line 187

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_DSP_PF0_MSI_CAP);
+	val &= ~PCIE_MSI_MULTIPLE_MSG_MASK;
+	val |= PCIE_MSI_MULTIPLE_MSG_32;
+	dw_pcie_writel_dbi(pci, PCIE_DSP_PF0_MSI_CAP, val);
+
+	/* disable msix cap */

Why? Hw doesn't support MSI-X but it advertises MSI-X capability?

I'm not quite sure what this comment means? Indeed, our hardware doesn't support MSI-X. We can't disable the MSI-X capability using the PCIE_NEXT_CAP_PTR register? Then which register is needed to disable the MSI-X capability?

Quoted 5 lines
Quoted 5 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +5 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_NEXT_CAP_PTR);
+	val &= 0xffff00ff;
+	dw_pcie_writel_dbi(pci, PCIE_NEXT_CAP_PTR, val);
+
+	return 0;
Quoted 8 lines

drivers/pci/controller/dwc/pcie-eic7700.c line 200

Quoted 8 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +8 -0
+
+err_clock:
+	reset_control_assert(pcie->perst);
+err_perst:
+	eswin_pcie_power_off(pcie);
+	return ret;
+}
+

Best Regards,
Senchuan Zhang

#14 lore raw

Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

Quoted 13 lines · zhangsenchuan

Dear Manivannan

Thank you for your thorough review.Here are some of my clarifications and questions. Looking forward to your answer, Thank you very much.

Quoted 6 lines

-----Original Messages-----
From: "Manivannan Sadhasivam" <[email protected]>
Send time:Monday, 01/09/2025 14:40:41
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

Quoted 9 lines
Quoted 4 lines

drivers/pci/controller/dwc/pcie-eic7700.c line 168

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+	/* config eswin vendor id and eic7700 device id */
+	dw_pcie_writel_dbi(pci, PCIE_TYPE_DEV_VEND_ID, 0x20301fe1);

Does it need to be configured all the time?

Clarification:
Our hardware initialization did not configure the device Id and vendor Id. Now, we can only rewrite the device Id and vendor Id in the code.

Ok. Then mention it in the comment itself. Like,

	/*
	 * Configure ESWIN VID:DID for Root Port as the default values are
	 * invalid.
	 */
Quoted 32 lines
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+	/* lane fix config, real driver NOT need, default x4 */

What do you mean by 'readl driver NOT need'?

Clarification:
Sorry, this was added during the compatibility platform test. It is not needed for real devices. I will remove it later.

Quoted 11 lines
Quoted 11 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +11 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL);
+	val &= 0xffffff80;
+	val |= 0x44;
+	dw_pcie_writel_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL, val);
+
+	val = dw_pcie_readl_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS);
+	val &= ~(0x7 << 5);
+	val |= (0x2 << 5);
+	dw_pcie_writel_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS, val);
+
+	/*  config support 32 msi vectors */
Quoted 9 lines

drivers/pci/controller/dwc/pcie-eic7700.c line 187

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_DSP_PF0_MSI_CAP);
+	val &= ~PCIE_MSI_MULTIPLE_MSG_MASK;
+	val |= PCIE_MSI_MULTIPLE_MSG_32;
+	dw_pcie_writel_dbi(pci, PCIE_DSP_PF0_MSI_CAP, val);
+
+	/* disable msix cap */

Why? Hw doesn't support MSI-X but it advertises MSI-X capability?

Quoted 1 line

I'm not quite sure what this comment means? Indeed, our hardware doesn't support MSI-X.

So it advertises MSI-X in capability by mistake then. If so, do you think it is going to be applicable for future revisions of the controller also? I believe this is a kind of hw bug.

Usually, these kind of issues are fixed in future revisions of the SoC. So I was checking if you intend to clear it for all SoCs in the future or not. Otherwise, you may set a flag and clear it conditionally.

Quoted 3 lines

We can't disable the MSI-X capability using the PCIE_NEXT_CAP_PTR register? Then which register is needed to disable the MSI-X capability?

No, my question was not about *how to clear MSI cap*.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#15 lore raw

Re: [PATCH v2 2/2] PCI: eic7700: Add Eswin eic7700 PCIe host controller driver

In reply to [email protected]
Quoted 4 lines · On Fri, Aug 29, 2025 at 04:24:05PM +0800, [email protected]…

From: Senchuan Zhang <[email protected]>

Add driver for the Eswin EIC7700 PCIe host controller. The controller is based on the DesignWare PCIe core.

Wrap to fill 75 columns.

drivers/pci/controller/dwc/Kconfig config PCIE_VISCONTI_HOST · line 496

Quoted 7 lines

+++ b/drivers/pci/controller/dwc/Kconfig

drivers/pci/controller/dwc/Kconfig +2 -0
@@ -492,4 +492,16 @@ config PCIE_VISCONTI_HOST
 	  Say Y here if you want PCIe controller support on Toshiba Visconti SoC.
 	  This driver supports TMPV7708 SoC.
 
+config PCIE_EIC7700
+	tristate "ESWIN PCIe host controller"

Should say "ESWIN PCIe controller" to match other entries.

drivers/pci/controller/dwc/Kconfig config PCIE_VISCONTI_HOST · line 498

Quoted 2 lines
drivers/pci/controller/dwc/Kconfig +2 -0
+	depends on PCI_MSI
+	depends on ARCH_ESWIN || COMPILE_TEST

Reorder these to match other entries, i.e.,

	depends on ARCH_ESWIN || COMPILE_TEST
	depends on PCI_MSI

drivers/pci/controller/dwc/Kconfig config PCIE_VISCONTI_HOST · line 505

Quoted 7 lines
drivers/pci/controller/dwc/Kconfig +7 -0
+	select PCIE_DW_HOST
+	help
+	  Enables support for the PCIe controller in the Eswin SoC
+	  The PCI controller on Eswin is based on DesignWare hardware
+	  It is a high-speed hardware bus standard used to connect
+	  processors with external devices. Say Y here if you want
+	  PCIe controller support for the ESWIN.

Alphabetize so the menuconfig entries remain sorted by vendor.

drivers/pci/controller/dwc/pcie-eic7700.c line 18

Quoted 11 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+++ b/drivers/pci/controller/dwc/pcie-eic7700.c
 
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/platform_device.h>
+#include <linux/resource.h>
+#include <linux/types.h>
+#include <linux/interrupt.h>
+#include <linux/iopoll.h>
+#include <linux/reset.h>
+#include <linux/pm_runtime.h>

Usually people sort these alphabetically.

drivers/pci/controller/dwc/pcie-eic7700.c line 34

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+#define PCIE_PM_SEL_AUX_CLK BIT(16)
+#define PCIEMGMT_APP_LTSSM_ENABLE BIT(5)

Put these under the offset of the register that contains them so we can tell the connections.

drivers/pci/controller/dwc/pcie-eic7700.c line 39

Quoted 4 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +4 -0
+#define PCIEMGMT_CTRL0_OFFSET 0x0
+#define PCIEMGMT_STATUS0_OFFSET 0x100
+
+#define PCIE_TYPE_DEV_VEND_ID 0x0

This looks like PCI_VENDOR_ID; use that instead.

drivers/pci/controller/dwc/pcie-eic7700.c line 41

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+#define PCIE_DSP_PF0_MSI_CAP 0x50
+#define PCIE_NEXT_CAP_PTR 0x70

These look like fixed offsets in config space that should be discovered by the usual method of traversing the capability lists, e.g., dw_pcie_find_capability().

Quoted 1 line

+#define DEVICE_CONTROL_DEVICE_STATUS 0x78

I don't think you need this at all (see below). But if you do, the use below should include PCI_EXP_DEVCTL (e.g., as an offset from the start of the PCIe Capability) so grep can find it.

drivers/pci/controller/dwc/pcie-eic7700.c line 45

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+#define PCIE_MSI_MULTIPLE_MSG_32 (0x5 << 17)
+#define PCIE_MSI_MULTIPLE_MSG_MASK (0x7 << 17)

Use PCI_MSI_FLAGS_QMASK instead.

drivers/pci/controller/dwc/pcie-eic7700.c line 48

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+#define PCIEMGMT_LINKUP_STATE_VALIDATE ((0x11 << 2) | 0x3)
+#define PCIEMGMT_LINKUP_STATE_MASK 0xff

Line up all the values of these #defines.

Quoted 12 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +12 -0
+static int eswin_pcie_host_init(struct dw_pcie_rp *pp)
+{
+	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
+	struct eswin_pcie *pcie = dev_get_drvdata(pci->dev);
+	int ret;
+	u32 val;
+	u32 retries;
+
+	/* Fetch clocks */
+	pcie->num_clks = devm_clk_bulk_get_all_enabled(pci->dev, &pcie->clks);
+	if (pcie->num_clks < 0)
+		return dev_err_probe(pci->dev, pcie->num_clks,

drivers/pci/controller/dwc/pcie-eic7700.c line 129

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+				     "failed to get pcie clocks\n");
+
+	ret = eswin_pcie_power_on(pcie);
+	if (ret)
+		return ret;
+
+	/* set device type : rc */
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+	val &= 0xfffffff0;
+	writel_relaxed(val | 0x4, pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);

"rc" is not a device type (a Root Complex is not itself a PCI device that appears in config space). I think you're talking about a Root Port, which is a PCIe device, so this should be PCI_EXP_TYPE_ROOT_PORT.

drivers/pci/controller/dwc/pcie-eic7700.c line 136

Quoted 6 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +6 -0
+	ret = reset_control_assert(pcie->perst);
+	if (ret) {
+		dev_err(pci->dev, "perst assert signal is invalid");
+		goto err_perst;
+	}
+	msleep(100);

This sleep needs a comment (if it's specific to eic7700) or a standard #define from drivers/pci/pci.h (if something from the PCIe spec).

Quoted 4 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +4 -0
+	ret = reset_control_deassert(pcie->perst);
+	if (ret) {
+		dev_err(pci->dev, "perst deassert signal is invalid");
+		goto err_perst;

drivers/pci/controller/dwc/pcie-eic7700.c line 150

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+	}
+
+	/* app_hold_phy_rst */
+	val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+	val &= ~(0x40);
+	writel_relaxed(val, pcie->mgmt_base + PCIEMGMT_CTRL0_OFFSET);
+
+	/*
+	 * It takes at least 20ms to wait for the pcie
+	 * status register to be 0.

s/pcie/PCIe/ (follow spec usage in comments, messages, etc)

drivers/pci/controller/dwc/pcie-eic7700.c line 159

Quoted 9 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +9 -0
+	 */
+	retries = 30;
+	do {
+		val = readl_relaxed(pcie->mgmt_base + PCIEMGMT_STATUS0_OFFSET);
+		if (!(val & PCIE_PM_SEL_AUX_CLK))
+			break;
+		usleep_range(1000, 1100);
+		retries--;
+	} while (retries);

This delay should also have a citation to eic7700 spec if it came from there. Suggest fsleep() instead of usleep_range(). The exact delay doesn't look critical here.

drivers/pci/controller/dwc/pcie-eic7700.c line 162

Quoted 2 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +2 -0
+	if (!retries) {
+		dev_err(pci->dev, "No clock exist.\n");

Drop period at end of messages.

Quoted 7 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +7 -0
+		ret = -ENODEV;
+		goto err_clock;
+	}
+
+	/* config eswin vendor id and eic7700 device id */
+	dw_pcie_writel_dbi(pci, PCIE_TYPE_DEV_VEND_ID, 0x20301fe1);
+

drivers/pci/controller/dwc/pcie-eic7700.c line 179

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+	/* lane fix config, real driver NOT need, default x4 */
+	val = dw_pcie_readl_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL);
+	val &= 0xffffff80;
+	val |= 0x44;
+	dw_pcie_writel_dbi(pci, PCIE_PORT_MULTI_LANE_CTRL, val);
+
+	val = dw_pcie_readl_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS);
+	val &= ~(0x7 << 5);
+	val |= (0x2 << 5);
+	dw_pcie_writel_dbi(pci, DEVICE_CONTROL_DEVICE_STATUS, val);

This sets MPS, which should be done by the PCI core, not by the driver.

drivers/pci/controller/dwc/pcie-eic7700.c line 181

Quoted 1 line
drivers/pci/controller/dwc/pcie-eic7700.c new file +1 -0
+	/*  config support 32 msi vectors */

Use "MSI" and "MSI-X" in comments, etc to match spec usage.

drivers/pci/controller/dwc/pcie-eic7700.c line 184

Quoted 3 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +3 -0
+	val = dw_pcie_readl_dbi(pci, PCIE_DSP_PF0_MSI_CAP);
+	val &= ~PCIE_MSI_MULTIPLE_MSG_MASK;
+	val |= PCIE_MSI_MULTIPLE_MSG_32;

Use FIELD_PREP() as in dw_pcie_ep_set_msi().

Quoted 50 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +50 -0
+	dw_pcie_writel_dbi(pci, PCIE_DSP_PF0_MSI_CAP, val);
+
+	/* disable msix cap */
+	val = dw_pcie_readl_dbi(pci, PCIE_NEXT_CAP_PTR);
+	val &= 0xffff00ff;
+	dw_pcie_writel_dbi(pci, PCIE_NEXT_CAP_PTR, val);
+
+	return 0;
+
+err_clock:
+	reset_control_assert(pcie->perst);
+err_perst:
+	eswin_pcie_power_off(pcie);
+	return ret;
+}
+
+static const struct dw_pcie_host_ops eswin_pcie_host_ops = {
+	.init = eswin_pcie_host_init,
+};
+
+static const struct dw_pcie_ops dw_pcie_ops = {
+	.start_link = eswin_pcie_start_link,
+	.link_up = eswin_pcie_link_up,
+};
+
+static int eswin_pcie_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct dw_pcie *pci;
+	struct eswin_pcie *pcie;
+	int ret;
+
+	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
+	if (!pcie)
+		return -ENOMEM;
+
+	pci = &pcie->pci;
+	pci->dev = dev;
+	pci->ops = &dw_pcie_ops;
+	pci->pp.ops = &eswin_pcie_host_ops;
+
+	/* SiFive specific region: mgmt */
+	pcie->mgmt_base = devm_platform_ioremap_resource_byname(pdev, "mgmt");
+	if (IS_ERR(pcie->mgmt_base))
+		return dev_err_probe(dev, PTR_ERR(pcie->mgmt_base),
+				     "failed to map mgmt memory\n");
+
+	/* Fetch reset */
+	pcie->powerup_rst = devm_reset_control_get_optional(&pdev->dev,
+							    "powerup");

drivers/pci/controller/dwc/pcie-eic7700.c line 244

Quoted 10 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +10 -0
+	if (IS_ERR_OR_NULL(pcie->powerup_rst))
+		return dev_err_probe(dev, PTR_ERR(pcie->powerup_rst),
+				     "unable to get powerup reset\n");
+
+	pcie->cfg_rst = devm_reset_control_get_optional(&pdev->dev, "cfg");
+	if (IS_ERR_OR_NULL(pcie->cfg_rst))
+		return dev_err_probe(dev, PTR_ERR(pcie->cfg_rst),
+				     "unable to get cfg reset\n");
+
+	pcie->perst = devm_reset_control_get_optional(&pdev->dev, "pwren");

Why is this not called "perst" in devicetree?

Quoted 28 lines
drivers/pci/controller/dwc/pcie-eic7700.c new file +28 -0
+	if (IS_ERR_OR_NULL(pcie->perst))
+		return dev_err_probe(dev, PTR_ERR(pcie->perst),
+				     "unable to get perst reset\n");
+
+	platform_set_drvdata(pdev, pcie);
+
+	pm_runtime_set_active(dev);
+	pm_runtime_enable(dev);
+	ret = pm_runtime_get_sync(dev);
+	if (ret < 0) {
+		dev_err(dev, "pm_runtime_get_sync failed: %d\n", ret);
+		goto err_get_sync;
+	}
+
+	ret = dw_pcie_host_init(&pci->pp);
+	if (ret) {
+		dev_err(dev, "failed to initialize host: %d\n", ret);
+		goto err_host_init;
+	}
+
+	return ret;
+
+err_host_init:
+	pm_runtime_put_sync(dev);
+err_get_sync:
+	pm_runtime_disable(dev);
+	return ret;
+}