docs/system/keys: fix incorrect reset scaling key binding
PATCH 1/1 docs/system/keys: fix incorrect reset scaling key binding
Fix incorrect key binding for resetting the graphical frontends scaling
--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
docs/system/keys.rst.inc +1 -1
@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensions * - :kbd:`Ctrl+Alt+n`
Signature · 1 line
2.39.5
Quoted 12 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)docs/system/keys.rst.inc +0
-0
docs/system/keys.rst.inc while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. · line 25
Quoted 6 lines
docs/system/keys.rst.inc +1
-1@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensions
Hi,
this unfortunately seems to depend on the graphical front-end: For "-display gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Should we unify them? If so, which is the better key combination?
Thomas
Quoted 21 lines · Thomas Huth
Quoted 12 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)docs/system/keys.rst.inc +0
-0docs/system/keys.rst.inc while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. · line 24
Quoted 5 lines
docs/system/keys.rst.inc +1
-1@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensionsHi,
Quoted 5 lines
this unfortunately seems to depend on the graphical front-end: For "-display gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Should we unify them? If so, which is the better key combination?
Established convention in various apps is '+' for zoom in, '-' for zoom out, and '0' for reset to 100% (each combined with the hotkey modifier(s)). So when changing hotkeys we should follow that I think, i.e. switch SDL to Ctrl+Alt+0.
my two cents,
Gerd
Quoted 26 lines · Gerd Hoffmann
Quoted 25 lines · Thomas Huth
Quoted 12 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)docs/system/keys.rst.inc +0
-0docs/system/keys.rst.inc while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. · line 24
Quoted 5 lines
docs/system/keys.rst.inc +1
-1@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensionsHi,
this unfortunately seems to depend on the graphical front-end: For "-display gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Quoted 6 lines
Quoted 1 line
Should we unify them? If so, which is the better key combination?
Established convention in various apps is '+' for zoom in, '-' for zoom out, and '0' for reset to 100% (each combined with the hotkey modifier(s)). So when changing hotkeys we should follow that I think, i.e. switch SDL to Ctrl+Alt+0.
I'll send a patch fixing SDL to use CTRL+ALT+0
Nir
Quoted 29 lines · Nir Lichtman
Quoted 28 lines · Gerd Hoffmann
Quoted 26 lines · Thomas Huth
Quoted 12 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)docs/system/keys.rst.inc +0
-0docs/system/keys.rst.inc while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. · line 24
Quoted 5 lines
docs/system/keys.rst.inc +1
-1@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensionsHi,
this unfortunately seems to depend on the graphical front-end: For "-display gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Should we unify them? If so, which is the better key combination?
Quoted 8 lines
Quoted 4 lines
Established convention in various apps is '+' for zoom in, '-' for zoom out, and '0' for reset to 100% (each combined with the hotkey modifier(s)). So when changing hotkeys we should follow that I think, i.e. switch SDL to Ctrl+Alt+0.
I'll send a patch fixing SDL to use CTRL+ALT+0
Nir
Hi,
Looks like the SDL patch I sent was merged into main, reminder regarding this patch which fixes the documentation.
Thanks,
Nir
Thomas Huth
Reviewed-byQuoted 27 lines · Nir Lichtman
Quoted 26 lines · Gerd Hoffmann
Quoted 25 lines · Thomas Huth
Quoted 12 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>--- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)docs/system/keys.rst.inc +0
-0docs/system/keys.rst.inc while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. · line 24
Quoted 5 lines
docs/system/keys.rst.inc +1
-1@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. * - :kbd:`Ctrl+Alt+-` - Shrink the screen - * - :kbd:`Ctrl+Alt+u` + * - :kbd:`Ctrl+Alt+0` - Restore the screen's un-scaled dimensionsHi,
this unfortunately seems to depend on the graphical front-end: For "-display gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Should we unify them? If so, which is the better key combination?
Established convention in various apps is '+' for zoom in, '-' for zoom out, and '0' for reset to 100% (each combined with the hotkey modifier(s)). So when changing hotkeys we should follow that I think, i.e. switch SDL to Ctrl+Alt+0.
I'll send a patch fixing SDL to use CTRL+ALT+0
Now that the patch for the SDL backend got merged:
Michael Tokarev
Reviewed-byQuoted 26 lines · Thomas Huth
Quoted 10 lines · Nir Lichtman
Quoted 9 lines · Gerd Hoffmann
Quoted 8 lines · Thomas Huth
Quoted 7 lines · Nir Lichtman
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by Nir Lichtman <[email protected]>---
docs/system/keys.rst.inc | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 14 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
docs/system/keys.rst.inc +0
-0@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes itto the right :kbd:
Ctrlkey.
* - :kbd:Ctrl+Alt+-
- Shrink the screen
- * - :kbd:Ctrl+Alt+u
+ * - :kbd:Ctrl+Alt+0
- Restore the screen's un-scaled dimensionsI'll send a patch fixing SDL to use CTRL+ALT+0
Quoted 1 line
Now that the patch for the SDL backend got merged:
(it'd be nice to merge the two changes together, but ok)
And applied to the trivial-patches tree.
Thanks,
/mjt