arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

PATCH Superseded Eric Gonçalves 2 participants 3 messages Sep 21, 2025 – Sep 28, 2025

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support

lore

Share & tools

lore

Eric Gonçalves

author

2025-09-21 13:57 UTC #0 lore raw

PATCH 1/1 arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Signed-off-by Eric Gonçalves <[email protected]>

---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1

index 96662bf9e527..1680be67e733 100644
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
+						   <40 4>; /* I2C (Unused) */
 };
 
 &usb_1 {

Signature · 1 line

2.51.0

Dmitry Baryshkov

2025-09-22 09:51 UTC #1 lore raw

Quoted 13 lines · Eric Gonçalves

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
Signed-off-by Eric Gonçalves <[email protected]>
---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
index 96662bf9e527..1680be67e733 100644

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi &pon_resin { · line 163

Quoted 6 lines

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1

@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
+						   <40 4>; /* I2C (Unused) */

Typically Tab size is 8 spaces, not 4.

Also:

Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")

Quoted 6 lines

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
 };
 
 &usb_1 {
Signature · 1 line
2.51.0

Signature · 2 lines

With best wishes
Dmitry

Eric Gonçalves

author

2025-09-28 04:49 UTC #2 lore raw

Quoted 16 lines · Dmitry Baryshkov

Quoted 15 lines · Eric Gonçalves
The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
Signed-off-by Eric Gonçalves <[email protected]>
---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
index 96662bf9e527..1680be67e733 100644
@@ -159,7 +159,8 @@ &pon_resin {
 };
 

Quoted 6 lines

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi &pon_resin { · line 163
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
+						   <40 4>; /* I2C (Unused) */
Typically Tab size is 8 spaces, not 4.

I'll change that, thanks

Quoted 14 lines

Also:
Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Quoted 6 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
 };
 
 &usb_1 {
Signature · 1 line
2.51.0